D24786: [GTK3] Add styles for libhandy widgets

2019-10-19 Thread Noah Davis
ndavis added a comment. I think it might be a bit premature to copy the look of Plasma Mobile at this point. I don't know what is likely to change and what is likely to change. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24786 To: cblack, #breeze, #vdg Cc:

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

2019-10-19 Thread Wolfgang Bauer
wbauer added a comment. The patch fixes the problem here, and I didn't notice regressions either so far. I only did a quick test though, and cannot really comment on the patch per se. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24748 To: davidedmundso

D24786: [GTK3] Add styles for libhandy widgets

2019-10-19 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY There are now styles specifically for libhandy widgets to make them better resemble Plasma's mo

D24785: Store stashed model index as QPersistentModelIndex

2019-10-19 Thread David Edmundson
davidedmundson added a comment. Thread 1 (Thread 0x7f17b0836400 (LWP 5535)): [KCrash Handler] #6 KService::d_func (this=0x0) at /home/david/projects/kde5/src/frameworks/kservice/src/services/kservice.h:587 #7 0x7f17b677e3c3 in KService::comment (this=0x0) at /home/david/projects/k

D24785: Store stashed model index as QPersistentModelIndex

2019-10-19 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we can crash if the model updates during load. TEST PLAN Had a s

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-19 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R124:a81d0ca787d7: Draw categories in iconview in a similiar style as Kirigami and new… (authored by davidre). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D245

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo
davidre updated this revision to Diff 68304. davidre added a comment. Build the new order only after setting the source model. In invalidate just shuffling is enough. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24723?vs=68302&id=68304 BRANCH

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo
davidre updated this revision to Diff 68302. davidre marked 3 inline comments as done. davidre added a comment. Like this? I also changed the condition in image.cpp otherwise the order wouldn't have been random on the first run with these changes. REPOSITORY R120 Plasma Workspace CHANGES

D24744: Remove unneeded options in GTK KCM

2019-10-19 Thread Nathaniel Graham
ngraham added a comment. In D24744#549568 , @broulik wrote: > Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to position radios Yeah I'm working on exposing that for QWidgets apps in the Genera

D24720: [applets/systemtray] Rewrite popups with layouts

2019-10-19 Thread Nathaniel Graham
ngraham added a comment. Seems like the RTL problem may be that your RowLayouts that are within the parent ColumnLayout don't have `Layout.fillWidth: true` set. Does the problem go away if you set that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24720

D24744: Remove unneeded options in GTK KCM

2019-10-19 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 68286. gikari added a comment. - Remove unneeded find_package of deprecated library REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68285&id=68286 BRANCH gtk-kcm-remove-unneeded-options REVI

D24744: Remove unneeded options in GTK KCM

2019-10-19 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 68285. gikari added a comment. Rebase on top of modified D24743 REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68189&id=68285 BRANCH gtk-kcm-remove-unnee

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Edmundson
davidedmundson added a comment. Other than Kai's comments, ship it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24723 To: davidre, #plasma Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zre

D24767: [SystemTray] Support for AttentionIcon

2019-10-19 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:51964243ad40: [SystemTray] Support for AttentionIcon (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24767?vs=68268&id=68277 REVISI