D24733: feedback kcm: Make it about Plasma

ngraham accepted this revision. ngraham added a comment. All right, let's fix it there. REPOSITORY R120 Plasma Workspace BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc: plasma-devel, LeGast00n,

D24733: feedback kcm: Make it about Plasma

apol added a comment. I integrated David's idea to move this patch forward, but I think here we should look into move this text elsewhere: https://cgit.kde.org/kuserfeedback.git/tree/src/provider/core/feedbackconfiguicontroller.cpp#n188 In this text we are talking about why to enable

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68620. apol added a comment. Integrate David's feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68184=68620 BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 AFFECTED

D24733: feedback kcm: Make it about Plasma

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:116 > I don't understand this top line Yeah... feedbackController.telemetryDescription() function depends on applicationName, but since it's a function we don't have a way to

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

The-Feren-OS-Dev updated this revision to Diff 68612. The-Feren-OS-Dev added a comment. Edited code based on feedback and added Latte Dock layout and BorderlessMaximisedWindow value changing functionality REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/19/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 23 Oct 2019 15:00:48 + Build duration: 11 min and counting CONSOLE OUTPUT

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

davidre added a comment. > We would need some way to hide the default _launch entry I don't think that is a problem. I think we could wrap https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n119 in an if and only register _launch if the [Desktop Entry]

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

The-Feren-OS-Dev updated this revision to Diff 68610. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Added support for BorderlessMaximizedWindows and specifying a Latte Layout - Based on a code review, re-added original behaviour for Splash Screen

D24847: KCM Icons fix theme selected when we hit delete theme

ngraham added a comment. I don't like the change to prevent deletion of the current theme. It's awkward and feels unnatural to me. I don't see what was wrong with the prior behavior. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart,

D24503: Integrate the normal keyboard layout switcher

davidedmundson added a comment. > I'd say so. We can do it when we deprecate the SNI though, unless you really want it now. I've never done it so I'll have to research how it's done. I don't want it to get forgotten and us to do work in a rush when the release comes along. ---

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 23 Oct 2019 14:46:26 + Build duration: 12 min and counting CONSOLE OUTPUT

D24733: feedback kcm: Make it about Plasma

davidedmundson added a comment. I agree with Nate's comment, but lets get this in and then tackle that there. I just one QML line that I don't follow, then lets ship it INLINE COMMENTS > main.qml:41 > > -QQC2.CheckBox { > -Layout.topMargin: Kirigami.Units.gridUnit

D24890: Report windowing system

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R871 DrKonqi BRANCH windowsystem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24890 To: davidre, sitter Cc: apol, plasma-devel,

D24890: Report windowing system

This revision was automatically updated to reflect the committed changes. Closed by commit R871:8b8f813620b5: Report windowing system (authored by davidre). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24890?vs=68607=68608 REVISION DETAIL

5.18 Kickoff meeting

Let's try a meeting to discuss plasma for Plasma 5.18 On IRC/Matrix channel Will go over schedule, qt and kf5 versions, then work items on the board Please schedule your availability https://doodle.com/poll/ykevuw6pwh22n47f Remember to set the correct timezone before filling it in Jonathan

D24890: Report windowing system

davidre updated this revision to Diff 68607. davidre added a comment. report Unknown REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24890?vs=68604=68607 BRANCH windowsystem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24890

D24890: Report windowing system

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidre wrote in CMakeLists.txt:30 > I don't know but I just moved the find_package WindowSystem out of the if > because now it would be needed

D24890: Report windowing system

davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > -Notifications IdleTime) > -if(APPLE) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem) I don't know but I just moved the find_package WindowSystem out of the if because now it would be needed

D24889: Remove pointless textColor assignment

This revision was automatically updated to reflect the committed changes. Closed by commit R112:0e61b5053180: Remove pointless textColor assignment (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24889?vs=68603=68606 REVISION DETAIL

D24890: Report windowing system

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > -Notifications IdleTime) > -if(APPLE) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem) Do we know why this was done? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D24890

D24888: Rename kded Networkmanagement -> Network Management

This revision was automatically updated to reflect the committed changes. Closed by commit R116:13272821d3c3: Rename kded Networkmanagement - Network Management (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24890: Report windowing system

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Sometimes applications have different code paths for X11 or Wayland. Drkonqi reporting that saves one "question -> wait for reply

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a comment. In D24847#552665 , @bport wrote: > I will update this patch to allow to delete current selected theme but remove bug > So if we have A B C, A selected > > 1. we delete B : B pending deletion A still selected > 2.

D24879: [ComboBox] Follow focusPolicy

broulik added a comment. In D24879#552657 , @apol wrote: > Wouldn't it make more sense to not accept the event then? Not sure. The main reason for the `MouseArea` (apart from wheel handling) seems to be opening the `ComboBox` on *press*.

D24888: Rename kded Networkmanagement -> Network Management

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. apol requested review of this revision. REVISION SUMMARY This is a user-visible string and it reads very weird as is REPOSITORY

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. I will update this patch to allow to delete current selected theme but remove bug So if we have A B C, A selected 1. we delete B : B pending deletion A still selected 2. we delete A : A and B pending deletion C selected What happen if we delete the last

D24879: [ComboBox] Follow focusPolicy

apol added a comment. Wouldn't it make more sense to not accept the event then? INLINE COMMENTS > ComboBox.qml:79 > onPressed: { > +if ((controlRoot.focusPolicy & Qt.ClickFocus) === Qt.ClickFocus) > { > +controlRoot.forceActiveFocus(); `if

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. By the way I can select next theme in case we delete the current instead of disable deletion REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi Cc: bport, ngraham, broulik, plasma-devel,

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. Don't know why but is not the case here. And even if this is the case, I will need explaination on why we want to change theme selection when I delete another theme I mean if we have 3 themes A B and C. If A is selected, I delete B why the selected theme will be

D24865: [SystemTray] Support for AttentionIcon

kmaterka updated this revision to Diff 68598. kmaterka added a comment. Get rid of ugly and ridiculous nullness check. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68566=68598 BRANCH master REVISION DETAIL

D24847: KCM Icons fix theme selected when we hit delete theme

broulik added a comment. > Yes sure, by the way the new behavior is the one implemented on other kcm like desktop theme When I hit delete in desktop theme KCM I also have it move to the next theme? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. My bad this patch depends on D24846 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi Cc: bport, ngraham, broulik, plasma-devel, LeGast00n,

D24845: KCM don't support icons effect anymore, clean-up config file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8e37d1c67343: KCM dont support icons effect anymore, clean-up config file (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24845?vs=68497=68595#toc REPOSITORY R119 Plasma

Re: D24847: KCM Icons fix theme selected when we hit delete theme

Hello, On Tuesday, 22 October 2019 20:17:15 CEST Nathaniel Graham wrote: > Does this patch have unmarked dependencies? It doesn't apply for me: I'd expect it also needs D24845 and D24846. They got all submitted together. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 457 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/457/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 19:49:18 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 202 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/202/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 17:59:19 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 435 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/435/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 16 Oct 2019 15:13:48 + Build duration: 5 min 32 sec and counting JUnit Tests Name: (root)

D24883: [ComboBox] Don't indicate focus when popup is open

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Technically the `ComboBox` has focus but the user is interacting with the popup inside. This

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/55/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 08:16:43 + Build duration: 1 hr 4 min and counting JUnit Tests Name:

D24265: support global edit mode

GB_2 added a comment. In D24265#551189 , @mart wrote: > - don't dismiss applet edit mode when overing the handle Also happens with the resize handles :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL

KDE CI: Plasma » plasma-browser-integration » stable-kf5-qt5 FreeBSDQt5.13 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/stable-kf5-qt5%20FreeBSDQt5.13/25/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 08:16:42 + Build duration: 33 min and counting

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/16/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 08:16:44 + Build duration: 35 min and counting JUnit Tests

KDE CI: Plasma » plasma-pa » stable-kf5-qt5 FreeBSDQt5.13 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/stable-kf5-qt5%20FreeBSDQt5.13/20/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 08:16:41 + Build duration: 32 min and counting

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#552239 , @ngraham wrote: > There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle.

FreeBSD CI Failures

Hi all, Apologies for the failures which took place in the past hour for the FreeBSD section of the CI system. This was caused by a regression within the Jenkins durable task plugin, so we've reverted to a previous version of this plugin and will await a fix from the responsible developers.

KDE CI: Plasma » plasma-pa » stable-kf5-qt5 FreeBSDQt5.13 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/stable-kf5-qt5%20FreeBSDQt5.13/19/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 07:02:13 + Build duration: 32 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/54/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 07:01:37 + Build duration: 23 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/15/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 07:00:47 + Build duration: 23 min and counting CONSOLE OUTPUT

D24879: [ComboBox] Follow focusPolicy

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a `MouseArea` in our `contentItem` stealing events from the underlying `Control`,