D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

2019-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This will unclutter the context menu a bit, +1 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D24839 REVISION DETAIL https://phabricator.kde.org/D24839 To: GB_2, #plasma, #vdg, ngraham, mart Cc: broulik, mart, ngraham, #vdg, p

D24894: notifier: Make action buttons translatable

2019-10-26 Thread Alexander Potashev
aspotashev added a comment. In D24894#554481 , @yurchor wrote: > A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: > > https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBac

D24894: notifier: Make action buttons translatable

2019-10-26 Thread Alexander Potashev
aspotashev added a comment. In D24894#554481 , @yurchor wrote: > A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: > > https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBac

D13360: Touchpad KDED module: Convert to JSON metadata

2019-10-26 Thread David Faure
dfaure added a comment. I didn't fully follow this saga, but AFAICS this patch was reverted (commit 3432c3342b1f801 , bug 395622), so we still rely on desktop files to load the touchpad kded module. Can this patch be

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

2019-10-26 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D24839 REVISION DETAIL https://phabricator.kde.org/D24839 To: GB_2, #plasma, #vdg, ngraham, mart Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24894: notifier: Make action buttons translatable

2019-10-26 Thread Yuri Chornoivan
yurchor added a comment. A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141 Can it be fixed as well? Thanks in advance for y

D24894: notifier: Make action buttons translatable

2019-10-26 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R134:d877aa09ba17: notifier: Make action buttons translatable (authored by aspotashev). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24894?vs=68625&id=

D24964: [applets/weather] Port from KIconLoader to QIcon

2019-10-26 Thread Ismael Asensio
iasensio created this revision. iasensio added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision. REVISION SUMMARY `KIconLoader` was used only to check if the `iconName` is valid. This patch uses `QIcon::hasT