KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 236 - Failure!

2019-10-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/236/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Oct 2019 08:32:05 + Build duration: 4 min 7 sec and counting CONSOLE OUTPUT [...truncated 584 l

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 89 - Failure!

2019-10-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/89/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 27 Oct 2019 08:32:05 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...truncated

D24865: [SystemTray] Support for AttentionIcon

2019-10-27 Thread Luca Beltrame
lbeltrame added a comment. +1 to my untrained eye. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma, broulik, #plasma_workspaces Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zren

D24985: [wallpapers/image] Seed random number generator

2019-10-27 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise when we randomise the wallpaper order we will always get the same

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

2019-10-27 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There was a concious decision that when we add a new wallpaper we should ap

D24985: [wallpapers/image] Seed random number generator

2019-10-27 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:140 > std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0); > std::random_shuffle(m_randomOrder.begin(), m_randomOrder.end()); > } random_shuffle is removed in C++17, so maybe we can change to

D24952: Add mmHg to pressure options in weather applet

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. Very nice. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24952 To: iasensio, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed

D24952: Add mmHg to pressure options in weather applet

2019-10-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:4092da9d1116: Add mmHg to pressure options in weather applet (authored by iasensio, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2495

D24964: [applets/weather] Port from KIconLoader to QIcon

2019-10-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:dc40abfa9cfa: [applets/weather] Port from KIconLoader to QIcon (authored by iasensio, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24

D24953: [applets/weather] Use unit description from KUnitConversion

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. Needs a rebase though. REPOSITORY R114 Plasma Addons BRANCH weather_use_unit_description REVISION DETAIL https://phabricator.kde.org/D24953 To: iasensio, #plasma, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zr

D24953: [applets/weather] Use unit description from KUnitConversion

2019-10-27 Thread Ismael Asensio
iasensio updated this revision to Diff 68853. iasensio added a comment. - Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24953?vs=68771&id=68853 BRANCH weather_use_unit_description REVISION DETAIL https://phabricator.kde.org/D24953 AFFEC

D24953: [applets/weather] Use unit description from KUnitConversion

2019-10-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:48f5eeffa787: [applets/weather] Use unit description from KUnitConversion (authored by iasensio, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.

D22823: Restore Mouse Keyboard navigation accessibility feature

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. There's only one accessibility feature that's still missing: double-click timeout. See https://bugs.kde.org/show_bug.cgi?id=413502 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22823 To: broulik, #plasma, schweingruber, rikmills, ro

D24994: [GTK3] Revert checkbox recolouring

2019-10-27 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This reverts the effects of commit 7b3d0777ea6c10dd430ed686434d3a4e2d072632

D24994: [GTK3] Revert checkbox recolouring

2019-10-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sad that it has to come to this. Maybe they'll fix the bug in GTK eventually. :/ 5.17 branch please (after running `arc amend` on your local branch so that it picks up the change I m