D25290: KCM launchfeedback : port to KConfig XT

ervin added inline comments. INLINE COMMENTS > crossi wrote in main.qml:33 > I agree it's a bit tricky, we have a kind of enum choice written as a binary > representation in the config file. > > Will try to work it with a QML enum to make it less confusing. Or... but that's more work and I'd s

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > crossi wrote in kcmstyle.cpp:245 > m_effectsDirty is checked line 291, to trigger or not a refresh of all > applications. > > This check before save is now useless, sinc

D24743: Update GTK settings according to Plasma settings

eszlari added a comment. In D24743#562745 , @gikari wrote: > I'm not very proficient in CMake, so how can I do that? https://cmake.org/cmake/help/latest/command/find_program.html REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAI

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham updated this revision to Diff 69781. ngraham added a comment. - Invoke first run logic when indexing is turned on again after previously being turned off - Show warning message when the user goes to turn it off, but before hitting "Apply" REPOSITORY R119 Plasma Desktop CHANGES S

D24744: Remove unneeded options in GTK KCM

ngraham accepted this revision. ngraham added a subscriber: apol. ngraham added a comment. This revision is now accepted and ready to land. @apol, are you good with this? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-kcm-remove-unneeded-options REVISION DETAIL https://phabricato

D24744: Remove unneeded options in GTK KCM

gikari updated this revision to Diff 69779. gikari added a comment. Rebase on new master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68286&id=69779 BRANCH gtk-kcm-remove-unneeded-options REVISION DETAIL https://phabricato

D24743: Update GTK settings according to Plasma settings

gikari added a comment. In D24743#562656 , @zzag wrote: > Sweet! I wonder whether this KDED module can be used to synchronize the `gtk-decoration-layout` property with kwin's decoration button layout. Yes it probably will be used for that

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Rebased. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zr

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 69775. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=63147&id=69775 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES applets/clipboard/contents/ui/ClipboardPage.qml applets/cli

D24743: Update GTK settings according to Plasma settings

eszlari added a comment. Maybe a warning about the runtime dependency on xsettingsd should be added to cmake, so distro packagers know about it. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, broulik, cblack Cc: es

D25212: Move the shortcut management in the settings object

ngraham closed this revision. ngraham added a comment. Never mind, it just needed a clean build, my bad. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25212 To: ervin, #plasma, davidedmundson, bport, crossi, mart Cc: ngraham, plasma-devel, LeGast00n, The-Fere

D25310: Use the right value of EnableMagicMimeActions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sensible to implement this the way reading all the other actions are implemented. #plasma people, is this okay? REPOSITORY R120 Plasma W

D25212: Move the shortcut management in the settings object

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. This patch causes a build failure for me: /home/nate/kde/src/kscreenlocker/kcm/kcm.cpp: In constructor ‘ScreenLockerKcm::ScreenLockerKcm(QWidget*, const QVariantList&)’: /home/n

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. How will this be merged? Will it be in time for Kde 19.12 ? REPOSITORY R106 KSysguard BRANCH acpi-move-battery-to-sysfs REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: alexde, plasma-devel, LeGast00n, The-Fe

D24744: Remove unneeded options in GTK KCM

gikari planned changes to this revision. gikari added a comment. In D24744#562640 , @ngraham wrote: > Can you rebase this? Sure REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari,

D24706: [RFC] Change button style

ngraham added a comment. In D24706#553074 , @ngraham wrote: > I do like how obvious it makes the selected button, but by doing this, it visually overwhelms and destroys the concept of the default button (which is supposed to be the most visually

D24798: Migrate QQC1 to QQC2

davidedmundson added inline comments. INLINE COMMENTS > configTimeZones.qml:21-22 > > -import QtQuick 2.0 > -import QtQuick.Controls 1.2 as QtControls > +import QtQuick 2.13 > +import QtQuick.Controls 2.13 as QQC2 > import QtQuick.Layouts 1.0 Next plasma release can only depend on Qt 5.12 Pl

D24743: Update GTK settings according to Plasma settings

zzag added a comment. Sweet! I wonder whether this KDED module can be used to synchronize the `gtk-decoration-layout` property with kwin's decoration button layout. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, br

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. From previous comments: In D24070#534832 , @ngraham wrote: > The logic looks sane to me and the UI is good, but the time-to-empty/time-to-full values still don't always update correctly for me after a state change. I s

D24744: Remove unneeded options in GTK KCM

ngraham added a comment. Can you rebase this? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk,

D24743: Update GTK settings according to Plasma settings

This revision was automatically updated to reflect the committed changes. Closed by commit R99:94732eb8d6ee: Update GTK settings according to Plasma settings (authored by gikari, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24743?vs=69704&id=69766#toc REPOSITORY

D24743: Update GTK settings according to Plasma settings

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Good job! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-settings-in-respective-kcms REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, broulik, c

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Yes, when the battery is being charged, right after I unplug the cord. I have a feeling that there is something odd going on with the power subsystem on my computer, since sometimes it doesn't show the time remaining. Most of the time it looks correct, like this: F77

Re: KScreen/libkscreen commit message policies

On Wed, Nov 13, 2019 at 12:26 AM Luigi Toscano wrote: > > Roman Gilg ha scritto: > > On Mon, Nov 11, 2019 at 10:58 PM Luigi Toscano > > wrote: > >> > >> Roman Gilg ha scritto: > >>> Hi, > >>> > >>> I just pushed commit message policies to KScreen [1] and libkscreen > >>> [2] (linked below from G

Re: Clang Format Update

On Thu, Nov 14, 2019 at 7:24 PM David Edmundson wrote: > > Thanks for testing and providing the feedback. > > What's extremely frustrating is that many of these issues were > absolutely fine with the version of clang-format that we were > intending to use for plasma, then due to timing a differen

D24798: Migrate QQC1 to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b7b25010aa58: Migrate QQC1 to QQC2 (authored by Guo Yunhe ). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69739&id=69763 REVI

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:c1d7ea734607: Fixup new Audio() constructor and apply autoplay prevention evasion to document. (authored by broulik).

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham When does that happen? I am guessing, when batery is being charged, right? This is how it looks for me: https://imgur.com/a/vSkdDmo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, b

Re: Clang Format Update

Thanks for testing and providing the feedback. What's extremely frustrating is that many of these issues were absolutely fine with the version of clang-format that we were intending to use for plasma, then due to timing a different competing clang-format file was merged into frameworks, and the r

D25309: [Notifications KCM] Fix keyboard navigation in apps list

ngraham updated this revision to Diff 69761. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25309?vs=69758&id=69761 BRANCH fix-notifications-kcm-apps-list-k

D25284: Make QmlComponentsPool one instance per engine

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4a9820a6df15: Make QmlComponentsPool one instance per engine (authored by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25284?vs=69697&id=69760

D25309: [Notifications KCM] Fix keyboard navigation in apps list

broulik added inline comments. INLINE COMMENTS > SourcesPage.qml:147 > id: sourceDelegate > +focus: true > width: sourcesList.width Why this? > SourcesPage.qml:153 > +sourcesList.forceActiveFoc

D25310: Use the right value of EnableMagicMimeActions

trmdi created this revision. trmdi added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 409801 TEST PLAN The bug is fixed. REPOSITORY R120 Plasma Workspace BRANCH fix-enableMagic

D25309: [Notifications KCM] Fix keyboard navigation in apps list

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Learned how to do this from @guoyunhe in D24798 !

Re: Clang Format Update

Hi, I've just ran make clang-format (thanks a lot for that tooling!) over plasma-workspace and checked my libnotificationmanager code which is pretty new, was only written a few months ago, and as such should be a good representation of modern KDE Frameworks-style code. The results were not v

D24798: Migrate QQC1 to QQC2

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Very nice work. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces, ngraham Cc: GB_2

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Erm, actually, I just saw this... F7763635: Screenshot_20191114_094001.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavi

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham accepted this revision. ngraham added a comment. LGTM now! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas

D25191: replace bespoke xkb geometry parser with xkb

davidre added a comment. Is the FooBar class for testing? I don't see it used anywhere. (and would guess soofrom the name) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25191 To: sitter, #plasma Cc: davidre, ngraham, plasma-devel, LeGast00n, The-Feren-OS-De

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

ngraham updated this revision to Diff 69753. ngraham added a comment. --boilerplate REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25279?vs=69653&id=69753 BRANCH only-conditionally-re-enable-bluetooth-after-airplane-mode (branche

D25191: replace bespoke xkb geometry parser with xkb

sitter updated this revision to Diff 69752. sitter added a comment. - bump preview size a bit - update documentation - resolve outstanding todos REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69747&id=69752 BRANCH master REVISION DET

D25294: [applets/kicker] Set icon for all applications group

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fff726ca49d: [applets/kicker] Set icon for all applications group (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25294?vs=69

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 268 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/268/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 14 Nov 2019 14:20:10 + Build duration: 26 min and counting JUnit Tests Name: projectroot Failed

D25306: Add translations for new memory sensors

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the translated strings for the new Total, Available and Allocated sensors.

D25305: Add Total/Available/Allocated memory sensors

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This exposes the previously hidden Total memory amount as "mem/physical/total". It al

D25191: replace bespoke xkb geometry parser with xkb

sitter updated this revision to Diff 69747. sitter added a comment. - document why section overlays aren't modelled - doodad qml item creation is now type based rather than duck typed - logo doodads are now supported as a compositie of shape doodads and labels - outline doodads now behave

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. I also tried to not use ScrollView but enable ListView's scrollbar: ListView { // add scrollbar, background and border clip: true flickableDirection: Flickable.VerticalFlick boundsBehavior: Flickable.StopAtBounds QQC2

D25290: KCM launchfeedback : port to KConfig XT

crossi updated this revision to Diff 69745. crossi added a comment. Use proper signal handler & Fix typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69683&id=69745 REVISION DETAIL https://phabricator.kde.org/D25290 AFFECTED FILES kc

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 433 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/433/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Nov 2019 12:58:24 + Build duration: 3 min 58 sec and counting CONSOLE OUTPUT [...truncated 3402 lin

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 267 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/267/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 14 Nov 2019 12:58:24 + Build duration: 3 min 46 sec and counting CONSOLE OUTPUT [...truncated 39

D24798: Migrate QQC1 to QQC2

GB_2 added a comment. In D24798#562431 , @guoyunhe wrote: > Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. Yeah, that is a general pre

D25290: KCM launchfeedback : port to KConfig XT

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:33 > Yes, I would prefer all of this to be abstracted away from the QML, the > `checked` bindings area also quite messy I agree it's a bit tricky, we have a kind of enum choice written as a binary representation in the c

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69739. guoyunhe added a comment. Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https:

D25223: Avoid side effects during menu initialization

kmaterka added a comment. In D25223#561638 , @nicolasfella wrote: > My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API OK, I will think about this. This change is only to fix one

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69737. mthw added a comment. Issue above fixed and some stuff removed. I do have a question though, what info should be shown when "Power management" is disabled? With this patch it shows: - Battery level + managemet disabled (with battery) - Widget n

D25290: KCM launchfeedback : port to KConfig XT

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:45 > onToggled is called both when it is checked, and presumably when it is > unchecked (or another button is checked) > > I assume we want something more like: > > onToggled: {if (!checked) return; formLayout.s

D25290: KCM launchfeedback : port to KConfig XT

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:33 > This is a bit of a boolean trap. > > We could declare an enum in QML > setCursorSettings(Busy | Blinking) would be a bit nicer maybe? > > Up to you. Yes, I would prefer all of this to be abstracted away fro

D25290: KCM launchfeedback : port to KConfig XT

davidedmundson added a comment. Wow, we're almost at a stage where we don't need to load a C++ plugin at all. INLINE COMMENTS > main.qml:33 > > -Connections { > -target: kcm > - > -onBusyCursorCurrentIndexChanged: applyBusyCursorCurrentIndex() > - > -

D24798: Migrate QQC1 to QQC2

ahiemstra added a comment. In D24798#562333 , @guoyunhe wrote: > Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager: > > F7762797: image.png >

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69730. guoyunhe added a comment. Enable keyboard navigation and proper highlight REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69705&id=69730 BRANCH master REVISION DETAIL https://phabricator.k

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager: F7762797: image.png It also miss the border in the connection list. REPOSITORY R120 Plasma Workspace REV