D23413: [System Tray] Unified data model for System Tray items

anthonyfieroni added inline comments. INLINE COMMENTS > PlasmoidItem.qml:85-87 > if (!applet) { > -plasmoidContainer.destroy(); > print("applet destroyed") > } Remove that code as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phab

D24706: [RFC] Change button style

ndavis added a comment. In D24706#563165 , @cblack wrote: > I'm not a fan of dropping the diagonal movement- the transformation makes buttons feel much more button-y. How about vertical movement? I feel like the diagonal movement only wor

D24706: [RFC] Change button style

cblack added a comment. I'm not a fan of dropping the diagonal movement- the transformation makes buttons feel much more button-y. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cblack, bodoeggert, ngraham, plasma-devel, LeGast00n,

D23413: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 69823. kmaterka added a comment. Fixed one mistake during rebase. I checked it, seems it is still working. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23413?vs=69821&id=69823 BRANCH master REVISION DETA

D23413: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 69821. kmaterka edited the test plan for this revision. kmaterka added a comment. Rebased, but I need to test it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23413?vs=64669&id=69821 BRANCH master REVISIO

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#562834 , @ahiemstra wrote: > Do you have a developer account to push the changes? Otherwise I can do that for you. I don't, so yes please do the push. REPOSITORY R106 KSysguard BRANCH acpi-move-bat

D25327: Fix cmake project command position

This revision was automatically updated to reflect the committed changes. Closed by commit R169:55cd76337897: Fix cmake project command position (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25327?vs=69802&id=69817 REVISION DETAIL

D22684: [Klipper] Fix clipboard history management

davidedmundson added inline comments. INLINE COMMENTS > historyimageitem.cpp:45 > if ( m_text.isNull() ) { > -m_text = QStringLiteral( "%1x%2x%3 %4" ) > +m_text = QStringLiteral( "▨ %1x%2 %3bpp" ) > .arg( m_data.width() ) what's this square about? Also if

D22684: [Klipper] Fix clipboard history management

ngraham added inline comments. INLINE COMMENTS > historyimageitem.cpp:65 > > +const QPixmap& HistoryImageItem::image() const { > +if (m_model->displayImages()) { Does this have to be a pixmap? Can it just be a QIcon instead? > historyimageitem.cpp:70 > +static QPixmap imageIcon( > +

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham updated this revision to Diff 69809. ngraham added a comment. Improve string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25280?vs=69781&id=69809 BRANCH purge-index-when-disabling (branched from master) REVISION DETAIL https://phabric

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

ngraham added a comment. Hmm, reading the code more closely, it looks like it should already work. In fact, when I remove all my changes... it does work! I could have sworn that it didn't work before though. Does this make any sense? Could it have been fixed by 7dd740aa963057c255fbbe833

D25319: Fix issues from D24798 comments by @davidedmundson

aspotashev added a comment. toFixed() makes decimal separator always a point, thus not localizable. We need something else to support point or comma depending on the locale. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25319 To: guoyunhe, #plasma, davide

D21829: Improved Touch support for Kickoff

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0322d1a25fac: Improved Touch support for Kickoff (authored by steffenh, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=69785&

D21829: Improved Touch support for Kickoff

ngraham added a comment. Sorry this has gotten stuck in limbo, @steffenh. I discussed this with @hein and @mart and we agreed that it can go in now so that it doesn't get blocked forever, but we will need to refactor how we handle touch throughout Plasma, including here in Kickoff. To track

D24706: [RFC] Change button style

ngraham added a comment. In D24706#562797 , @ndavis wrote: > How is it for you compared to the git master focus decorations? I know it's not what you're asking, but I'd like to know. Almost perfect except for I'd like the focus outline to

D25319: Fix issues from D24798 comments by @davidedmundson

This revision was automatically updated to reflect the committed changes. Closed by commit R120:df49734ff991: Fix issues from D24798 comments by @davidedmundson (authored by Guo Yunhe ). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D25324: Display a warning, if xsettingsd is not found

gikari added a comment. In D25324#562909 , @broulik wrote: > I think you would want to make that a `RUNTIME` dependency. This is probably a stupid question, but how can I do that? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETA

D25327: Fix cmake project command position

dkardarakos created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Establish version and policy settings before invoking other commands REPOSITORY R169 Kirigami BRANCH cmake-command-o

D25191: replace bespoke xkb geometry parser with xkb

sitter updated this revision to Diff 69799. sitter added a comment. - remove all color mapping tech, it's pointless since the code now uses the system palette - remove garbage foobar class - remove unnecessary main.moc include - create two global SystemPalettes instead of in individual i

D25324: Display a warning, if xsettingsd is not found

broulik added a comment. I think you would want to make that a `RUNTIME` dependency. This stuff is mostly for packagers, telling them to install something isn't what we want. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari Cc: brou

D25290: KCM launchfeedback : port to KConfig XT

crossi added inline comments. INLINE COMMENTS > ervin wrote in main.qml:33 > Or... but that's more work and I'd say it should come in another patch on top > of that one. We migrate the config file to use an enum all the way. This > boolean trap exists in the config after all. Added enum to rem

D25324: Display a warning, if xsettingsd is not found

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since xsettingsd daemon is used to update the look of gtk applications on a fly (D24743 ), distr

D25290: KCM launchfeedback : port to KConfig XT

crossi updated this revision to Diff 69794. crossi added a comment. Add enum declaration to make boolean settings in qml a bit more readable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69745&id=69794 REVISION DETAIL https://phabricato

D25320: Show startup error in popup as well

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7b033c52e1bc: Show startup error in popup as well (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25320?vs=69789&id=69792

D25320: Show startup error in popup as well

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I wonder whether the `getStatus` handler could be cleaned up by removing the `UNKNOWN` value of `portStatus` and removing the `default:` case. REPOSITORY R856 Plasma Browser Integration RE

D25321: Remove dead code

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25321 AFFECT

D25322: Have the wallpaper combo managed by KConfigDialogManager

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY We use an intermediate property which maps to an index since it's exactl

D25320: Show startup error in popup as well

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the host crashes, the error message is shown to the user. When startup fails, only a g

D25319: Fix issues from D24798 comments by @davidedmundson

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Cannot use i18ncp because the number isn't integer. Oh, I see. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2531

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. KSysGuard is part of Plasma, so these changes will not be released until the next plasma release, which is 5.18 and should be released I think January next year. Do you have a developer account to push the changes? Otherwise I can do that for you. REPOSITORY

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

jgrulich added a comment. We were actually saving already the value of current BT state, it was just not used. Your code assumes there is just one BT adapter, while in theory there might be more of them. What I would just is just simply not add property like m_tmpBluetoothEnabled and use m_b

D25319: Fix issues from D24798 comments by @davidedmundson

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigGeneral.qml:134 > var seconds = value / 1000 > -return i18n("%1 seconds", seconds.toFixed(1)) > +

D25319: Fix issues from D24798 comments by @davidedmundson

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 69785. steffenh edited the summary of this revision. steffenh added a comment. rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60216&id=69785 BRANCH D21829 REVISION DETAIL https://phabricato

D24706: [RFC] Change button style

ndavis added a comment. In D24706#562666 , @ngraham wrote: > In D24706#553074 , @ngraham wrote: > > > I do like how obvious it makes the selected button, but by doing this, it visually overwhelms an