D24224: Start of the accessibility KCM

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. A few changes still needed. Also, in all the QML code we need to handle immutability of the settings (unfortunately that part can't be easily made magic like for the widgets).

D24798: Migrate QQC1 to QQC2

lbeltrame added a comment. Fixed in 47c76ebc83ee1f96c7a5fd9be23c6234a93143e8 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces,

D24798: Migrate QQC1 to QQC2

lbeltrame added a comment. This change breaks SDDM theme loading. See https://bugs.kde.org/show_bug.cgi?id=414252. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces, ngraham Cc: lbeltrame, davidedmundson, GB_2,

D24706: [RFC] Change button style

ndavis added a comment. The effect of removing a shadow in Breeze is pretty subtle. I think it makes it at least a little better, but I wonder if the shadow should be bigger. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc:

D24706: [RFC] Change button style

ndavis updated this revision to Diff 69901. ndavis added a comment. - Don't use focus colors on sunken buttons - If sunken, remove shadow - Use Button AlternateBackground color for sunken buttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does

ngraham updated this revision to Diff 69900. ngraham added a comment. Update terminology REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25361?vs=69899=69900 BRANCH left-click-warps-scrollbar-settings-ui (branched from master) REVISION DETAIL

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does

ndavis added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:136 > How about "Scrollbar track?" That would work too. I said groove because that's the term that the Breeze QStyle uses in the code, but I don't think it matters too much whether we use groove or track as long as we

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in main.qml:136 > I feel like it's too easy to mistake the word trough for though or through. I > think it would be better to use "scrollbar groove" instead of "scroll trough" How about "Scrollbar track?" REPOSITORY R119 Plasma

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does

ndavis added a comment. +1 for exposing this option I su INLINE COMMENTS > main.qml:136 > +id: leftClickNavigatesByPage > +Kirigami.FormData.label: i18n("Clicking in scroll trough:") > +text: i18nc("@radio completes the sentence 'Clicking in scroll >

Re: Translate software

On Wed, Nov 13, 2019 at 9:38 AM David Rebolo Magariños wrote: > > Hello there, > > I was wondering if Plasma Mobile has an official site for translators to > translate their ROM to our respective languages? If so, what is it call? > > > > > Thank you for answering my question, > > > David Rebolo

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch exposes a UI for choosing what happens when you left-click in the scroll trough

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

GB_2 added a comment. Ping :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma, davidedmundson, mart Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25351: [Style KCM] Change name to KDE/Qt Application Style

ngraham added a comment. In D25351#563678 , @GB_2 wrote: > In D25351#563677 , @ngraham wrote: > > > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. All good now, @broulik? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. I can confirm the bug and that this fixes it. However, you're porting to use the QQC2 Combobox even though https://bugs.kde.org/show_bug.cgi?id=403153 isn't fixed yet. As a result, the pop-up looks like this a lot of the time: F7768289:

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. In D25351#563677 , @ngraham wrote: > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but

D25351: [Style KCM] Change name to KDE/Qt Application Style

ngraham added a comment. In D25351#563619 , @broulik wrote: > Do we really want the user having to be aware there's something like different toolkits? Not a fan of this change. We are already surfacing this distinction by having a KCM

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY BUG: 412976 TEST PLAN Open Lock Screen KCM. Change wallpaper type to Picture of The Day. Check the ComboBox of POTD.

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis added a comment. In D25351#563617 , @davidre wrote: > Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that

D25351: [Style KCM] Change name to KDE/Qt Application Style

broulik added a comment. Do we really want the user having to be aware there's something like different toolkits? Not a fan of this change. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25351 To: ndavis, #plasma, #vdg, ngraham Cc: broulik,

D25351: [Style KCM] Change name to KDE/Qt Application Style

davidre added a comment. Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that Applications and Plasma are intertwined. REPOSITORY R119 Plasma Desktop BRANCH

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis added a subscriber: cblack. ndavis added a comment. In D25351#563601 , @GB_2 wrote: > I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69869. mthw added a comment. Added i18n() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=69854=69869 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. REPOSITORY

D22684: [Klipper] Fix clipboard history management

pdabrowski added inline comments. INLINE COMMENTS > davidedmundson wrote in historyimageitem.cpp:45 > what's this square about? > > Also if "bpp" is bits per pixel, we need to put it in i18n() for translation The square indicates that the clipboard contains an image, not a literal string like