KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 276 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/276/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 04:36:02 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 04:34:01 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 21 Nov 2019 02:29:10 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated 70

D25418: [Folder view] Use selected text color for selected items in full representation

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D25418#565427 , @ngraham wrote: > That was my first reaction in the bug report as well (see the discussion there). But try clicking on that

D25418: [Folder view] Use selected text color for selected items in full representation

ngraham added a comment. That was my first reaction in the bug report as well (see the discussion there). But try clicking on that file, not just highlighting it. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25418 To: ngraham, #vdg, #plasma Cc: ndavis,

D25418: [Folder view] Use selected text color for selected items in full representation

ndavis added a comment. It looks like your highlight effect is bugged or you are using a modified desktop theme. Here's what mine looks like: F7774871: Screenshot_20191120_165311.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D25426 and D25425 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25019 To: ngraham, #kirigami, mart, apol, a

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

ngraham added a reviewer: Baloo. ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25278 To: ngraham, #vdg, #baloo Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngra

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham added a reviewer: Baloo. ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25430: fix layout of overlaysheet

ngraham added inline comments. INLINE COMMENTS > ProgressView.qml:60 > separatorVisible: false > +//implicitWidth: 400//tasksView.width > hoverEnabled: model.application Needed? REPOSITORY R134 Discover Software Store REVISION DET

D25415: Improve package documentation

filipf updated this revision to Diff 70082. filipf added a comment. simpler dependencies list REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70020&id=70082 BRANCH better-documentation (branched from master) REVISION DETAI

D25006: Make sure -dpi value is valid

davidedmundson added a comment. Turning a number into a string and back again isn't ideal I would suggest: int dpiValue = dpiConfigGroup.readEntry("forceFontDPI", -1); if (dpiValue > 24) { const QString dpiArgument = QStringLiteral("-dpi ") + QString::number

D25415: Improve package documentation

davidedmundson added a comment. > The list would probably get outdated soon and maybe the deps can be listed more abstractly so there's fewer lines. Yeah. Also this looks like the output of running cmake anyway, so I don't see what we gain by writing it in another place. REPOSITORY R1

D25430: fix layout of overlaysheet

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY makes the overlaysheet howit's supposed to be rendered: since it's "global" in the app, it should be parented to the applicationwindow

D25428: Improved support for desktop "Folder View"

nicolasfella added a comment. Nice! Works as described REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alex

D25375: Start of the accessibility KCM

ognarb added a comment. :) INLINE COMMENTS > CMakeLists.txt:2 > # KI18N Translation Domain for this library > +# KI18N Translation Domain for this library > add_definitions(-DTRANSLATION_DOMAIN=\"kcmaccess\") Duplicate line REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham Cc:

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70078. steffenh added a comment. oops was wrong diff, now is it the correct version REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70066&id=70078 BRANCH touchFolderView REVISION DETAIL https://pha

D25428: Improved support for desktop "Folder View"

steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY moving icon's on the desktop around with touch open/launch icons with tap (only singe tap, re

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ngraham added a comment. QWidgets KCMs in English. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. @ngraham which applications are they? I didn't see similar thing in my system. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Things seem noticeably too short to me now, and QWidgets things are smaller than their QML versions. Observe: Above, QWidgets. Below, QML: F7774370: Screenshot_20191120

D25426: use the new GlobalDrawer header property

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DiscoverDrawer.qml:26 > import org.kde.discover.app 1.0 > import org.kde.kirigami 2.8 as Kirigami > import "navigation.js" as Navigation 2.12 now, right?

D25425: header property for the drawer

mart updated this revision to Diff 70072. mart added a comment. - apidocs REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25425?vs=70070&id=70072 BRANCH mart/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25425 AFFECTED FILES src/control

D25426: use the new GlobalDrawer header property

ngraham added a comment. Is `header:` new API? Does this need a kirigami version increase in cmake? REPOSITORY R134 Discover Software Store BRANCH phab/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25426 To: mart, #discover_software_store, ngraham Cc: ngraham, plasma-devel

D25426: use the new GlobalDrawer header property

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great with D25426 ! REPOSITORY R134 Discover Software Store BRANCH phab/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25426 T

D25425: header property for the drawer

ngraham added a comment. Looks great with D25426 ! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25425 To: mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mar

D25413: [Weather] Make compact representation temperature text match size of clock text

This revision was automatically updated to reflect the committed changes. Closed by commit R114:edb1367acc39: [Weather] Make compact representation temperature text match size of clock text (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde

D25425: header property for the drawer

mart updated this revision to Diff 70070. mart added a comment. - single item for header REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25425?vs=70065&id=70070 BRANCH mart/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25425 AFFECTED FILE

D25426: use the new GlobalDrawer header property

mart updated this revision to Diff 70071. mart added a comment. small fixes REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25426?vs=70068&id=70071 BRANCH phab/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25426 AFFECTED FI

D25426: use the new GlobalDrawer header property

mart updated this revision to Diff 70068. mart added a comment. - actually use header REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25426?vs=70067&id=70068 BRANCH phab/drawerHeader REVISION DETAIL https://phabricator.kde.org/D25426 A

D25426: use the new GlobalDrawer header property

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY depends from D25425 REPOSITORY R134 Discover Software Store BRANCH phab/drawerHeader REVISION

D25425: header property for the drawer

mart added a comment. WIP: apidocs still missing REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25425 To: mart, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25425: header property for the drawer

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY GlobalDrawer has the new property header, which does not scroll. It can be used for toolbars that need

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham added a comment. Can you formally accept, maybe? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, a

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. as for the change, it looks good to me.. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, n

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. Probably could also say the same for, winds/visibility those could be rounded in some places depending on the unit(s). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25413 To: ngraham, #vdg, #plasma Cc: spstarr, filipf, plasma-devel,

D25413: [Weather] Make compact representation temperature text match size of clock text

ngraham added a comment. In D25413#565258 , @spstarr wrote: > I wonder, some users might not want to see the temperature decimal points, maybe an option to hide it? The reason I exposed that level of temperature in the engine was when you live i

D25413: [Weather] Make compact representation temperature text match size of clock text

spstarr added a comment. I wonder, some users might not want to see the temperature decimal points, maybe an option to hide it? The reason I exposed that level of temperature in the engine was when you live in cold climates the exact decimal temperature might help to tell you if there was ic

D25395: Make avatar icon dpr aware aka HiDPI rendered

This revision was automatically updated to reflect the committed changes. Closed by commit R128:a6f37349cd40: Make avatar icon dpr aware aka HiDPI rendered (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25395?vs=70008&id=70063 REVISI

D25424: Fix default card background

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dddef02dad95: Fix default card background (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25424?vs=70058&id=70060 REVISION DETAIL https://

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe updated this revision to Diff 70059. guoyunhe added a comment. Force height consistency REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25381?vs=69954&id=70059 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25381 AFFECTED FILES ks

D25424: Fix default card background

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY A theme-collowing color background got lost in 4203a779031cb7c2268fbdd75d3d9d786056

D25404: Just return applicationDisplayName in MPRIS Identity

This revision was automatically updated to reflect the committed changes. Closed by commit R856:78347989fca8: Just return applicationDisplayName in MPRIS Identity (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25404?vs

D25398: Check values have changed before setting the model

ngraham added a comment. Agreed. Works for me and looks safe, but maybe let's do master only for safety. Can you file a bug upstream on the odd behavior in AccountsService? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D25398 To: meven, #plasma Cc: ngraha

D25408: [KCM] Port main page to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b5f223f36da2: [KCM] Port main page to QQC2 (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25408?vs=70009&id=70056 R

D25375: Start of the accessibility KCM

mart added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:42 > Needs keyboard navigation. See > https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359 > for details regarding how. more than that, the correct way of doing keyboard navigation in

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. The remaining 1px difference between QPushButton and QLineEdit is caused by content. QLineEdit directly expands from its content size, while QPushButton calculate size of text metrics and icons. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/

D25415: Improve package documentation

filipf added a comment. Maybe I shouldn't list all those dependencies like that. The list would probably get outdated soon and maybe the deps can be listed more abstractly so there's fewer lines. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH better-documentation (branched from m

D25140: kcm/fonts: set initial settings correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:243d0b6d4ea3: kcm/fonts: set initial settings correctly (authored by bshah). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25140?vs=69258&id=70038 REVISION