D25624: Don't use qmlRegisterType with QT-5.14

plevine created this revision. plevine added a reviewer: jriddell. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. plevine requested review of this revision. REVISION SUMMARY Building Plymouth-kcm-5.17.3 against Qt 5.14.0_beta3 fails with: ../plymouth-kcm-5.17.3/s

D25618: Account for a mnemonic label to go back to ""

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We are discarding the value if there's no weights which meant that when setting a button to "",

D25617: MenuIcon: fix warnings when the drawer isn't initialized

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Have a plan for when drawer isn't initialized TEST PLAN I don't get all the warnings from disco

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

kossebau added a comment. Something to consider in time for Plasma 5.18, post 5.17.5 and before 5.17.90) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D22778: Restore option to create a Qt Designer plugin

kossebau updated this revision to Diff 70584. kossebau added a comment. Update to latest master REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22778?vs=62646&id=70584 BRANCH readdoptiontogeneratedesignerplugin REVISION DETAIL https://phabric

D25581: [TabBar] Use window color instead of button color

This revision was automatically updated to reflect the committed changes. Closed by commit R858:386248f6d454: [TabBar] Use window color instead of button color (authored by filipf). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2558

D25581: [TabBar] Use window color instead of button color

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Yeah, the widget style version uses a lightened version of the window color for the active tab and the frame's background. Ideally we would do the same thing in the QQC2 desktop

D25581: [TabBar] Use window color instead of button color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH right-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25581 To: filipf, #plasma, #vdg, ng

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

ngraham added a comment. Thanks so much for this, it made D25361 such a breeze! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25586 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: ngraham, plasma-devel, LeGas

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham updated this revision to Diff 70579. ngraham added a comment. Rebase; soo much easier now with D25586 ! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25361?vs=69933&id=70579 BRANCH left-click-w

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham updated this revision to Diff 70580. ngraham added a comment. Clean up more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25361?vs=70579&id=70580 BRANCH left-click-warps-scrollbar-settings-ui (branched from master) REVISION DETAIL http

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

GB_2 added a comment. In D25361#566193 , @ngraham wrote: > I share you concern about this KCM becoming a dumping ground. But I don't see a better place for this setting right now. And I think it does make some sense for it to hold general behavi

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

This revision was automatically updated to reflect the committed changes. Closed by commit R119:95047f61275e: Reshape Kickoff avatar to a circle with Opacity Mask (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13415?vs=70124&id=70

D24866: Wired setting: improve handling of link negotiation

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks good to me. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24866 To: jgrulich, #plasma, #vdg Cc: ngraham, dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25614: [System Tray] Clean up popup code

ngraham added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:103 > checked: plasmoid.configuration.pin > -onCheckedChanged: plasmoid.configuration.pin = checked > +onClicked: plasmoid.configuration.pin = checked > icon.name: "window

D25614: [System Tray] Clean up popup code

filipf added a comment. Everything looks the same, but I did notice that the "Status and Notifications" isn't on the right in RTL mode, not sure why: F7789933: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D25614: [System Tray] Clean up popup code

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This removes hacks and does things in a cleaner way. Credits go to @broulik. REPOSITORY R120 Plasma Workspace BRANCH code-c

D25602: [System Tray] Restore old pin button size

This revision was automatically updated to reflect the committed changes. Closed by commit R120:37c1ec10888f: [System Tray] Restore old pin button size (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25602?vs=70526&id=70575 REVIS

D25612: Simplify load of locale variables

This revision was automatically updated to reflect the committed changes. Closed by commit R120:26284d73cf94: Simplify load of locale variables (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70568&id=70573 REVISION DETAIL

D25613: Remove generation of plasma-locale-settings.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f5ab71acc03b: Remove generation of plasma-locale-settings.sh (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25613?vs=70572&id=70574 REVI

D25613: Remove generation of plasma-locale-settings.sh

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's being addressed with D25612 TEST PLAN Builds, makes sense. RE

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. @jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9b

D25018: Move ACPI battery information from /proc/acpi to /sys

This revision was automatically updated to reflect the committed changes. Closed by commit R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys (authored by l10n daemon script , committed by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2

D25612: Simplify load of locale variables

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Lovely. There's a writeexports.h in p-d to kill too. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 To: apol,

D25569: Also overwrite document.createElement using exportFunction

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Ugly... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D25569 To: broulik, fvogt, davidedmundson, ognarb Cc: plasma-devel, LeGast00n, The-Feren-OS

D25612: Simplify load of locale variables

apol updated this revision to Diff 70567. apol added a comment. Address david comment, merge all of the LANG things REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70555&id=70567 BRANCH master REVISION DETAIL https://phabricator.kde.o

D25612: Simplify load of locale variables

apol updated this revision to Diff 70568. apol added a comment. Remember to sync REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70567&id=70568 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES kcms/tr

D25566: [Notifications] Move out of the way of dialog rather than just hiding

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:24900b334788: [Notifications] Move out of the way of dialog rather than just hiding (authored by broulik). CHANGED PRI

D25608: Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c95d7fad0ef7: Remove dead code (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25608?vs=70548&id=70562 REVISION DETAIL https://phabrica

D25609: Port KSMServer's KCM to KConfigXT

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:506d1807e6a4: Port KSMServer's KCM to KConfigXT (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE L

D25525: KCM Style : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25525?vs=70351&id=70559

D25523: KCM LookAndFeel : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:277bb04e7455: KCM LookAndFeel : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25523?vs=70295&id=7

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25524: KCM KSplash : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd9a6da45f9e: KCM KSplash : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25524?vs=70296&id=70558

D25526: KCM launch feedback : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=7030

D25522: KCM Colors : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:298611977e3b: KCM Colors : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25522?vs=70350&id=70556

D24846: Port kcm icons to kconfigxt

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Looks like you didn't address a faire number of comments, or they ended up in the wrong commit (by the look of D24847 ). INLINE COMMENTS > main.

D25612: Simplify load of locale variables

davidedmundson added a comment. +1 INLINE COMMENTS > startplasma.cpp:143 > if (!QFile::exists(localerc)) { > QFile f(localerc); > f.open(QFile::WriteOnly); This may as well be merged if we're going to open the config next anyway REPOSITORY R120 Plasma Workspace REV

D25612: Simplify load of locale variables

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Load l10n values using kconfig instead of sourcing a generated shell script from the kcm. TEST PLAN Bu

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

broulik closed this revision. broulik added a comment. https://cgit.kde.org/breeze.git/commit/?id=6fe549361b4301efddb358989af45ad44d4ae7a8 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25593 To: broulik, #vdg, hpereiradacosta, davidedmundson, ndavis Cc: plasma-devel

D25609: Port KSMServer's KCM to KConfigXT

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmsmserver.cpp:203 > This patch renames this entry "default" to "emptySession" > > From what I can tell it won't matter for ksmserver itself as that only > compares against the other two strings. > > But if a user had thi

D25609: Port KSMServer's KCM to KConfigXT

ervin updated this revision to Diff 70551. ervin added a comment. Add missing scoped pointer. I thought I did it, apparently just in my head. :-D REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25609?vs=70549&id=70551 REVISION DETAIL https://phabr

D25609: Port KSMServer's KCM to KConfigXT

davidedmundson added a comment. So much red :D INLINE COMMENTS > kcmsmserver.cpp:203 > - if ( dialog->emptySessionRadio->isChecked() ) > - s = QStringLiteral("default"); > - else if ( dialog->savedSessionRadio->isChecked() ) This patch renames this entry "default" to "emptySession" F

D25609: Port KSMServer's KCM to KConfigXT

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmsmserver.h:50 > > + Ui::SMServerConfigDlg *ui; > + SMServerSettings *m_settings; it seems that ui is never deleted. (I can't see it deleted in dest

D25608: Remove dead code

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25608

D25609: Port KSMServer's KCM to KConfigXT

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25609

D25592: handle action for custom shadow background hint

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:e473bdd3f9ad: handle action for custom shadow background hint (authored by mart). REPOSITORY R119 Plasma Desktop CH

D25591: support for the shadow and effectiveBackgroundhints

This revision was automatically updated to reflect the committed changes. Closed by commit R120:84247e8424b7: support for the shadow and effectiveBackgroundhints (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25591?vs=70515&id=7054

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

sniperrifle added a comment. I'm thinking of adding what the intended behaviour is of the function regarding XDG_DATA_DIRS to the function comment and removing the comment in the code. Would that be acceptable? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

This revision was automatically updated to reflect the committed changes. Closed by commit R120:02bbef3b506a: [XembedSNIProxy] Send all container windows to background on KWin restart (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka added a comment. In D25603#569113 , @davidedmundson wrote: > Alternatively, if we need to reset something when our window gets moved...could we watch for our window getting moved? > It'll be the more technically correct, and keeps th