[Breeze] [Bug 365690] kaccessibleapp icon

https://bugs.kde.org/show_bug.cgi?id=365690 --- Comment #2 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[Breeze] [Bug 370569] kde4breeze.upd ignores system distributor values from XDG_CONFIG_DIRS/kdeglobals

https://bugs.kde.org/show_bug.cgi?id=370569 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 --- Comment #6 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Yeah, I think that makes a lot of sense. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma, ngraham, ervin Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26124: Add byte display option in Network Monitor plasmoid

ngraham added a comment. Even nicer. :) INLINE COMMENTS > main.xml:22 > + > +1 > + an inline comment documenting what the ints map to would be nice > displayConfig.qml:2 > +/* > + * Copyright 2015 Marco Martin > + * Your copyright REPOSITORY R120 Plasma Workspace

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added a comment. In D26121#580666 , @ngraham wrote: > Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: > > F7826930:

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in recentusagemodel.cpp:365 > Probably worth just doing this in a single line rather than defining a > variable used only once I did this for readability, I think we should keep this. The

D26124: Add byte display option in Network Monitor plasmoid

gvgeo updated this revision to Diff 71921. gvgeo added a comment. Add xml display entry, to save the option. Added in the common main.xml. Now the rest 4 system monitor applets will have an extra entry that will not use. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26121: Kicker/RecentDocument display file path as decoration

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually I see that other list items on other tabs already have path captions like this, so it's not a newly-introduced issue. INLINE COMMENTS > recentusagemodel.cpp:365 > +

D26125: [Notifications] Release all cookies when service unregisters

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1967dc08e3db: [Notifications] Release all cookies when service unregisters (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26125?vs=71905=71906#toc REPOSITORY R120

D26125: [Notifications] Release all cookies when service unregisters

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY An application could have multiple inhibitions. Release all of them when the service unregisters

D25851: [Notifications] Add quick reply feature

ngraham accepted this revision as: VDG. ngraham added a comment. Love it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25851 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26121: Kicker/RecentDocument display file path as decoration

davidre added a comment. In D26121#580666 , @ngraham wrote: > Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: > > F7826930: Screenshot_20191220_100525.png

D26124: Add byte display option in Network Monitor plasmoid

ngraham accepted this revision as: VDG. ngraham added a reviewer: Plasma. ngraham added a comment. Nice clean QML and a reasonable UI. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26124 To: gvgeo, #vdg, #plasma Cc: ngraham, plasma-devel, LeGast00n,

D26124: Add byte display option in Network Monitor plasmoid

gvgeo added a comment. I can't find a way to add the new option in the same Interfaces group. If I add Kirigami.FormLayout stops reading the values, even if the layout works. Tried something like this: Kirigami.FormLayout { //

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided: F7826930: Screenshot_20191220_100525.png Not a -1, but I wonder how useful this will be in practice. However big

D26124: Add byte display option in Network Monitor plasmoid

gvgeo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add the option to select between byte and bit display in Network Monitor plasmoid. Bug: 383019 REPOSITORY R120 Plasma Workspace

D26069: Fix usage of deprecated QSet/QList methods

alexeymin added a comment. Should be fine now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26069 To: alexeymin Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

meven added a comment. Seems good to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26051 To: bport, #plasma, ervin, meven, crossi Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

ngraham accepted this revision as: VDG. ngraham added a comment. Yep, much nicer. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D26120 To: broulik, #vdg, drosca, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26121: Kicker/RecentDocument display file path as decoration

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in recentusagemodel.cpp:269 > I am thinking about adding this utility feature to KCoreAddons and avoid more > duplication. https://phabricator.kde.org/D26122 REPOSITORY R120 Plasma Workspace

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 71894. meven added a comment. const isDefaults, type variable name fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=71878=71894 BRANCH component-browser REVISION DETAIL

D26121: Kicker/RecentDocument display file path as decoration

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > broulik wrote in recentusagemodel.cpp:269 > Can you use the "~" for HOME like the runners do please I am thinking about adding this utility feature to KCoreAddons and avoid more duplication. REPOSITORY

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71893. meven added a comment. Replace homePath by '~' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71892=71893 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 AFFECTED FILES

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

crossi added a comment. some nitpicks, otherwise looks good. INLINE COMMENTS > componentchooser.h:42 > virtual void defaults()=0; > +virtual bool isDefaults() { > +return false; Can you make it const please. > componentchooserbrowser.cpp:110 > > -const auto = >

D26121: Kicker/RecentDocument display file path as decoration

broulik added inline comments. INLINE COMMENTS > recentusagemodel.cpp:269 > +QString desc = fileItem.localPath(); > +desc.truncate(desc.lastIndexOf(QChar('/'))); > +return desc; Can you use the "~" for HOME like the runners do please REPOSITORY R120 Plasma Workspace

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71892. meven added a comment. Correct case REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71891=71892 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26121 AFFECTED FILES

D26121: Kicker/RecentDocument display file path as decoration

meven created this revision. meven added reviewers: VDG, Plasma, ngraham, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Also add an open containing folder action REPOSITORY R120 Plasma Workspace

D26021: Display sub categories when searching

This revision was automatically updated to reflect the committed changes. Closed by commit R124:f82cca0cb07f: Display sub categories when searching (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71889=71890 REVISION

D26021: Display sub categories when searching

mart updated this revision to Diff 71889. mart added a comment. - root categories are 0 depth REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71881=71889 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in MenuModel.cpp:49 > In other models we tend to drop the suffix "Role" from the rolename > > i.e Qt::DisplayRole -> "display" > > but it's not super important. I followed what it was doing previously, MenuItemRols->MenuItem

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

broulik updated this revision to Diff 71887. broulik added a comment. - Use renamed hint REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26120?vs=71879=71887 REVISION DETAIL https://phabricator.kde.org/D26120 AFFECTED FILES src/bluedevil.notifyrc

D26104: Add KIOFuse to mapping

This revision was automatically updated to reflect the committed changes. Closed by commit R871:bbdf8950e0d4: Add KIOFuse to mapping (authored by feverfew). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26104?vs=71840=71886 REVISION DETAIL

D25634: Add kconf update script for ksmserver

davidedmundson added a comment. > -1 I'd prefer if the config value was kept See D25609 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n,

D26021: Display sub categories when searching

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > MenuModel.cpp:49 > > +QHash MenuModel::roleNames() const > +{ In other models we tend to drop the suffix "Role" from the rolename i.e

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8dc1db04b9be: [Notifications] Add hint for a notification being response to explicit user… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25935?vs=71877=71882#toc

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

broulik added a comment. In D25935#580527 , @davidedmundson wrote: > I thought you were going to call it UserActionFeedback? You said "user-action works" REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I thought you were going to call it UserActionFeedback? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma,

D26021: Display sub categories when searching

mart updated this revision to Diff 71881. mart added a comment. - remove trailing space REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71880=71881 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFFECTED

D26021: Display sub categories when searching

mart updated this revision to Diff 71880. mart added a comment. - switch column when there are two REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71876=71880 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

broulik created this revision. broulik added reviewers: VDG, drosca, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Saves the user from having to close the dialog when pairing succeeded. TEST PLAN -

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

broulik updated this revision to Diff 71877. broulik retitled this revision from "[Notifications] Add hint for showing a notification even in do not disturb mode" to "[Notifications] Add hint for a notification being response to explicit user interaction". broulik edited the summary of this

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 71878. meven added a comment. Better filter web browser to expose to users REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=71833=71878 BRANCH component-browser REVISION DETAIL

D26021: Display sub categories when searching

mart updated this revision to Diff 71876. mart added a comment. - don't accept invalid index as root - select proper category when not in search more REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71803=71876 BRANCH arcpatch-D26021

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #43 from Alexander Fieroch --- Created attachment 124611 --> https://bugs.kde.org/attachment.cgi?id=124611=edit power is critical at 0% for some seconds and thorws a waring, than it gets real information about 60% -- You are receiving

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #42 from Alexander Fieroch --- (In reply to Konrad Materka from comment #41) > I'm not able to reproduce, can you check few things? Interesting, it changed since my comment. I've noticed that KDE Frameworks has upgraded to 5.65.0 what the

D25916: [Notifications] Provide better feedback when copying a single file

broulik abandoned this revision. broulik added a comment. I forgot why this was needed - KDE Connect works fine after I fixed the job... REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D25916 To: broulik, #plasma, #vdg Cc: plasma-devel, LeGast00n,

D25951: Show peripheral low battery notification for NoCharge

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R122:14212f78de5f: Show peripheral low battery notification for NoCharge (authored by broulik). REPOSITORY R122

D26091: [Notifications] Improve self-closing behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R120:90a69a7b508a: [Notifications] Improve self-closing behavior (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26091?vs=71821=71873#toc REPOSITORY R120 Plasma Workspace

D26093: Use a fixed icon size for the notification popup close button

broulik added a comment. F7826451: Screenshot_20191220_095532.png The icon looks pretty big here now - wouldn't it be `small` for normal `ToolButton` icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26093 To:

D26091: [Notifications] Improve self-closing behavior

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:153 > > +function closePlasmoid() { > +if (plasmoid.status !== PlasmaCore.Types.PassiveStatus) { closePassivePlasmoid() REPOSITORY R120 Plasma