D26147: Kickoff computer tab : don't display filepath for places in description

meven updated this revision to Diff 72041. meven added a comment. Use default fallthrough REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26147?vs=71962&id=72041 BRANCH arcpatch-D26147 REVISION DETAIL https://phabricator.kde.org/D26147 AFFECT

D25973: Make the theme info QuickWidget transparent

filipf abandoned this revision. filipf added a comment. Going to have to be a no from me since the lack of font anti-aliasing looks pretty bad with darker color schemes. Not sure if it's worth it to report the bug to Qt. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL htt

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

filipf added a comment. @broulik? REPOSITORY R112 Milou BRANCH fix-bad-text-legibility (branched from master) REVISION DETAIL https://phabricator.kde.org/D25374 To: filipf, #plasma, #vdg, ngraham Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbamp

D25584: [TabBar] Add a border property

filipf updated this revision to Diff 72050. filipf added a comment. remove tabbar frame REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25584?vs=70473&id=72050 BRANCH border-property (branched from master) REVISION DETAIL htt

D25584: [TabBar] Add a border property

filipf updated this revision to Diff 72051. filipf added a comment. clean up REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25584?vs=72050&id=72051 BRANCH border-property (branched from master) REVISION DETAIL https://phabri

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72052. meven added a comment. [KCM/Component] Clean up code of filemanager cfg REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=71894&id=72052 BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72053. meven added a comment. Clean unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72052&id=72053 BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D26100 AFFECTED

D26178: [KCM/Component] Clean up code of filemanager cfg

meven created this revision. meven added reviewers: Plasma, crossi, ervin. meven added a project: Plasma. meven requested review of this revision. TEST PLAN kcmshell5 componentchooser REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D2617

D26179: [KCM/Component] Clean up code of filemanager cfg

meven created this revision. meven added reviewers: Plasma, crossi, ervin. meven added a project: Plasma. meven requested review of this revision. TEST PLAN kcmshell5 componentchooser REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D2617

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72059. meven added a comment. Add an override in header REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72058&id=72059 BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D26179 AFFECT

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72058. meven added a comment. Add an override in header REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72056&id=72058 BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D26179 AFFECT

D26160: [Notifications] For non-configurable applications use fake "@other" category

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4280515eebb0: [Notifications] For non-configurable applications use fake "@other" category (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

D26161: [Notifications KCM] Add "Other Applications" category

This revision was automatically updated to reflect the committed changes. Closed by commit R119:41e27fa56cd8: [Notifications KCM] Add "Other Applications" category (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26161?vs=72013&id=7

D24846: Port kcm icons to kconfigxt

ervin added a comment. Just a couple of stylistic issues left AFAICT INLINE COMMENTS > iconsmodel.h:47 > public: > -IconsModel(QObject *parent); > +IconsModel(QObject *parent, IconsSettings *iconsSettings); > ~IconsModel() override; Kind of a nitpick in this context, but parent

D26181: [KCM/Component] Clean deprecated code, modernize code

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN No changes REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.

D26045: Add immutability to KCM Icons

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n

D26183: Fix build with Qt 5.14

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R112 Milou BRANCH master REVISION DETAIL https://phabricator.kde.org/D26183 AFFECTED FILES lib/draghelper.cpp To: tcanabra

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz created this revision. ahartmetz added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahartmetz requested review of this revision. REVISION SUMMARY Whatever behavior change was apparently expected in Qt 5.14 didn't happen. I compiled again

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. Compiled against Qt 5.14 before this change: F7832282: before.png Compiled against Qt 5.14 after this change: F7832284: after.png REPOSITORY R120 Plasma Workspace REVISION DETAI

D26039: [Plasma Style KCM] Add search filter

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filterproxymodel.cpp:110 > + > +bool FilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex > &source_parent) const > +{ Ditto > filterproxymode

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > PrivacyTab.cpp:50 > public: > -KSharedConfig::Ptr mainConfig; > -KSharedConfig::Ptr pluginConfig; > +KActivityManagerdSettings mainConfig; > +KActivityMan

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Oops, selected wrong state :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi Cc: plasma-devel, LeGast00n,

D26077: [kcms/ksmserver] Swap shutdown options

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. I'm surprised, I was sure I checked that... but maybe I did it only for the loginMode. This is indeed the better quick and dirty fix we can apply for now. REPOSITORY R119 Plasma Desktop RE

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me, hoping we don't have two items with the same name in different settings objects. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082 To

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:207 > + > +CfgPlugin * plugin = dynamic_cast( configWidget ); > +emit defaulted(plugin->isDefaults()); No spaces between the parent

D26181: [KCM/Component] Clean deprecated code, modernize code

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:83 > > - for (KService::List::const_iterator tit = offers.begin(); tit != > offers.end(); ++tit) { > - ComponentSelector-

D26179: [KCM/Component] Clean up code of filemanager cfg

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooserfilemanager.cpp:72 > bool first = true; > -Q_FOREACH(const KService::Ptr& service, apps) > +for (const KService::Ptr& service : apps

D26189: Port to QRandomGenerator

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator TEST PLAN autotest ok REPOSITORY R111 KSysguard Library BRANCH port_QRandomGenerator (branched f

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#582095 , @anthonyfieroni wrote: > Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ That unfortunately does not seem to help. I set the environment in a shell inside konso

D26047: Expose KConfig settings to allow registration in KCM Notification

ervin added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Will need API documentation > broulik wrote in settings.h:343 > Not a fan of this becoming public API @broulik I understand you don't like much this becoming exposed as one could abuse

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 72087. davidre marked 7 inline comments as done. davidre added a comment. - ervin's comments - remove unused method declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71760&id=72087 BRANCH f

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 72088. davidre added a comment. Diff against master, somehow this branch is screwed up when using arc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=72087&id=72088 BRANCH filtermodel REVISION DETAIL

D26039: [Plasma Style KCM] Add search filter

davidre added inline comments. INLINE COMMENTS > themesmodel.cpp:161 > +QStringList themes; > +const QStringList &packs = > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, > QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory); > +for(const QString

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72089. meven added a comment. Make pluginConfig and mainConfig pointers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=71729&id=72089 BRANCH arcpatch-D26068 REVISION DETAIL https://phabricator.kde.or

D26039: [Plasma Style KCM] Add search filter

ervin added inline comments. INLINE COMMENTS > davidre wrote in themesmodel.cpp:237 > Is it also needed in a const member method? Not strictly speaking indeed. Now C++ being what it is you're never safe of someone introducing a member as mutable though. ;-) REPOSITORY R119 Plasma Desktop R

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72090. meven added a comment. Formatting issues fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72059&id=72090 BRANCH arcpatch-D26179_1 REVISION DETAIL https://phabricator.kde.org/D26179 AFFECTED

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72091. meven added a comment. Fix * position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72089&id=72091 BRANCH arcpatch-D26068 REVISION DETAIL https://phabricator.kde.org/D26068 AFFECTED FILES

D26068: [KCM/Activity] Use KConfigXT to store settings

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PrivacyTab.cpp:57 > > -Private() > -: viewBlacklistedApplicationsRoot(nullptr) > +Private(QObject* parent) > +: mainConfig(new KActivit

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72092. meven added a comment. Fix formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72090&id=72092 BRANCH arcpatch-D26179 REVISION DETAIL https://phabricator.kde.org/D26179 AFFECTED FILES

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 72093. meven marked 3 inline comments as done. meven added a comment. Fix position of * REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72091&id=72093 BRANCH arcpatch-D26068 REVISION DETAIL https://ph

D26181: [KCM/Component] Clean deprecated code, modernize code

meven updated this revision to Diff 72096. meven added a comment. Fix indentation (file mostly uses Tabs but not only), fix & position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26181?vs=72063&id=72096 BRANCH arcpatch-D26181 REVISION DETAIL

D26181: [KCM/Component] Clean deprecated code, modernize code

meven updated this revision to Diff 72097. meven marked 3 inline comments as done. meven added a comment. Fix & position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26181?vs=72096&id=72097 BRANCH arcpatch-D26181 REVISION DETAIL https://phabr

Proposal for Season of KDE 2020

Hello, I wanted to participate in Season Of KDE 2020, and was particularly interested in the Plasma-Phonebook project. I'm currently understanding the codebase and relevant frameworks involved in the project. I needed some help regarding my proposal for the same, I wanted to discuss and re-frame m

D26189: Port to QRandomGenerator

This revision was automatically updated to reflect the committed changes. Closed by commit R111:161b6c42205f: Port to QRandomGenerator (authored by mlaurent). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26189?vs=72085&id=72098 REVISION DETAIL h

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72099. meven marked 4 inline comments as done. meven added a comment. Keep isDefaults virtual, fix a fishy ref&, space formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72053&id=72099 BRANCH com

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72100. meven added a comment. Space formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72099&id=72100 BRANCH component-browser REVISION DETAIL https://phabricator.kde.org/D26100 AFFECTED FILE

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

ervin added a comment. Still some broken indentation, the files have weird indentation in that module it seems INLINE COMMENTS > componentchooserterminal.h:33 > void defaults() override; > +bool isDefaults() const override; > broken indentation > kcm_componentchooser.cpp:40 >

D26181: [KCM/Component] Clean deprecated code, modernize code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9eaa0d9ae73: [KCM/Component] Clean deprecated code, modernize code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26181?vs=72097&id=721

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72102. meven added a comment. fix two indentation issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72092&id=72102 BRANCH arcpatch-D26100 REVISION DETAIL https://phabricator.kde.org/D26179 AFFEC

D26192: Fix localization of the systemmonitor widget configuration window

yurchor created this revision. yurchor added reviewers: Localization, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Currently, the common config window messages are neither extracted nor used in all 5

D26179: [KCM/Component] Clean up code of filemanager cfg

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ervin wrote in componentchooserfilemanager.cpp:72 > Opening curly brace should be on the same line than for Is it me or it's in fact not done? Also should have

D26039: [Plasma Style KCM] Add search filter

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b25a0d41985e: [Plasma Style KCM] Add search filter (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=72088&id=72106 REVISION DE

D26183: Fix build with Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R112:dfecda35d4c7: Fix build with Qt 5.14 (authored by tcanabrava). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26183?vs=72067&id=72114 REVISION DETAIL https://phabr

D22382: Add global shortcuts for switching to the previous/next activity

ngraham added a comment. The Meta+Ctrl+Left/Light shortcuts being proposed for virtual desktop switching in D24281 . Let's wait to see what shakes out of that first. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

ngraham added a comment. IIRC Kai told me in person that this was okay, but let's wait for official confirmation. REPOSITORY R112 Milou BRANCH fix-bad-text-legibility (branched from master) REVISION DETAIL https://phabricator.kde.org/D25374 To: filipf, #plasma, #vdg, ngraham Cc: ngra

D26199: Remove unneeded shortcut for page naviagtion

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Kirigami provides shortcuts for page navigation out of the box TEST PLAN Still can switch pages by Alt+Arrow REPOSITOR

D26200: Add shortcut for closing pages

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart, ngraham. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The lack of standard way to close a page has always bothered me,

D26199: Remove unneeded shortcut for page naviagtion

alexeymin added a comment. Doesn't work for me, needs very fresh kirigami too? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella, #discover_software_store Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26199: Remove unneeded shortcut for page naviagtion

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me with Kirigami from git master. REPOSITORY R134 Discover Software Store BRANCH shortcut REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella, #discover_

D26200: Add shortcut for closing pages

ngraham added a comment. Hmm, does not work for me with Discover. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26200 To: nicolasfella, #kirigami, mart, ngraham Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, m

D26192: Fix localization of the systemmonitor widget configuration window

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9f5ed252baa4: Fix localization of the systemmonitor widget configuration window (authored by yurchor). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26192