D26238: Improve context menu

mvourlakos added a comment. In D26238#583413 , @trmdi wrote: > 1. It still works for other cases. Do you cycle in settings tabs with Meta+W, between Layouts and Preferences ? > 3. "Configure Application" sounds a bit unclearly. And i

D26238: Improve context menu

trmdi added a comment. 4. I want to separate between **View's items** (Add widget, Edit View) and **Latte's items** (Layouts, Configure Latte) because they are two different groups. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #v

D26238: Improve context menu

trmdi added a comment. 1. It still works for other cases. 3. "Configure Application" sounds a bit unclearly. And it can confuse users with "Configure Application Dashboard". "Configure Latte Global Settings..." is too long? REPOSITORY R878 Latte Dock REVISION DETAIL https://ph

D26238: Improve context menu

mvourlakos added a comment. the [Verb+Noun] sounds logical, updated names in my last comment REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fb

D26238: Improve context menu

mvourlakos added a comment. This commit needs to be split in different commits. Based on the approach I wil describe the issues of the commit and in what changes I can approve or not. SPLITTED COMMITS 1. The showLatteSettingsDialog() is used from more places and you have changed i

D26238: Improve context menu

trmdi updated this revision to Diff 72228. trmdi added a comment. - Add a new separator and change addWidget's icon REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72227&id=72228 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26

D26238: Improve context menu

ndavis added a comment. In D26238#583390 , @trmdi wrote: > In D26238#583389 , @ndavis wrote: > > > In the plasma panel context menu, add widgets and edit panel are below the separator > > > May

D26238: Improve context menu

trmdi added a comment. In D26238#583389 , @ndavis wrote: > In the plasma panel context menu, add widgets and edit panel are below the separator Maybe I need to create a new separator at the line 126 instead of reusing it. What about the

D26238: Improve context menu

ndavis added a comment. In the plasma panel context menu, add widgets and edit panel are below the separator REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus

D26238: Improve context menu

ndavis added a comment. This seems inconsistent with the Plasma panel context menu: F7844566: Screenshot_20191227_000605.png REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg Cc: ndavis, plas

D26238: Improve context menu

trmdi created this revision. trmdi added reviewers: Latte Dock, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Merge branch 'master' of https://anongit.kde.org/latte-dock REPOSITORY R878 Latte Dock BRANC

D26217: Add standard pen widths and replace hardcoded numbers

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. ...And after these patches land, let's do the doxygen-friendly comment formatting all at once in another patch. REPOSITORY R31 Breeze BRANCH replace-hardcoded (branched from master)

D26217: Add standard pen widths and replace hardcoded numbers

ndavis updated this revision to Diff 72223. ndavis added a comment. Change comment formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72157&id=72223 BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator.kde.

D25624: Don't use qmlRegisterType with QT-5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R258:92ffa670f0e5: Don't use qmlRegisterType with QT-5.14 (authored by plevine, committed by ngraham). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25624?vs=70645

D26212: [Applet] Remember devices to raise maximum volume

ngraham added a comment. Nice work. INLINE COMMENTS > StreamListItem.qml:29 > property bool onlyOne: false > +readonly property string maxVolumeTarget: if (Client) {return > Client.name} > Could be simplified and hardened to `Client ? Client.name : ""` REPOSITORY R115 Plasma A

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

ngraham added a comment. I think there is a deeper UI issue here in that there are two ways to raise the maximum volume that live in different places: one globally in the settings page, and another on a per-app/device basis accessed from the app/device's hamburger menu. Even if all the bugs

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

ngraham added a comment. Actually I spaced for a moment and just remembered that we already have a mockup in T10470 that shows how we'd like this to work in the future: F7842082: audio tray.png Basically the

D26217: Add standard pen widths and replace hardcoded numbers

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in breeze.h:179 > It's a Doxygen style. If you do it, KDevelop shows the comments in the > tooltips for the commented functions, classes and variables. Probably makes sense to do this universally all at once, rather than in little b

D26217: Add standard pen widths and replace hardcoded numbers

ndavis added inline comments. INLINE COMMENTS > ngraham wrote in breeze.h:179 > Why three slashes for these comments? It's a Doxygen style. If you do it, KDevelop shows the comments in the tooltips for the commented functions, classes and variables. REPOSITORY R31 Breeze REVISION DETAIL h

D9875: Extend parsing ssh prompt

ngraham added a comment. In D9875#583139 , @fvogt wrote: > In D9875#583106 , @pali wrote: > > > Is there anything else or something which blocks merging this change into upstream git repository? >

D26217: Add standard pen widths and replace hardcoded numbers

ngraham added a comment. +1, seems sensible to me, but probably wait for @hpereiradacosta's go-ahead. INLINE COMMENTS > breeze.h:179 > + */ > +/// The standard pen stroke width for symbols. > +static constexpr qreal Symbol = 1.01; Why three slashes for these comments?

D26121: Kicker/RecentDocument display file path as decoration

ervin accepted this revision. ervin added a comment. LGTM, might need an update if D26122 lands though. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma, ngraham, e

D26235: fix latte-dock command not showing in README

zlatin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zlatin requested review of this revision. REPOSITORY R878 Latte Dock BRANCH fix-readme (branched from master) REVISION DETAIL https://phabricator.kde.org/D26235 AFFECTED FILES README.m

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Unify 'raise maximum volume' menu option and 'maximum volume' configuration setting. M

D26228: KCM Fonts ConfigModule to ManagedConfigModule

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fonts.cpp:600 > > -void KFonts::updateNeedsSave() > -{ > -setNeedsSave(m_settings->isSaveNeeded() || > m_fontAASettings->needsSave()); > +bool KFonts::isS

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#583106 , @pali wrote: > Is there anything else or something which blocks merging this change into upstream git repository? Do you have a contributor account? If not, I can push it. REPOSITORY R105 KDE SSH

D9875: Extend parsing ssh prompt

pali added a comment. Is there anything else or something which blocks merging this change into upstream git repository? REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali, fvogt Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D26229: Add immutability to kcm fonts

bport created this revision. bport added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Add immutability to kcm fonts, apply all willa apply font for mutable font type only REPOSITORY

D26228: KCM Fonts ConfigModule to ManagedConfigModule

bport created this revision. bport added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26228 AFFECTED FILES kcms/fonts/f

D26052: KCM Cursor Theme : Use ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1e4271fb4cc3: KCM Cursor Theme : Use ManagedConfigModule (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26052?vs=71958&id=72191 REVISIO

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:81747d91c1dd: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor… (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. In D24847#574269 , @ngraham wrote: > So what is this patch doing now? When I delete the selected icon theme, the selection rect moves to the first one in the grid, causing the theme to change when you click Apply. This see

D24846: Port kcm icons to kconfigxt

bport updated this revision to Diff 72189. bport added a comment. Update according to ervin feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24846?vs=71956&id=72189 REVISION DETAIL https://phabricator.kde.org/D24846 AFFECTED FILES kcms/i