D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

ndavis updated this revision to Diff 72280. ndavis added a comment. Change comment formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26225?vs=72277&id=72280 BRANCH replace-hardcoded-2 (branched from master) REVISION DETAIL https://phabricator.kd

D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen

ndavis updated this revision to Diff 72277. ndavis added a comment. - Change newFrameRadius to newPenWidthFrameRadius This name doesn't sound very good, but at least it's more descriptive. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26225?vs=72185&id=

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein added a comment. It's definitely a discussion I'd enjoy more :) REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D25773 To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis Cc: filipf, plasma-devel,

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham added a comment. Well, I don't wanna hasten our demise under the crushing weight of bloat, and I can appreciate your voice of wisdom. :) So I'll hit the pause button and continue the discussion. Now that I think about it, if I step back and examine my motivations for this, it's

D25889: Polish the "review this review" UI and presentation

ngraham planned changes to this revision. ngraham added a comment. In D25889#583707 , @ndavis wrote: > Here's a suggestion for a way to improve the UI: F7846171: Screenshot_20191227_195713.png That l

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 28 Dec 2019 04:25:43 + Build duration: 38 sec and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 28 Dec 2019 04:25:43 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncat

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein accepted this revision. hein added a comment. Ah sorry, I had a reply typed into the text field but must have botched hitting Submit. Personally, I'm not a fan - I think there's a bad trend of us overstuffing the default panel now like we're looking out of "what more can we add ..."

D25762: Only serialize window pixmap if we're using it

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbam

D26217: Add standard pen widths and replace hardcoded numbers

This revision was automatically updated to reflect the committed changes. Closed by commit R31:c16eb7a4614f: Add standard pen widths and replace hardcoded numbers (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72270&id=72271 REVIS

D26217: Add standard pen widths and replace hardcoded numbers

ndavis updated this revision to Diff 72270. ndavis marked 2 inline comments as done. ndavis added a comment. Change symbol pen width back to 1.1 REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72223&id=72270 BRANCH replace-hardcoded (branched from

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. Another thing to consider is whether or not the review section in Discover should be kept consistent with the reviews/comments in the new GHNS UI. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol,

D26244: Install all kcm plugins into kcms subdir

apol added a comment. Hi, This is a good change but I'm afraid it needs some more tweaking. Are you sure this doesn't need adapting the desktop files? In fact, can you take a look at how the colors kcm does it? Emphasis on the kcoreaddons_desktop_to_json bit. REPOSITORY R119 Plasma

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. In D25889#577558 , @ngraham wrote: > I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Mayb

D26217: Add standard pen widths and replace hardcoded numbers

ndavis marked an inline comment as done. ndavis added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breeze.h:180 > For the record, //* (and /**) should also be caught by Doxygen (and hopefully > KDevelop). It is used more or less systematically in oxygen, so please use > this inst

D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen

hpereiradacosta added inline comments. INLINE COMMENTS > breezehelper.h:318 > +//* frame radius with new pen width > +constexpr qreal newFrameRadius ( const qreal oldRadius, const int > penWidth ) const > +{ return qMax( oldRadius - (0.5 * penWidth), 0.0 ); } Would need

D26217: Add standard pen widths and replace hardcoded numbers

hpereiradacosta accepted this revision. hpereiradacosta added a comment. looks good. See comment about the symbol pen width change and then ship it. In D26217#583358 , @ngraham wrote: > ...And after these patches land, let's do the doxygen-fr

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0fffa46372c: [KCMs/Workspace] Add explanatory labels for click-related settings (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25873?

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

Fuchs accepted this revision. Fuchs added a comment. This revision is now accepted and ready to land. Good for me, hopefully the upstream bug will be fixed, too :) REPOSITORY R119 Plasma Desktop BRANCH explanatory-text (branched from master) REVISION DETAIL https://phabricator.kde.org/

D25889: Polish the "review this review" UI and presentation

ngraham added a comment. Ping. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngra

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

ngraham added a comment. Ping. If nobody likes this, I can just abandon it, but I'd appreciate some feedback one way or another. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25873 To: ngraham, #vdg, #plasma, Fuchs Cc: davidedmundson, ndavis, plasma

D25991: [KFilePlacesModel] Fix supported scheme check for devices

ngraham added a comment. @bruns? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, al

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. @davidedmundson ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, The-Feren-OS-Dev, jra

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham added a comment. @hein ping. Other folks seem to like this, but I don't want to move ahead without your approval since you're the maintainer. Maybe we can discuss it some more? REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL h

D26238: Improve context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72253&id=72255 REVISION DETAIL https://phabrica

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

https://bugs.kde.org/show_bug.cgi?id=369158 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

D26238: Improve context menu

mvourlakos added a comment. In D26238#583563 , @trmdi wrote: > In D26238#583556 , @mvourlakos wrote: > > > In D26238#583555 , @trmdi wrote: > > > > > I

D26238: Improve context menu

trmdi added a comment. In D26238#583556 , @mvourlakos wrote: > In D26238#583555 , @trmdi wrote: > > > In D26238#583551 , @mvourlakos wrote: > > > > > @

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

gvgeo planned changes to this revision. gvgeo added a comment. Either I missing something, or I need to make it more clear. With this patch, the maximum volume setting is for the devices/apps that have enabled the raise maximum option. By default users will be limited to 100. Will need

D26238: Improve context menu

trmdi updated this revision to Diff 72253. trmdi added a comment. - Change icon of the configure action REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72246&id=72253 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTE

D26238: Improve context menu

mvourlakos added a comment. In D26238#583555 , @trmdi wrote: > In D26238#583551 , @mvourlakos wrote: > > > @trmdi I used Cuttlefish app, it points to **"edit"** > > > Maybe it's `document-edit`

D26238: Improve context menu

trmdi added a comment. In D26238#583551 , @mvourlakos wrote: > @trmdi I used Cuttlefish app, it points to **"edit"** Maybe it's `document-edit`. (See this: https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.ht

D26238: Improve context menu

mvourlakos added a comment. @trmdi I used Cuttlefish app, it points to **"edit"** REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D26238: Improve context menu

mvourlakos added a subscriber: ngraham. mvourlakos added a comment. In D26238#583529 , @trmdi wrote: > In D26238#583386 , @ndavis wrote: > > > This seems inconsistent with the Plasma panel context men

D26244: Install all kcm plugins into kcms subdir

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY To reduce clutter in the plugins dir. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.or

D26238: Improve context menu

trmdi added a comment. In D26238#583386 , @ndavis wrote: > This seems inconsistent with the Plasma panel context menu: F7844566: Screenshot_20191227_000605.png Do you know what icon is used for the "

D26238: Improve context menu

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. looks ok... I am not that fond of the second line separator but we can discuss this again in the future. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https:

D26238: Improve context menu

trmdi added a comment. In D26238#583520 , @mvourlakos wrote: > look ok! Can you please provide also the three screenshots mentioned earlier for reference? Done. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org

D26238: Improve context menu

mvourlakos added a comment. look ok! Can you please provide also the three screenshots mentioned earlier for reference? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-O

D26238: Improve context menu

trmdi updated this revision to Diff 72246. trmdi added a comment. - Typo REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72244&id=72246 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTED FILES app/layouts/manager.c

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.h:114 > void hideLatteSettingsDialog(); > -Q_INVOKABLE void showLatteSettingsDialog(int page = > Latte::Types::LayoutPage); > +Q_INVOKABLE void showLatteSettingsDialog(int firstPage = > Latte::Types::LayoutPage, bool toogl

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

anthonyfieroni added inline comments. INLINE COMMENTS > main.xml:10 > > - 100 > + 150 > I don't think the default should be anything but 100 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo, #vdg, #plasma, drosca

D26238: Improve context menu

trmdi updated this revision to Diff 72244. trmdi added a comment. - Call toggleCurrentPage() only when using the shortcut REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72238&id=72244 BRANCH master REVISION DETAIL https://phabricator.kde.o

D26242: Port the translations module to ManagedConfigModule

ervin updated this revision to Diff 72243. ervin added a comment. Add missing files REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26242?vs=72242&id=72243 REVISION DETAIL https://phabricator.kde.org/D26242 AFFECTED FILES kcms/translations/CMa

D26242: Port the translations module to ManagedConfigModule

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2624

D26241: Remove Kirigami DelegateRecycler

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This is not really needed here due to the size of the delegates and

D26212: [Applet] Remember devices to raise maximum volume

gvgeo planned changes to this revision. gvgeo added a comment. Patch is not needed, without separate raise maximum volume mode. D26234#583337 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26212 To: gv

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

gvgeo added a comment. I get what you mean global, but I'll try to clarify for others, too. Currently, the option in configuration, only works from shortcuts or mouse wheel on task icon. And affects only the default output device, that is selected, at the moment of volume change. Fro

D26238: Improve context menu

mvourlakos added a comment. @trmdi based on your last commit: 1. you have made all showLatteSettingsDialog callers as togglers, meaning that : IF Latte Layouts manager is already shown and the user tries Layouts->Manage Layouts then the settings tab will switch to Latte Preferences wind

D26238: Improve context menu

trmdi updated this revision to Diff 72238. trmdi added a comment. - Address comments REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72228&id=72238 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTED FILES app/layou

D26219: Check DPMS extension being present

This revision was automatically updated to reflect the committed changes. Closed by commit R122:18e53dbaaea2: Check for DPMS extension being present (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26219?vs=72160&id=72234 REVISION DETA

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.cpp:419 > > void Manager::showLatteSettingsDialog(int page) > { We could try to rename the function to: void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = false) when cycleBetweenPages = true then the