D26418: [Applet]Add global mute function

gvgeo planned changes to this revision. gvgeo added a comment. Will remove timer,`onRowsInserted` in `paSinkModel` does the same during init. And will move `forceGlobalMute` inside `paSinkModel`. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D

[Breeze] [Bug 370569] kde4breeze.upd ignores system distributor values from XDG_CONFIG_DIRS/kdeglobals

https://bugs.kde.org/show_bug.cgi?id=370569 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[Breeze] [Bug 365690] kaccessibleapp icon

https://bugs.kde.org/show_bug.cgi?id=365690 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham commandeered this revision. ngraham edited reviewers, added: mthw; removed: ngraham. ngraham added a comment. Yoink. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-d

D26425: [Notifications KCM] Fixup current item syncing logic

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of relying on `currentIndex` and some massively complicated logic to track when the index

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

broulik added a comment. hmm, I wanted to have it more obvious than being the first "System Service" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26423 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fba

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

ngraham added a comment. Hmm, it's a bit odd to have an item not in a section when everything else is. Maybe it could be moved to the top of the "System Services" category or be renamed "General" or something. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it obvious that it's not an application or "service" but more of an overall category of

D26422: [Notifications] Fix ListView attached property

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is only attached to the delegate item itself. Broke when it got shuffled around when swi

D26421: Only show full name in review dialog

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The review gets submitted with your full name, but the review dialog curren

D26418: [Applet]Add global mute function

ngraham added a comment. Code looks sane enough except for one thing: INLINE COMMENTS > main.qml:659 > > +// Wait for paSinkModel init. > +Timer { This makes me nervous. How do we know it will have initialized after 200 ms? Is there an `onFinished` signal we can listen for or some

D26271: [Applet]Update layout based on T10470

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Very nice work! I continue to be impressed with your contributions. > What else to do, without displaying the full device names? Display full device names when there's m

D26256: [Applet] Make 'raise maximum volume' global

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Works great. Just a few code change requests: INLINE COMMENTS > main.qml:546 > +id: raiseMaximumVolumeCheckbox > +spacing: units.smallSpacing * 1

D26418: [Applet]Add global mute function

ngraham accepted this revision as: VDG. ngraham added a comment. UI and functionality are good. I'll leave the code review to a #plasma person or @drosca. There is quite a lot of added code. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETA

D26378: [Download Plugin] Register downloaded files as recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ddea25bf47f1: [Download Plugin] Register downloaded files as recent documents (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72762. gvgeo added a comment. Add global mute for shortcuts/tray icon. Will prioritize current sink mute state, and accordingly will also trigger global mute. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kd

D26378: [Download Plugin] Register downloaded files as recent documents

hein accepted this revision. hein added a comment. I love it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D26378 To: broulik, #plasma, hein, #vdg, fvogt, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalo

D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

ngraham added a comment. #plasma folks, does the way I've changed this make sense? REPOSITORY R120 Plasma Workspace BRANCH fix-clock-long-date-in-vertical-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D26312 To: ngr

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven updated this revision to Diff 72761. meven added a comment. Remove outdate ifdef, we depend on KF5 5.62 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26416?vs=72735&id=72761 BRANCH arcpatch-D26416 REVISION DETAIL https://phabricator.kd

D26305: Fix Ctrl+F shortcut conflict

This revision was automatically updated to reflect the committed changes. Closed by commit R124:4a82adba76df: Fix Ctrl+F shortcut conflict (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26305?vs=72503&id=72760 REVISION DETAIL

D25889: Polish the reviews UI and presentation

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f41f25e895a9: Polish the reviews UI and presentation (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72758&id=72759

D25889: Polish the reviews UI and presentation

ngraham updated this revision to Diff 72758. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72336&id=72758 BRANCH polish-review-reviewing (

D26409: [kicker] Use arrow functions in signal handlers

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4b20f3a91006: [kicker] Use arrow functions in signal handlers (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26409?vs=72723&id=72

D25889: Polish the reviews UI and presentation

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ReviewDelegate.qml:188 > +checkable: true > +checked: { > +switch(usefulChoice) { `checked: usef

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:251 > +auto getFileItem = [=] () { > +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0) > +// Avoid calling QT_LSTAT and accessing recent documents I'm pretty sure we can/should depend on newer KF5. I'd say just

D26418: [Applet]Add global mute function

ngraham added a comment. Current icon is fine BTW. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26418 To: gvgeo, #vdg, #plasma, drosca Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBo

D26418: [Applet]Add global mute function

ngraham added a comment. Nice. One thing I notice is that when I press the mute button on my keyboard, it triggers the applet to enter the muted state for the (sole) audio output, but it does not trigger the new global muted state. Could it do this? REPOSITORY R115 Plasma Audio Volume Appl

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72755. meven added a comment. Use view-hidden icon for Hide Application action for consistency REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72754&id=72755 BRANCH arcpatch-D26386_1 REVISION DETAIL

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72754. meven added a comment. Clean unwanted change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72752&id=72754 BRANCH arcpatch-D26386_1 REVISION DETAIL https://phabricator.kde.org/D26386 AFFECT

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72752. meven added a comment. Change signature of Kicker::createActionItem and update all its users REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72697&id=72752 BRANCH arcpatch-D26386_1 REVISION DET

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72753. gvgeo added a comment. squash REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72741&id=72753 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418 A

D26256: [Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 72751. gvgeo added a comment. squash REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72740&id=72751 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256

D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 72750. gvgeo added a comment. Add visibility to the line that splits playback and record. On the application side, will show if there is 1 record and 1 playback application. Because there is no port name to easily differentiate them. REPOSITORY R115 Pl

D26418: [Applet]Add global mute function

gvgeo added a comment. Icon is not monochrome. Is there an alternative? Or have to do it with desaturate graphical effect? With the current functionality, fits nice to make it colored when all the devices are muted. This adds a semi enabled state, when global mute is not enabled.

D26271: [Applet]Update layout based on T10470

gvgeo marked 7 inline comments as done. gvgeo added a comment. About the devices labels, I feel it is fine as it is. It is not a problem, to have two devices with the same port name. Only if could put a tooltip. But no, Radiobutton does not deserve a tooltip. What else to do, without displ

D26418: [APPLET]Add global mute function

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add a Mute icon that will force all playback devices to mute. Even if new device/port conn

D26256: [WIP][Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 72740. gvgeo added a comment. Moved limit max volume, code part,from listbase.qml into the main.qml checkbox. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72295&id=72740 BRANCH raise (bra

D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 72739. gvgeo added a comment. Remove port combobox and put port selection back the hamburger menu. Now port selection appears only if there is at least 2 available ports. Made devices/applications labels clickable. Removed RTL margin problems.

D26378: [Download Plugin] Register downloaded files as recent documents

broulik updated this revision to Diff 72737. broulik edited the test plan for this revision. broulik added a comment. - Make configurable REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26378?vs=72656&id=72737 REVISION DETAIL https://ph

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Save quite a few KFileItem instanciation. On each document hovering several KFileItem were instanc