D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-12 Thread Kai Uwe Broulik
broulik added a comment. > can you look into that? Perhaps @ngraham can. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

Re: Long press global shortcuts

2020-01-12 Thread Kai Uwe Broulik
Hi, I noticed on my phone all buttons (power, volume, home) react only on release. On the desktop I don't know how annoying it would be to react only on press. However, that would also make it consistent with in-application shortcuts, which also trigger on press. Perhaps it's best to only

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

2020-01-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 73369. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Remove enable/disable animation - Enabled becomes green - Now monitors kded running - Notifies when modules got

D26586: [SystemTray] Rework system tray settings

2020-01-12 Thread Nathaniel Graham
ngraham added a comment. In D26586#592707 , @kmaterka wrote: > In D26586#592050 , @ngraham wrote: > > > Much better! The scrollview needs a frame around it though. You can do this by adding this to

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Nathaniel Graham
ngraham added a comment. Gross, I hate it when Phabricator does that. :( I still haven't figured out what causes this. Whenever it happens, I just go back in the history (in this case https://phabricator.kde.org/D22382?vs=on=61521=ignore-most#toc) copy the diff, manually apply it to HEAD

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser
muesli added a comment. Oops, I'm not sure what I've did here was what I intended: I rebased master (>800 commits since my original changeset) into my feature branch because I otherwise couldn't build/test my changes anymore, but obviously I didn't touch/change > 600 files. Is this how

[plasmashell] [Bug 368942] Splash screen spinner should disappear instead of pause when fading into desktop

2020-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368942 Nate Graham changed: What|Removed |Added Component|Global Theme packages |Theme - Breeze -- You are receiving this mail

D26586: [SystemTray] Rework system tray settings

2020-01-12 Thread Konrad Materka
kmaterka added a comment. In D26586#592050 , @ngraham wrote: > Much better! The scrollview needs a frame around it though. You can do this by adding this to it: Is it decided (D26530 )? Correct me if

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 73354. muesli added a comment. - Remove default key-sequence for "Previous/Next Activity" shortcut REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=61521=73354 BRANCH shortcut-prevnext-activity

D26609: [kstyle] Port to KWindowSystem shadows API

2020-01-12 Thread Vlad Zahorodnii
zzag created this revision. zzag added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R113 Oxygen Theme BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26609

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-12 Thread Vlad Zahorodnii
zzag updated this revision to Diff 73350. zzag added a comment. Track Shadow object REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=72863=73350 BRANCH port-to-shadows-api REVISION DETAIL

D26475: [kstyle] Port to KWindowSystem shadows API

2020-01-12 Thread Vlad Zahorodnii
zzag updated this revision to Diff 73349. zzag added a comment. Re-write the entire port :/ In case of server-side drop-shadows, we don't want to destroy KWindowShadow before QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed is emitted, otherwise the associated window will be

Long press global shortcuts

2020-01-12 Thread Aleix Pol
Hi, In a discussion some weeks ago, we came to the conclusion that it would make sense to support long press global shortcuts. The use-case we discussed back then was the power button on the Plasma phone. We need to have 2 actions upon press. Short press would lock and dim the screen, long press

D25947: Add applet for controlling Night Color

2020-01-12 Thread Yuri Chornoivan
yurchor added a comment. In D25947#592565 , @victorr wrote: > There is a small typo. > You need to replace the quotation marks. > Attached a patch. > F7879213: kdeplasma-addons-5.17.80-fix.patch

D26584: Load localization catalog for slideshow config window

2020-01-12 Thread David Edmundson
davidedmundson added a comment. > I'm still not totally clear on why some things require a domain to be added for translations, and other things don't. Everything requires a domain set in some way. For apps/C++ this is done effectively magically at compile time. For QML we have

D25947: Add applet for controlling Night Color

2020-01-12 Thread Victor Ryzhykh
victorr added a comment. There is a small typo. You need to replace the quotation marks. Attached a patch. F7879213: kdeplasma-addons-5.17.80-fix.patch REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25947 To:

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-12 Thread Méven Car
meven added a comment. In D26582#592266 , @aleksejshilin wrote: > In D26582#591959 , @meven wrote: > > > Well there was already KRun::setRunExecutables :) > > > I've already talked about it in

D26584: Load localization catalog for slideshow config window

2020-01-12 Thread Yuri Chornoivan
This revision was automatically updated to reflect the committed changes. Closed by commit R120:025387c931b3: Load localization catalog for slideshow config window (authored by yurchor). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE