D14949: Add option for whether to show the volume change OSD

baberts added a comment. In D14949#580132 , @romangg wrote: > In D14949#580117 , @alexde wrote: > > > Additional there could be a radiobutton > > > > - Display none in full screen apps > > >

D26777: [App Style KCM] Port away from QDBusInterface

apol added a comment. Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari Cc: apol, plasma-devel, Orage, LeGa

D26772: [kcm] Handle empty shortcut in property fetch

apol added a comment. FWIW, for this you could have used QList::value(0), it would have saved quite a bit of boilerplate. https://doc.qt.io/qt-5/qlist.html#value REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26772 To: davidedmundson, #plasma, ngraham Cc: a

D26738: Fix typo, launch plugin with argument, change signals

apol added a comment. +1 to me, hopefully someone more familiar with this code can review, otherwise I'll approve it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26738 To: alex, broulik Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26777: [App Style KCM] Port away from QDBusInterface

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Giving that the QDBusInterface introspects the DBus interface blockingly in its constructor. REPOSITORY R119 Plasma Desktop BRANC

D26773: Added option to blur background on active window

Zren added a comment. I don't care if Inactive Blur is upstreamed or not as all my code is GPL. I didn't upstream it since I thought the feature was niche enough I shouldn't burden others with it's maintenance. This doesn't blur the desktop widgets, onl

D26773: Added option to blur background on active window

niccolove added a comment. Yes, I *DID* take some code from Zren plugin and wrote some other. My intention was absolutely not to steal his code, I want to be clear about that: I had opened an issue on his repo asking him to upstream the code, but then I thought that it was probably simple en

D26772: [kcm] Handle empty shortcut in property fetch

This revision was automatically updated to reflect the committed changes. Closed by commit R133:5140150ef80c: [kcm] Handle empty shortcut in property fetch (authored by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26772?vs=73892&id=739

D26772: [kcm] Handle empty shortcut in property fetch

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch. REPOSITORY R133 KScreenLocker BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D26772 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Ora

D26773: Added option to blur background on active window

ngraham added a comment. There are legitimate questions regarding whether or not we should add this feature, and if this is the right place for it (a KWin effect intuitively seems more appropriate to me, if we upstream it). However aside from that, is this your code? The absence of a license

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595756 , @davidedmundson wrote: > I don't want us to make krunner autostart. It's a hack, not a fix. I'm gonna play devil's advocate here :) If having an already running KRunner service is a hack, t

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski planned changes to this revision. pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:262 > if (!e->modifiers() || e->modifiers() == Qt::ShiftModifier) { > const QString text = e->text().trimmed(); > if (!text.isEmpty() && text[0].isPrint()) { TO

D26773: Added option to blur background on active window

niccolove added a comment. Mh, but this is specifically to blur just the wallpaper, as you might want to get information from other windows. At that point, it would be weird for it to be a kwin effect, as it's much more related to just the wallpaper, and the user would expect it to be in the

D26773: Added option to blur background on active window

anthonyfieroni added a comment. That's look interesting but indeed it should be a KWin feature, say it has effect `dim inactive` this should be `blur inactive` then wallpaper and any other inactive window will be blurred. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D26773: Added option to blur background on active window

niccolove added a comment. I've tried to ask some users, and I received generally positive feedback on the idea, as many considered it pretty. There's a plugin that does this (with many positive reviews on the store), but I think it's not a good idea to fork very similar codebases, and this

D26773: Added option to blur background on active window

davidedmundson added a comment. What's the use case? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26773 To: niccolove, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, n

D26773: Added option to blur background on active window

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Create an option, off by default, that blurs the wallpaper when it detecs an open window. Currently it broke the transition f

D26772: [kcm] Handle empty shortcut in property fetch

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY .first() wasn't guarded with a check of the list size. REPOSITORY R133 K

D26720: Cache single image wallpapers locally

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > This doesn't appear to be containment-aware (e.g. multi-screen, activities, etc). As Kai said, changing status just to clean up the queue. I was also un

D24706: [RFC] Change button style

ahiemstra added a comment. > Or is QML's rotation property not the right property to use? Basically this. I would even go further and say that a normal Button/ToolButton is not the right control to use and instead you should use some sort of "VerticalTextButton" or so. Except that of cou

D26770: [App Style KCM] Hide preview buttons, if previewers are not found

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY BUG: 416343 FIXED-IN: 5.18.0 TEST PLAN 1. Open GTK page of Application Style KCM, the preview buttons should be present 2. Del

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73876. trmdi added a comment. - Add https://phabricator.kde.org/D11025 REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73861&id=73876 BRANCH update-ToolTipInstance-fromPlasma REVISION DETAIL https://phabr

D26765: Correctly save shortcuts of new Items

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY When saving first all changes are saved before updating syscoca. This lead to a crash because serviceByStorageId failed. We can j

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/1/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 05:17:25 + Build duration: 7 hr 40 min and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/1/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 19 Jan 2020 05:31:58 + Build duration: 7 hr 25 min and counting CONSOLE OUTPUT [...trun

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#596760 , @mvourlakos wrote: > Is there any improvement, or it is just a code update? Some minor improvements: - https://phabricator.kde.org/D22230 - https://phabricator.kde.org/D21629 REPOSITORY

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. Is there any improvement, or it is just a code update? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26760: Update from Plasma

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Just pull the update from Plasma REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-from