D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. I would prefer to be separate commits. Please commit this one and we can discuss in upcoming commit the highlight changes REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :) REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL

D26889: Change notification button text to "View Updates"

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is more accurate; "Update" inaccurately implies that updates will

D26836: [kcmshell] Drop kdeinit

This revision was automatically updated to reflect the committed changes. Closed by commit R126:15d375fe81b0: [kcmshell] Drop kdeinit (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26836?vs=74104=74290 REVISION DETAIL

D26838: Drop kdeinit

This revision was automatically updated to reflect the committed changes. Closed by commit R103:fcbae4cbadd5: Drop kdeinit (authored by davidedmundson). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26838?vs=74106=74289 REVISION DETAIL

D26720: Cache single image wallpapers locally

trmdi added inline comments. INLINE COMMENTS > trmdi wrote in image.cpp:503 > `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath Sorry, I meant QDir::mkpath is needed for KIO::CopyJob, not here, otherwise CopyJob will fail when the destination directory does not exist.

D21764: Port all plasma workspace to new libkworkspace API

davidedmundson updated this revision to Diff 74288. davidedmundson marked 4 inline comments as done. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21764?vs=59642=74288 BRANCH master REVISION DETAIL

D25428: Improved support for desktop "Folder View"

hein added a comment. Just a quick note I will review this tomorrow or next week when I'm on vacation, sorry for the long wait. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfella,

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf added a comment. In D26880#600026 , @abetts wrote: > I would suggest a circular button instead of square. I also think this would look more attractive. I've already investigated the possibility and here's a few notes: - our

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

abetts added a comment. I would suggest a circular button instead of square. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26880 To: filipf, ngraham, #vdg, #plasma, hein, broulik Cc: abetts, hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26885: Remove misleading comment about the setting, that does not exist anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R119:51e6e92468f9: Remove misleading comment about the setting, that does not exist anymore (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26885: Remove misleading comment about the setting, that does not exist anymore

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY BUG: 416636 FIXED-IN: 5.18.0 REPOSITORY R119 Plasma Desktop BRANCH remove-colors-comment (branched from master) REVISION

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7127464c0d66: [Task Manager] Draw audio icon highlight effect behind the icon, not in front… (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26884: [Folder View] Fix text label color in pop-up

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently there's a top-level ColorScope that is almost entirely unused

D26850: [SystemTray] Refresh icon in settings on update

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > broulik wrote in systemtraymodel.cpp:269 > Avoid `keys()` which creates a temporary list, instead use iterators > > const auto roleNames = sourceModel->roleNames(); > for (auto it =

D26850: [SystemTray] Refresh icon in settings on update

kmaterka updated this revision to Diff 74272. kmaterka added a comment. Iterator used REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26850?vs=74164=74272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26850 AFFECTED FILES

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. In D26861#599957 , @Fuchs wrote: > - Icon wise, given that it can still overlap with the app icon, I would prefer something that has a contrasting border, so e.g. a dark audio indicator is still visible on a dark app

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a comment. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a reviewer: manueljlin. ngraham added a comment. Looking pretty good to me, UI-wise. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson,

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

ngraham created this revision. ngraham added reviewers: hein, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the "Arrange in" and "Align" submenus below "Sort by" and "Icon size", which are more

D26861: [Applet/Task Manager] Move audio indicator to the corner

Fuchs added a comment. Looks good to me, thank you very much for the work :-) Sidesnotes that I mentioned in the group, just so they are documented here: - I think for a clickable action it can become too small, so it takes too much aiming. However, it doesn't get in the way, and

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo planned changes to this revision. gvgeo added a comment. In D26880#599939 , @filipf wrote: > I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller: > >

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Pretty nice. But clicking on `playerControlsRow` (exclude buttons) does not behave the same way like clicking on the cover art, while the effect would make users think that they can click on the control row to open the window. REPOSITORY R119 Plasma Desktop

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's wait for a #plasma review too to make sure this is the most technically correct way (I think it is but I'm not 100% sure).

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf updated this revision to Diff 74269. filipf added a comment. have the hover effect fill the icon instead of the mousearea so that the icon doesn't overflow the effect at small sizes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf added a comment. I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller: F7923931: Screenshot_20200123_190024.png The icon overflows the hover effect. I'm going

D26881: [Applets/Folder View] Allow using a folder that ends with a space

ngraham created this revision. ngraham added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `QUrl::fromLocalFile` is otherwise appropriate but automatically strips a trailing space,

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf added a subscriber: hein. filipf added a comment. In D26880#599907 , @gvgeo wrote: > More sane value like z: 1 in the svg should be enough . > > But in this case can MouseArea move before svg? Makes more sense to me, having the code

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf updated this revision to Diff 74267. filipf added a comment. don't use "z" hacks, just rearrange the order of items also port the top item to MouseArea to be more efficient REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26880?vs=74261=74267

D26514: Delay popup for containments

trmdi updated this revision to Diff 74264. trmdi added a dependency: D26484: Add KIO::DropJobFlag to allow manually showing the menu. trmdi added a comment. - Show drop menu manually when dropping things into the desktop REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

gvgeo added a comment. More sane value like z: 1 in the svg should be enough . But in this case can MouseArea move before svg? Makes more sense to me, having the code in the draw order . I'm not a developer, just asking. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74262. gvgeo added a comment. Fix inhibition icon size. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74228=74262 BRANCH b3 (branched from master) REVISION DETAIL

D26866: [Kickoff] Theme separators

This revision was automatically updated to reflect the committed changes. Closed by commit R119:33b138893bcd: [Kickoff] Theme separators (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26866?vs=74221=74263 REVISION DETAIL

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Some Plasma themes used filled-style highlight effects which means that their audio icon gets completely covered by the highlight

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. In D26797#599747 , @filipf wrote: > A lot cleaner and straightforward now, good job. I was wondering though what it would look like if we made all the comoboboxes have equal width (if possible). I can make that

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#599227 , @mvourlakos wrote: > @trmdi have you checked the previews still work OK after the patch? Yes, I tested it. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To:

D26861: [Applet/Task Manager] Move audio indicator to the corner

filipf added a comment. I don't use IOTM, but this looks quite alright to me. REPOSITORY R119 Plasma Desktop BRANCH audioshrink (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf,

D26875: Make it possible to stream only input

jgrulich added inline comments. INLINE COMMENTS > waylandintegration.cpp:257 > m_streamingEnabled = true; > +startStreamingInput(); > bindOutput(output.waylandOutputName(), > output.waylandOutputVersion()); Maybe use m_streamInput = true for consistendy with

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 74260. trmdi added a comment. - Address comment REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73935=74260 BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added inline comments. INLINE COMMENTS > PopupDialog.qml:76 > +visible: inhibitions.length > 0 > +iconSource: inhibitions.length > 0 ? inhibitions[0].Icon > || "" : "" > +text: { The icon is a bit small: F7923036:

D26875: Make it possible to stream only input

apol created this revision. apol added reviewers: Plasma, KDE Connect. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to share our screen contents to be able to move the mouse. TEST PLAN Ported KDE

D26850: [SystemTray] Refresh icon in settings on update

broulik added inline comments. INLINE COMMENTS > systemtraymodel.cpp:269 > +QHash roleNames = sourceModel->roleNames(); > +for (const int key : roleNames.keys()) { > +if (!m_roleNames.contains(key)) { Avoid `keys()` which creates a temporary list, instead use iterators const

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added subscribers: cblack, filipf, ndavis, Fuchs, broulik. ngraham added a comment. This revision is now accepted and ready to land. I was working on a patch to improve things here and it was almost identical to this one. I think this is a good fix.

D26709: add gpu entry to about system

sitter updated this revision to Diff 74250. sitter added a comment. s/gpu/graphics processor/ REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26709?vs=73710=74250 BRANCH gpu REVISION DETAIL https://phabricator.kde.org/D26709 AFFECTED FILES

D26709: add gpu entry to about system

sitter added a comment. Good point. REPOSITORY R102 KInfoCenter BRANCH gpu REVISION DETAIL https://phabricator.kde.org/D26709 To: sitter, davidedmundson Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26866: [Kickoff] Theme separators

ngraham added a comment. No objection. REPOSITORY R119 Plasma Desktop BRANCH themed-kickoff-separators (branched from master) REVISION DETAIL https://phabricator.kde.org/D26866 To: filipf, #plasma, #vdg, davidedmundson, ngraham Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n,

D26709: add gpu entry to about system

ngraham added a comment. Maybe the label should say "Graphics:" or "Graphics Processor" instead of using an acronym. We say "Memory" instead of "RAM" after all. REPOSITORY R102 KInfoCenter BRANCH gpu REVISION DETAIL https://phabricator.kde.org/D26709 To: sitter, davidedmundson Cc:

D26866: [Kickoff] Theme separators

filipf added a comment. Can I land it on the 5.18 branch as well? REPOSITORY R119 Plasma Desktop BRANCH themed-kickoff-separators (branched from master) REVISION DETAIL https://phabricator.kde.org/D26866 To: filipf, #plasma, #vdg, davidedmundson, ngraham Cc: ndavis, ngraham,

D26797: KCM/Component Refactor UI to a single list of combobox

filipf added a comment. A lot cleaner and straightforward now, good job. I was wondering though what it would look like if we made all the comoboboxes have equal width (if possible). REPOSITORY R119 Plasma Desktop BRANCH new-component-chooser REVISION DETAIL

D26797: KCM/Component Refactor UI to a single list of combobox

broulik added inline comments. INLINE COMMENTS > componentchooser.cpp:65 > > - if (loadedConfigWidget) { > - configWidgetMap.insert(service, loadedConfigWidget); > - configContainer->addWidget(loadedConfigWidget); > - connect(loadedConfigWidget,

D26866: [Kickoff] Theme separators

ngraham accepted this revision. ngraham added a comment. Makes sense now. Let's land this and then fix the separator in another patch. REPOSITORY R119 Plasma Desktop BRANCH themed-kickoff-separators (branched from master) REVISION DETAIL https://phabricator.kde.org/D26866 To: filipf,

D26866: [Kickoff] Theme separators

filipf added a subscriber: ndavis. filipf added a comment. Might actually be a lot simpler. It seems our line SVG file adds 1px of padding on each side: F7922297: image.png @ndavis do you think it's alright to remove this padding? REPOSITORY

D26866: [Kickoff] Theme separators

filipf added a comment. In D26866#599653 , @ngraham wrote: > When using the Breeze style, the blue selection line no longer touches the separator line: > > F796: Screenshot_20200123_073450.png >

D26870: [ksgrd] Drop a QWidget dependency

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The broadcaster just needs to receive a QEvent getting propogated upwards,

D26871: [examples/simplechatapp] Always set isMenu to true

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It does the right thing on mobile automatically REPOSITORY R169 Kirigami

D26866: [Kickoff] Theme separators

ngraham added a comment. When using the Breeze style, the blue selection line no longer touches the separator line: F796: Screenshot_20200123_073450.png F7922231: Screenshot_20200123_073540.PNG

D26842: Fix fonts KCM button state

ervin added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:479 > Kinda defies the purpose of using kconfigxt if we end up hardcoding the state > in code again? That part was never transitioned to KConfigXT though since it doesn't have a KConfig backend. Clearly inheriting by

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo marked 3 inline comments as done. gvgeo added a comment. I marked 3 comments as done that had forgotten, as I removed the old tooltip code. If there is something else, please be more specific. I can not see a better way to address any of your comments. INLINE COMMENTS >

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. In D26797#598189 , @ngraham wrote: > In D26797#598030 , @meven wrote: > > > @ngraham I think I should wait for some feedback/review from #VDG

D26842: Fix fonts KCM button state

broulik added inline comments. INLINE COMMENTS > fonts.cpp:479 > +defaultState.dpi = 0; > +defaultState.subPixel = KXftConfig::SubPixel::Rgb; > +defaultState.hinting = KXftConfig::Hint::Slight; Kinda defies the purpose of using kconfigxt if we end up hardcoding the state in code

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in BatteryItem.qml:64 > That's been in there ever since the initial release 2013. Well that explains "// GridLayout crashes with a Repeater in it somehow" REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in BatteryItem.qml:64 > You can't do that. > > That'll change the column size, which will change our text bounding box which > will change our paintedWidth. A loop. That's been in there ever since the initial release 2013.

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Few of my initial comments do not seem to be addressed yet. INLINE COMMENTS > BatteryItem.qml:64 > > -states: [ > -State { >

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74228. gvgeo added a comment. Remove detailsLoader visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74222=74228 BRANCH b3 (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74222. gvgeo added a comment. Removed battery tooltip (had no extra info). Changed details view. Would be better without colon and without grid arrangement? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Guarding against use of Plasma with qt5ct

I would say the latter in most cases - distros set it. On Thu, Jan 23, 2020, 12:06 David Edmundson wrote: > >Some ideas could be adding an inline message in the Application Style kcm > when qt5ct is detected or just simply unsetting the qt5ct env variable on > start. > > Can you explain how

D26866: [Kickoff] Theme separators

filipf updated this revision to Diff 74221. filipf added a comment. use the element's own dimensions for geometry instead of hardcoding REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26866?vs=74218=74221 BRANCH themed-kickoff-separators (branched

D26862: Remove unused includes

This revision was automatically updated to reflect the committed changes. Closed by commit R102:5a5f32ea02f8: Remove unused includes (authored by broulik). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26862?vs=74197=74219 REVISION DETAIL

D26866: [Kickoff] Theme separators

filipf added inline comments. INLINE COMMENTS > FullRepresentation.qml:127 > } > +height: Math.floor(units.devicePixelRatio) > +width: root.width - 2 * units.gridUnit maybe this doesn't need to be specified anymore? (and everywhere else in the diff) REPOSITORY R119

D26866: [Kickoff] Theme separators

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Kickoff's separators were drawn as rectangles which doesn't allow them to be themed. We have the infrastructure to theme lines

Re: Guarding against use of Plasma with qt5ct

>Some ideas could be adding an inline message in the Application Style kcm when >qt5ct is detected or just simply unsetting the qt5ct env variable on start. Can you explain how users get this env set. Is it them manually doing something or do some distros install some sort of hook that sets it?

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 74208. leinir added a comment. - Actually make the service locator work (need to query for the right thing) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25961?vs=73756=74208 BRANCH

D26825: Bind gtk-enable-animations setting to global animation speed slider

This revision was automatically updated to reflect the committed changes. Closed by commit R99:66ab37df7aed: Bind gtk-enable-animations setting to global animation speed slider (authored by broulik). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74203. broulik added a comment. - Fix typos REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74193=74203 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26825: Bind gtk-enable-animations setting to global animation speed slider

gikari added a comment. Some typos, without them everything is OK. INLINE COMMENTS > configeditor.cpp:173 > QStringLiteral("gtk-primary-button-warps-slider"), > +QStringLiteral("enable-animations"), > }; You have a typo. The correct name of the parameter is

D26862: Remove unused includes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Compiles REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26862

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Could not pin point a specific size to disable mute function. If it is still a problem with this patch, maybe need to disable it for 5.18, and add a config option in the next release. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, hein, ngraham. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY When vertical or Icon-only task manager, shrink click area 10% and indicator 30%.

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74193. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74115=74193 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/configeditor.cpp kded/configeditor.h

D26256: [Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 74192. gvgeo added a comment. Fix volume icons REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=74146=74192 BRANCH raise2 (branched from master) REVISION DETAIL