D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#602082 , @filipf wrote: > ^ I can't reproduce that, the patch works as intended for me. (we should investigate this though) > > One thing to just comment is that this is tailor-made for Breeze (the 1px thing

D26896: Kill the KinfoCenter binary

jjazeix added inline comments. INLINE COMMENTS > CMakeLists.txt:85 > -configure_file(config-project-version.h.cmake > ${CMAKE_CURRENT_BINARY_DIR}/config-project-version.h) > -configure_file(config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h) > include_directories(${CMAKE_CURRENT_BINARY

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74541. meven marked 7 inline comments as done. meven added a comment. Code formatting, add qAsConst, only search for one directory kcm_componentchooser to find its components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/92/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 29 Jan 2020 04:45:28 + Build duration: 3 min 31 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 154 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/154/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 29 Jan 2020 04:45:28 + Build duration: 2 min 27 sec and counting CONSOLE OUTPUT [...truncated 5

D26979: KWallet-PAM SELinux context transition support

secureworkstation created this revision. secureworkstation added projects: Frameworks, Plasma. Herald added a subscriber: plasma-devel. secureworkstation requested review of this revision. REVISION SUMMARY This patch is a repurposed patch by Daniel Walsh for gnome-keyring: https://github.c

D26977: Fix setting of initial passwords for new users

ngraham added a comment. Oh gosh, every time someone touches that KCM to fix a bug, it breaks something else. :/ It's so fragile. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D26977 To: davidedmundson, #plasma, meven Cc: ngraham, plasma-devel, Orage, LeGast00

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag added a comment. > monitors compositing manager selections Only if XFIXES is present; otherwise it will fallback to `xcb_get_selection_owner` as Breeze does now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26978 To: zzag, #plasma, hpereiradacosta Cc: pla

D26977: Fix setting of initial passwords for new users

davidedmundson added a comment. Aha, found what changed it: 2471fa7d252de904b305dac77171fa300d66c05d - if (!roles.contains(Username) || !roles.contains(RealName) || !roles.contains(Administrator)) { +

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Every time Breeze needs to check whether given widget has an alpha channel, it makes a synchronous X call

D26977: Fix setting of initial passwords for new users

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is somewhat a simple fix for 5.18.0, but this really needs revisiting.

D26739: [applets/Task Manager] Refine tooltip highlight effect

This revision was automatically updated to reflect the committed changes. Closed by commit R119:84182a554588: [applets/Task Manager] Refine tooltip highlight effect (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74475&id=

D26972: Work around an issue with changing the wallpaper's filetype

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8f4ea0a93ffb: Work around an issue with changing the wallpaper's filetype (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26972?vs=74527&id=74530

D26912: Use Qt5 signal syntax, format files, optimizations

alex updated this revision to Diff 74528. alex added a comment. Remove unnecessary parentheses. I just forgot to remove these, sorry. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26912?vs=74355&id=74528 REVISION DETAIL https://phabricator.k

D26972: Work around an issue with changing the wallpaper's filetype

ngraham created this revision. ngraham added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Because of the issue described in T12611 , cha

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostart.cpp:64 > +connect(widget->btnProperties, &QPushButton::clicked, > +this, static_cast (Autostart::*)()>((&Autostart::slotEditCMD))

D26739: [applets/Task Manager] Refine tooltip highlight effect

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. ^ I can't reproduce that, the patch works as intended for me. (we should investigate this though) One thing to just comment is that this is tailor-made for Breeze (the 1px thing), but

D26970: Remove use of deprecated KDialog, fix two warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fb71ced98460: Remove use of deprecated KDialog, fix two warnings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26970?vs=74516&id=74525

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#601921 , @ngraham wrote: > In D26739#601762 , @trmdi wrote: > > > Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail

D26797: KCM/Component Refactor UI to a single list of combobox

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:62 > +// fill the form layout > +const auto name = cg.readEntry("Name",i18n("Unknown")); > +CfgPlugin *loadedConfigW

D26954: Add Ice Cold wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R131:7a69dcc37c93: Add Ice Cold wallpaper (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26954?vs=74463&id=74521 REVISION DETAIL http

D26953: Replace Ice Cold with Volna for Plasma 5.18

This revision was automatically updated to reflect the committed changes. Closed by commit R31:e920200e29bb: Replace Ice Cold with Volna for Plasma 5.18 (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26953?vs=74510&id=74520 REVISION DETAI

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a comment. VDG folks approved in the chatroom; landing it! REPOSITORY R31 Breeze BRANCH icecold-to-volna (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D26953 To: ngraham, #vdg, #plasma, davidedmundson Cc: raveomelette, IlyaBizyaev, Luwx, ndavis,

D26970: Remove use of deprecated KDialog, fix two warnings

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN No UI changes REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.k

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have everything perfectly aligned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D26937: Add a convenience property to retrieve the size of the decorated client

This revision was automatically updated to reflect the committed changes. Closed by commit R129:13e6459a3bae: Add a convenience property to retrieve the size of the decorated client (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26937?vs=74418&id=74515#toc REPOSITORY

D26956: Remove export header from static install

masonm added a comment. It appears all the sources which reference the export header have an appropriate guard on them: #ifndef KIRIGAMI_BUILD_TYPE_STATIC #include #endif I found these in tabletmodewatcher.h, kirigamipluginfactory.h, platformtheme.h REPOSITORY R169 Kirigami

D26937: Add a convenience property to retrieve the size of the decorated client

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please bump the SOVERSION REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D26937 To: zzag, #kwin, davidedmundson

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a subscriber: IlyaBizyaev. ngraham added a comment. @IlyaBizyaev suggested using the MozJPEG encoder at https://squoosh.app/ and the results are fantastic. I can detect no difference in appearance whatsoever from normal viewing distances (i.e. not zoomed in to 500%) and the tota

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham updated this revision to Diff 74510. ngraham added a comment. This revision is now accepted and ready to land. Replace those lousy dithered PNGs with JPEGs created using the MozJPEG encoder at https://squoosh.app REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator

D26893: Fix a building issue

meven added a comment. In D26893#601874 , @jriddell wrote: > Add this patch fixes compile on the KDE neon CI https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/ > > Curiously I can't recreate the failure on my local computer

D26966: [kstyle] Unregister a shadow when it's destroyed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:cf12bf4a077d: [kstyle] Unregister a shadow when it's destroyed (authored by zzag). REPOSITORY R31 Breeze CHANGES SIN

D26967: [kstyle] Unregister a shadow when it's destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R113:120fb3e01f22: [kstyle] Unregister a shadow when it's destroyed (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26967?vs=74503&id=74508 REVI

D26893: Fix a building issue

This revision was automatically updated to reflect the committed changes. Closed by commit R128:e1569e3341e7: Fix a building issue (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26893?vs=74303&id=74507 REVISION DETAIL https://phabri

D26966: [kstyle] Unregister a shadow when it's destroyed

zzag updated this revision to Diff 74506. zzag edited the summary of this revision. zzag added a comment. Edit summary. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26966?vs=74504&id=74506 BRANCH fix-crash REVISION DETAIL https://phabricator.kde.org/D

D26665: Switch to KNSQuick for getting new wallpapers

ngraham added a comment. In D26665#601715 , @leinir wrote: > In D26665#601713 , @IlyaBizyaev wrote: > > > What about the "Get New Plugins" button in the same dialog? It still uses the old style. >

D26966: [kstyle] Unregister a shadow when it's destroyed

broulik added a comment. +1 Can confirm that the `QWindow` belonging to `KlipperPopup` that caused the crash before is destroyed before the destructor, fixing the crash. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26966 To: zzag, #plasma, broulik Cc: apol, plasm

D26966: [kstyle] Unregister a shadow when it's destroyed

zzag updated this revision to Diff 74504. zzag retitled this revision from "[kstyle] Use guarded pointers to store shadows" to "[kstyle] Unregister a shadow when it's destroyed". zzag edited the summary of this revision. zzag added a comment. Re-title and edit summary. REPOSITORY R31 Breeze

D26965: [Emojier] Copy Emoji also into selection clipboard

ngraham added a comment. Now could we just blindly send a middle-click event after you select an emoji to have it paste the emoji into the focused text field, if any? >:D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26965 To: broulik, #plasma, apol Cc: ngr

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. In D26739#601762 , @trmdi wrote: > Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical. With the latest iteration of the patch, they should be. Fee

D26966: [kstyle] Use guarded pointers to store shadows

apol added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26966 To: zzag, #plasma, broulik Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. I thought about this; so, I should remove margins from everywhere, and we add them to the desktop theme? I can make that patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma Cc: gvgeo, ngraham,

D26967: [kstyle] Use guarded pointers to store shadows

zzag updated this revision to Diff 74503. zzag added a comment. Clean up _shadows upon a shadow emitting QObject::destroyed() REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26967?vs=74498&id=74503 BRANCH fix-crash REVISION DETAIL https://phabrica

D26966: [kstyle] Use guarded pointers to store shadows

zzag added inline comments. INLINE COMMENTS > apol wrote in breezeshadowhelper.h:157 > if this is a thing, maybe it would make sense to actually try and remove the > KWindowShadows upon destruction? > Something like `connect(newshadow, &QObject::destroyed, this, [this, widget] > { _shadows.rem

D26966: [kstyle] Use guarded pointers to store shadows

zzag updated this revision to Diff 74502. zzag added a comment. Connect to QObject::destroyed REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26966?vs=74497&id=74502 BRANCH fix-crash REVISION DETAIL https://phabricator.kde.org/D26966 AFFECTED FILES ks

D26966: [kstyle] Use guarded pointers to store shadows

broulik added inline comments. INLINE COMMENTS > apol wrote in breezeshadowhelper.h:157 > if this is a thing, maybe it would make sense to actually try and remove the > KWindowShadows upon destruction? > Something like `connect(newshadow, &QObject::destroyed, this, [this, widget] > { _shadows.

D26966: [kstyle] Use guarded pointers to store shadows

apol added inline comments. INLINE COMMENTS > breezeshadowhelper.h:157 > //* managed shadows > -QMap _shadows; > if this is a thing, maybe it would make sense to actually try and remove the KWindowShadows upon destruction? Something like `connect(newshadow, &QObject::destroye

D26965: [Emojier] Copy Emoji also into selection clipboard

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Right, didn't think of this since we don't have selection clipboard on wayland. 😢 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26965 To: broulik, #plasma, a

D26967: [kstyle] Use guarded pointers to store shadows

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since a KWindowShadow is a child of QWindow, we need to use a guarded pointer to store the shadow in order to prevent accessing or delet

D26966: [kstyle] Use guarded pointers to store shadows

zzag created this revision. zzag added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since a KWindowShadow is a child of QWindow, we need to use a guarded pointer to store the shadow

D26893: Fix a building issue

jriddell accepted this revision as: jriddell. jriddell added a comment. This revision is now accepted and ready to land. Add this patch fixes compile on the KDE neon CI https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/ Curiously I can't recreate the failure on my local

D26965: [Emojier] Copy Emoji also into selection clipboard

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Surprisingly, the Emojier does not insert an Emoji into a text field ... to make it a bit easier

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 153 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/153/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 28 Jan 2020 13:16:40 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...truncated 6

D26896: Kill the KinfoCenter binary

This revision was automatically updated to reflect the committed changes. Closed by commit R102:24f4c6f97875: Kill the KinfoCenter binary (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26896?vs=74434&id=74493#toc REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDAT

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/91/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 28 Jan 2020 13:16:39 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated 48

D26895: Introduce an Info Center mode

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ca28b62000ff: Introduce an Info Center mode (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74491&id=74492 REVISION DETAIL ht

D26896: Kill the KinfoCenter binary

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:106 > + > +ADD_CUSTOM_TARGET(kinfocenter_link ALL > + COMMAND ${CMAKE_COMMAND} -E create_symlink > ${KDE_INSTALL_FULL_BI

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74491. mart added a comment. - better todo message REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74487&id=74491 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECT

D26895: Introduce an Info Center mode

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > SidebarMode.cpp:589 > > -if (introPageVisible) { > -d->activeCategoryRow = -1; > -emit activeCategoryRowChanged(); > -d->ac

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74487. mart added a comment. - use mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74481&id=74487 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECTED FILES

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. Not yet looked at the code carefully, but I feel the top margin and the bottom one of the thumbnail are not identical. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf, ndavis Cc: trmdi, filipf, n

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > main.cpp:81 > > -SettingsBase *mainWindow = new SettingsBase(); > +if (binaryName == QStringLiteral("kinfocenter")) { > +aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter")); You can use mode here REPOSITORY R124

D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a727fde4cb9: [Kickoff] Don't enable OpacityMask layer.effect in software mode (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26958?vs

D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It won't render otherwise. The code tried to check but only disabled the outline, not the actual

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74481. mart added a comment. - remove usekless qdebug REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74422&id=74481 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFF

D26892: Switch to the old-style button text for the KNSQuick buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec387280ad9d: Switch to the old-style button text for the KNSQuick buttons (authored by leinir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26892?vs=7430

D26665: Switch to KNSQuick for getting new wallpapers

leinir added a comment. In D26665#601713 , @IlyaBizyaev wrote: > What about the "Get New Plugins" button in the same dialog? It still uses the old style. > Probably unrelated, but for me, both of these buttons fail to actually load anything,

D26665: Switch to KNSQuick for getting new wallpapers

IlyaBizyaev added a comment. What about the "Get New Plugins" button in the same dialog? It still uses the old style. Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried it

D26892: Switch to the old-style button text for the KNSQuick buttons

leinir added a comment. In D26892#600510 , @aacid wrote: > stable branch please :) Ah! Missed this somehow - landing on the 5.18 branch momentarily! :) REPOSITORY R119 Plasma Desktop BRANCH restore-old-style-kns-button-text (branched