D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in reloader.c:26 > What is this 801? GTK loads in the original colors.css at priority 800, so priority 801 will override it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack marked an inline comment as done. cblack added a comment. Looking at documentation, the colour module should gracefully fail when it's unable to locate the colors.css, however I have not tested this. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24275

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

davidedmundson added a comment. This would also be loaded and operational when running in a gnome session. It's important we don't cause issues there. Does this work if colours.css doesn't exist and is then created at runtime? INLINE COMMENTS > reloader.c:26 > +801 > +); > +

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75205. cblack added a comment. Fix memory leak REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=75203&id=75205 BRANCH arcpatch-D24275_1 REVISION DETAIL https://phabricator.kde.org/D24275 AFFECTED FILE

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75203. cblack added a comment. Drop meson.build, clean CMakeLists.txt, rebase on master REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=70834&id=75203 BRANCH arcpatch-D24275_1 REVISION DETAIL https://

D27225: Add support for static platformtheme plugins

masonm created this revision. masonm added reviewers: VDG, Kirigami, mart. masonm added a project: Kirigami. masonm requested review of this revision. REVISION SUMMARY PlatformTheme::qmlAttachedProperties is currently not looking for static KirigamiPluginFactory plugins. This change will search

D27199: [WIP][Applet]Update layout based on T10470

manueljlin added a comment. I think that it should use a footer to be consistent with the other ones REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-

D27199: [WIP][Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Found a better way to hide the separator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n,

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh updated this revision to Diff 75195. camiloh added a comment. correct undefined line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27212?vs=75168&id=75195 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27212 AFFECTED FILES src

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes, per VDG mockup

ngraham created this revision. ngraham added reviewers: VDG, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Depends on D27221 TEST PLAN Before: F8090890: Smal

D27182: [applets/taskmanager] Clean up Tooltip code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5194d6183094: [applets/taskmanager] Clean up Tooltip code (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27182?vs=75189&id=75190 REVI

D27182: [applets/taskmanager] Clean up Tooltip code

ngraham updated this revision to Diff 75189. ngraham added a comment. @trmdi was right, I did make it a bit bigger by accident REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27182?vs=75188&id=75189 BRANCH clean-up-tooltip-code (branched from maste

D27182: [applets/taskmanager] Clean up Tooltip code

ngraham updated this revision to Diff 75188. ngraham added a comment. Remove unnecessary spacing in the ColumnLayout with all Headings in it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27182?vs=75109&id=75188 BRANCH clean-up-tooltip-code (branc

D27182: [applets/taskmanager] Clean up Tooltip code

hein added a comment. trmdi's point is good, otherwise I like it. REPOSITORY R119 Plasma Desktop BRANCH clean-up-tooltip-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D27182 To: ngraham, #plasma, #vdg, ndavis Cc: hein, trmdi, broulik, plasma-devel, Orage, LeG

D27219: Center placeholder texts in system tray popups

trmdi added a comment. Could you post screenshots of a same tab? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27219 To: ngraham, #vdg, #plasma Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragr

D27219: Center placeholder texts in system tray popups

ngraham added a comment. The strings could use a bit of adjustment, but I'll have to do that on master. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27219 To: ngraham, #vdg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, z

D27219: Center placeholder texts in system tray popups

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We use this centered style in many other places and are moving towards using it everywhere.

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/186/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 07 Feb 2020 17:21:34 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 333 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/333/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 07 Feb 2020 17:21:34 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated 402 lines.

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:100 > Depends on the font; you can't necessarily count on that. Heading has `lineHeight: 1.2`, so there are 2 things for padding here right? Could we remove one? REPOSITORY R119 Plasma Desktop BRANCH clean

D27182: [applets/taskmanager] Clean up Tooltip code

ngraham added a comment. Is `gridUnit` screen-size-aware? That would be kind of weird. REPOSITORY R119 Plasma Desktop BRANCH clean-up-tooltip-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D27182 To: ngraham, #plasma, #vdg, ndavis Cc: trmdi, broulik, plasma-de

D15418: Dim application icon when it is not playing anything

gvgeo added a comment. In D15418#604205 , @alexde wrote: > ...what about adding an overlay pause-icon, similar to D3302 ?... This could be interpreted as a button. Not that we removed the audiostrea

D27182: [applets/taskmanager] Clean up Tooltip code

trmdi added a comment. It's super big on my 1366x768 screen: Before: F8090526: image.png After: F8090521: image.png And the Before and After size are not the same. REPOSITORY R119 Plasma Desktop BR

D27205: [Applet]Always get valid device and stream name

gvgeo updated this revision to Diff 75176. gvgeo added a comment. i18n without context. Fix typo, from previous commit. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27205?vs=75167&id=75176 BRANCH names (branched from master) REVIS

D27084: Don't delay ksplash until the entire lideshow is loaded

davidre added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27084 To: davidre, davidedmundson, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

This revision was automatically updated to reflect the committed changes. Closed by commit R118:bd130c6b0225: [Cuttlefish] Remove last traces of themes and plasma themes (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27136?vs=74942&id=75174#toc REPOSITORY R118 Pl

D27061: replace samba module with data that works

sitter updated this revision to Diff 75170. sitter added a comment. move from qmap to straight up qlist as values() within the map wouldn't necessarily have the expected order. instead find_by udi on add/remove and rely on index within the list the rest of the time additional qa: have 2

D27079: Don't escape search text in search page title

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9bf3f942d329: Don't escape search text in search page title (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27079?vs=74948&id=

D27205: [Applet]Always get valid device and stream name

gvgeo planned changes to this revision. gvgeo added a comment. I get some more messages now... REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27205 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D27212 AFFECTED

D27061: replace samba module with data that works

jriddell added a comment. As release mangler for Plasma I'd normally point out this is a breach of feature freeze, but it seems to have the support of important Plasma people so great go ahead when ready. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27061 To

D27079: Don't escape search text in search page title

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. whatever REPOSITORY R134 Discover Software Store BRANCH show-search-text-un-escaped (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #di

D27205: [Applet]Always get valid device and stream name

gvgeo added a comment. > If this is something that should be shown to the user It should not. It worked like that for years. I have never encounter this, as a UI bug. And I don't expect that I'll ever see that message. It's more to avoid error messages. And for the rare occasion for a d

D27205: [Applet]Always get valid device and stream name

gvgeo updated this revision to Diff 75167. gvgeo added a comment. localize REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27205?vs=75154&id=75167 BRANCH names (branched from master) REVISION DETAIL https://phabricator.kde.org/D27205

D27061: replace samba module with data that works

davidedmundson added inline comments. INLINE COMMENTS > smbmountmodel.cpp:73 > +case ColumnRole::Share: > +return > devices().at(index.row()).as()->url(); > +case ColumnRole::Path: This looks dangerous. You always add row indexes to the end, but you're taking an ind

D27205: [Applet]Always get valid device and stream name

ngraham added a reviewer: VDG. ngraham added inline comments. INLINE COMMENTS > DeviceListItem.qml:49 > +} > +return "Device name not found"; > } If this is something that should be shown to the user (is it?), then it needs to be localized by wrapping it in `i18n()` > Stre

D27061: replace samba module with data that works

ltoscano added a comment. As no one else complained, and given the general brokeness of the current code, I'd say: please go for it. 5.18.0 is already tagged, there are ~11 days before 5.18.1 (planned for Tue 11th) and ~18 before 5.18.2, so we will probably catch up. +1 from the localiz

D27061: replace samba module with data that works

ngraham added a comment. #localization folks, can we get an approval or rejection for this? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27061 To: sitter, #localization, #plasma, #vdg Cc: yurchor, ngraham, alexd

D27079: Don't escape search text in search page title

ngraham added a comment. But again, what user would actually write, by hand, "potato" in the search field? When users type into a search field, they don't add HTML styling. That only happens if they're copying and pasting from another source. In this case, if that do that and the tags come a

D27079: Don't escape search text in search page title

apol added a comment. In D27079#607311 , @ngraham wrote: > Why is that not entirely correct? The bold tags are just styling; the user clearly intended to search for the word "potato". Because the user actually wrote "potato", it's only s

D27191: [KSplash KCM] Fix ghns button label

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1e10987d5af9: [KSplash KCM] Fix ghns button label (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27191?vs=75100&id=75162 REVISION DET

rewrite samba KIC plugin in stable branch

It's come to my attention that people don't read diff emails so here's your explicit notification that there is a rewrite diff up for landing in 5.18 https://phabricator.kde.org/D27061

D27079: Don't escape search text in search page title

ngraham added a comment. Why is that not entirely correct? The bold tags are just styling; the user clearly intended to search for the word "potato". REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, a

D27206: [Sessions KCM] Fix firmware setup

broulik created this revision. broulik added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We hide the UI after we show it in `initFirmwareSetup` TEST PLAN 5.18, should we respin?

D27205: [Applet]Always get valid device and stream name

gvgeo updated this revision to Diff 75154. gvgeo added a comment. typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27205?vs=75152&id=75154 BRANCH names (branched from master) REVISION DETAIL https://phabricator.kde.org/D27205 AF

D27205: [Applet]Always get valid device and stream name

gvgeo added a comment. Occasionally I get this. kf5.ki18n: "0 instead of 1 arguments to message {Adjust volume for %1} supplied before conversion." kf5.ki18n: "0 instead of 1 arguments to message {Mute %1} supplied before conversion." kf5.ki18n: "0 instead of 1 arguments to mes

D27205: [Applet]Always get valid device and stream name

gvgeo created this revision. gvgeo added reviewers: Plasma, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Added more checks and an error message. REPOSITORY R115 Plasma Audio Volume Applet B

D27199: [WIP][Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75150. gvgeo edited the summary of this revision. gvgeo added a comment. Remove active connections section. I had a typo in my script. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=

D27079: Don't escape search text in search page title

apol added a comment. So with this change, if you search "potato", you'll get as a title "potato". I wouldn't say that's entirely correct. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc: pla

D27129: [Notifications] Allow expiring an entire group

broulik added a comment. Hmm just crashed on me: #6 0x7f7a94c1cdf4 in NotificationManager::NotificationGroupingProxyModel::index(int, int, QModelIndex const&) const (this=0x555f621dd0e0, row=0, column=, parent=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:241 #7