D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ToolTipInstance.qml:123 > opacity: 0.75 > -visible: !hasPlayer && text.length !== 0 > +visible: !hasPlayer &&

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Before-and-after pictures below should be self-explanatory: TEST PLAN Before: F8094802:

D27149: Scroll the truncated song/artist text when long hovering over it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c8a7a3bd98a8: Scroll the truncated song/artist text when long hovering over it (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi updated this revision to Diff 75321. trmdi added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75287=75321 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL

D27262: Reduce blank space inside tooltip's header

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5be0b548b6ed: Reduce blank space inside tooltips header (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27262?vs=75288=75320 REVISION

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/33/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Feb 2020 03:28:19 + Build duration: 19 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 57 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/57/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Feb 2020 03:28:15 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/4/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 01:39:43 + Build duration: 11 min and counting

D27271: [kcms/colors] RFC: Accent Colours

cblack updated this revision to Diff 75318. cblack added a comment. Use ColorButton REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27271?vs=75317=75318 BRANCH accent-colors (branched from master) REVISION DETAIL

D27271: [kcms/colors] RFC: Accent Colours

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH accent-colors (branched from master) REVISION DETAIL

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. Hmm, good point. Should we not fix the bug in the PC3 toolbutton? How should we proceed? REPOSITORY R120 Plasma Workspace BRANCH fix-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc:

D27265: Use Kirigami.PasswordField instead of plain text field

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5fbc994c959a: Use Kirigami.PasswordField instead of plain text field (authored by ognarb). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D26806: [Applets/Power Manager] Update layout based on T10470

manueljlin added a comment. Thanks, and sorry for wasting your time :x REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 75315. gvgeo added a comment. Up it goes again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=75297=75315 BRANCH b4 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26806

D27257: [Applet]Move toolbar to the bottom

manueljlin added a comment. you can close this task if you want, after talking a bit over T10470 it's better to use headers instead of footers REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc:

D27199: [WIP][Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Background margins and big connect button is a problem. Other themes break as it is now. Also creates an awkward empty space between label and details. Which direction to take? 1. Remove button and replace with a text.

D27142: Have authhelper define config file paths on its own

This revision was automatically updated to reflect the committed changes. Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on its own (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 334 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/334/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 09 Feb 2020 18:15:11 + Build duration: 4 min 18 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/187/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 09 Feb 2020 18:15:11 + Build duration: 3 min 28 sec and counting JUnit Tests Name:

D27262: Reduce blank space inside tooltip's header

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R119 Plasma Desktop BRANCH reduce-tooltip-blank-space (branched from master) REVISION DETAIL https://phabricator.kde.org/D27262 To: trmdi, #plasma, #vdg, ndavis, ngraham Cc: ngraham, davidedmundson, ndavis,

D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY VirtualDesktopInfo::Private is ref counted and shared between N

D27262: Reduce blank space inside tooltip's header

trmdi added a subscriber: ngraham. trmdi added a comment. Do you have any objection @ngraham ? REPOSITORY R119 Plasma Desktop BRANCH reduce-tooltip-blank-space (branched from master) REVISION DETAIL https://phabricator.kde.org/D27262 To: trmdi, #plasma, #vdg, ndavis Cc: ngraham,

D27261: [Folder view] Fix binding loop on width

gvgeo added a comment. This removes the smallSpacing. Text will touch the edges. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27265: Use Kirigami.PasswordField instead of plain text field

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ognarb requested review of this revision. REVISION SUMMARY Allow showing the plain text password when typing (optional) TEST PLAN :( REPOSITORY R116

D27260: [applets/systemtray] Set pin button's size correctly

davidedmundson added a comment. workspace changes required as a result of a frameworks change raises questions What happens to users of Plasma 5.17 with the D27221 applied and not this? REPOSITORY R120 Plasma Workspace BRANCH fix-pin-button

D27264: Fix tabbar width computation

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c31e7ea68957: Fix tabbar width computation (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27264?vs=75299=75300 REVISION DETAIL

D27264: Fix typo in Math call

cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REPOSITORY R169 Kirigami BRANCH bugfix/widthComputation REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 75297. gvgeo added a comment. Small improvement of Power Managment checkbox's tooltip code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74347=75297 BRANCH b3 (branched from master) REVISION

D27109: Fix duplicate results for sessions, simplify and optimize

alex added a comment. No problem, thanks for reviewing :-) REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27109 To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann Cc: cullmann,

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann added a comment. Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=) REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann added a comment. Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27109 To: alex,

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Improved output seems fine for me, thanks for taking care. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL

D27257: [Applet]Move toolbar to the bottom

gvgeo added a comment. The was plan to move them all to the bottom, and there are patches for most of them. There is a recent small discussion about it in T10470 . REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo, #plasma, #vdg, jgrulich,

D27257: [Applet]Move toolbar to the bottom

gvgeo updated this revision to Diff 75293. gvgeo added a comment. For some reason arc send both patches together here. Updated with diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27257?vs=75291=75293 REVISION DETAIL https://phabricator.kde.org/D27257 AFFECTED FILES

D27257: [Applet]Move toolbar to the bottom

anthonyfieroni added a comment. Why? That's make huge inconsistency, bluetooth applet has it on top, battery and brightness too. REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n,

D27262: Reduce blank space inside tooltip's header

davidedmundson added a comment. Code wise, no objections. Needs vdg to approve visual changes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27262 To: trmdi, #plasma, #vdg Cc: davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27257: [Applet]Move toolbar to the bottom

gvgeo updated this revision to Diff 75291. gvgeo edited the test plan for this revision. gvgeo added a comment. Requested change REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27257?vs=75279=75291 BRANCH flip (branched from

D27262: Reduce blank space inside tooltip's header

ndavis added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27262 To: trmdi, #plasma, #vdg Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,