D27199: [Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Clicking and highlight only on the main row, and only when hover. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc:

D27337: [Emojier] Optimize performance

davidedmundson added a comment. Delegates are already async loaded. What does nesting a loader provide on top? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

mmustac added a comment. Wouldn't it look better to use the new header/title component for the list view ? F8099139: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:145-148 > https://github.com/qt/qtdeclarative/blob/9893e71cea5de10193376c1733db627ef0783614/src/quick/items/qquickimage.cpp#L600-L603 That says the opposite of what you want. We want image's

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. That turned out to be an unrelated Baloo bug that was recently fixed by D27326 . This is ready for re-review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 75508. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73775=75508 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

ngraham added a comment. @mart ping REPOSITORY R169 Kirigami BRANCH smaller-and-more-left-padded-page-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D27198 To: ngraham, #vdg, #kirigami, manueljlin, mart Cc: alexde, ahiemstra, plasma-devel, fbampaloukas,

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/165/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 04:33:33 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 296 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/296/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 12 Feb 2020 04:33:28 + Build duration: 5 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 300 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/300/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 12 Feb 2020 04:33:32 + Build duration: 5 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 167 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/167/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 04:33:31 + Build duration: 5 min 0 sec and counting JUnit Tests

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. Looks like plasma doesn't respect the accent color. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ExpandedRepresentation.qml:261 > +} > +PlasmaExtras.Heading { // Song Album > +color:

D27282: [Applet]Correct raise max volume functions for mic

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Everyone else good with this? REPOSITORY R115 Plasma Audio Volume Applet BRANCH mic (branched from master) REVISION DETAIL https://phabricator.kde.org/D27282 To: gvgeo, #plasma,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Overall looks much better I think! However the minimum height seems to be a bit tall now: F8098822: Screenshot_20200211_203232.png Also I have a hard time putting my finger on why, but somehow the scrubber not filling the

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 299 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/299/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 12 Feb 2020 03:09:57 + Build duration: 2 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 166 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/166/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 03:09:57 + Build duration: 1 min 55 sec and counting CONSOLE

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/164/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 12 Feb 2020 03:09:57 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 295 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/295/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 12 Feb 2020 03:09:57 + Build duration: 1 min 42 sec and counting CONSOLE OUTPUT

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. Hmm, I think the 1.5 ratio makes a nice shape, the thumbnail is also not too small. A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail. F8098753: image.png REPOSITORY R119 Plasma Desktop REVISION

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Pretty nice. If the list items are no longer going to have a selection highlight but still open up/unfold when single-clicked, then the cursor should change to a pointing hand when hovering over them. REPOSITORY R116 Plasma Network Management Applet REVISION

D27337: [Emojier] Optimize performance

ngraham added reviewers: apol, Plasma. ngraham added a comment. Very nice. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27337: [Emojier] Optimize performance

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY BUG: 417454 The emojier fairly slow. Launching is slow. Resizing the window is slow. Changing pages is slow. Scrolling is also

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

wstephenson abandoned this revision. wstephenson added a comment. @broulik Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27078: Drag-and-drop files at the right coordinates

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, nice fix. #plasma folks, y'all good with this? 5.18 branch? REVISION DETAIL https://phabricator.kde.org/D27078 To:

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

broulik added a comment. In the "Add Action..." combobox above the comment field at the end you choose say "Abandon revision" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc: broulik, plasma-devel,

D27199: [WIP][Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75498. gvgeo added a comment. Route no.2 Added line and Warning messages. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75280=75498 BRANCH layout2 (branched from master) REVISION

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

wstephenson added a comment. Changes integrated into https://phabricator.kde.org/D27322 - how do I withdraw/close a posted diff in phabricator? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc:

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

wstephenson added a comment. I tried to test dragging multiple windows (as a grouped taskbar entry) but this fails at the first test, outside of my changes, so I think there's an unrelated bug hiding in TaskManager::XWindowTasksModel::winIdsFromMimeData(), which can wait for another patch.

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

wstephenson updated this revision to Diff 75496. wstephenson added a comment. Implement feedback from d_ed Integrate logic fix from https://phabricator.kde.org/D27319 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27322?vs=75472=75496 REVISION DETAIL

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

filipf added a comment. In D27329#609851 , @ngraham wrote: > That's better, though I dunno, I can't shake the feeling that the album art is still too compressed. Me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

ngraham added a comment. That's better, though I dunno, I can't shake the feeling that the album art is still too compressed: F8098251: Screenshot_20200211_113432.png Maybe I'm just being crotchety though. #VDG

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. We can increase the height a bit, but not sure which ratio is the best. Another thing is that, even with a bigger thumbnail, we could hardly see its content, so making it bigger doesn't make it more clear. In D27329#609831

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi updated this revision to Diff 75486. trmdi added a comment. - Increase the height a bit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27329?vs=75484=75486 BRANCH adjust-size-of-tooltip (branched from master) REVISION DETAIL

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Okay, seeing this in action, I don't hate it. However I feel like my concern with the album art being squeezed too much is valid: F8098196: Screenshot_20200211_104708.png

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi created this revision. trmdi added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. TEST PLAN The size of tooltips are not changed between cases e.g. a normal window vs a window which is available

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. Shadows look fine in wayland. Like many other elements, the problem is with X11. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27325: improve some previously recycled strings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In that case, with kio-fuse, "Mounted shares" is probably more accurate and just fine. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D27325: improve some previously recycled strings

sitter added a comment. That may be misleading expectations I fear. When you browse smb:// in dolphin you'd be accessing shares, but they'd not appear in that list ;) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27325 To: sitter, ngraham Cc: plasma-devel,

D27325: improve some previously recycled strings

ngraham added a comment. "Accessed shares"? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27325 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D27325: improve some previously recycled strings

sitter added a comment. I do wonder if "Mounted Shares" is all that grand. Technically they may not be mounted but mountable. E.g. when you put a mount into /etc/fstab it will be listed here but not necessarily mounted. Another question is if someone has better suggestions for the

D27325: improve some previously recycled strings

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY for 5.18 we recycled these to reduce the new strings, for 5.19 we want something more

D27316: [Folder view]Make shadow scale aware

gvgeo updated this revision to Diff 75476. gvgeo added a reviewer: VDG. gvgeo added a comment. Rebase. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27316?vs=75453=75476 BRANCH shadow2 (branched from master) REVISION DETAIL

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

davidedmundson added a comment. Seems sensible +1 INLINE COMMENTS > pagermodel.cpp:615 > +// if on >1 activity, remove it from the current > activity and add it to the new activity > +QString currentActivity = > d->activityInfo->currentActivity(); >

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

wstephenson created this revision. wstephenson added reviewers: davidedmundson, Plasma, hein. wstephenson added a project: Plasma. Herald added a subscriber: plasma-devel. wstephenson requested review of this revision. REVISION SUMMARY This allows the familiar file manager semantics of

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a0c4f86530f: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fonts.cpp:131 > +for (int t = KXftConfig::SubPixel::None; t <= > KXftConfig::SubPixel::Vbgr; ++t) { > +QStandardItem *item = new >

D27316: [Folder view]Make shadow scale aware

ngraham added a comment. Oh gosh, are shadows not scale-aware anywhere? We'd have to replicate this code in a lot of places... might it make more sense to fix this in Qt itself? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma Cc:

D27261: [Folder view] Fix binding loop on width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b1cc98f0959: [Folder view] Fix binding loop on width (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75470=75471 REVISION

D27261: [Folder view] Fix binding loop on width

ngraham updated this revision to Diff 75470. ngraham added a comment. One more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75469=75470 BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL

D27261: [Folder view] Fix binding loop on width

ngraham updated this revision to Diff 75469. ngraham added a comment. Use identical margins; don't change the visuals at all (should be done in another patch if necessary) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75427=75469 BRANCH

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > usta wrote in main.qml:242 > I am really away from qml thing but are you sure this one correct ? I mean > isnt this should be > kcm.dpi instead of kcm.fontsAASettings.dpi ?? No dpi is declared inside fontsAASettings REPOSITORY R119 Plasma

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

https://bugs.kde.org/show_bug.cgi?id=354004 Harald Sitter changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

Plasma 5.18 LTS

Plasma 5.18.0 is now released https://www.kde.org/announcements/plasma-5.18.0.php This includes plasma-nano and plasma-phone-components which are not part of the LTS.

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75465. bport added a comment. fix coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75446=75465 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

wstephenson created this revision. wstephenson added reviewers: hein, davidedmundson. wstephenson added a project: Plasma. Herald added a subscriber: plasma-devel. wstephenson requested review of this revision. REVISION SUMMARY The code to handle a window drag from the taskbar to drop on the

D27316: [Folder view]Make shadow scale aware

gvgeo updated this revision to Diff 75453. gvgeo edited the test plan for this revision. gvgeo added a comment. Enclosed in Math.round() Although works fine without it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27316?vs=75450=75453 BRANCH

D27316: [Folder view]Make shadow scale aware

gvgeo created this revision. gvgeo added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Added devicePixelRatio to shadow's radius. TEST PLAN Check the shadow of items on the desktop.

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75446. bport added a comment. coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75444=75446 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27084: Don't delay ksplash until the entire slideshow is loaded

davidre added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27084 To: davidre, davidedmundson, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75444. bport added a comment. Fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75442=75444 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75442. bport added a comment. Take in consideration Cyril's feedbacks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75000=75442 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES

D27237: [Background Finder] Create a valid invocation token

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ae0fafe23700: [Background Finder] Create a valid invocation token (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27237?vs=75232=75435

D27261: [Folder view] Fix binding loop on width

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's technically different to before. The old code had half a small margin each side. Generally speaking bug fixes shouldn't change things, as then you're mixing