D27329: Make Taskmanager's tooltip a fixed ratio rectangle

mvourlakos added a comment. For reference https://en.m.wikipedia.org/wiki/Golden_ratio REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27329 To: trmdi, #vdg, #plasma, ngraham Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, c

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

mvourlakos added a comment. In D27329#611906 , @trmdi wrote: > How about this? > F8104781: image.png You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Anc

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. How about this? F8104781: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27329 To: trmdi, #vdg, #plasma, ngraham Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, c

D27412: Port away from deprecated API on Qt 5.15.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27412?vs=75714&id=75731#toc REPOSITORY R871 DrKonqi CHANGES SINCE

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/5/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 15 Feb 2020 00:57:17 + Build duration: 3 min 43 sec and counting CONSOLE OUTPUT [...tru

D27418: Don't let the Advanced tab's spacers expand all they want

This revision was automatically updated to reflect the committed changes. Closed by commit R123:26022caf9a2a: Don't let the Advanced tab's spacers expand all they want (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D27418: Don't let the Advanced tab's spacers expand all they want

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. `dont-stretch-it` REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH dont-stretch-it (branched from master) REVISION DETAIL https://phabricator.kde.org/D27418 To: filipf, #vdg,

D27418: Don't let the Advanced tab's spacers expand all they want

ngraham added a comment. probably stable branch REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH dont-stretch-it (branched from master) REVISION DETAIL https://phabricator.kde.org/D27418 To: filipf, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jrale

D27418: Don't let the Advanced tab's spacers expand all they want

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We have 3 vertical spacers in the Advanced tab and their defined as Expanding. So that means they become quite the gaps if the wi

D27088: [applets/SystemTray] Implement sorting in the model

ngraham accepted this revision. ngraham added a subscriber: mart. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's make sure one of our model experts (@davidedmundson, @broulik, @mart) gets a chance to make sure I'm not smoking crack by approving this. :

Re: 2 kirigami fixes for a point release

On 2020-02-13 00:48, Kai Uwe Broulik wrote: To minimize potential Frameworks dependency problems I would even go as far as put Feature freeze on same date as Frameworks tagging date so that no new stuff goes in that could require a Framework change, like the wallpaper JPG vs PNG situation. Bu

Re: 2 kirigami fixes for a point release

On 2020-02-13 00:42, Ben Cooksley wrote: A better way of approaching this would be to freeze the Frameworks version you are going to require API wise at an earlier point in the Plasma development cycle. This would allow for a full Frameworks release cycle to pass where bugs encountered during the

D27412: Port away from deprecated API on Qt 5.15.0

usta added a comment. isnt this also needs #include REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27412 To: apol, #frameworks, davidedmundson, sitter Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D26726: [Breeze Cursors] Add some more cursor names

ngraham added a comment. In D26726#610446 , @guilhermesilva wrote: > Hello, > > I'm the person the reported this issue to the Chromium team. The fix they made will probably lan

Re: Plasma 5.18 release post-mortem

Some of the features or large changes that were added to 5.18 but caused regressions made it in close to the cut-off, but many were committed months ago. In particular 417424, 416695, 416358 were not the result of rush jobs, but they got broken anyway. I don't necessarily disagree though, but

D27365: fix condition in KonsoleProfiles::run

alex added a comment. Hello, I have already created a patch for this (and some other improvements) which is currently waiting to be reviewed: https://phabricator.kde.org/D27098 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27365 To: McPain, heikobecker Cc

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 75724. alex added a comment. Remove unnecessary include, simplify REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=74853&id=75724 BRANCH konsole_bugfix (branched from master) REVISION DETAIL https://phab

D27401: [applets/SystemTray] Fix crash on shutdown

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27401?vs=75690&id=75723 RE

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added a comment. How about you @bport ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ra

5.19 Kickoff Meeting Thursday 20th at 15:00UTC/16:00CET

Let's have a Kickoff meeting at Thursday 20th at 15:00UTC/16:00CET in #plasma on freenode or #plasma:kde.org on Matrix. Agenda will be: review of 5.18, review of dependencies for 5.19, review of schedule for 5.19, review of workitems for 5.19. We usually take 2 hours for these meetings but someti

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. No need to worry. The flip of the toolbar is a small proportion of the patch, most of the time I try to solve other problems. And in the end of the line was a team decision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: g

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

crossi added a comment. looks ok to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeym

D27393: [Applet]Fix details layout.

gvgeo added a comment. > Might be nice to port to ColumnLayout while we're at it It is not really possible, what makes sense is changing to GridLayout. But because is a similar situation with battery's info bug, I don't want to do it together with these patches. D26806#inline-151955

D27392: [Applet]Add info messages.

gvgeo updated this revision to Diff 75721. gvgeo added a comment. Set first label enabled false, and the second specified opacity to 0.6 instead (it is used as a delay). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27392?vs=75669

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > meven wrote in componentchooseremail.cpp:154 > I would rather do the opposite the check below is for historical reasons from > before my refactoring. I meant to remove the check below (which I did). REPOSITORY R119 Plasma Desktop REVISION DETAI

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Sounds like it will provide a complete fix, the update script will fix the issue without requiring the user to reset its application style, and this patch will ensure it won't come back. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D27406: Fix build with Qt 5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R122:3a5aca82527e: Fix build with Qt 5.15 (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27406?vs=75707&id=75718 REVISION DETAIL https://phabric

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > crossi wrote in componentchooseremail.cpp:154 > While you are here, can you had a check on this pointer. I don't understand > why there is one below but not here. I would rather do the opposite the check below is for historical reasons from before

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Could we maybe ship a kconfig update script to change the string in the config file for people who don't ever change their global theme? Or is the problem moot because the global theme gets automatically applied on upgrade or something? REPOSITORY R120 Plasma Work

D27402: Make it possible to change the sorting when searching

ngraham added a comment. I'm on Tumbleweed and everything is up to date, but hmm, I see that libappstream is still at 0.12.7, not 0.12.10, the current release. I wonder why that is. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27402 To: apol, ngr

D27402: Make it possible to change the sorting when searching

apol added a comment. In D27402#611754 , @ngraham wrote: > Being able to sort search results in different ways is a nice feature for sure. But the desire for it arises from dissatisfaction with the default "relevance" search results. We might wa

D27412: Port away from deprecated API on Qt 5.15.0

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Upstream recommends using QLocale for turning dates into strings. TEST PLAN Builds on my system now

D27402: Make it possible to change the sorting when searching

ngraham added a comment. Being able to sort search results in different ways is a nice feature for sure. But the desire for it arises from dissatisfaction with the default "relevance" search results. We might want to still do this, but the pressure for it could be reduced if the relevance al

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. In D27407#611723 , @ngraham wrote: > This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for

D27411: Port away from deprecated API

apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QComboBox::currentIndexChanged now gets an int and a string TEST PLAN Can build it now on my system R

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. So this is clearly a correct fix, but I'm not sure it's sufficient to fully resolve 417515. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel, Orage

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D27406: Fix build with Qt 5.15

apol updated this revision to Diff 75707. apol added a comment. I am potato REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27406?vs=75697&id=75707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27406 AFFECTED FILES daemon/actions/bun

D27407: Breeze widgetStyle value is Breeze

crossi added a subscriber: ngraham. crossi added a comment. @ngraham my bad, didn't see your edit ^^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-

D27408: Fix build with Qt 5.15.0

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY currentIndexChanged(int) is reprecated and bound to be removed. TEST PLAN Builds REPOSITORY R121 Poli

D27393: [Applet]Fix details layout.

ngraham added a comment. Might be nice to port to `ColumnLayout` while we're at it REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27393 To: gvgeo, #plasma, #vdg, jgrulich Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D27390: [GTK3] Fix menubar colours

This revision was automatically updated to reflect the committed changes. Closed by commit R98:d3e9aa737502: [GTK3] Fix menubar colours (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27390?vs=75655&id=75700 REVISION DETAIL https:

D27392: [Applet]Add info messages.

ngraham added a comment. Both labels should have `enabled: false` set to lighten the text in a consistent way. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27392 To: gvgeo, #plasma, #vdg, jgrulich Cc: ngraham, broulik, plasma-devel, Orage

D27407: Breeze widgetStyle value is Breeze

crossi created this revision. crossi added reviewers: ervin, bport, meven, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 414885 REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#611308 , @gvgeo wrote: > I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393

D27406: Fix build with Qt 5.15

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Doesn't compile, there is no such signal as `currentIndexChanged(int, QString)` REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27406 To: apol, #pl

D27406: Fix build with Qt 5.15

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QComboBox::currentIndexChanged(int) got deprecated. TEST PLAN Builds REPOSITORY R122 Powerdevil BRAN

D27394: [applets/notes] Only show configure button when focussed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. stable branch? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27394 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage

D27402: Make it possible to change the sorting when searching

apol added a comment. In D27402#611597 , @ngraham wrote: > When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you switch to

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75695. meven marked an inline comment as done. meven added a comment. Clean a redundant check, ensure that if the user cancels selecting a custom app, the right entry is selected and hasChanged reflects the state correctly REPOSITORY R119 Plasma Desktop

D27402: Make it possible to change the sorting when searching

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D27398#611564 , @davidedmundson wrote: > >> This patch fixes the issue, but I do still see the sidebar > > I meant to phrase that as

D27402: Make it possible to change the sorting when searching

apol created this revision. apol added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We were hiding it because sorting wouldn't work when we have the relevancy on, so now we'll disable it wh

D27397: Align name displayed for wayland session with sddm

meven abandoned this revision. meven added a comment. Was fixed by D27358 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27397 To: meven, ervin, crossi, bport Cc: ngraham, plasma-devel, Orage, LeGast00n, Th

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

davidedmundson added a comment. > I don't get why it would overlap if it's not visible since we're in a RowLayout here? Because the background to the categories view isn't in the categories view. There's some rectangles at the top that don't update. The content is clashing with these.

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

davidedmundson added a comment. >> This patch fixes the issue, but I do still see the sidebar I meant to phrase that as this patch completes the removal of the code, so that we always show the sidebar REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D27397: Align name displayed for wayland session with sddm

ngraham added a comment. Didn't this just get fixed with D27358 ? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27397 To: meven, ervin, crossi, bport Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-O

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

crossi added inline comments. INLINE COMMENTS > componentchooseremail.cpp:154 > } else { > pSettings->setSetting(KEMailSettings::ClientProgram, > emailClientService->storageId()); > pSettings->setSetting(KEMailSettings::ClientTerminal, > emailClientService->terminal() ? Q

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. In D27260#611545 , @davidedmundson wrote: > It still sounds like you're saying "we've just made a breaking change in frameworks " I mean... yeah. :/ It's kind of a lousy situation since the Frameworks change fix

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

broulik added inline comments. INLINE COMMENTS > AppletConfiguration.qml:167 > Layout.fillHeight: true > -visible: (configDialog.configModel ? > configDialog.configModel.count : 0) + globalConfigModel.count > 1 > +visible: true >

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

ngraham added a comment. This patch fixes the issue, but I do still see the sidebar with only one category in it: F8103697: Screenshot_20200214_073711.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27398 To: davide

D27260: [applets/systemtray] Set pin button's size correctly

davidedmundson added a comment. FWIW, Plasma 5.17 uses PC2, so I have no real objections to this patch in the context of this patch. I'm only questioning if that frameworks change is safe, given if it is causing changes elsewhere REPOSITORY R120 Plasma Workspace BRANCH fix-pin-button (b

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75691. meven added a comment. standardize how we check if the combobox has a value to save, allow to mark the value as changed when there was no value selected at the beginning REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricato

D27260: [applets/systemtray] Set pin button's size correctly

davidedmundson added a comment. It still sounds like you're saying "we've just made a breaking change in frameworks " REPOSITORY R120 Plasma Workspace BRANCH fix-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc: mart

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a subscriber: mart. ngraham added a comment. @mart, @davidedmundson So the PC3 ToolButton change just went in anyway via D27396 . So we now need to fix this somehow or else it'll be mega broken looking. If we fix it by landing this patch

D27401: [SysterTray] Fix crash on shutdown

broulik added a comment. Luckily, the change is only in `master` anyway REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27401 To: kmaterka, #plasma_workspaces, #plasma, broulik Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jr

D27401: [SysterTray] Fix crash on shutdown

anthonyfieroni added a comment. It should target 5.18. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27401 To: kmaterka, #plasma_workspaces, #plasma, broulik Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D27401: [SysterTray] Fix crash on shutdown

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When having expanded System Tray once, plasmashell crashes on teardown. BUG: 417552 FIXED-IN: 5.19.

D27358: Sync ("Wayland") appending to match SDDM

This revision was automatically updated to reflect the committed changes. Closed by commit R123:c0fdf0039be4: Sync ("Wayland") appending to match SDDM (authored by davidedmundson). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27358?vs=

Fonts KCM

The fonts KCM can't apply changes in Plasma 5.18.0. This will be fixed in Plasma 5.18.1 next week but it's a popular problem so distros may well want to patch it out before https://bugs.kde.org/show_bug.cgi?id=416358 Jonathan

D27381: [sidebar] Resolve changes in module before switching

This revision was automatically updated to reflect the committed changes. Closed by commit R124:979419d7430d: [sidebar] Resolve changes in module before switching (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27381?vs=756

D27386: Set toolbox to invisble when it's invisible

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a48de1efa22: Set toolbox to invisble when it's hidden (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27386?vs=75647&id=75683

D27007: [kcm/standardactions] Don't register kcminit hook when we don't have one

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ea7013f17b31: [kcm/standardactions] Don't register kcminit hook when we don't have one (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D27398: [desktoppackage] Fix layout when

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There was some broken code to hide the sidebar when we only have one module. However at some point it seems half was

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > bport wrote in componentchooserbrowser.cpp:107 > add a space between - and 1 > > By the way this check seems strange to me, can you confirm it still allow to > save custom browser ? Once the user has added browsers to the list, they appear as bef

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75679. meven marked an inline comment as done. meven added a comment. Add a space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395?vs=75671&id=75679 BRANCH arcpatch-D27384 REVISION DETAIL https://phabrica

D27397: Align name displayed for wayland session with sddm

meven created this revision. meven added reviewers: ervin, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417499 Since commit https://github.com/sddm/sddm/commit/62cd789ff62d7d9c6ef189314f0

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooserbrowser.cpp:107 > { > +if (currentIndex() == count() -1) { > +// no browser installed, nor selected add a space between - and 1 B

D27393: [Applet]Fix details layout.

gvgeo updated this revision to Diff 75674. gvgeo added a comment. Removed empty line. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27393?vs=75673&id=75674 BRANCH details (branched from master) REVISION DETAIL https://phabric

D27393: [Applet]Fix details layout.

gvgeo updated this revision to Diff 75673. gvgeo added a comment. Used Column as root item. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27393?vs=75658&id=75673 BRANCH details (branched from master) REVISION DETAIL https://p

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven created this revision. meven added reviewers: bport, ervin, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417276 TEST PLAN Have no email client installed. In kcm componentchooser - s

D27391: [Applet]Fix dimensions of traffic Monitor

gvgeo updated this revision to Diff 75670. gvgeo edited the summary of this revision. gvgeo added a comment. Changes: Added O value and aligned to the right. Used Math.round Made the plot's topMargin more specific. (Need to alling lines with labels) About the label workaround: It i

D27392: [Applet]Add info messages.

gvgeo updated this revision to Diff 75669. gvgeo added a comment. Made properties readonly. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27392?vs=75657&id=75669 BRANCH warings (branched from master) REVISION DETAIL https://p

D27392: [Applet]Add info messages.

broulik added inline comments. INLINE COMMENTS > Toolbar.qml:32 > > +property var displayWifiMessage: !wifiSwitchButton.checked && > wifiSwitchButton.visible > +property var displayWwanMessage: !wwanSwitchButton.checked && > wwanSwitchButton.visible Make it `readonly property bool`

D27391: [Applet]Fix dimensions of traffic Monitor

broulik added inline comments. INLINE COMMENTS > TrafficMonitor.qml:40 > top: parent.top > -topMargin: Math.round(units.gridUnit / 3) + (index * > plotter.height / 5) > +topMargin: index * plotter.height / 5 > } Always `Math.round` w

D27393: [Applet]Fix details layout.

broulik added a comment. Can we not make the `Column` the root item of the component? Then it should propagate the size automatically. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27393 To: gvgeo, #plasma, #vdg, jgrulich Cc: broulik, plas

Re: Plasma 5.18 release post-mortem

On Thu, Feb 13, 2020 at 5:40 PM Nate Graham wrote: > > Plasma 5.18 was a pretty buggy release, and I'd like to start a > discussion about how we think it happened and what we can do better next > time. Here are some of the top bugs that our users are reporting: I think we wanted to put too much i

D27380: [GTK Config] Write Font without style name

davidre added a comment. Stretch is in https://doc.qt.io/qt-5/qfont.html#Stretch-enum REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-dev

D27380: [GTK Config] Write Font without style name

gikari added a comment. In D27380#611204 , @davidedmundson wrote: > Take this code How about other styles, such as Condensed, Book etc? F8103081: Screenshot_20200214_114315.png REPOSITORY R9

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0c4da0774e43: [KCM Fonts] force need save to false during load to avoid state to be true too… (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D27394: [applets/notes] Only show configure button when focussed

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This makes the behaviour of the entire bottom panel consistent with how the

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

crossi accepted this revision. crossi added a comment. I can confirm this fix the issue here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev Cc: The-Feren-OS-D

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. I will look at a proper fix in the next days REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev Cc: The-Feren-OS-Dev, plasma-devel, Orage, L

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

davidedmundson accepted this revision. davidedmundson added a comment. > In more long term we need to fix ConfigModule do you think is better to do a setNeedsSave(false) after loading or emiting signal in all case ? I think we need something, I've seen some similar report in the nightmode

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

meven accepted this revision. meven added a comment. I can confirm the patch fix the issue. Tested with [General] font=Noto Sans,10,-1,5,50,0,0,0,0,0 in `.config/kdeglobals` With and without the patch, and the apply button now is highlighted when it the font setting w