D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I don't see any objections, will push to stable. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel,

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

gvgeo created this revision. gvgeo added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use the component already created. TEST PLAN Functionality must stay the same. Test with

D27723: feat(kwayland): enable the auto-rotation and tablet mode

This revision was automatically updated to reflect the committed changes. Closed by commit R110:65585290f109: feat(kwayland): enable the auto-rotation and tablet mode (authored by bshah). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27509: Introduce ProcessDataModel

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in extended_process_list.cpp:394 > This could have used a `reserve` call :) not a meaningful one, each provider can add provide many attributes REPOSITORY R111 KSysguard Library REVISION DETAIL

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 76653. davidedmundson marked 15 inline comments as done. davidedmundson added a comment. some but not all review comments REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=76011=76653 BRANCH

D27509: Introduce ProcessDataModel

ahiemstra added inline comments. INLINE COMMENTS > broulik wrote in process_data_model.cpp:278 > Superfluous; or have it return `name()` instead Oops. Both this one and the one in data() should return name() if shortName() is empty. REPOSITORY R111 KSysguard Library REVISION DETAIL

D27509: Introduce ProcessDataModel

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in process_data_model.h:53 > should this just be `Qt::DisplayRole` given you return for both in `data`? It breaks our roleNames as you can't have two names for the same value. Then on the QML side we can't interchange with

D27509: Introduce ProcessDataModel

broulik added inline comments. INLINE COMMENTS > extended_process_list.cpp:62 > +if (m_changeFlag != 0) { > +connect(parent, ::processChanged, this, > [=](KSysGuard::Process *process) { > +if (!process->changes().testFlag(m_changeFlag)) { Capture only

D27723: feat(kwayland): enable the auto-rotation and tablet mode

bshah created this revision. bshah added reviewers: romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Related kwin_wayland patches have been landed for rotation, so enable the relevant

D24706: [RFC] Change button style

ndavis added a comment. In D24706#619482 , @mart wrote: > hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be

D24706: [RFC] Change button style

mart added a comment. hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be considered an usability issue? REPOSITORY R31 Breeze REVISION DETAIL

D27458: Set a better position for Krunner in wayland

trmdi closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27458 To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76629. trmdi added a comment. Rename m_realVisible to m_requestedVisible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76597=76629 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

D25324: Display a warning, if xsettingsd is not found

gikari updated this revision to Diff 76627. gikari added a comment. Add XSettingsd find module REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25324?vs=69795=76627 BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D27721: globalaccel: allow sleep and hibernate keyboard shortcuts

bshah created this revision. bshah added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This is useful for the phone specially. You can quickly turn on-off your phone from lockscreen

D27458: Set a better position for Krunner in wayland

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Lets go for it. INLINE COMMENTS > view.cpp:411 > +{ > +m_realVisible = visible; > + this is a very confusing name. It refers to the visible state krunner has set, but

D27711: [Applet]Use gridLayout for details

gvgeo abandoned this revision. gvgeo added a comment. In favor of kirigami form. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,