KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 807 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/807/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Mar 2020 05:25:58 + Build duration: 2 min 25 sec and counting CONSOLE OUTPUT

D27669: [kstyle] Tools area

ndavis added a comment. I use a kdesrc-build environment. My process was this: cd breeze arc patch D27669 ninja -C "$( pwd | sed 's:/src/:/build/:' )" install #I use this through a script named kdesrc-ninja and it works well source ~/kde/.setup-env #This makes the

D27669: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#634758 , @ngraham wrote: > So I'm still having an issue with the feature um, not working. :( I have it turned on in the Breeze settings but it behaves as if off; that is to say, I see no different

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#634758 , @ngraham wrote: > So I'm still having an issue with the feature um, not working. :( I have it turned on in the Breeze settings but it behaves as if off; that is to say, I see no different appearance

D28134: Add ColorUtils

cblack updated this revision to Diff 78510. cblack added a comment. Fix errors REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78188=78510 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES

D27669: [kstyle] Tools area

ngraham added a comment. So I'm still having an issue with the feature um, not working. :( I have it turned on in the Breeze settings but it behaves as if off; that is to say, I see no different appearance compared to the status quo. Is anyone else experiencing this, or just me?

D27669: [kstyle] Tools area

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. All good, as far as I am concerned. Thanks ! REPOSITORY R31 Breeze BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78505. cblack added a comment. Address feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78306=78505 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

davidedmundson added inline comments. INLINE COMMENTS > globalshortcuts.cpp:42 > editor = new KGlobalShortcutsEditor(this, > KShortcutsEditor::GlobalAction); > -connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool))); > +connect(editor, ::changed, this, >

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

broulik planned changes to this revision. broulik added a comment. I'll look into creating a `KNotificationUiDelegate` or something along the lines REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: plasma-devel,

D27669: [kstyle] Tools area

hpereiradacosta added a comment. I finally got some time to look at the code. Some minor comments below (compiler warnings) Also there is a problem with menubar text color when option is disabled. Here at least it is still set to the decoration color, leading to invisible text with

D28262: [applets/analog-clock] Optional minute hand

aloiseau added a comment. In D28262#634715 , @broulik wrote: > > I can not find a kcfg file in this applet to simply extend > > In applets it's the `config.xml` you edited, so from a technical POV patch is good. Not sure this option is very

D28262: [applets/analog-clock] Optional minute hand

broulik added a comment. > I can not find a kcfg file in this applet to simply extend In applets it's the `config.xml` you edited, so from a technical POV patch is good. Not sure this option is very useful, however. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28262: [applets/analog-clock] Optional minute hand

aloiseau added a comment. Thanks Nathaniel for your feedbacks. About your technical comment, I can not find a kcfg file in this applet to simply extend. I will have a closer look to existing kcfg files and create one for analog clock (next weekend I guess) About the conceptual

D28281: Add options for OSD feedback

sgoth added a comment. I see. Then i'll let $things happen. Thanks! REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack Cc:

D28281: Add options for OSD feedback

cblack added a comment. In D28281#634702 , @sgoth wrote: > Cool thanks! > > As this is my first contribution via phabricator, can you give me a short advice on how to proceed? > Do i "arc land" it myself? To master? Since there's

D28281: Add options for OSD feedback

The-Feren-OS-Dev added a comment. In D28281#634702 , @sgoth wrote: > Cool thanks! > > As this is my first contribution via phabricator, can you give me a short advice on how to proceed? > Do i "arc land" it myself? To master? IIRC

D28281: Add options for OSD feedback

sgoth added a comment. Cool thanks! As this is my first contribution via phabricator, can you give me a short advice on how to proceed? Do i "arc land" it myself? To master? REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL

D28281: Add options for OSD feedback

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik,

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78498. sgoth added a comment. Refactor show functions to be members of VolumeOsd REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78495=78498 BRANCH volumeosdcfg (branched from master)

D28281: Add options for OSD feedback

sgoth marked an inline comment as done. sgoth added a comment. Ah, that seems a lot better yes, thanks. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack Cc: cblack, drosca, ngraham,

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. In D28057#634650 , @ngraham wrote: > Abandoning the existing `iconSize` config value and adding a new one called `gridViewIconSize` means that everyone'e existing icon view size will be reset, since nothing will be

D28281: Add options for OSD feedback

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. Code looks good, bar one minor issue—instead of using global showOsdX functions, it would be more idiomatic to declare these functions on the OSD object itself. Other than that,

D28281: Add options for OSD feedback

sgoth added a comment. Yeah, was unsure too if it's a good idea but now with your sanitized wording i'd prefer it that way :) But if i should go for a single OSD on/off i wouldn't mind either. REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master)

D28281: Add options for OSD feedback

ngraham accepted this revision. ngraham added a reviewer: drosca. ngraham added a subscriber: drosca. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me! I have to admit I was skeptical when I first saw the patch, but I think making the

D28281: Add options for OSD feedback

sgoth added a comment. now with spacing F8198928: image.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78495. sgoth added a comment. Add spacing REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78494=78495 BRANCH volumeosdcfg (branched from master) REVISION DETAIL

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78494. sgoth added a comment. Change wording REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78483=78494 BRANCH volumeosdcfg (branched from master) REVISION DETAIL

D28281: Add options for OSD feedback

sgoth added a comment. "default output" "Default output" "Default output device" ? looks like this then: F8198919: image.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth,

D28281: Add options for OSD feedback

ngraham added a comment. This works great! In terms of the UI, it feels like we need a bit more logical separation between the groups now. I would adjust things (in this same patch) to be like this: Play audio feedback for changes to: [x] Audio volume Show visual

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Abandoning the existing `iconSize` config value and adding a new one called `gridViewIconSize` means that everyone'e existing icon view size will be reset, since nothing will be reading from the `iconSize` values in the config files anymore. You have two options

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. I am not so sure about the QPlatform integration bit, it looks easier/cleaner to just use KFontChooserDialog; QFontDialog isn't widely used in KDE code, so porting to KFontChooserDialog is doable (though that sounds like going back in time to using KFontDialog in

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#634593 , @davidre wrote: > Do you know if `IconThemePath` is specified somewhere? Initial commit: https://github.com/KDE/kde-workspace/commit/4c553dbf39f4189290387bba35589200ca051084 Someone

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. Honestly that's what makes sense to me. I don't think the use case of "I trust this app enough to open it and show it my files, but not enough to let it modify my files" really exists. I think most normal users would just not use an app they don't trust, or not let

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#634593 , @davidre wrote: > Do you know if `IconThemePath` is specified somewhere? Initial commit: What I could observe is that some apps create a folder hierachy under this path and palce their

D28232: [SpellChecking KCM] Fix the build

ahmadsamir added a comment. I don't know when the CI will be updated, probably soon based on what I read on IRC #kde-devel, but until then isn't it better to keep the CI working for plasma-desktop? I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added inline comments. INLINE COMMENTS > backend.cpp:178 > +auto *job = new KIO::ApplicationLauncherJob(service, > serviceAction); > +// TODO uidelegate > +job->start(); Only if you like messageboxes. Plasma code might prefer something else? A

D28281: Add options for OSD feedback

sgoth marked an inline comment as done. sgoth added a comment. Oh.. good catch thanks :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78483. sgoth added a comment. Fix typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78456=78483 BRANCH volumeosdcfg (branched from master) REVISION DETAIL

D28289: Refactor of OverlaySheet

ngraham added a comment. FWIW this needs a rebase as there were apparently some changes to OverlaySheet on master since this was branched. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28289 To: mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2,

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. Do you know if `IconThemePath` is specified somewhere? What I could observe is that some apps create a folder hierachy under this path and palce their icon there. I currently don't have any idea how to handle this in qml. Maybe we need to do this in the model / c++

D28281: Add options for OSD feedback

ngraham added inline comments. INLINE COMMENTS > main.qml:198 > +function showOsdMicMute(text) { > +if (!Plasmoid.configuration.mutecOsd) > +return `mutecOsd`? :-) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To:

D28289: Refactor of OverlaySheet

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Rework OverlaySheet to remove some sizing hacks that made ListView and GridView not work well, fix

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78481. davidre marked an inline comment as done. davidre added a comment. Also change it in the tooltip icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78479=78481 BRANCH sni (branched from

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78479. davidre marked an inline comment as done. davidre added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78384=78479 BRANCH sni (branched from master) REVISION DETAIL

D28275: skip over supposed network shares that aren't

This revision was automatically updated to reflect the committed changes. Closed by commit R102:4847c9e2fed2: skip over supposed network shares that arent (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28275?vs=78442=78472 REVISION

D28276: only add devices to the smb mount model that are network shares

This revision was automatically updated to reflect the committed changes. Closed by commit R102:23d52fa33394: only add devices to the smb mount model that are network shares (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob

broulik created this revision. broulik added reviewers: Plasma, hein, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In the process, port jump list actions from custom `KDesktopFile` parsing to

D28275: skip over supposed network shares that aren't

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R102 KInfoCenter BRANCH smb-type-check REVISION DETAIL https://phabricator.kde.org/D28275 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Right, so my intention was to make it easy to add a new entry to the combobox titled "Metadata-only indexing". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634471 , @ngraham wrote: > Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail.

D28277: [UrlButton] Disable when there is no URL

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28277 To: broulik, mart, #vdg, #kirigami, ngraham Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail. However we probably don't have to worry too much about that for the purpose of

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634405 , @ngraham wrote: > In D28280#634388 , @bruns wrote: > > > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options.

D28277: [UrlButton] Disable when there is no URL

broulik updated this revision to Diff 78460. broulik retitled this revision from "[UrlButton] Don't show tooltip if it would be empty" to "[UrlButton] Disable when there is no URL". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. In D28280#634388 , @bruns wrote: > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. That would be fine. Comboboxes handle many options pretty well. In

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. For the "Add folder setting...": How about a config dialog **after** the File Dialog? This may seem over the top for now, but the next step is to make the excludeFilters and mimetype filters configurabe from the KCM, and then also per folder. REPOSITORY R119

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage, LeGast00n,

D28281: Add options for OSD feedback

sgoth added a comment. F8198388: image.png Not sure about the actual wording and whether we would want all 3 of them. Probably would use "input volume", "output volume" but i tried to match the existing "aural feedback" string. Also i

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven created this revision. meven added reviewers: ervin, bport, crossi, hchain, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Builds, changed a shortcut and back again REPOSITORY R119 Plasma Desktop

D28277: [UrlButton] Don't show tooltip if it would be empty

apol added a comment. disabling as suggested would make sense, thanks for looking into this! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28277 To: broulik, mart, #vdg, #kirigami Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D28281: Add options for OSD feedback

sgoth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sgoth requested review of this revision. REVISION SUMMARY Extend configuration knobs for visual feedback by adding separate ones for output volume, input volume and mute state. BUG:

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. UI refinement is here: D28280 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham updated this revision to Diff 78455. ngraham added a comment. use `onActivated:` rather than `onCurrentIndexChanged:` for the combobox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28280?vs=78454=78455 BRANCH refine-baloo-kcm-ui

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham created this revision. ngraham added reviewers: VDG, Baloo, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch refines the UI added in D28025 . The

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. If there are objections to this change, we can just make all the opened files automatically writable. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28218 To: jgrulich, #plasma, #vdg Cc: ngraham, apol,

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. With D28122 I think you can go ahead and port this code to it. Unless you want to take care of the QPlatform integration for it first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To:

D28277: [UrlButton] Don't show tooltip if it would be empty

ngraham added reviewers: VDG, Kirigami. ngraham added a comment. If `button.url` is undefined, then the whole thing won't work in the first place. Maybe instead the control could disable itself automatically, or change its color to red to indicate a broken link? REPOSITORY R169 Kirigami

D28272: Avoid copying buffer twice

This revision was automatically updated to reflect the committed changes. Closed by commit R838:f6e559702cf5: Avoid copying buffer twice (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28272: Avoid copying buffer twice

meven added a comment. Seems good to me REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28272 To: jgrulich, #plasma Cc: meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28272: Avoid copying buffer twice

zzag added inline comments. INLINE COMMENTS > screencaststream.cpp:549-563 > +// bind framebuffer to copy pixels from > +GLuint framebuffer; > +glGenFramebuffers(1, ); > +glBindFramebuffer(GL_FRAMEBUFFER, framebuffer); > +glFramebufferTexture2D(GL_FRAMEBUFFER,

D28277: [UrlButton] Don't show tooltip if it would be empty

broulik created this revision. broulik added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN F8198260: Screenshot_20200325_141929.png None of these links

D28232: [SpellChecking KCM] Fix the build

bport added a comment. https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series So we need to see if we can update the CI REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28232 To: ahmadsamir, #plasma, bport, meven, crossi, ervin Cc:

D28234: Use SyntaxHighlighter for highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R871:f304e0185fb8: Use SyntaxHighlighter for highlighting (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28234?vs=78354=78446 REVISION DETAIL

D28232: [SpellChecking KCM] Fix the build

ahmadsamir added a comment. In D28232#634281 , @bport wrote: > Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it But the CI still uses 5.12 for the opensuse image, and probably 5.13 for the

D28232: [SpellChecking KCM] Fix the build

bport added a comment. Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it INLINE COMMENTS > CMakeLists.txt:9 > set(QT_MIN_VERSION "5.12.0") > -set(KF5_MIN_VERSION "5.66.0") > Indeed this is needed thanks REPOSITORY R119 Plasma Desktop REVISION

D28234: Use SyntaxHighlighter for highlighting

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I love it! INLINE COMMENTS > backtracewidget.cpp:230 > +m_highlighter = new > KSyntaxHighlighting::SyntaxHighlighter(ui.m_backtraceEdit->document()); > + >

D28276: only add devices to the smb mount model that are network shares

sitter added a comment. In D28276#634264 , @broulik wrote: > This is because the device monitor emits all devices, not the query returning unwanted devices? Yep connect(Solid::DeviceNotifier::instance(),

D28276: only add devices to the smb mount model that are network shares

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. This is because the device monitor emits all devices, not the query returning unwanted devices? REPOSITORY R102 KInfoCenter BRANCH smb-type-check2 REVISION DETAIL

D28276: only add devices to the smb mount model that are network shares

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd add all devices which would then cause a crash when trying to access them ->as()

D28275: skip over supposed network shares that aren't

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we explicitly request listFromType(Solid::DeviceInterface::NetworkShare) but apparently still can

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 806 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/806/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 25 Mar 2020 09:44:02 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

D28272: Avoid copying buffer twice

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Previously we copied frames first to a temporary QImage and then to PipeWire buffer. This shouldn't be necessary as we can

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 25 Mar 2020 09:44:02 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D28270: [Colors KCM] Also save colors when active scheme was edited

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0f673d0e92b: [Colors KCM] Also save colors when active scheme was edited (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28270?vs=78431=78436#toc REPOSITORY R119

D28270: [Colors KCM] Also save colors when active scheme was edited

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I fixed the case that the "Apply" button wasn't enabled when the selected scheme didn't change

D27971: Solid-device-automounter/kcm: correctly update automountOn

meven added a comment. ping @ervin should be good now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27971 To: meven, bport, #plasma, ervin, crossi, hchain Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27513: Kill Runner: Remove duplicate function calls and refactor

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27513 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,