KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 08 Apr 2020 05:58:25 + Build duration: 1 min 17 sec and counting JUnit Tests Name: (ro

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 08 Apr 2020 05:58:26 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT

D28666: Refactor for loops

ngraham added a comment. I'm not a Javascript expert, but the old/current versions seem much more readable to me. Is there a performance advantage to your proposed new versions? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28666 To: cblack, #kirigami Cc: ngraham

D28666: Refactor for loops

cblack updated this revision to Diff 79623. cblack added a comment. Use Array.prototype.*.call() instead of Array.from to reduce copying REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28666?vs=79621&id=79623 BRANCH cblack/for-refactor (branched from mas

D28671: Improve appearance of gallery listing

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The gallery listing is now a CardsLayout of cards with images. TEST PLAN F8224151:

D28666: Refactor for loops

cblack updated this revision to Diff 79621. cblack added a comment. Use Array.from REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28666?vs=79614&id=79621 BRANCH cblack/for-refactor (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. In D28627#644050 , @davidedmundson wrote: > We only want to: > > - check when isMaximised potentially changes It would also be nice to turn off transparency for a panel that has a window tiled against its scr

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. > or is the window.isMaximized implementation bad in win? The problematic part of this patch is that whenever any property on any window changes we're checking all items. We only want to: - check when isMaximised potentially changes - only check

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. > You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful. > We're also mixing up shadows from one SVG with the output of another. Right. Originally I just

D28658: [krdb] Drop GTK2 colour exporting

gikari added a comment. We also need to remove the remaining GTK stuff from here once D28070 and D28072 are landed. Does anyone else wants to test the later? INLINE COMMENTS > krdb.cpp:642 >// Export colors to no

D28666: Refactor for loops

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY For loops have been refactored to use more idiomatic JavaScript functions (`filter()`, `some()`,

D28627: WIP: Made panel opaque on maximized window

davidedmundson requested changes to this revision. davidedmundson added a comment. Ok, so the logic is - the goal is to blend in. If you're not showing the desktop, you can't blend in to it. I can at least understand the thought process. --- Code wise, this needs a lot of work.

D28665: Explicitly type ColorUtils lambda

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Fixes Qt 5.12 CI failure: no known conversion from ColorUtils* (*)(QQmlEngine*, QJSEngine*

D28662: KCM LookAndFeel check widgetStyle availability before applying it

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM modulo some trivial code comment changes Probably a candidate for the stable branch. INLINE COMMENTS > kcm.cpp:268 > +QString widgetStyle = cg.readEntry("widgetStyle

D28658: [krdb] Drop GTK2 colour exporting

ngraham accepted this revision. ngraham added reviewers: gikari, davidedmundson. ngraham added 1 blocking reviewer(s): Plasma. ngraham added a subscriber: gikari. ngraham added a comment. Conceptually this makes sense, and the support for this doesn't really work anymore and is in fact causin

Re: Making PipeWire required for xdp-kde

On Wed, Apr 8, 2020 at 12:05 AM David Edmundson wrote: > > Check the KDE CI has everything before doing that. > You may also find kde-distro-packagers a better ML to ask to find real > world problems. At the moment per the CMake logs, we do not have Pipewire installed. You'll need to file a tick

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.14 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 07 Apr 2020 18:39:03 + Build duration: 45 sec and counting CONSOLE OUTPUT [...truncate

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3e8c7dada73e: Add .kksrc extension to the file name when global shorcuts scheme is exported (authored by harogaston, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28664: [OverlaySheet] add bottomMargin property

ngraham added a comment. Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before? INLINE COMMENTS > OverlaySheet.qml:108 > + */ > +p

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

harogaston updated this revision to Diff 79608. harogaston added a comment. Removed unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28547?vs=79256&id=79608 BRANCH add-kksrc-extension-to-exported-global-shortcuts (branched from mas

D28664: [OverlaySheet] add bottomMargin property

cblack created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Add a bottomMargin property that allows customizing the distance of the sheet from the bottom of the screen. This defaults to `Unit

D28134: Add ColorUtils

kossebau added a comment. Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #p

D28154: Add users KCM

cblack updated this revision to Diff 79605. cblack marked 2 inline comments as done. cblack added a comment. Improved avatar sheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79596&id=79605 BRANCH arcpatch-D28154_1 REVISION DETAIL h

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

davidre added inline comments. INLINE COMMENTS > kglobalshortcutseditor.cpp:54 > #include > +#include > Why do we need this include? > kglobalshortcutseditor.cpp:550 > +// TODO: Bug ossi to provide a method for this > +Q_FOREACH(const QString &group, config.groupLis

D28646: [Notifications] Sort popups ascending

This revision was automatically updated to reflect the committed changes. Closed by commit R120:55400729c478: [Notifications] Sort popups ascending (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28646?vs=79554&id=79604 REVISION

D28614: Add better player tab crash handling

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b50818455f89: Add better player tab crash handling (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28614?vs=79454&id=79602

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

ngraham accepted this revision. ngraham added a comment. Very nice! REPOSITORY R119 Plasma Desktop BRANCH add-kksrc-extension-to-exported-global-shortcuts (branched from master) REVISION DETAIL https://phabricator.kde.org/D28547 To: harogaston, ngraham, mart Cc: plasma-devel, Orage, L

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. Yeah plasmoid pop-ups should probably also be opaque when the panel is opaque, good call. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove, #plasma Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Fe

D27979: Add top area to notifications

ngraham added a comment. Sorry. With no //header text.// REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27979 To: niccolove, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. Thanks Nate for explaining. Couple of things that hit my mind: - Plasmoids should also be opaque, to be fully integrated: F8223607: Screenshot_20200407_191202.png Should I have very similiar code in the applet c

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0cf73170479b: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=788

D27979: Add top area to notifications

niccolove added a comment. In D27979#643330 , @ngraham wrote: > So I think the padding issue isn't related to fonts after all. I noticed while doing a backup today that there's no spacing between the header and the content underneath it even whe

D28462: [KCM] Add color state probe to allow system settings to display current default state

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > colorsstateprobe.cpp:29 > +: KCModuleStateProbe(parent, args) > +, m_settings(new ColorsSettings(this)) > +{ I'm not sure I see the point of doing this.

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > UserDetailsPage.qml:267 > +id: imgDelegate > +smooth: true > + Despite this, they're still jaggy for me. Maybe play with the mipmapping settings? > cblack wrote in main.qml:88 > Seems to be

D28154: Add users KCM

cblack marked 2 inline comments as done. cblack added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:88 > Not actually fixed. Just open System Settings with its default window size > and navigate to the new KCM and you'll see what I'm talking about. Seems to be a bug with syse/mul

D28461: In sidebar mode show if a module is in default state or not

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > MenuItem.h:160 > + > +void updateDefault(); > + I don't like the name much, I think it could be confused with updating actual default value or such... upda

D28663: Kate Runner: Cleanup and improvements

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The overview feature has been removed, because this is already handled using the

D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 419552 - Some Global Theme may refer to breeze widget style with a lowe

D28154: Add users KCM

cblack updated this revision to Diff 79596. cblack added a comment. Move columWidth set to KCM constructor REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79593&id=79596 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.o

D28154: Add users KCM

cblack updated this revision to Diff 79593. cblack added a comment. Add border to button on details page REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79592&id=79593 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org

D28154: Add users KCM

cblack updated this revision to Diff 79592. cblack added a comment. Add circle to accounts in the list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79250&id=79592 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28331 REVISION DETAIL https://phabricator.kde.org/D28331 To: meven, #kwin, #plasma, davidedmundson, ervin, bport, crossi, hchain C

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. For the wayland one at least I'm sure it's not that because without restarting session nothing happen For the X one I didn't see anything related to apply on the bug report (but yes the apply bug exist) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. Yes after restarting the session, the new cursor sized is fully applied everywhere. However 385920 413783 are about applying the cursor size everywhere immediately without having to restart the session, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. In D28652#643733 , @ngraham wrote: > After locally fixing the compile error, applying this patch as well as all three others, and restarting KWin, I'm unfortunately seeing the bugs marked as fixed still happening: I change

D28652: [Cursors] Remove Resolution Dependant option

bport updated this revision to Diff 79590. bport added a comment. Add migration to delete old default REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79576&id=79590 REVISION DETAIL https://phabricator.kde.org/D28652 AFFECTED FILES doc/k

D28646: [Notifications] Sort popups ascending

ngraham accepted this revision. ngraham added a comment. Indeed, much better. Now you can read them when a bunch come in at once. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28646 To: broulik, #plasma, #vdg, ndavis, ngraham Cc: ngraham, ndavis, plasma

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. Hm, this is bizarre. I've tested once again and now the bug I mentioned before is gone. @ngraham Did you launch system settings (colors section) **after applying** D28070 to plasma-desktop? Without that patch it won't work pos

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. After locally fixing the compile error, applying this patch as well as all three others, and restarting KWin, I'm unfortunately seeing the bugs marked as fixed still happening: I change the cursor size, click Apply in the KCM, then the cursor size still changes back

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. No. :( I feel like I'm doing something really stupid here to make nothing work... REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638800 , @gikari wrote: > I also noticed a **dynamic** recoloration bug: it doesn't work if the app is launched with the color scheme, that it was using in the previous launch. To make it work I have to change c

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Still doesn't work: gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module" In D28072#643694

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#643693 , @ngraham wrote: > Still doesn't work for me: > > gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so > Gtk-Message: 08:49:51.962: Failed to load modul

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Still doesn't work for me: gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module" REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-col

D28658: [krdb] Drop GTK2 colour exporting

cblack updated this revision to Diff 79579. cblack added a comment. Drop the exportColors argument REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28658?vs=79577&id=79579 BRANCH cblack/drop-gtk2-colors (branched from master) REVISION DETAIL http

D28658: [krdb] Drop GTK2 colour exporting

ngraham added a comment. Probably needs some inline documentation here (as well as in the header file) that the `exportColors` arg now is does a no-op. Or can we even remove it entirely? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28658 To: cblack, #plas

D28651: Load and use global animation settings

ndavis added a comment. I don't know enough about KDE configuration management to judge the code, but changing animation speeds in SySe works if I restart apps after the change. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ngraham,

D28658: [krdb] Drop GTK2 colour exporting

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY With the vast supermajority of modern GTK2 themes using pixmaps, exporting colours is only likely

D28652: [Cursors] Remove Resolution Dependant option

bport added inline comments. INLINE COMMENTS > ngraham wrote in x11_backend.cpp:145 > Would `size` ever be empty now (not a leading question; I'm genuinely asking) No never be empty, not sure what I made there... looks like I reverted something before commiting REPOSITORY R119 Plasma Desktop

D28651: Load and use global animation settings

ngraham added a comment. I agree with Hugo that if we make Breeze respect the new global animation speed slider, we should remove the user-facing setting in Breeze's own settings to control the animation speed. Having two config knobs for ostensibly the same thing (or more accurately, one ad

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in autostart.cpp:182 > Yes. > It then also needs to set a transient parent and window modality manual I > think Yes, otherwise you wouldn't get a

D28652: [Cursors] Remove Resolution Dependant option

davidedmundson added a comment. Other related question. What happens if we specify the size as being 24, but the icon set doesn't have that? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson, ngraham Cc: ngra

D28652: [Cursors] Remove Resolution Dependant option

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in x11_backend.cpp:145 > Would `size` ever be empty now (not a leading question; I'm genuinely asking) And of course now this fails to build too since you can't call `isEmpty` on an `int` REPOSITORY R119 Plasma Desktop REVISION

D28652: [Cursors] Remove Resolution Dependant option

ngraham added inline comments. INLINE COMMENTS > x11_backend.cpp:145 > } > if (!size.isEmpty()) { > +UpdateLaunchEnvJob launchEnvJob(QStringLiteral("XCURSOR_SIZE"), > QByteArray::number(size)); Would `size` ever be empty now (not a leading question; I'm genuinely asking) REPO

D28652: [Cursors] Remove Resolution Dependant option

bport planned changes to this revision. bport added a comment. In D28652#643612 , @ngraham wrote: > For them I guess we'll need a kconf update file to migrate them to the new 24 value. We will need to remove this entry we don't write defa

D28652: [Cursors] Remove Resolution Dependant option

bport updated this revision to Diff 79576. bport added a comment. fix build REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79569&id=79576 REVISION DETAIL https://phabricator.kde.org/D28652 AFFECTED FILES doc/kcontrol/cursortheme/index.

D28651: Load and use global animation settings

hpereiradacosta added a comment. I have no idea how this is supposed to work. But the current fix overwrites what's in the breeze configutation, right ? Would it not lead to utter confusion ? These settings should be set at one place and one only. Whether breeze or global I have no strong

D28652: [Cursors] Remove Resolution Dependant option

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > x11_backend.cpp:138 > } > applyCursorTheme(theme, intSize); > `intSize` is no longer defines so it fails to build REPOSITORY R119 Plasma Desk

D28657: [Notifications] Report roleNames in the relevant places

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY QML needs it on the model it uses (`Notifications`) where they used to be but GammaRay seems to b

D26934: KCM/Autostart Add a model to separate logic from UI

ervin added inline comments. INLINE COMMENTS > meven wrote in autostartmodel.h:52 > I see, I meant my code to have all Roles used explicitly declared here rather > than relying on the developer knowing about Qt::DisplayRole. Weeell... knowing about Qt::DisplayRole is kind of prerequisite to mak

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 414417 - While saving a new global theme, don't set splash screen if no

D28631: Remove Icons from system tray item tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R120:96ad51cde0ea: Remove Icons from system tray item tooltips (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79545&id=79573 RE

D28651: Load and use global animation settings

ndavis added a comment. So this makes Breeze respect the global animation speed setting in the Workspace Behavior - > General Behavior KCM? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ndavis, plasma-devel, #breeze, Orage, LeGast00n

D28652: [Cursors] Remove Resolution Dependant option

ngraham added a comment. For them I guess we'll need a kconf update file to migrate them to the new 24 value. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson Cc: ngraham, plasma-devel, kde-doc-english, Orage, Le

D28652: [Cursors] Remove Resolution Dependant option

davidedmundson added a comment. what happens to users that have 0 written out in their config file already? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson Cc: plasma-devel, kde-doc-english, Orage, LeGast00n, The

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28653 https://phabricator.kde.org/D28654 https://phabricator.kde.org/D28655 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, dav

D28653: Set cursor size default to 24 to align with KCM default value

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28652 https://phabricator.kde.org/D28654 https://phabricator.kde.org/D28655 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28653 To:

D28655: Set default cursor size as 24 to follow new default on KCM

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28652 https://phabricator.kde.org/D28653 https://phabricator.kde.org/D28654 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28655 To: bport, #plasma, meven, d

D28655: Set default cursor size as 24 to follow new default on KCM

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28655 AFFECTED FI

D28653: Set cursor size default to 24 to align with KCM default value

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kd

D28652: [Cursors] Remove Resolution Dependant option

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. bport requested review of this revision. REVISION SUMMARY This option don't work as expected for years on X, a

D28651: Load and use global animation settings

sandsmark created this revision. sandsmark added a reviewer: Breeze. sandsmark added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sandsmark requested review of this revision. REVISION SUMMARY In addition to the specific Breeze animation settings, KD

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik planned changes to this revision. broulik added a comment. Apparently this causes all kinds of breakages :0 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jrale

D28650: [Notifications] Don't reverse() Array

broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This mutates the source array. In practice actions don't really change in existing

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Now that we can depend on Qt 5.14 TEST PLAN Still get both jobs and notifications. Can still in

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#643502 , @sitter wrote: > My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function o

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function of kguiaddons so it actually links it) ;) REPOSITORY R124 System Settings REVISION DE

D28646: [Notifications] Sort popups ascending

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Nice usability improvement! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28646 To: broulik, #plasma, #vdg, ndavis Cc: ndavis, plasma-devel, Orage, LeGa

D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in background.cpp:165 > From the docs > > Commandline to use add when autostarting at login. >If this is not specified, the Exec line from the >desktop file will be used. > > I can't see us doing that last

D28214: Add background portal

jgrulich added a comment. In D28214#643478 , @bcooksley wrote: > This change, as committed does not appear to compile: > https://build.kde.org/view/Failing/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/lastFailedBuild/cons

Re: Making PipeWire required for xdp-kde

Check the KDE CI has everything before doing that. You may also find kde-distro-packagers a better ML to ask to find real world problems. >From the plasma side, go for it. David

D28214: Add background portal

davidedmundson added inline comments. INLINE COMMENTS > background.cpp:165 > +qCDebug(XdgDesktopPortalKdeBackground) << "enable: " << enable; > +qCDebug(XdgDesktopPortalKdeBackground) << "commandline: " << > commandline; > +qCDebug(XdgDesktopPortalKdeBackground) << "flags

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#643466 , @sitter wrote: > FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also se

Re: Making PipeWire required for xdp-kde

On Tue, Apr 7, 2020 at 1:27 PM Jan Grulich wrote: > > Hi, > > I recently pushed a background portal implementation, which also needs some > KWayland stuff, while previously it was needed just for screen sharing purpose > and compiled only when PipeWire and some other libraries are found. Now I nee

Making PipeWire required for xdp-kde

Hi, I recently pushed a background portal implementation, which also needs some KWayland stuff, while previously it was needed just for screen sharing purpose and compiled only when PipeWire and some other libraries are found. Now I need the Wayland part available all the time and I don't want

D28214: Add background portal

bcooksley added a comment. This change, as committed does not appear to compile: https://build.kde.org/view/Failing/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/lastFailedBuild/console REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL http

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also see https://markmail.org/message/m3mdrsfgxoyfjtte REPOSITORY R124 System Settings REVI

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 79560. alex added a comment. Suspend matching if the profiles are empty REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=75930&id=79560 BRANCH arcpatch-D27098_1 REVISION DETAIL https://phabricator.kde.or

D28616: Split KWin startup out of KSMServer

broulik updated this revision to Diff 79558. broulik added a comment. - Implement saveCurrentSession - Clean up states and some comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28616?vs=79461&id=79558 REVISION DETAIL https://phabricator

D28631: Remove Icons from system tray item tooltips

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28631#643325 , @ngraham wrote: > Remove no-longer-relevant reference to icon in `AbstractItem.qml` Thanks, accepted. REPOSITOR

  1   2   >