D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

cblack added a comment. In D28664#646279 , @ngraham wrote: > Well, one of the ideas of Kirigami is to not spawn new windows when not needed. The Dialog in QQC2 (not to be confused with the dialog from QtQuick Dialogs) isn't a separate

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. Well, one of the ideas of Kirigami is to not spawn new windows when not needed. Maybe the basic QQC2 popup (which does open centered) needs to gain the same visual style as an OverlaySheet. Or maybe OverlaySheet should be able to be used as a centered pop-up thingy.

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

cblack added a comment. In D28664#646254 , @ngraham wrote: > I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. Super-awesome! INLINE COMMENTS > ShortcutActionDelegate.qml:54 > +spacing: Kirigami.Units.smallSpacing > +QQC2.Label { > +Layout.fillWidth: true I might right-align the text for improved visual parse-ability

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be improved: F8232058: Screenshot_20200411_180348.png

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk wrote: > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > wrote: > > > > Yes the only reason why a cleanup script might be needed is if the > > logical path used to express the repo in dependency information > > changes at the same time. E.g.

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote: > > Yes the only reason why a cleanup script might be needed is if the > logical path used to express the repo in dependency information > changes at the same time. E.g. suppose a `frameworks/kf5foo` gets > remapped to `frameworks/kf5/foo`

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:03 PM Michael Pyne wrote: > > On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote: > > > > > A cleanup script could be handy. I think kdesrc-build will > > automatically pick up new repo paths from metadata and that should > > work transparently, but the old

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. I need a small help for the second one. When there's no toolbar, the toolbar.visible is set to false; otherwise, it's true. But when I'm in the systemtray and I try to check activeApplet.fullRepresentationItem.header.visible, it always returns false. What could

D28664: [OverlaySheet] add bottomMargin property

cblack updated this revision to Diff 79891. cblack added a comment. Add whitespace REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28664?vs=79890=79891 BRANCH cblack/sheet-scroll-fix (branched from master) REVISION DETAIL

D28664: [OverlaySheet] add bottomMargin property

cblack updated this revision to Diff 79890. cblack added a comment. Use heuristics instead of exposing new API REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28664?vs=79607=79890 BRANCH cblack/sheet-scroll-fix (branched from master) REVISION DETAIL

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 79889. niccolove added a comment. Removed extra line REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=79155=79889 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

Re: Notice of upcoming changes to the behaviour of the anongit network

On Sat, Apr 11, 2020 at 10:14:38PM +1200, Ben Cooksley wrote: > Hi all, > > As part of the preparations for the move to Gitlab, and the rewrite of > our anongit tooling, one of the things we have looked into is how the > anongit network in general operates. > > As part of this, it has been

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 79886. cblack added a comment. Fallback to album cover icon without album art or desktop file name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77796=79886 BRANCH media-plasmoid-relayout (branched

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote: > On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > > > Yes, the hostname git.kde.org will be fully retired as part of this > > transition. > > > > From my understanding kdesrc-build will automatically pick this up > > once

Re: Update on Status of Gitlab Migration

El sáb., 11 de abr. de 2020 a la(s) 16:26, Johan Ouwerkerk (jm.ouwerk...@gmail.com) escribió: > > On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > > > Yes, the hostname git.kde.org will be fully retired as part of this > > transition. > > > > From my understanding kdesrc-build will

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 9:01 PM Nicolás Alvarez wrote: > > How would it work during the "grace period"? Keeping an outdated read-only > mirror on the old URL? I have done some research into redirecting or > remapping from the old URL to the new one so we can keep it working for a > longer

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote: > > Yes, the hostname git.kde.org will be fully retired as part of this > transition. > > From my understanding kdesrc-build will automatically pick this up > once we update sysadmin/repo-metadata to show the new repository > paths. > This is

Re: Update on Status of Gitlab Migration

El 11 abr. 2020, a la(s) 08:31, Johan Ouwerkerk escribió: > > On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: >> Should anyone have any questions on the above, please let us know. > > Does the migration also mean that `git.kde.org` push URL will be > retired and would need to be

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:31 PM Johan Ouwerkerk wrote: > > On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > > > Should anyone have any questions on the above, please let us know. > > > > Does the migration also mean that `git.kde.org` push URL will be > retired and would need to be

D28383: Add PageRouter component

cblack updated this revision to Diff 79874. cblack added a comment. Add tests REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79870=79874 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED FILES

D28383: Add PageRouter component

cblack updated this revision to Diff 79870. cblack added a comment. Add currentRoutes function REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79785=79870 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED

D28113: Fix initial loading of autostart program names

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c20db943b994: Fix initial loading of autostart program names (authored by yuyichao). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28113?vs=77876=79841

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 79831. davidre added a comment. enabled REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=79829=79831 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744

D28744: Rewrite of the global shortcuts kcm

davidre added a comment. - I omitted the remove button for now because removing things correctly from KGlobalAccel is hard and any program could add itself again, but I could add it again. - The expanded ui needs some work. Open for any idea there. REPOSITORY R119 Plasma Desktop

D28744: Rewrite of the global shortcuts kcm

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY This is a total rewrite of the global shortcuts kcm from scratch. It uses an abstract item model backend with a qml frontend.

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > Should anyone have any questions on the above, please let us know. > Does the migration also mean that `git.kde.org` push URL will be retired and would need to be remapped to `invent.kde.org`? In that case, it would be good to have a

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik updated this revision to Diff 79818. broulik added a comment. - Also change tooltip Note to future me: put this logic in a shared location REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28740?vs=79816=79818 REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. That is exactly what it should do and it did originally but I just noticed it still showed a date, presumable for leap year reasons. With this patch no date is shown again when "until turned off" is chosen. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

pino added a comment. Wouldn't be better instead to not display a date in case the "until turned off" option is chosen? I personally found it confusing the first time I chose this option, and yet a date was shown. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When setting "until turned off" it effectively sets it to today in a year. Now with leap year

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > To help assist with this, it would be appreciated if all holders of a > KDE Developer account could please login on our Gitlab instance (at > https://invent.kde.org/) and ensure they are listed as a 'Developer' > of the KDE group. You can

Notice of upcoming changes to the behaviour of the anongit network

Hi all, As part of the preparations for the move to Gitlab, and the rewrite of our anongit tooling, one of the things we have looked into is how the anongit network in general operates. As part of this, it has been observed that the git:// protocol is unencrypted, and thus vulnerable to

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. I will this for a few days and merge if no more feedback is sent. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28658: [krdb] Drop GTK2 colour exporting

gikari resigned from this revision. gikari added a comment. No objections from me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28658 To: cblack, #plasma, ngraham, davidedmundson Cc: gikari, fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

Update on Status of Gitlab Migration

Good morning Community, I'm pleased to report that this week we reached a major milestone, with all the necessary technical components now being in place on our side for our migration to Gitlab to take place. This includes the replacement of the tooling that supports the anongit network, as well