D26111: Runner: make recentdocument use KActivityStats data

meven marked 2 inline comments as done. meven added a comment. I need to change dev machine, now that plasma-workspace needs Qt5.14, that explains the delay. INLINE COMMENTS > broulik wrote in recentdocuments.cpp:78 > Do we really want `QUrl::fromUserInput` here? This thing typically

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. The latter, if you don't mind. I appreciate your patience! I hope to have the rewrite submitted tomorrow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage,

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#40 , @ngraham wrote: > Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a few days until that's done, it might make your patch a lot simpler. REPOSITORY

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. Managed to re-introduce https://bugs.kde.org/show_bug.cgi?id=414045, so it looks like that's not related to this. Will fix it in another patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82324. ngraham added a comment. Move the config bar as the panel changes thickness REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82280=82324 BRANCH panel-adjustment-adjustment (branched from master)

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82323. kurmikon added a comment. So I worked on this. It's not easy to me to do this stuff since the slider and the spinbox have to synchronize themselves on the other one. Making symply and update from one to another would lead to infinite

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If status is set to NeedsAttention it

D29535: Change panel thickness adjustment UI to use a SpinBox

abetts added a comment. +1 from me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29518: Remove remaining icons from applets with custom tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eeab79954d7d: Remove remaining icons from applets with custom tooltips (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham planned changes to this revision. ngraham added a comment. Need to re-implement the panel thickness change handling REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage,

D29517: Remove remaining icons from applets with custom tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R114:1d64bd119235: Remove remaining icons from applets with custom tooltips (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D29516: Remove remaining icon from applet with custom tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fe20601bddd5: Remove remaining icon from applet with custom tooltip (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 82302. apol added a comment. Adapt to changes in the protocol, implement windows REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81926=82302 BRANCH arcpatch-D28884 REVISION

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari added a comment. In D28623#666400 , @cblack wrote: > While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible. I'm not completely sure about this

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82294. gikari added a comment. Export buttons with fixed geometry (Now all buttons are exported with the same size) REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82266=82294 BRANCH

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

kmaterka accepted this revision. kmaterka added a comment. plasma-workspace compiles using cmake 3.10 without issues now. REPOSITORY R111 KSysguard Library BRANCH ancient_cmake_fix REVISION DETAIL https://phabricator.kde.org/D29529 To: ahiemstra, #plasma, ngraham, kmaterka Cc:

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

cblack added a comment. While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible. Even our own Breeze GTK uses palette swaps rather than unique pixmaps for every state. REPOSITORY R99 KDE Gtk

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 82289. mart added a comment. - Merge branch 'sensors_lib' into mart/sensor_face REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82279=82289 BRANCH mart/sensor_face REVISION DETAIL

D28487: Redesign of system monitor plasmoids

ngraham added a comment. When I create a new System Monitor Sensor widget, it's totally blank: F8300732: Screenshot_20200508_103957.png Needs to have a Configure... button on it in this case. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a subscriber: ahiemstra. ngraham added a comment. An idea brought up by @ahiemstra would be to add dragability into the SpinBox control itself, which was suggested in T9460 and would automatically re-implement/preserve draggability. I can

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 82287. mart added a comment. - Merge branch 'master' into mart/mewSystemMonitor REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82224=82287 BRANCH mart/mewSystemMonitor REVISION DETAIL

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

ngraham added a comment. Very cool stuff! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28623 To: gikari, #breeze, #plasma, cblack Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29157: force systemsettings for kcms

ngraham accepted this revision. ngraham added a comment. I say ship it! REPOSITORY R120 Plasma Workspace BRANCH phab/systemsettings REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma, ngraham Cc: broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D29157: force systemsettings for kcms

mart updated this revision to Diff 82283. mart added a comment. - infocenter modules in own category REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29157?vs=82282=82283 BRANCH phab/systemsettings REVISION DETAIL

D29157: force systemsettings for kcms

mart updated this revision to Diff 82282. mart added a comment. - use kinfocenter for kinfocenter modules REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29157?vs=81320=82282 BRANCH phab/systemsettings REVISION DETAIL

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. In D29535#666303 , @abetts wrote: > I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. I considered that, but

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82280. ngraham marked an inline comment as done. ngraham added a comment. Use less arbitrary min and max values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82277=82280 BRANCH

D29535: Change panel thickness adjustment UI to use a SpinBox

abetts added a comment. I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg,

D29535: Change panel thickness adjustment UI to use a SpinBox

cblack added inline comments. INLINE COMMENTS > ToolBar.qml:119-120 > + > +from: 2 > +to: 960 > +stepSize: 2 These values seem arbitrary. Could it be possible to base off the screen dimensions? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 82279. mart added a comment. - sensorColors is now a map - fix preset uninstall REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82223=82279 BRANCH mart/sensor_face REVISION DETAIL

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham created this revision. ngraham added reviewers: abetts, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We receive many complaints and bug reports about the current UI for adjusting panel

D29028: feat(wayland): add Wrapland plugin

romangg abandoned this revision. romangg added a comment. Will become an external plugin with libkscreen Wayland headers being exported now. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29028 To: romangg, #plasma, davidedmundson, apol Cc: anthonyfieroni,

D29029: feat(wayland): add plugin for wlroots based compositors

romangg abandoned this revision. romangg added a comment. Will become an external plugin with libkscreen Wayland headers being exported now. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29029 To: romangg, #plasma Cc: plasma-devel, Orage, LeGast00n,

D29533: [Reminder] Also advert Chromie store for Vivaldi

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. "Chromie"? :D For some reason I can't get the reminder to trigger. `dbus-monitor` shows method call time=1588952594.025913 sender=:1.16 ->

D29533: [Reminder] Also advert Chromie store for Vivaldi

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They advertise supporting Chrome extensions TEST PLAN Untested To test: - Run

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82266. gikari added a comment. Support the maximize button in the checked state REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82206=82266 BRANCH decorations-appearance (branched from

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. A separate library KScreenWayland is installed additionally to the runtime plugin, so that library can be linked against to create nested plugins for a Wayland session. These plugins must be installed in a certain directory

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 82265. romangg added a comment. - refactor: export Wayland plugins headers REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80700=82265 BRANCH wayland-plugins-export REVISION DETAIL

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82264. ngraham added a comment. Remove more FIXMEs (the first one was already broken with the current implementation), and for the second one, there's no better way to implement this, though I may remove the logic entirely REPOSITORY R120 Plasma

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra added a comment. Please see if D29529 resolves it. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D29302 To: ahiemstra, #plasma, davidedmundson Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently IMPORTED_GLOBAL is a 3.11 feature and Neon uses 3.10 TEST PLAN Use CMake

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82262. ngraham added a comment. Fix a FIXME REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82111=82262 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D29264: New tabs for Breeze

ngraham added a comment. The tab widget's active tab background color is something that can be played with in code--and already is, in fact. With the default Breeze color scheme, observe how it has a subtly lightened background color compared to the rest of the view background. Since

D29302: Use KSysGuard namespace for KSysGuard library targets

kmaterka added a comment. In D29302#666138 , @ahiemstra wrote: > Which version of CMake are you using? I needed to promote the imported KSysGuard targets to "global" using set_target_property. Without that, I saw similar errors. The

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra added a comment. Which version of CMake are you using? I needed to promote the imported KSysGuard targets to "global" using set_target_property. Without that, I saw similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11. REPOSITORY R111 KSysguard Library REVISION

D29393: Use player "poster" as album cover if available

This revision was automatically updated to reflect the committed changes. Closed by commit R856:811ae0dd5a54: Use player poster as album cover if available (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE