D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2020-06-13 Thread Carl Schwan
ognarb added a comment. I rebased this merge request on top of master and moved it to gitlab. https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/37 I see a major problem to move forward with this patch, not all the files have a license header and as such can't be merged. @gpar

D19444: Make long menus optionally scrollable instead of always expanding horizontally

2020-06-13 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Doesn't seem like there's interest in this. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, Orage,

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment. I'd like to land this early in the 5.20 cycle so we have lots of time for testing, if possible. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, Th

D29154: Use QWindow overload of QIcon::pixmap

2020-06-13 Thread David Redondo
davidre added a comment. In my testing dragging a window to a screen with a different scalefactor has no issue and @apol said for him it's better than the status quo. So I would like to land this REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29154 To: davidre, apo

D29140: Show POTD in lock screen

2020-06-13 Thread Yunhe Guo
guoyunhe added a comment. Also in KDE Invent. https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/3 Can someone review it? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham, plas

sprint notes for 12/06/2020

2020-06-13 Thread Marco Martin
Convertible and Mobile: Topics Touch gestures usage in shell Implementation should mostly inside KWin ideally Currently possibly we have gestures like edge gestures in wayland Currently we use plasmashell side gestures Action point: research into having kwin effects API for

D9875: Extend parsing ssh prompt

2020-06-13 Thread Fabian Vogt
fvogt added a comment. In D9875#675107 , @mkoller wrote: > They did not overwrite each other since the entry for the Username holds an URL _without_ user but the password entry did. That's pretty fragile, but would need to be kept for comp

D9875: Extend parsing ssh prompt

2020-06-13 Thread Martin Koller
mkoller added a comment. They did not overwrite each other since the entry for the Username holds an URL _without_ user but the password entry did. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: fvogt, pali, lbeltrame Cc: mkoller, lbeltrame

D9875: Extend parsing ssh prompt

2020-06-13 Thread Fabian Vogt
fvogt added a comment. In D9875#675101 , @mkoller wrote: > This patch breaks usage for git (and probably others): > git first asks for a "Username for 'https:" which leads to ksshaskpass open the input dialog but the typed-in user > is n

D9875: Extend parsing ssh prompt

2020-06-13 Thread Martin Koller
mkoller reopened this revision. mkoller added a comment. This revision is now accepted and ready to land. This patch breaks usage for git (and probably others): git first asks for a "Username for 'https:" which leads to ksshaskpass open the input dialog but the typed-in user is no long