Re: Clang Format Update

2021-01-01 Thread Roman Gilg
On Sat, Jan 2, 2021 at 2:07 AM David Edmundson wrote: > > It does. I've tried to collect some stats and provide some context on > the change. > > Taking just plasma-workspace, we have a lot of lines over 100 > characters at the moment. > 3817 lines to be exact. ~3.3% [1] > We also have 146 lines

Re: Clang Format Update

2021-01-01 Thread David Edmundson
It does. I've tried to collect some stats and provide some context on the change. Taking just plasma-workspace, we have a lot of lines over 100 characters at the moment. 3817 lines to be exact. ~3.3% [1] We also have 146 lines over 160 chars. One is 383 chars long! When the limit was 100 we had

Re: email for subscribing to the plasma devel

2021-01-01 Thread David Edmundson
Looks like you managed. If you haven't managed to subscribe, you can find everything you need at: https://mail.kde.org/mailman/listinfo/plasma-devel David

email for subscribing to the plasma devel

2021-01-01 Thread dhruv arora

Re: Clang Format Update

2021-01-01 Thread Roman Gilg
On Fri, Jan 1, 2021 at 6:04 PM Kai Uwe Broulik wrote: > > Setting it the column width too narrow makes it have the habit of > pointlessly breaking statements apart a lot. Is this a counter-argument to something I said? If you feel that way (I wouldn't) it does not resolve the contradiction with

Re: Clang Format Update

2021-01-01 Thread Kai Uwe Broulik
Setting it the column width too narrow makes it have the habit of pointlessly breaking statements apart a lot. Am 01.01.21 um 17:59 schrieb Roman Gilg: > 160 chars column limit contradicts Frameworks recommendation of 100 chars.

Re: Clang Format Update

2021-01-01 Thread Roman Gilg
On Fri, Jan 1, 2021 at 3:01 PM David Edmundson wrote: > > There has been lots of work on this lately, especially by Alexander Lonhau. > > Both in the clang-format file and with some custom changes, and some > changes throughout the code. > > If anyone has specific objections please be sure to

Re: Clang Format Update

2021-01-01 Thread David Edmundson
There has been lots of work on this lately, especially by Alexander Lonhau. Both in the clang-format file and with some custom changes, and some changes throughout the code. If anyone has specific objections please be sure to note any specific concerns ASAP before plasma is updated. David