D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. In D26582#592469 , @meven wrote: > We may want to change KRun::runUrl when a native binary is to be run but with runExecutable is false, around line 400: > > } else if (isNativeBinary) { > // Show warn

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. In D26582#591959 , @meven wrote: > Well there was already KRun::setRunExecutables :) I've already talked about it in my previous message: In D26582#591952 , @al

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. I thought about using KRun::setShowScriptExecutionPrompt() for D10835 , but "Recent Documents" include only those files which were opened, and doesn't include ones which were executed, so an execution prompt there would be to

D13923: [User Switcher] Swap Cancel and Switch buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eaa093443a7c: [User Switcher] Swap Cancel and Switch buttons (authored by aleksejshilin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13923?vs=37251&id=37253#toc REPOSITORY R120 Plasma Wo

D13923: [User Switcher] Swap Cancel and Switch buttons

aleksejshilin created this revision. aleksejshilin added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Cancel is typically the rightmost button. REPO

D12701: Remove D10890 workaround

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ada8fca90381: Remove D10890 workaround (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12701?vs=33655&id=34150 REVISION DETAIL

D12701: Remove D10890 workaround

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY D10890

D11195: Use separate config group for each wallpaper plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb5645d8c6e7: Use separate config group for each wallpaper plugin (authored by aleksejshilin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11195?vs=2911

D11194: Load correct wallpaper plugin configuration in the dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0304a2ef312: Load correct wallpaper plugin configuration in the dialog (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11194?vs=

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222490 , @davidedmundson wrote: > typically we'd do cfg = cfg.group("") which IMHO is easier to read Yeah, I like it more, too, but I saw the same styling almost everywhere in shell/ and therefor

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222450 , @davidedmundson wrote: > Fix setting cfg twice It's not setting twice, it's creating a nested config group. Or did you mean to use a separate variable each time instead of reusing `cf

D11195: Use separate config group for each wallpaper plugin

aleksejshilin added a comment. In D11195#222313 , @davidedmundson wrote: > One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause? It's not limited to colors, that's just a testcase. And un

D11194: Load correct wallpaper plugin configuration in the dialog

aleksejshilin added a comment. In D11194#222319 , @davidedmundson wrote: > I think there's a bug report about this somewhere if you want to find it. I've found quite a few similar ones (like 366390, 367546, 374691, 375532 etc.) - but the

D11195: Use separate config group for each wallpaper plugin

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Wallpaper plugins were storing their config

D11194: Load correct wallpaper plugin configuration in the dialog

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Wallpaper plugin was previously set for con

D10890: Don't skip certain recent documents in kicker and taskmanager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca96f850efbf: Don't skip certain recent documents in kicker and taskmanager (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin updated this revision to Diff 28681. aleksejshilin marked an inline comment as done. aleksejshilin added a comment. - Use QString::mid() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28639&id=28681 BRANCH prepare_for_krecen

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin updated this revision to Diff 28639. aleksejshilin added a comment. - Make sure to forget all documents, too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28626&id=28639 BRANCH prepare_for_krecentdocument_fix REVISION DETA

D10890: Don't skip certain recent documents in kicker and taskmanager

aleksejshilin retitled this revision from "Prepare for KIO KRecentDocument fix (D10863)" to "Don't skip certain recent documents in kicker and taskmanager". aleksejshilin edited the summary of this revision. aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop R

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin updated this revision to Diff 28626. aleksejshilin added a comment. - Clean up and better comment the code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28398&id=28626 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin updated this revision to Diff 28398. aleksejshilin added a comment. Diff against Plasma/5.12 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28397&id=28398 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://pha

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin updated this revision to Diff 28397. aleksejshilin added a comment. Rebase onto Plasma/5.12 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28192&id=28397 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL https://phab

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin added a comment. In D10890#215479 , @anthonyfieroni wrote: > So why you called hack, why no just add conditional compilation against 5.44 Alright, I re-read the summary and admit that it's somewhat confusing. Sorry for that

D10835: [kicker] Never execute recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R119:88d866c07951: [kicker] Never execute recent documents (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10835?vs=28171&id=28342 RE

D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. If there are no more concerns, could anyone actually accept the revision, please? :) Thanks in advance! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: ngraham, hein, anthonyfieroni, broulik,

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Revision D10863

D10835: [kicker] Never execute recent documents

aleksejshilin marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: hein, anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10835: [kicker] Never execute recent documents

aleksejshilin updated this revision to Diff 28171. aleksejshilin added a comment. - Use proper coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10835?vs=28032&id=28171 BRANCH always_open_recent_documents REVISION DETAIL https://phabr

D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. In D10835#214865 , @hein wrote: > Do you have a contributor account to commit this or should we do it on your behalf? I have a contributor account, thanks. I'll update the revision to address code style

D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. In D10835#214197 , @broulik wrote: > So why not do the same here instead of offering "Open With"? Currently recent documents in application launchers (i.e. Kicker, Kickoff etc.) are opened in their default a

D10835: [kicker] Never execute recent documents

aleksejshilin added a comment. In D10835#213787 , @broulik wrote: > Can you check whether this affects Task manager also? Task Manager runs the corresponding application explicitly by its .desktop file, so it's not affected. REPOSITORY

D10835: [kicker] Never execute recent documents

aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY When one tried to open a recent document which h

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. @broulik @ngraham Many thanks! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8502 To: aleksejshilin, #plasma, broulik Cc: ngraham, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. In https://phabricator.kde.org/D8502#160618, @broulik wrote: > I bet there's a bug report on Bugzilla about this. Yeah, 352497 looks like it. There are also a few suspects: 351693 and 358588 (but they say 'Reproducible: Always'), 357621 (not sur

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin added a comment. I've created a script to demonstrate the issue (attached). It uses VLC to acquire inhibition after the screen is dimmed. Usage: ./test_restore_brightness.sh F5451108: test_restore_brightness.sh REPOSITORY R122 Power

D8502: Fix brightness not restoring when an inhibition is active

aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY An active inhibition with ChangeScreenSettings policy won't allow to restore dimmed screen brig

D8397: Align logout screen action buttons to the top

aleksejshilin added a comment. I don't have push access, so could you do that for me, please? :) I've attached the original diff made with 'git format-patch' for your convenience. F5445601: 0001-Align-logout-screen-action-buttons-to-the-top.patch RE

D8397: Align logout screen action buttons to the top

aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY With default vertical alignment to the center, the buttons became misaligned when their text la