Re: Slimming and tidying libplasma2

2013-02-06 Thread Aaron J. Seigo
On Wednesday, February 6, 2013 18:28:26 Marco Martin wrote: On Wednesday 06 February 2013, Aaron J. Seigo wrote: On Wednesday, February 6, 2013 17:46:11 Marco Martin wrote: anybody else would be in? ;) even more usefully: when? i can't tomorrow ... Friday and Saturday both work

Re: Review Request 108223: use Plasma::Dialog for kmix osd

2013-02-05 Thread Aaron J. Seigo
change the theme before it hides, the OSD updates size, color, etc. is there some other trick one must do to trigger the problem? (i also just fixed a memory leak in the theme updating code in the OSD, btw :/) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself

2013-02-05 Thread Aaron J. Seigo
On Feb. 1, 2013, 6:38 p.m., Aaron J. Seigo wrote: plasma/declarativeimports/plasmacomponents/qmenu.cpp, line 299 http://git.reviewboard.kde.org/r/108700/diff/1/?file=111521#file111521line299 we try not to use slot* names (as they tend to drift over time from the signals connected

Re: new version for kcfg - strange behavior

2013-02-05 Thread Aaron J. Seigo
to true will cause the config key to be deleted .. since the default is true. (this allows changing the default in the kcfg file later ..) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

Re: new version for kcfg - strange behavior

2013-02-05 Thread Aaron J. Seigo
On Tuesday, February 5, 2013 18:21:42 Michail Vourlakos wrote: So the kcfg behavior is that when a field is in its default value is not stored at all, correct? correct -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: plasma search and launch javasscripting

2013-02-01 Thread Aaron J. Seigo
noticed that in configChanged, the strip widget was not getting updated, so i fixed that in master as well. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https

PW2 planning: one shell to rule them all

2013-02-01 Thread Aaron J. Seigo
in the past. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PW2 planning: one shell to rule them all

2013-02-01 Thread Aaron J. Seigo
in the shell layout package [1] http://community.kde.org/Plasma/DesktopScripting -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself

2013-02-01 Thread Aaron J. Seigo
() or sth - Aaron J. Seigo On Feb. 1, 2013, 3:04 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108700

Re: Review Request 108706: bodega-server: Move authorization checks to the routes.js

2013-02-01 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108706/#review26526 --- Ship it! Ship It! - Aaron J. Seigo On Feb. 1, 2013, 8:45

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-30 Thread Aaron J. Seigo
testing needed. may require a full scan of all uses of Plasma/Generic packages :/ Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repository changes for plasma2/frameworks5

2013-01-30 Thread Aaron J. Seigo
other part (which is not the case for many/most other parts of kdelibs which does indeed benefit as a result from delaying the split) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

pruning branches in kde-workspace

2013-01-30 Thread Aaron J. Seigo
J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: pruning branches in kde-workspace

2013-01-30 Thread Aaron J. Seigo
On Wednesday, January 30, 2013 12:45:46 Marco Martin wrote: On Wednesday 30 January 2013, Aaron J. Seigo wrote: plasma/mart/declarativeWidgetsExplorer plasma/mart/notifications-qml plasma/mart/wac-appletscript ouch, forgot about those all3 can be killed i think done. thanks

Re: pruning branches in kde-workspace

2013-01-30 Thread Aaron J. Seigo
in these branches? (i know you moved on to homerun, question is how far sal got in terms of qmlification before that) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: KDEREVIEW: share like connect and plasmate

2013-01-30 Thread Aaron J. Seigo
On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and Share-Like-Connect headed? Base thanks :) -- Aaron J. Seigo

Re: pruning branches in kde-workspace

2013-01-30 Thread Aaron J. Seigo
homerune. the code in sal-qml should be pretty useful, iirc it had a lot of sal's functionality implemented except for favoriting which needed some work. so if someone had a hardon for it they could certainly spend a few weeks and make it usable. ok, good to know. -- Aaron J. Seigo

Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed. may require a full scan of all uses of Plasma/Generic packages :/ Thanks, Aaron J. Seigo

Re: plasma javascripting

2013-01-29 Thread Aaron J. Seigo
, too ... sanitize in 4.10.x and get-me-the- desktop-file in 4.11 -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
--- packagestructuretest passes; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed. may require a full scan of all uses of Plasma/Generic packages :/ Thanks, Aaron J. Seigo

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. ksmserver/screenlocker/lockwindow.cpp http://git.reviewboard.kde.org/r/108585/#comment20020 spaces, not tabs. - Aaron J. Seigo On Jan. 25

Re: Review Request 108640: Check for Valid Wallet Pointer

2013-01-28 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/108640/#comment20021 can just as easily be: if (wallet the isNull is not particularly necessary. - Aaron J. Seigo On Jan. 28, 2013, 12:40 p.m., David Narváez wrote: --- This is an automatically generated e

Re: Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108641/#review26305 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 28, 2013, 12:43

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote

Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
automagically switches it on and the laptop screen off locker displays properly Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
is on plug in external screen kscreen automagically switches it on and the laptop screen off locker displays properly Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
--- On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
--- On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
into this with the oxygen-transparent style or the resp. settings of QtCurve or Bespin? Aaron J. Seigo wrote: yes, that's also true: it probably doesn't need to be translucent. or rather, shouldn't be because we actively do *not* want content visible through it. this could be a hold-over

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Aaron J. Seigo
to restart the shell process (as we currently do with, e.g., netbook vs desktop) it's look rather nice, and it's great to see another component clicking into place so nicely. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
--- start locker when internal laptop screen is on plug in external screen kscreen automagically switches it on and the laptop screen off locker displays properly Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel

Re: Access data engine from C++ QML Plugin?

2013-01-25 Thread Aaron J. Seigo
classes in libplasma have for DataEngines. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

some updates on screen locking related things

2013-01-23 Thread Aaron J. Seigo
. i'm still debating whether or not this is actually a problem or not. it's still a work in progress, so input is welcome. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel

Re: some updates on screen locking related things

2013-01-23 Thread Aaron J. Seigo
On Wednesday, January 23, 2013 11:00:18 Marco Martin wrote: On Wednesday 23 January 2013, Aaron J. Seigo wrote: * if the root item of the lock screen doesn't have some property to say that supports locking (or even its metadata.desktop) load another qml file instead that is purely used

Re: Review Request 108534: some string in javascript is not extracted

2013-01-23 Thread Aaron J. Seigo
allowed to be added as translate for exactly the reason you noted: they don't break anything, but give translations teams a chance to actually, well, translate these strings :) - Aaron J. Seigo On Jan. 21, 2013, 10:35 p.m., Xuetian Weng wrote

Re: Review Request 108559: some screen locker visual fix

2013-01-23 Thread Aaron J. Seigo
, but nothing that prevents giving this a ShipIt! ksmserver/screenlocker/greeter/greeterapp.cpp http://git.reviewboard.kde.org/r/108559/#comment19851 fullName can be marked const - Aaron J. Seigo On Jan. 22, 2013, 8:20 p.m., Xuetian Weng wrote

Re: some thoughts on screensavers in Plasma Workspaces 2

2013-01-22 Thread Aaron J. Seigo
On Sunday, January 13, 2013 20:25:14 Martin Graesslin wrote: On Sunday 13 January 2013 19:48:48 Aaron J. Seigo wrote: I hope that the startup time of a shell get's better with PW2 - especially being able to delay loading of elements through a QML LoaderItem and better threading should improve

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-21 Thread Aaron J. Seigo
it is accomplished. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kwin thumbnail effect in Workspaces 2

2013-01-21 Thread Aaron J. Seigo
be avoided), that implies making information available from kwin about thumbnail sizes for specific windows. (and all this to ensure that we have fluidly updating thumbnails ...) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Plans and status Frameworks5, Plasma2, Qt5 and Wayland

2013-01-21 Thread Aaron J. Seigo
we're missing a non-libplasma2 TODO list. it's all related. if we do start a new page, it should probably just be a set of links to topical pages: one for libplasma2, one for the runtime components, etc. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aaron J. Seigo
windows or to determine when the panel should break in (only on attention required, e.g.?) if there is a sufficient use case to get at panels from full screen windows, we could perhaps enumerate those and ask ourselves if there are other ways to accomplish that. -- Aaron J. Seigo signature.asc

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aaron J. Seigo
given application to have more than a few such triggers (even plasma-desktop with multiple screens is unlikely to have more than a handful), the one-dbus-object-per-trigger should not result in overhead issues. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aaron J. Seigo
On Monday, January 21, 2013 12:35:07 Marco Martin wrote: plasma/desktop/shell/panelview.cpp ;) key words: GlowBar and m_glowBar -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

Re: kwin thumbnail effect in Workspaces 2

2013-01-21 Thread Aaron J. Seigo
is complex at all and so keeping them in sync should be easy .. and should QML imports improve sufficiently we can always move the item later without causing problems like BIC :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-21 Thread Aaron J. Seigo
) CompositingTracker: signal changed(bool isAvailable) property bool isAvailable -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 108465: a couple of fixes in participant/changeAccountDetails

2013-01-21 Thread Aaron J. Seigo
, this looks fine. put that next() back in and then push it. server/lib/db/changeAccountDetails.js http://git.reviewboard.kde.org/r/108465/#comment19795 should remain just so that if something does get added to it later, we don't have to track down where it isn't getting next() from - Aaron J

Re: Review Request 108480: Always confirm Leave... from desktop context menu

2013-01-21 Thread Aaron J. Seigo
On Jan. 20, 2013, 2:34 a.m., Maarten De Meyer wrote: This change is wrong imho. If 'Confirm logout' is disabled it should not ask for confirmation. Otherwise what's the point of that option? Showing the dialog depending on the button clicked breaks UI expectations a lot more than the

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aaron J. Seigo
/statusnotifieritem/index.html -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-21 Thread Aaron J. Seigo
/python/dataengines) also, I wonder when you guys are planning to release plasma 2? sometime after Qt 5.1, when Frameworks 5 is ready for release. no earlier. we don't have a deadline set yet, however. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Plans and status Frameworks5, Plasma2, Qt5 and Wayland

2013-01-21 Thread Aaron J. Seigo
of a simplification than anything else) also, the hackfest spoken of earlier: how is that coming? and that will be used for PW2 stuff, yes? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-16 Thread Aaron J. Seigo
touch the UI itself. as such, i don't see any reason to support writing Applets in a python+QML hybrid form. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Plasmoid object class for QML...

2013-01-16 Thread Aaron J. Seigo
of the window thumbnails) could be provided for by a DataEngine+Service pair that is created on-demand in the shell itself using Plasma::PluginLoader. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma

kwin thumbnail effect in Workspaces 2

2013-01-16 Thread Aaron J. Seigo
a gameplan now so we can work towards it in 2013 :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kwin thumbnail effect in Workspaces 2

2013-01-16 Thread Aaron J. Seigo
On Wednesday, January 16, 2013 13:11:35 Martin Gräßlin wrote: On Wednesday 16 January 2013 12:13:39 Aaron J. Seigo wrote: there have been more reasons to do it that way. One is that only KWin has information to the most recently used windows. you mean that it is the only process that currently

Re: Plasmoid object class for QML...

2013-01-16 Thread Aaron J. Seigo
remain stable. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Python in KF5; was Re: Having an issue with the minimum size of Plasma.WebView

2013-01-16 Thread Aaron J. Seigo
where this is not possible? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kwin thumbnail effect in Workspaces 2

2013-01-16 Thread Aaron J. Seigo
On Wednesday, January 16, 2013 15:22:10 Martin Gräßlin wrote: On Wednesday 16 January 2013 14:12:16 Aaron J. Seigo wrote: On Wednesday, January 16, 2013 13:11:35 Martin Gräßlin wrote: On Wednesday 16 January 2013 12:13:39 Aaron J. Seigo wrote: * providing the thumbnail slows

Re: KActivities::Info::linkedResources

2013-01-15 Thread Aaron J. Seigo
in docs. it also means we don't have to worry about thinking if/how it breaks SLC in certain version combinations. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Plasmoid object class for QML...

2013-01-15 Thread Aaron J. Seigo
of things, from security to presentation flexibility). if we are missing some API that is needed, then we can look at filling that gap. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

Re: [KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-15 Thread Aaron J. Seigo
On Tuesday, January 15, 2013 07:29:49 Martin Gräßlin wrote: Is actually anyone looking at these lists? If no: could we get rid off it? i have in the past, but i don't think anyone is now. once a week would be bearable, but daily is really too much imho. -- Aaron J. Seigo signature.asc

Re: repositories beyond kde-workspace

2013-01-15 Thread Aaron J. Seigo
On Monday, January 14, 2013 20:54:56 Marco Martin wrote: On Monday 14 January 2013, Aaron J. Seigo wrote: the question we have is: how do we want to bring these various repositories together into a coherent, usable result? most of them are projects of quite different, so it's

Re: repositories beyond kde-workspace

2013-01-15 Thread Aaron J. Seigo
here are my current thoughts on these questions: On Monday, January 14, 2013 17:51:50 Aaron J. Seigo wrote: * where should the repositories live? i'd like to see a single Workspaces category on projects.kde.org. the current kde-workspace repo would be moved to it, and we'd add in all the other

Re: repositories beyond kde-workspace

2013-01-15 Thread Aaron J. Seigo
. it might be easier to confirm this once we list all our components, ensure there's a maintainer for each of them, and then have each maintainer represent their module in such a decision. i think we can, and ought to, make this decision democratically as it impacts us all. -- Aaron J. Seigo

Re: Thoughts about a better Quality Management process for Plasma

2013-01-15 Thread Aaron J. Seigo
On Monday, January 14, 2013 17:11:31 Martin Gräßlin wrote: On Monday 14 January 2013 16:24:28 Aaron J. Seigo wrote: Whoever is maintainer of a component, should become the default assignee for bugs in that component. No longer a one address for all assignee. i think the maintainer

Re: Thoughts about a better Quality Management process for Plasma

2013-01-15 Thread Aaron J. Seigo
On Monday, January 14, 2013 17:22:14 Martin Gräßlin wrote: On Monday 14 January 2013 16:24:28 Aaron J. Seigo wrote: a merge commit can document exactly what it is merging, feature or bug fix, and that can also be used to generate a changelog. that's a good point. Sounds like a reasonable

Re: Thoughts about a better Quality Management process for Plasma

2013-01-15 Thread Aaron J. Seigo
On Monday, January 14, 2013 23:03:03 David Edmundson wrote: On Mon, Jan 14, 2013 at 3:24 PM, Aaron J. Seigo ase...@kde.org wrote: we need some people who use master, but aren't responsible for writing (much) code, doing this work. otherwise those writing the code will simply get nothing

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-15 Thread Aaron J. Seigo
it now that we have QML? Like above, I don't think (even if a decision would be made) that they could be removed until the transition to KF5. ageed. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma

Re: KActivities::Info::linkedResources

2013-01-15 Thread Aaron J. Seigo
. in Active, we're busy clearing up numerous regressions there and rebasing on 4.10. pushing this change right now means doing more testing and altering our version requirements. if we can delay doing that until we have everything in good order for PA4, that would be most welcome. -- Aaron J. Seigo

Re: Review Request 107650: Don't call exec() on KIO::MimetypeJob

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107650/ --- (Updated Jan. 15, 2013, 2:32 p.m.) Review request for Plasma, Aaron J

Re: Review Request 107650: Don't call exec() on KIO::MimetypeJob

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107650/#review25581 --- Ship it! - Aaron J. Seigo On Jan. 15, 2013, 2:32 p.m

Re: Review Request 108241: use Plasma::Dialog for icontasks tooltips

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review25582 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 8, 2013, 9:50

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-15 Thread Aaron J. Seigo
reasonable testing in on it. - Aaron J. Seigo On Jan. 10, 2013, 6:50 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-15 Thread Aaron J. Seigo
/impossible to make the viewitem svg work for this use case and the general use case of QML views .. so +1 from me. - Aaron J. Seigo On Jan. 14, 2013, 8:08 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply

Re: KActivities::Info::linkedResources

2013-01-15 Thread Aaron J. Seigo
that the users can test against which version they are being compiled? usually we ship a version.h. if you look at kdelibs/plasma/version.[h|cpp] you'll see a pretty standard version of this. (speaking of which, that version # is outdated. gah, forgot to change it for 4.10) -- Aaron J. Seigo

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Aaron J. Seigo
in future. so if this is going to be a goal, then we probably need to invest some time into making it dreadfully simple to write tests that require the event loop and waiting for responses. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Aaron J. Seigo
which, const QSizeF constraint) const { if (which == Qt::PreferredSize) { return d-webView-page()-mainFrame()-contentsSize(); } else { return QGraphicsWidget::sizeHint(which, constraint); } } the real fix, however, is not to do the UI in python. use QML. -- Aaron J

4.10 reflection summary

2013-01-14 Thread Aaron J. Seigo
maintainers (e.g. noticing when one is gone) * ensuring needed communication happens between component teams (shadows being a great example of where that didn't happen) * ensuring the big picture goals are seeing progress Commentary: What more needs be said, really? :) -- Aaron J

Re: reflecting on 4.10

2013-01-14 Thread Aaron J. Seigo
ok, so finally my answers ... i deliberately waited until the discussion was done give my own answers as it's really hard to facilitate a discussion and participate at the same time. (well, i did poke my thoughts into the thread a few times .. :) On Thursday, January 10, 2013 22:05:28 Aaron J

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Aaron J. Seigo
On Monday, January 14, 2013 16:33:48 Luca Beltrame wrote: In data lunedì 14 gennaio 2013 16:30:15, Aaron J. Seigo ha scritto: the real fix, however, is not to do the UI in python. use QML. Speaking of that, how does Plasma (or the workspace in general) fit when using QML, according

repositories beyond kde-workspace

2013-01-14 Thread Aaron J. Seigo
leading to do so ..) (I'll post my personal answers in a reply to this email as well ...) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: XDpms in screenlocker

2013-01-13 Thread Aaron J. Seigo
all the code handling this exact feature in *one* place and if/when platform changes under us we only need to make changes in one place as well. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel

some thoughts on screensavers in Plasma Workspaces 2

2013-01-13 Thread Aaron J. Seigo
. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: reflecting on 4.10

2013-01-13 Thread Aaron J. Seigo
On Saturday, January 12, 2013 20:01:46 Alex Fiestas wrote: On Saturday 12 January 2013 18:45:07 Aaron J. Seigo wrote: we have 3 repositories which probably should target 4.11: * kscreen (playground/base/) * libkscreen (playground/libs/) * kio_mtp (playground/base/) they have a few

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-13 Thread Aaron J. Seigo
/108375/#comment19429 {}s - Aaron J. Seigo On Jan. 13, 2013, 11:22 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108375

Re: Review Request 108377: fix rest von 313020

2013-01-13 Thread Aaron J. Seigo
report, and yes, it works nicely and is a big improvement over white as you noted. pls commit :) - Aaron J. Seigo On Jan. 13, 2013, 11:25 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: various fix for battery plasmoid

2013-01-13 Thread Aaron J. Seigo
. we can make packagers aware of the commit hash id so they can include it if they wish. i don't think we need to do the actual backporting to the 4.9 branch, however. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
are extremely hard to do without sprints. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
if's plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml http://git.reviewboard.kde.org/r/108355/#comment19274 missing {}s - Aaron J. Seigo On Jan. 11, 2013, 11:37 p.m., Xuetian Weng wrote

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/108355/ --- (Updated Jan. 11, 2013, 11:37 p.m.) Review request for Plasma, Aaron J. Seigo, Viranch Mehta, and Viranch Mehta. Description --- 1. fix access undefined value warning, when calling

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
find 3-4 ideas that we can decide on together online and then put into place as best we can so that when we gather in Bilbao in the summer we will already have some experience in the matter and can use that opportunity to improve (or drop :) what we're doing. -- Aaron J. Seigo signature.asc

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Aaron J. Seigo
value is the current value. Aaron J. Seigo wrote: the cached value will be correct all the time, except when a new value hasn't yet made the trip from powerdevil over dbus yet. which means it will only not make the call when it is the same in the DataEngine even though it may be different

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
On Saturday, January 12, 2013 17:01:40 Alex Fiestas wrote: This is my opinion now (no longer what I remember from the sprint). On Saturday 12 January 2013 15:54:39 Aaron J. Seigo wrote: On Saturday, January 12, 2013 14:08:44 Alex Fiestas wrote: -Master -Integration this is what we

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
, but fewer KDE devs run master than probably ever before. it seems a recent phenomenon, just as with you. i'm personally very excited that more people will be running master again. and i hope with an integration branch, that will extend even further. -- Aaron J. Seigo signature.asc Description

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Aaron J. Seigo
/108316/#comment19294 can be const? - Aaron J. Seigo On Jan. 12, 2013, 3:46 p.m., Emil Sedgh wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
if there could be a bit of automation ivolved? probably, but git already makes it so fast that i think little more is really needed. i'm more interested in tools for nominating branches as merge candidates. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
that might even look like a plan ;) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: reflecting on 4.10

2013-01-12 Thread Aaron J. Seigo
sometimes makes its way straight into master. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: krunner qml

2013-01-11 Thread Aaron J. Seigo
and the task manager is applications and commands being run. that's not so strong a relationship that the button would need to remain there, but i also don't know of a better place to put it. suggestions welcome. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

<    1   2   3   4   5   6   7   8   9   10   >