D28487: Redesign of system monitor plasmoids

alexde added a comment. Not sure, if this is part of the scope of this work, but do you also plan to add some meaningful labels and ticks to the axis? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: alexde, ngraham, ksmanis,

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

alexde added a comment. In D27198#607110 , @ngraham wrote: > I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas: When looking at the screenshots, 1.4

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

alexde added a comment. Looks way better, thanks Nate! Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how would it looke like with 1.40 instead of 1.50? Would it be too small? Would you like attach another screenshot please? :-) REPOSITORY R169 Kirigami

D15418: Dim application icon when it is not playing anything

alexde added a comment. In D15418#604200 , @broulik wrote: > > Can't we dim label instead? > > I quite like that. Also not very obvious what it means, I guess.. Not sure if it was already discussed, but what about adding an overlay

D26392: Add option to easily configure and start a hotspot

alexde added a comment. > UI-wise, this would probably be better off as a button than a checkbox. Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an action? Right now, I don't see the big difference. (I assume "hotspot" and "shared wifi" are equivalent.)

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. In D21273#586877 , @luc4 wrote: > Probably the consequence of not reviewing changes? This one can probably be abandoned. What a shame! As you are familiar with the code, you could probably review the other patch

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. This patch looks pretty similar to the already merged one https://phabricator.kde.org/D25018. How are they related? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: alexde, meven, alexeymin,

D20569: RFC: Use more compact OSD

alexde added a comment. Since the most common problem that people have is "the OSD gets in the way when I change the volume while playing a video", how about only changing those OSD styles for the "volume" and "brightness" and leave the rest as it is with their characteristic appearance and

D14949: Add option for whether to show the volume change OSD

alexde added a comment. Personally I am in favour of the current Windows 10 style, a compact version in the top left corner. I tried to to create a mockup to demonstrate how it could look like: F7825127: Mockup.png To make hopefully everyone

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added a comment. In D25018#561268 , @jjorge wrote: > > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > > Yes : this is a percentage. States out of this value are bad

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added inline comments. INLINE COMMENTS > acpi.c:129 > +} else if (state < 0) { > +state = 0; /* prevent insane numbers with bad hardware */ > } Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > acpi.c:161

D24379: [energy kcm] Fix Technology values

alexde added a comment. As this it not in the scope of this patch, those values look suspicious to me too: switch(model.battery.type) { case 3: return i18n("Internal battery") case 2: return i18n("UPS battery") case 9: return i18n("Monitor battery") case 4: return

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66344. alexde added a comment. The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ... REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66343=66344

D24036: Fix the last fix of the max y-range computation

alexde added a comment. This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend. Regards REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg,

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66343. alexde added a comment. Add range check for index variable REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66340=66343 BRANCH ymax_again (branched from master) REVISION DETAIL

D24036: Fix the last fix of the max y-range computation

alexde added a comment. In D24036#533557 , @ngraham wrote: > I still get: > > file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined >

D24036: Fix the last fix of the max y-range computation

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The last fixed was not correct. This version should serve better. REPOSITORY R102

D24029: Fix maximum y-value-range computation

alexde created this revision. alexde added reviewers: VDG, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY Rounding to the next 10 did not work if the maximum value was something like y_max =

D23520: Add time line to X axis

alexde updated this revision to Diff 66063. alexde added a comment. Remove redundant and now wrong comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66062=66063 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 66062. alexde added a comment. Fix offset calculation for the one hour graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66055=66062 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde added a comment. In D23520#531168 , @ngraham wrote: > Thanks, that's fixed now. However the "Last hour" graph still looks a little odd... > > F7350933: Screenshot_20190914_084935.png Mm,

D23520: Add time line to X axis

alexde updated this revision to Diff 66055. alexde added a comment. Fix typo in variable and by that make all X axis labels appear again. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66044=66055 BRANCH energy-timeline (branched from

D23520: Add time line to X axis

alexde updated this revision to Diff 66044. alexde added a comment. The former scaling of the x-Positions of the data points did not fit to the time axis. Now the x-values of the points, i. e. their timestamps, are correctly aligned. For some unknown reasons, all data points, which

D23520: Add time line to X axis

alexde updated this revision to Diff 66034. alexde added a comment. Remove redundant semicolons and move comment about unit (ms) to the declaration of the var REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66031=66034 BRANCH

D23520: Add time line to X axis

alexde updated this revision to Diff 66031. alexde added a comment. Use a switch statement for xTicksAt REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65457=66031 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde added a comment. *Friendly ping to the reviewers.* REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23746: Set a minimum window size to reasonable 800x600 px.

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH minimum-window-size (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 65457. alexde added a comment. Set correct right border for the grid lines and ticks. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65428=65457 BRANCH energy-timeline (branched from master) REVISION

D23520: Add time line to X axis

alexde updated this revision to Diff 65428. alexde added a comment. Move stroke() out of the loop. Reduce line with by pixel. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65423=65428 BRANCH energy-timeline (branched from master)

D23520: Add time line to X axis

alexde updated this revision to Diff 65423. alexde added a comment. Shrink plotWidth a little bit so the earliest date on the right side may fit. Change the way the division widths are defined to hopefully make the code easier to understand and to maintain. REPOSITORY R102 KInfoCenter

D23520: Add time line to X axis

alexde added a comment. For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs. F7320671: Screenshot_20190905_132313.png REPOSITORY R102 KInfoCenter REVISION DETAIL

D23520: Add time line to X axis

alexde requested review of this revision. alexde added a comment. I have changed some stuff, can you please review it again. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n,

D23520: Add time line to X axis

alexde updated this revision to Diff 65413. alexde added a comment. Rename variables to make their function clearer. Decrease the lower loop border by 1 to make sure that all possible grid lines are drawn. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D23520: Add time line to X axis

alexde updated this revision to Diff 65410. alexde added a comment. Fix issue that a date may be displayed unintentionally. Shrink right margin for grid lines and try to add an additional grid line on the right side if reasonable. Add more divisions for 2h and 24h graphs. REPOSITORY

D23520: Add time line to X axis

alexde updated this revision to Diff 65409. alexde added a comment. Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint. Rename variable to make its function clearer. Show grid lines at all five minutes for the 1 hour graph. REPOSITORY R102

D23520: Add time line to X axis

alexde updated this revision to Diff 65407. alexde added a comment. Align grid to 10 minutes for the 1h graph. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65321=65407 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 65320. alexde added a comment. - Set valid defaults. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64920=65320 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 65321. alexde added a comment. Set valid defaults. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65320=65321 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde added a comment. Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph. However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer

D23520: Add time line to X axis

alexde updated this revision to Diff 64920. alexde added a comment. Fix displaying wrong variable. Add postfix "Str" to indicate that those vars are explicitely strings. Make sure that the date is only displayed when date has changed for <= 24h graphs. REPOSITORY R102 KInfoCenter

D23520: Add time line to X axis

alexde updated this revision to Diff 64896. alexde added a comment. Improve the formatting's consistancy REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64892=64896 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 64892. alexde added a comment. Update comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64890=64892 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 64890. alexde added a comment. Omit the date if date equals today and the graph does not range over 24 hours. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64889=64890 BRANCH energy-timeline (branched

D23520: Add time line to X axis

alexde updated this revision to Diff 64889. alexde added a comment. Resolve formatting issues - remove semicolons - replace tab indention by 4 spaces - add space between operator and arguments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D23520: Add time line to X axis

alexde added a comment. > As you can see, it's kind of funny that only one of the labels has a date under it. This is fine for the multi-day graphs, but for the graphs that are entirely within the current day, I would recommend omitting the date. There's actually not such thing as a

D23520: Add time line to X axis

alexde updated this revision to Diff 64840. alexde added a comment. Set more sane left/right margins REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64805=64840 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde updated this revision to Diff 64805. alexde added a comment. Set correct default value for a tick position REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64803=64805 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current energy plot does not display any time line. This patch adds a grid and time stamps to the

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > for various technical reasons that are not yet fixable Can you please point me to those? Is there ongoing work? I'm curious. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > DnD is not very intuitive for things that don't look inherently draggable That's why I draw a frame around the entries and also the mouse pointer could change to a hand. Otherwise I neither really like 1) or 2). How do other systems handle this? REPOSITORY

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others". The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.F7276701: Screenshot_20190824_201127.png

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In D23237#514325 , @broulik wrote: > It literally says in the commit message that this will be moved exactly there. I definitely need more coffee, sorry. O:-) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In which GUI do I find "Vendor" and "Model" now? There's the "Energy Information" in KInfocenter, which has a section "manufacturer" (in screenshot "Herstller"), but only lists the serial number. Maby it could go there? F7259918: Screenshot_20190819_105414.png

D22493: [Notifications] Move history items' icons over to the left a bit

alexde added a comment. Friendly ping. :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma Cc: alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22493: [Notifications] Move history items' icons over to the left a bit

alexde added a comment. In D22493#496764 , @ngraham wrote: > Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like. Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked

D22605: Set notifications entry icon size to medium

alexde added a comment. > For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though. I have to admit, that I'm not very much satisfied myself with the size. It could be a bit larger, something between medium and large. Maby we should

D22605: Set notifications entry icon size to medium

alexde added a comment. > You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part. What I also needed to install is kdesignerplugin then So the procedure is as follows:

D22605: Set notifications entry icon size to medium

alexde added a comment. I would like to test it and post a screenshot, however I am not able to compile it: 1. I cloned the source from the git repository 2. mkdir plasma-workspace/applets/notifications/build 3. cd plasma-workspace/applets/notifications/build 4. cmake .. This

D22605: Set plasma-nm history entry icon size to medium

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current history entry icon is rather large and therefore hits the bottom of the entry in the

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. In D18809#408482 , @davidre wrote: > Do you mean the Controls on the top? (...) Please correct me if I'm wrong. Exactly, but let's wait for the expertise of Nate and the rest of the VDG team as I am not sure

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. Great work! Currently you have a very long folder list object. However, in my experience most users only have a few folders, where they store their wallpapers. So, what about saving space by positioning the folder list to the right of the controls? As we now

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. In D17354#372274 , @ngraham wrote: > Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indeted by a tab: General [ ] Show week number Available plugins [ ] Plugin A [ ] Plugin B That's would I

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

alexde added a comment. I would like to introduce another suggestion, which has not yet came up: If you don't want to blur everything, how about to only blur an rectangle underneath the login controls. That means a combination of early Plasma 5 > The early Plasma 5 login screen put a