Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-12-01 Thread Alexander Richardson
solved. - Alexander Richardson On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

2014-10-27 Thread Alexander Richardson
tocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/p

Re: Review Request 118073: Use QHostInfo in kio_nfs

2014-09-23 Thread Alexander Richardson
/r/118073/diff/ Testing --- Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

2014-09-23 Thread Alexander Richardson
https://git.reviewboard.kde.org/r/119081/diff/ Testing (updated) --- Archive protocol works fine in dolphin (KF5) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

2014-09-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/#review67273 --- Ping? - Alexander Richardson On Sept. 23, 2014, 10:36 vorm

Re: Review Request 119913: Force creation of a OpenGL core context

2014-08-28 Thread Alexander Richardson
4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa Diff: https://git.reviewboard.kde.org/r/119913/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-08-23 Thread Alexander Richardson
> On Aug. 11, 2014, 8:35 vorm., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > th

Review Request 119913: Force creation of a OpenGL core context

2014-08-23 Thread Alexander Richardson
/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

2014-07-01 Thread Alexander Richardson
d8251 thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9 trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e Diff: https://git.reviewboard.kde.org/r/119081/diff/ Testing --- Thanks, Alexander Richa

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

2014-05-30 Thread Alexander Richardson
an be disabled? - Alexander Richardson On May 30, 2014, 12:29 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Review Request 118073: Use QHostInfo in kio_nfs

2014-05-10 Thread Alexander Richardson
--- Use QHostInfo in kio_nfs Diffs - nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5 nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742 Diff: https://git.reviewboard.kde.org/r/118073/diff/ Testing --- Thanks, Alexander Richardson

Re: Review Request 118015: Dont convert URLs with protocol h**p: to http:

2014-05-09 Thread Alexander Richardson
ilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118015/diff/ Testing --- entering haap://foo.bar in the dolphin address bar no longer attempts to open the browser Thanks, Alexand

Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread Alexander Richardson
ot;) was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
lly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57458 --- On May 6, 2014, 2:42 p.m., Alexander Richardson wrote: > > --- > This is an a

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
> On May 6, 2014, 2:51 p.m., David Faure wrote: > > kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 > > <https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374> > > > > Better use QUrl u = QUrl::fromLocalFile(path) then

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
> On May 6, 2014, 2:51 p.m., David Faure wrote: > > kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 > > <https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374> > > > > Better use QUrl u = QUrl::fromLocalFile(path) then

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
Doesn't pass before - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- On May 6, 2014,

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
ereas KUrl("~") was not Diffs - kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks,

Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
0c58684bcf8b6 Diff: https://git.reviewboard.kde.org/r/118017/diff/ Testing --- Added unit test in KIO, works now Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118015: Dont convert URLs with protocol h**p: to http:

2014-05-06 Thread Alexander Richardson
Diff: https://git.reviewboard.kde.org/r/118015/diff/ Testing --- entering haap://foo.bar in the dolphin address bar no longer attempts to open the browser Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mai

Re: Review Request 117779: fix crash when textureNode->texture() is null

2014-04-30 Thread Alexander Richardson
sma no longer crashes every few minutes Diffs - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richard

Re: Review Request 117779: fix crash when textureNode->texture() is null

2014-04-25 Thread Alexander Richardson
ffs (updated) - src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mail

Re: Review Request 117779: fix crash when textureNode->texture() is null

2014-04-25 Thread Alexander Richardson
iewboard.kde.org/r/117779/#review56577 --- On April 25, 2014, 11:41 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 117779: fix crash when textureNode->texture() is null

2014-04-25 Thread Alexander Richardson
ore/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708 Diff: https://git.reviewboard.kde.org/r/117779/diff/ Testing --- No longer crashes Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.

Re: Review Request 117058: plasma-nm CMake fixes

2014-03-27 Thread Alexander Richardson
27;t build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117058: plasma-nm CMake fixes

2014-03-27 Thread Alexander Richardson
. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr

2014-01-14 Thread Alexander Richardson
16ed29638b6b253d1fefc220341b91f20c2d76d5 src/plasma/svg.cpp ae97783308574c9478b6f194b8460a457a2a187e Diff: https://git.reviewboard.kde.org/r/114932/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr

2014-01-13 Thread Alexander Richardson
cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/#review47315 --- On Jan. 9, 2014, 8:14 p.m., Alexander Richardson wrote: > > --- > This is an

Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr

2014-01-09 Thread Alexander Richardson
: https://git.reviewboard.kde.org/r/114932/diff/ Testing --- compiles Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113193: fix some warnings

2013-10-13 Thread Alexander Richardson
d7438506c6d120429d24d6680821030398af6101 src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson

Re: Review Request 113193: fix some warnings

2013-10-12 Thread Alexander Richardson
0431a42c5b44f45bc5a > > Diff: http://git.reviewboard.kde.org/r/113193/diff/ > > > Testing > --- > > warnings are gone > > > Thanks, > > Alexander Richardson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson

Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 Diff: http://git.reviewboard.kde.org/r/113193/diff/ Testing --- warnings are gone Thanks, Alexander Richardson