D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

astippich added a comment. For the concept a big +1 from me. I did not even know that we had that in the infocenter... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns Cc: astippich, plasma-devel, hurikhan77,

D25345: use new icon for search category

This revision was automatically updated to reflect the committed changes. Closed by commit R124:a7a2d277e81f: use new icon for search category (authored by astippich). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25345?vs=69860=70202 REVISION

D25344: change icon for baloo kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f1a6bfa3b876: change icon for baloo kcm (authored by astippich). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25344?vs=69858=70201 REVISION DETAIL

D25345: use new icon for search category

astippich created this revision. astippich added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Use new icon added in kf 5.65 REPOSITORY R124 System Settings BRANCH master

D25344: change icon for baloo kcm

astippich created this revision. astippich added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY use a standard icon name similar to other kcms REPOSITORY R119 Plasma Desktop BRANCH

D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

astippich added a comment. +1, also fixes the warnings in Elisa REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21514 To: dfaure, mart, apol, broulik Cc: astippich, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D21944: Show shortcut in menu item when specified

This revision was automatically updated to reflect the committed changes. Closed by commit R858:721c348d1a1e: Show shortcut in menu item when specified (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D22011: Add MenuSeparator

This revision was automatically updated to reflect the committed changes. Closed by commit R858:6eb266c3d4fc: Add MenuSeparator (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22011?vs=60433=60528 REVISION

D22011: Add MenuSeparator

astippich updated this revision to Diff 60433. astippich added a comment. - remove unneeded height REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22011?vs=60391=60433 BRANCH menu_separator REVISION DETAIL

D22011: Add MenuSeparator

astippich added a comment. Related to D21944 Menu now looks like F6924938: menu_separator.png before: F6924945: menu_before.png REPOSITORY R858 Qt Quick Controls 2:

D22011: Add MenuSeparator

astippich created this revision. astippich added reviewers: mart, apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Make the MenuSeparator span the full width of the menu like in QWidget-based

D21944: Show shortcut in menu item when specified

astippich added a comment. Unfortunately, even with this reverted change I know get a wrong menu separator. I don't know what was different before... Since it was also there without this patch (see screenshot), it is probably a different issue which needs investigation REPOSITORY

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60332. astippich added a comment. - use item for margin again REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60300=60332 BRANCH menu_item REVISION DETAIL

D21944: Show shortcut in menu item when specified

astippich added a comment. The menu separator now does not look correct: F6923245: menu_after2.png I don't know why REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, mart,

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60300. astippich added a comment. - simplify REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60162=60300 BRANCH menu_item REVISION DETAIL https://phabricator.kde.org/D21944

D21944: Show shortcut in menu item when specified

astippich added a comment. This is required to port the menu of Elisa to qqc2 (D21943 ) qqc1 version F6918483: menu_qqc1.png qqc2 version without this patch F6918485: menu_before.png

D21944: Show shortcut in menu item when specified

astippich created this revision. astippich added reviewers: mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Show the shortcut as text for menu items when they are given via an action

D16658: Respect the display property of buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:974efd584666: Respect the display property of buttons (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16658: Respect the display property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16658: Respect the display property of buttons

astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16658: Respect the display property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16658: Respect the display property of buttons

astippich updated this revision to Diff 48917. astippich added a comment. - remove compatibility for Qt 5.9 and cleanup REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=46372=48917 BRANCH display_property REVISION

D16284: do not force text display for ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d37015a5d1b0: do not force text display for ToolButton (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16284?vs=45425=48915#toc REPOSITORY R858 Qt Quick Controls 2:

D16284: do not force text display for ToolButton

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: hein, mgallien, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16658: Respect the display property of buttons

astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

astippich updated this revision to Diff 46372. astippich added a comment. - use hasOwnProperty and add fixme comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=45424=46372 BRANCH display_property REVISION DETAIL

D16284: do not force text display for ToolButton

astippich updated this revision to Diff 45425. astippich added a comment. - follow style REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16284?vs=43823=45425 BRANCH toolbutton REVISION DETAIL

D16658: Respect the display property of buttons

astippich added a comment. Can I convince you to land this for Kf 5.53 with the promise to clean up once frameworks depends on Qt 5.10? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc:

D16658: Respect the display property of buttons

astippich updated this revision to Diff 45424. astippich added a comment. - rebase - more verbose comment about compatibility REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=44827=45424 REVISION DETAIL

D16659: Size according to specified icon width and height

This revision was automatically updated to reflect the committed changes. Closed by commit R858:66d8bdb32735: Size according to specified icon width and height (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16651: Honor flat property of buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16651: Honor flat property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16651 To: astippich, ngraham, mart, apol, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16658: Respect the display property of buttons

astippich added a comment. In D16658#354233 , @apol wrote: > I guess we can wait until we can bump to Qt 5.10 as a dependency? This looks a bit chaotic. > Also the Under/Beside setting isn't taken into account yet. Yep,

D16659: Size according to specified icon width and height

astippich updated this revision to Diff 44936. astippich added a comment. - only query pixelMetric on demand REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16659?vs=44828=44936 BRANCH icon_size REVISION DETAIL

D16651: Honor flat property of buttons

astippich marked an inline comment as done. astippich added a comment. How can I actually run this test? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16651 To: astippich, ngraham, mart, apol, #plasma Cc: plasma-devel, ragreen, Pitel,

D16651: Honor flat property of buttons

astippich updated this revision to Diff 44934. astippich added a comment. - do not unnecessarily check flat property REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16651?vs=44800=44934 BRANCH flat REVISION DETAIL

D16659: Size according to specified icon width and height

astippich created this revision. astippich added reviewers: Plasma, mart, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY The icon.width and icon.height property were not used before for the icon

D16658: Respect the display property of buttons

astippich created this revision. astippich added reviewers: Plasma, apol, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Before, the display property of buttons introduced in Qt 5.10 was not taken

D16651: honor flat property for buttons

astippich created this revision. astippich added reviewers: ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY The flat property of buttons is currently not taken into account for the desktop

D16284: do not force text display for ToolButton

astippich added a subscriber: mgallien. astippich added a comment. @mgallien stated in the meantime that we probably have been abusing the ToolButton in Elisa for our needs, and we will go a different route anyway. Since the desktop style still behaves differently than QQC1 and the Fusion

D16284: do not force text display for ToolButton

astippich added a comment. opinions? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text for ToolButton

astippich added a comment. I noticed this while porting from qqc1 to qqc2 for #Elisa , as the qqc2 ToolButton did not behave as expected. I don't know the reason why this was added and also have no clue about the implications this change may have.

D16284: do not force text for ToolButton

astippich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Do not force to display text besides the icon for the ToolButton REPOSITORY R858 Qt Quick Controls 2: Desktop Style