Re: Yahoo! Weather ion dataengine review

2010-01-16 Thread Amos Kariuki
Aaron J. Seigo wrote: On January 11, 2010, Amos Kariuki wrote: Marco Martin wrote: On Monday 11 January 2010, Aaron J. Seigo wrote: On January 10, 2010, Amos Kariuki wrote: Is there a need to use both kdereview (svn) and reviewboard or should I just submit a patch for review

plasma.include() and member visibility

2010-01-14 Thread Amos Kariuki
(name); When I run the plasmoid, I get a message stating that x is undefined. I’m I referencing the variables incorrectly or is there some other way to achieve what I want? Thanks, Amos Kariuki ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: plasma.include() and member visibility

2010-01-14 Thread Amos Kariuki
On Thu, Jan 14, 2010 at 10:21 AM, Amos Kariuki amoskah...@gmail.com wrote: When I run the plasmoid, I get a message stating that x is undefined. Correction: When I run the plasmoid, I get a message stating that 'name' is undefined. Amos Kariuki

Re: plasma.include() and member visibility

2010-01-14 Thread Amos Kariuki
to reference the variables and functions declared in it. Amos Kariuki ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma.include() and member visibility

2010-01-14 Thread Amos Kariuki
On Thu, Jan 14, 2010 at 4:31 PM, Sebastian Kügler se...@kde.org wrote: On Thursday 14 January 2010 17:21:15 Amos Kariuki wrote: var name = “Amos”; plasmoid.include(“lib.js”); Does it work if you use or ' instead of “and ”? Doesn't work. Just a guess ... -- sebas Looking

Re: Yahoo! Weather ion dataengine review

2010-01-12 Thread Amos Kariuki
Aaron J. Seigo wrote: On January 11, 2010, Amos Kariuki wrote: Marco Martin wrote: On Monday 11 January 2010, Aaron J. Seigo wrote: On January 10, 2010, Amos Kariuki wrote: if you're into that plan, then i can write an example DataEngine in JavaScript for you tomorrow and put

Re: Yahoo! Weather ion dataengine review

2010-01-11 Thread Amos Kariuki
Matt Williams wrote: 2010/1/10 Amos Kariuki amoskah...@gmail.com: Is there a need to use both kdereview (svn) and reviewboard or should I just submit a patch for review in reviewboard and ignonre kdereview? Any clarification is appreciated. http://techbase.kde.org/Policies/SVN_Guidelines

Re: Yahoo! Weather ion dataengine review

2010-01-11 Thread Amos Kariuki
Marco Martin wrote: On Monday 11 January 2010, Aaron J. Seigo wrote: On January 10, 2010, Amos Kariuki wrote: Is there a need to use both kdereview (svn) and reviewboard or should I just submit a patch for review in reviewboard and ignonre kdereview? no, if it is in playground, move

Yahoo! Weather ion dataengine review

2010-01-10 Thread Amos Kariuki
) and reviewboard or should I just submit a patch for review in reviewboard and ignonre kdereview? Any clarification is appreciated. Thanks, Amos Kariuki ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Time dataengine invalid sunrise and sunset results

2009-11-26 Thread Amos Kariuki
Petri Damstén wrote: On Thursday 26 November 2009 06:56:09 Amos Kariuki wrote: I have some test code to obtain the sunrise and sunset time given a longitude and latitude for a location: There are problems in KDE 4.3 calculation. In KDE 4.4 Thanks. (I tested and verified it works

Time dataengine invalid sunrise and sunset results

2009-11-25 Thread Amos Kariuki
:01) and have a significant offset (20 min). Is this a bug or am I misunderstanding the results? Amos Kariuki ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- (Updated 2009-09-14 23:24:56.419041) Review request for Plasma and Shawn Starr.

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
23:24:56, Amos Kariuki wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- (Updated 2009-09-14 23:24:56) Review

Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-13 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- Review request for Plasma and Shawn Starr. Summary --- The patch uses the

Re: Review Request: Condition icons for the NOAA weather ion

2009-08-27 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1418/ --- (Updated 2009-08-28 01:11:00.621982) Review request for Plasma and Shawn Starr.

Review Request: Condition icons for the NOAA weather ion

2009-08-26 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1418/ --- Review request for Plasma and Shawn Starr. Summary --- Possible patch to

Re: Plamsa::PopupApplet and modal dialogs

2009-05-25 Thread Amos Kariuki
On Sun, May 24, 2009 at 1:21 AM, Aaron J. Seigo ase...@kde.org wrote: On Friday 22 May 2009, Chani wrote: On May 20, 2009 16:48:01 Amos Kariuki wrote: Have a question regarding the Plasma::PopupApplet behavior after it displays a modal dialog.  In the current implementation, when a modal

Re: Plamsa::PopupApplet and modal dialogs

2009-05-21 Thread Amos Kariuki
dialog? Maybe it's just me, but it seems strange (from a UI perspective) to have a modal dialog displayed without a visible parent. Thanks for the suggestions Marco, Amos Kariuki ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Plamsa::PopupApplet and modal dialogs

2009-05-20 Thread Amos Kariuki
the Popup applet to verify the folder got added. I'm currently working around this by manually calling PopupApplet::show() after opening the KDirSelectDialog but it feels kind of hackish so I thought I'd get some opinions. Thanks, Amos Kariuki ___ Plasma