D9746: openconnect: support MFA

2018-01-09 Thread Andrea Scarpino
scarpino updated this revision to Diff 24997. scarpino added a comment. Store tokenSecret as secret. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9746?vs=24971=24997 REVISION DETAIL https://phabricator.kde.org/D9746 AFFECTED FILES vpn/openconnect/nm-openconnect-service.h

D9746: openconnect: support MFA

2018-01-08 Thread Andrea Scarpino
scarpino created this revision. scarpino added a reviewer: jgrulich. Restricted Application added a project: Plasma. scarpino requested review of this revision. REVISION SUMMARY support MFA authentication in openconnect TEST PLAN build and tested REPOSITORY R116 Plasma Network Management

D6520: Summary: L2TP: pre-sharedkey should be mask

2017-07-10 Thread Andrea Scarpino
This revision was automatically updated to reflect the committed changes. Closed by commit R116:c86bb0d58380: Summary: L2TP: pre-sharedkey should be mask (authored by scarpino). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D6520: Summary: L2TP: pre-sharedkey should be mask

2017-07-05 Thread Andrea Scarpino
scarpino created this revision. Restricted Application added a project: Plasma. TEST PLAN built and tested REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D6520 AFFECTED FILES vpn/l2tp/l2tpadvanced.ui To: scarpino, jgrulich

Re: Review Request 126250: knetattach: Changing host port does not enable connect button

2015-12-05 Thread Andrea Scarpino
marked as submitted. Review request for Plasma. Changes --- Submitted with commit e8f8f1e375e0bcd33ee5b8434d89b0c7c2454988 by Andrea Scarpino to branch master. Repository: plasma-desktop Description --- After a connection failed, changing host port does not enable the connect

Re: Review Request 126250: knetattach: Changing host port does not enable connect button

2015-12-05 Thread Andrea Scarpino
/r/126250/#review89150 --- On Dec. 5, 2015, 4:55 p.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Review Request 126250: knetattach: Changing host port does not enable connect button

2015-12-05 Thread Andrea Scarpino
, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-23 Thread Andrea Scarpino
On Fri, Jan 23, 2015 at 6:18 AM, Bhushan Shah bhus...@gmail.com wrote: So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. Also IMHO it makes sense to move plasmaengineexplorer to plasma-frameowork repo due to the fact that is important tool to debug

Re: Review Request 121473: Port mouse dataengine

2014-12-14 Thread Andrea Scarpino
On Dec. 13, 2014, 5:33 p.m., Andrea Scarpino wrote: I know this has already been submitted thanks to Bhushan, but I really have to add a -2 here. This code has clearly not been ported at all! Did you even test this before you pushed it, or is this a case of It builds, ship

Re: Review Request 114260: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc Diff: https://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea Scarpino

Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/mouse/mouseengine.h d55565dc3875b794dce14054d9a8b77cef9b2347 Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/CMakeLists.txt cae926b550cdd69aa0194e19bc4818c597e174c0 Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
f1c898150e04b44dad1c8a0fc757c1ffdf94941b Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/CMakeLists.txt cae926b550cdd69aa0194e19bc4818c597e174c0 Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
cf1c3fbe91a9afee5090d167dd6cd51637df04d4 Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121473: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
/cursornotificationhandler.cpp cf1c3fbe91a9afee5090d167dd6cd51637df04d4 Diff: https://git.reviewboard.kde.org/r/121473/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 339792] Don't install libmolletnetwork.so symlink

2014-11-26 Thread Andrea Scarpino
https://bugs.kde.org/show_bug.cgi?id=339792 Andrea Scarpino scarp...@kde.org changed: What|Removed |Added Latest Commit||9e44dfa16facbad57b1b13737ba

Re: Review Request 114260: Port mouse dataengine

2014-02-20 Thread Andrea Scarpino
3b571f8f5ffe6db4efeef7827acf003911bcd5dc Diff: https://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Andrea Scarpino
/dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc Diff: https://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea Scarpino

Re: Review Request 114260: Port mouse dataengine

2014-02-01 Thread Andrea Scarpino
://git.reviewboard.kde.org/r/114260/#review45349 --- On Dec. 3, 2013, 10:51 a.m., Andrea Scarpino wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-05 Thread Andrea Scarpino
Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-05 Thread Andrea Scarpino
/ Testing (updated) --- If I try to fetch several favicons an empty image is returned, except the first one which contains a valid favicon. Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-05 Thread Andrea Scarpino
3e94325 plasma/generic/dataengines/favicons/CMakeLists.txt 4af0f14 Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing --- If I try to fetch several favicons an empty image is returned, except the first one which contains a valid favicon. Thanks, Andrea Scarpino

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-03 Thread Andrea Scarpino
Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114291: Fix kde-workspace build

2013-12-03 Thread Andrea Scarpino
--- the pager applet still uses KGlobalSettings::taskbarFont() from KDE4Support. Diffs - plasma/desktop/applets/pager/CMakeLists.txt 733660f Diff: http://git.reviewboard.kde.org/r/114291/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Review Request 114260: Port mouse dataengine

2013-12-02 Thread Andrea Scarpino
/cursornotificationhandler.cpp 3cb9add plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8 plasma/generic/dataengines/mouse/CMakeLists.txt 29cab87 plasma/generic/dataengines/CMakeLists.txt 3e94325 Diff: http://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea

Review Request 111074: Adapt the CMakeLists to the cmake modules changes

2013-06-17 Thread Andrea Scarpino
/diff/ Testing --- Thanks, Andrea Scarpino ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel