Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-18 Thread Andrei Amuraritei
notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66978 --- On Sept. 19, 2014, 10:17 p.m., Andrei Amuraritei wrote: > > --- > This is an automatically gene

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66979 ------- On Sept. 19, 2014, 10:17 p.m., Andrei Amuraritei wrote: > > --- > This is an autom

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
you don't > > define any plugin macro (K_PLUGIN_FACTORY), this can't work as a plugin > > without it > > > > Looks like you should keep this line (but port to K_PLUGIN_FACTORY) > > Andrei Amuraritei wrote: > Please de

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-12 Thread Andrei Amuraritei
code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

2014-10-12 Thread Andrei Amuraritei
rfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" Copying metadata went ok. Successfully upgraded /home/developer/Downloads/92037-garfield.comic Thanks, Andrei Amuraritei ___ Plasma-deve

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-12 Thread Andrei Amuraritei
notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
p it. I am working on porting the applet also and until we have a working version I'd like to keep it here. - Andrei ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review68304 -

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-12-13 Thread Andrei Amuraritei
ll. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- On Oct. 17, 2014, 3:08 a.m., Andrei Am

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Update: Engine is working...still need to port away from Solid and KService to remove KDELibs4Support, that is still wip. Thanks, Andrei Amuraritei

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
> On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has

Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

2015-08-31 Thread Andrei Amuraritei
/r/120563/#review84629 --- On Oct. 12, 2014, 7:05 p.m., Andrei Amuraritei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

2016-09-15 Thread Andrei Amuraritei
e: "garfield" -- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop" Copying metadata went ok. Successfully upgraded /home/developer/Downloads/92037-garfield.comic Thanks, Andrei Amuraritei