D13849: WIP: Add fractional scaling to wayland scaling GUI

2019-04-21 Thread Andrius Štikonas
stikonas added a comment. In D13849#384351 , @davidedmundson wrote: > It runtime requires Qt 5.12 for xdg-output which the shell needs for fullscreen, which means we can merge for Plasma 5.16 Is this going to be merged for 5.16? We only

Re: CI system maintainability

2019-03-29 Thread Andrius Štikonas
+1 for this. I think running tests before merging is more acceptable than having mandatory reviews. On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan wrote: >Hello, > >A Merge Request in GitLab does not necessarily imply the need for a >review by e person. It can just run a pipeline to

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-23 Thread Andrius Štikonas
stikonas added a comment. In D12311#252165 , @bruns wrote: > Resizing: http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize Does not work well yet,

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-21 Thread Andrius Štikonas
stikonas added a comment. In D12311#250688 , @bruns wrote: > Gnome-disks does, and so do other programs. Gnome-disks uses UDisks to do everything and can't do anything on its own. So available features are very limited (not even resizing

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-20 Thread Andrius Štikonas
stikonas added a comment. In D12311#250660 , @bruns wrote: > No, thats completely off, as thats the action you are authorizing. > > > Authorization is required to format disk WDC WD10EZEX-08M2NA0 > > I want it to show what it is asking

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas reclaimed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas abandoned this revision. stikonas added a comment. Le's close it in favour of https://phabricator.kde.org/D10518 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas updated this revision to Diff 27181. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10495?vs=27106=27181 REVISION DETAIL https://phabricator.kde.org/D10495 AFFECTED FILES src/kstatusnotifieritem.cpp To: stikonas, wbauer, #plasma,

D10495: Workaround to restore KF5 programs from system tray

2018-02-14 Thread Andrius Štikonas
stikonas added a comment. Well, basically when you click on any KF5 application (e.g. Konversation, KGpg, Akregator, etc...) in the system tray, nothing happens. This does no happen with Qt5-only programs. Clicking on system tray there always brings the window up. From what I can see

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Andrius Štikonas
stikonas added a comment. This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland. REPOSITORY R289 KNotifications REVISION DETAIL

D10495: Workaround to restore KF5 programs from system tray

2018-02-13 Thread Andrius Štikonas
stikonas created this revision. stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. stikonas requested review of this revision. REVISION SUMMARY Currently

D9180: port to Package::fileUrl

2017-12-26 Thread Andrius Štikonas
stikonas added a comment. In https://phabricator.kde.org/D9180#183083, @davidedmundson wrote: > > Ok, so apparently we can't do this because 5.42 will be released after Plasma 5.12 beta. So should we revert both commits? > > Urgh. We have this same issue every single release. > >

D9180: port to Package::fileUrl

2017-12-26 Thread Andrius Štikonas
stikonas added a comment. Ok, so apparently we can't do this because 5.42 will be released after Plasma 5.12 beta. So should we revert both commits? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9180 To: mart, #plasma, davidedmundson Cc: stikonas,

D9180: port to Package::fileUrl

2017-12-26 Thread Andrius Štikonas
This revision was automatically updated to reflect the committed changes. Closed by commit R133:b84e7fd794cb: Bump KF5 required version to 5.42 (authored by stikonas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9180?vs=23454=24378#toc REPOSITORY R133 KScreenLocker CHANGES SINCE

D9180: port to Package::fileUrl

2017-12-26 Thread Andrius Štikonas
stikonas reopened this revision. stikonas added a comment. This revision is now accepted and ready to land. You need to bump KF5 version requirement if you use this! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9180 To: mart, #plasma, davidedmundson Cc:

D6304: Properly block the edge also for touch screen edges

2017-06-20 Thread Andrius Štikonas
stikonas accepted this revision. stikonas added a comment. This revision is now accepted and ready to land. I've also tested this patch on a few full screen games. That bug is gone. REPOSITORY R108 KWin BRANCH fix-edge-x11-update-blocking-5.10 REVISION DETAIL

D4799: Delay notifications until desktop session has loaded

2017-06-08 Thread Andrius Štikonas
stikonas added a comment. This introduces a regression https://bugs.kde.org/show_bug.cgi?id=380974 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: stikonas,

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-14 Thread Andrius Štikonas
stikonas added a comment. Tested on XWayland 1.19.2 and it works. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5452 To: graesslin, #kwin, #plasma Cc: stikonas, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-13 Thread Andrius Štikonas
stikonas added a comment. > ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote: > My comment was not meant as a stop-this-effort comment. If we can improve here to do more sane things I'm all for it. No, it's not your comment. We were discussing this on #kde-devel and it

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas abandoned this revision. stikonas added a comment. Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne,

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas added a comment. In fact API documentation says explicitely that > IMPORTANT: if the organization domain is set, the .desktop file that describes your application should have an entry like X-DBUS-ServiceName=reversed_domain.kmyapp For instance kwrite passes

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas added a comment. In https://phabricator.kde.org/D5405#101575, @mak wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-11 Thread Andrius Štikonas
stikonas created this revision. stikonas added a project: Plasma on Wayland. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY On Wayland icons are obtained from desktop files that are named

[Powerdevil] [Bug 340892] System Settings's Power management complains about power management service

2015-01-14 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=340892 Andrius Štikonas andr...@stikonas.eu changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED