Re: semicolons and the policy that was none

On Wednesday, 10 August 2022 15:57:53 CEST Harald Sitter wrote: > Aloha, > > Someone recently dug up this page from 2012 > > https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks > > First I'd like to point out that this page isn't a policy page, if it > was meant to be then it needs to be li

Re: testing UIs and improving a11y all at once!

On Wednesday, 10 August 2022 12:29:14 CEST Harald Sitter wrote: > Servus, > > A while ago I prototyped a "new" approach to UI testing and I'm > wondering if there's general interest in doing more Plasma testing > using it. I'm able to invest time in polishing the experience for us. > > Very rough

libksysguard respin request

Hi, A FreeBSD build failure slipped into ksystemstats that was best resolved with some API addition in libksysguard. Please respin the libksysguard tar so ksystemstats can build properly on FreeBSD. Relevant commit: https://invent.kde.org/plasma/libksysguard/-/commit/ dbf3020563f31755486935ea34

Re: 5.22 Soft Freeze

On Thursday, 29 April 2021 14:52:11 CEST Jonathan Riddell wrote: > List of git repos I have to turn into tars for Plasma 5.22: > > bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi > kactivitymanagerd kde-cli-tools kde-gtk-config kdecoration kdeplasma-addons > kgamma5 khotke

Splitting KSystemStats out of ksysguard

Hi, During the beta phase of Plasma 5.21 there was some discussion with regards to what to do with ksysguard now that we are shipping a replacement. Back then, a plan was made to ship the ksysguard repo for 5.21 and to split out ksystemstats for 5.22. I spent some time over the last two weeks

Re: qqc2-breeze-style

On Monday, 12 April 2021 23:26:18 CEST Carl Schwan wrote: > Le lundi, avril 12, 2021 10:20 PM, Nate Graham a écrit : > > [explicitly CCing Noah] > > > > And I still have the same worries as before. Building a universal theming > system will takes **years** to make in a way that won't feel like a

Re: Plasma 5.22 Kickoff Notes

On Wednesday, 10 March 2021 14:24:02 CET Marco Martin wrote: > On Wed, Mar 10, 2021 at 1:57 PM Carl Schwan wrote: > > qqc2-desktop-style has the advantage of using in a few places the QStyle > > so some controls are looking native but in an usual Kirigami application > > many other components are

Re: Plasma 5.22 Kickoff Notes

On Wednesday, 10 March 2021 13:57:31 CET Carl Schwan wrote: > Le mercredi, mars 10, 2021 10:56 AM, Marco Martin a écrit : > > I knew from a long time it was to be the default style on plamo.. I > > never really agreed to default to it on plasma mobile but since looked > > like it was the majority

Re: Plasma 5.21 repo and soft feature freeze

On Tuesday, 5 January 2021 17:35:49 CET Jonathan Riddell wrote: > I propose to exclude ksysguard from 5.21 and do a standalone release > alongside it Since we still need ksysguard for the daemon and we're a bit too close to beta for major changes, I want to propose releasing both for 5.21, then f

Re: Plasma 5.21 repo and soft feature freeze

On Wednesday, 6 January 2021 13:23:47 CET Jonathan Riddell wrote: > So should plasma-systemmonitor packages depend on ksysguard packages for > ksystemstats ? Hmm, I suppose it should yes, since it can't run without ksystemstats. > > Jonathan > > On Wed, 6 Jan 2021 a

Re: Plasma 5.21 repo and soft feature freeze

On Tuesday, 5 January 2021 17:35:49 CET Jonathan Riddell wrote: > I propose to exclude ksysguard from 5.21 and do a standalone release > alongside it We still need the ksysguard repo as it contains the ksystemstats daemon and all its plugins. We could disable building ksysguard GUI but that may g

Re: plasma-systemmonitor in kdereview

On Thursday, 1 October 2020 14:11:16 CET Harald Sitter wrote: > > Cool stuff. > > L10n is currently a bit incomplete. > Notably > - the pages files lack any localization at all and I'm also not sure how > those could be best localized. As an update to this, this should be fixed for 5.21. The pag

Re: plasma-systemmonitor in kdereview

On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote: > > Plasma System Monitor looks quite good, but it doesn't look like it is > navigable with the keyboard only. I know that some of the issues are caused > by Kirigami and Qml but it looks like many custom components can't get any > focus w

Re: plasma-systemmonitor in kdereview

On Monday, 19 October 2020 00:28:38 CEST Albert Astals Cid wrote: > How serious are these cmake warnings? http://paste.debian.net/1167754/ I've seen those before; apparently the result is that there's no autogenerated appdata for the sensor faces. Not sure how important that is to be honest. At

Re: plasma-systemmonitor in kdereview

On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote: > Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit : > > Hello, > > > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde

Re: plasma-systemmonitor in kdereview

On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: > On 01.10.20 11:36, Arjen Hiemstra wrote: > > Hello, > > > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma

plasma-systemmonitor in kdereview

Hello, I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can be found at https://invent.kde.org/plasma/plasma-systemmonitor . plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes use of the ksystemstats daemon and the faces system for system moni

Re: KSysguard - CGroup functionality breakage

On Wednesday, 19 August 2020 12:29:21 CEST Ben Cooksley wrote: > Hi all, > > Recently functionality was introduced to KSysguard to allow it to > interact with Linux CGroups. > > Unfortunately when this change was made the code in question used > classes/functionality that was introduced in Qt 5.1

Re: merge request and issue notifications to this list?

On Wednesday, 29 July 2020 14:16:59 CEST Bhushan Shah wrote: > Hello everyone! > > KDE sysadmin team introduced the activity filter, which allows us to > have the MR, commits and issues related notifications to plasma-devel or > list of our choice. > > This is proposal to enable it for plasma/* r

A new UI for KSysGuard

Hi, It's been mentioned a few times already over the past, but we have been working on a new UI for KSysGuard over the past year. With landing most of the base work for Plasma 5.19 the new UI has been split to its own repo and can be found at https://invent.kde.org/ahiemstra/ksysguardqml . The

Re: Gitlab and plasma dev

On Wednesday, 27 May 2020 20:11:25 CEST David Edmundson wrote: > One thing I'm missing when I'm doing reviews is I don't have a nice way to > separate merge requests that need review, and merge requests that are > awaiting changes. > > I think this could be achieved with a label, that reviewers ca

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Hmm, this is good idea, I'm not really happy about the implementation though. It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic num

D29630: Use the new KSysGuard namespace for KSysGuard related targets

ahiemstra closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29630 To: ahiemstra, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moh

D29760: Replace MapProxySource with some javascript code

This revision was automatically updated to reflect the committed changes. Closed by commit R111:1d8f9a9024c0: Replace MapProxySource with some javascript code (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29760?vs=82870&id=8

D29760: Replace MapProxySource with some javascript code

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY MapProxySource has only been added to QuickCharts master so is not available in 5.70, so w

D29688: Exclude all loop devices from partition and disk sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:f4e2c2022cd7: Exclude all loop devices from partition and disk sensors (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29688?vs=82738&id=8

D29721: Add context to translated strings and clarify some strings

This revision was automatically updated to reflect the committed changes. Closed by commit R106:857eff12328e: Add context to translated strings and clarify some strings (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29721?vs=82766&id

D29721: Add context to translated strings and clarify some strings

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Many of the shorter strings are not really informative, so add context so translators can

D29688: Ignore mount paths that start with '/snap/'

ahiemstra updated this revision to Diff 82738. ahiemstra added a comment. - Exclude all loop devices from partition and disk sensors REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29688?vs=82682&id=82738 BRANCH ignore_snap_partitions REVISION DETAIL

D29688: Ignore mount paths that start with '/snap/'

ahiemstra added a comment. In D29688#669867 , @anthonyfieroni wrote: > Should it /var/lib/flatpak (or just /flatpak/) be included as well? Flatpak doesn't use mounts for this as far as I can tell, or at least they don't show up in mtab.

D29688: Ignore mount paths that start with '/snap/'

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently, each snap is mounted as a squashfs file. This causes a lot of sensors to appea

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

ahiemstra requested changes to this revision. ahiemstra added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jpalecek wrote in SensorBrowser.cpp:53 > No, it only deletes the HostInfo structure. See the source >

D29630: Use the new KSysGuard namespace for KSysGuard related targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY The targets in the KF5 namespace have been deprecated. This updates the cmake files to use

D29628: Use the right targets for KSysGuard

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8ae9b561c82f: Use the right targets for KSysGuard (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29628?vs=82516&id=82522 REVISION

D29628: Use the right targets for KSysGuard

ahiemstra updated this revision to Diff 82516. ahiemstra added a comment. - Also change system monitor plasmoid REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29628?vs=82513&id=82516 BRANCH ksysguard_targets REVISION DETAIL https://phabricato

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. You need to change `find_package(KF5 REQUIRED COMPONENTS SysGuard)` to `find_package(KSysGuard CONFIG REQUIRED)` in the root CMakeLists file. REPOSITORY R119 Plasma Deskto

D29628: Use the right targets for KSysGuard

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Otherwise the build fails when things try to link to KF5::SysGuard etc. TEST PLAN Builds

D29623: Fix Warning about KF5::KSysGuard target being deprecated

ahiemstra added a comment. Uh, I'm not sure how this fixes anything? It'll remove the warning but it means anything using the previous KF5:: namespaced targets is now broken. So this at least needs a follow up to change those usages. REPOSITORY R120 Plasma Workspace REVISION DETAIL http

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

This revision was automatically updated to reflect the committed changes. Closed by commit R111:fc35d85131ed: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra added a comment. Please see if D29529 resolves it. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D29302 To: ahiemstra, #plasma, davidedmundson Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently IMPORTED_GLOBAL is a 3.11 feature and Neon uses 3.10 TEST PLAN Use CMake 3.10,

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra added a comment. Which version of CMake are you using? I needed to promote the imported KSysGuard targets to "global" using set_target_property. Without that, I saw similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11. REPOSITORY R111 KSysguard Library REVISION D

D29507: Use KSysGuard namespace for KSysGuard targets

This revision was automatically updated to reflect the committed changes. Closed by commit R106:dbb0b515364b: Use KSysGuard namespace for KSysGuard targets (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29507?vs=82204&id=82207 REVIS

D29507: Use KSysGuard namespace for KSysGuard targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY With D29302 all KSysGuard targets have been placed in

D29302: Use KSysGuard namespace for KSysGuard library targets

This revision was automatically updated to reflect the committed changes. Closed by commit R111:b1e9126e2087: Use KSysGuard namespace for KSysGuard library targets (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29302?vs=82193

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ahiemstra added a comment. > This is a major identity change better suited for Plasma 6. I disagree. I would like Plasma 6 to be a really uneventful release, not one that has a whole bunch of changes. There's going to be enough breakage as it is, let's do things that can be done now, now

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra updated this revision to Diff 82193. ahiemstra added a comment. - Add backward-compatibility package config file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29302?vs=81594&id=82193 BRANCH lib_namespace REVISION DETAIL https://ph

D28140: Add a declarative plugin to ProcessCore

This revision was automatically updated to reflect the committed changes. Closed by commit R111:82879c590d99: Add a declarative plugin to ProcessCore (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28140?vs=78360&id=82182 REV

D28141: Add KSysGuard::Sensors library

This revision was automatically updated to reflect the committed changes. Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82082&id=82181 REVISION DET

D28922: Port Sensor Face loading from plasmoid

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Let's get this in and fix anything broken in follow ups. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To: mart,

D28333: Add a new daemon for stats monitoring

ahiemstra accepted this revision. ahiemstra added a comment. Let's do this. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D28333 To: davidedmundson, #plasma, mart, ngraham, ahiemstra Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n,

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 82082. ahiemstra added a comment. Maybe right now? REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82081&id=82082 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTED

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 82081. ahiemstra added a comment. Urgh arc REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82080&id=82081 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTED FILES

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 82080. ahiemstra added a comment. - Correct Vlad's name in a few more places - Make comments in SensorInfo_p.h a bit more useful REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=81577&id=82080 BRAN

D29437: Use font: instead of font.pointSize: where possible

ahiemstra added a comment. Actually I'm fairly sure `font: someFont` is still going to work, it's `font.something: somethingElse` syntax that's going away, instead becoming something like `font: Font { something: somethingElse }`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorFaceController.h:47 > how would that work in current faces that have this binded to that single big > number inside graphs? You'd use the first one from the list? If we want to limit it I think we need to limit it in the UI

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorFaceController.cpp:247 > perhaps line chart? I was more thinking something along the lines of a new face that's either completely empty or displays a "not configured" message. REPOSITORY R111 KSysguard Library REVISION D

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a6bf4a67f099: ColorUtils: Use const ref for QColor/QJSValue, fix code style (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29046?vs=80747&

D28487: Redesign of system monitor plasmoids

ahiemstra added a comment. In D28487#661262 , @ksmanis wrote: > Is there an ETA for this? Is it worth fixing any bugs in the old applets in the meantime? We'd really like this in 5.19, but it's a pretty large set of changes in multiple p

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > ConfigAppearance.qml:90 > +} > +RowLayout { > +Kirigami.FormData.label: i18n("Presets:") It would probably be nice if we can make this a GridLayout with flow bound to the FormLayout's wide setting. Right now, if the layout becom

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Instead of using KF5 which is wrong since KSysGuard isn't part of frameworks. This ne

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 81577. ahiemstra added a comment. Don't eat the lib Arc REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=81576&id=81577 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFF

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 81576. ahiemstra added a comment. - Don't expose private SensorInfo in public interface of SensorQuery REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=80758&id=81576 BRANCH sensors_lib REVISION D

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > SensorFaceController.h:42 > + > +class FACES_EXPORT SensorFaceController : public QObject > +{ Can you place this class (and related classes) in the KSysGuard namespace? Then it would match the rest of the libraries. REPOSITORY R111 KSysguar

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > CMakeLists.txt:52 > KF5::I18n > +KF5::Package > +KF5::ConfigCore This is no longer needed. > CMakeLists.txt:5 > > -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors > KF5::ProcessCore) > +target_link_li

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > SensorFaceController.cpp:21 > +#include "SensorFaceController.h" > +#include "SensorFaceController_p.h" > +#include "SensorFace_p.h" This file is missing. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922

D29127: Account for top and bottom margin in default card height

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a9c8cb612992: Account for top and bottom margin in default card height (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29127?vs=80975&id=80

D29129: Remove implicitHeight from cards in main page

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:40f6034f35c1: Remove implicitHeight from cards in main page (authored by ahiemstra). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29129?vs=80978&id=809

D29129: Remove implicitHeight from cards in main page

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Card now has a correct default height. Depends on D29127

D29127: Account for top and bottom margin in default card height

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This makes Card account for the negative top and bottom margin when used in its defaul

D29092: Various fixes to new Cards

This revision was automatically updated to reflect the committed changes. ahiemstra marked an inline comment as done. Closed by commit R169:5dfa3e9e983b: Various fixes to new Cards (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?

D29092: Various fixes to new Cards

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > ndavis wrote in sdf.glsl:199 > I played around with this value and found that 0.625 was pretty decent. It > slightly improved the corners in bigscreen and made the corners of > Kirigami.Card a bit smo

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80962. ahiemstra added a comment. - Use a slightly higher smoothing value. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80891&id=80962 BRANCH cards_fixes REVISION DETAIL https://phabricator.kde.org/D

D29092: Various fixes to new Cards

ahiemstra added a comment. In D29092#654887 , @ndavis wrote: > This has a ShadowedRectangle underneath and a transparent Rectangle with a border on top: F8253587: Screenshot_20200422_115104.png > > Is t

D28333: Add a new daemon for stats monitoring

ahiemstra added inline comments. INLINE COMMENTS > client.cpp:45 > +{ > +for (auto sensor : m_subscribedSensors) { > +sensor->unsubscribe(); This should probably use `qAsConst`. > ksysguarddaemon.cpp:76 > +auto factory = qobject_cast(plugin); > +if (!factory) { > +

D29092: Various fixes to new Cards

ahiemstra added a comment. Urgh, I knew there was a point to that damn fwidth() call. As far as I can tell this version has about the same visual appearance without it changing dependent on resolution. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29092 To: ahie

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80891. ahiemstra added a comment. - Restore fwidth() call in shader, tweak smoothing values more REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80885&id=80891 BRANCH cards_fixes REVISION DETAIL https:/

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80885. ahiemstra added a comment. - Remove sdf_polygon, it is unused and causes breakage on Android REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80878&id=80885 BRANCH cards_fixes REVISION DETAIL http

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80878. ahiemstra added a comment. - Slightly increase smoothing, to avoid too harsh corners REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80876&id=80878 BRANCH cards_fixes REVISION DETAIL https://phab

D29092: Various fixes to new Cards

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This contains various small fixes to the new Cards. - Still show the border of Abst

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 80758. ahiemstra added a comment. - clang-format sensors lib - Capture this rather than = REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=79072&id=80758 BRANCH sensors_lib REVISION DETAIL htt

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Use const ref for QColor and QJSValue values. Clean up code style, lots of missing bra

D28141: Add KSysGuard::Sensors library

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorsPlugin.cpp:2 > also here Same issue as above. > mart wrote in SensorsPlugin.h:2 > shouldn't remove existing copyrights? It's a new file, but for some reason Phab thinks it's copied from formatter.h (which it has nothing t

D28625: Use ShadowedRectangle for Card backgrounds

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e770b0ddd2af: Use ShadowedRectangle for Card backgrounds (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28625?vs=80735&id=80736 REVISION

D28625: Use ShadowedRectangle for Card backgrounds

ahiemstra updated this revision to Diff 80735. ahiemstra added a comment. - Rebase on most recent master - Use ShadowedRectangleNode for ShadowedTexture if source is not set - Use transparent color for BannerImage's ShadowedImage - Hide BannerImage scrim if source or title is not set -

D28625: Use ShadowedRectangle for Card backgrounds

ahiemstra added a comment. In D28625#652529 , @mart wrote: > In D28625#642954 , @cblack wrote: > > > Looks like a nice visual improvement. > > > > Are the changes to the scenegraph stuff related?

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Seems fine to me now. You didn't have a developer account right? REPOSITORY R106 KSysguard BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #p

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This switches cards to use ShadowedRectangle for their background. It also refreshe

D28314: Allow setting separate corner radii for ShadowedRectangle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:eb4e9064e7e4: Allow setting separate corner radii for ShadowedRectangle (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=79075&id=7

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra added inline comments. INLINE COMMENTS > acpi.c:73 > > -void registerBatteryRate(int number, struct SensorModul *sm) > +void registerBatteryEnergy(char name, int number, struct SensorModul *sm) > { Uhm, this should be `const char *name` right? I don't really see how this can work o

D28438: Add per-partition total and all partitions sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:0fbf39bc37a7: Add per-partition total and all partitions sensors (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28438?vs=78903&id=79130

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra added a comment. Good stuff. Just two small comments. Additionally, you may be interested in https://phabricator.kde.org/D28333 , which will eventually replace ksysguardd and has a better API for sensors. INLINE COMMENTS > acpi.c:82 > +char name[ ACPIFILENAMELENGTHMAX ]; >

D28314: Allow setting separate corner radii for ShadowedRectangle

ahiemstra updated this revision to Diff 79075. ahiemstra added a comment. Rebase onto master, also support ShadowedTexture REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=78574&id=79075 BRANCH shadowedrect_separatecorners REVISION DETAIL http

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 79072. ahiemstra added a comment. - Fix qmldir file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78985&id=79072 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTE

D28487: Upstream of the ksysguard based plasmoids

ahiemstra added a comment. In D28487#639476 , @mart wrote: > should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma? Ideally, I'd like to see them installed into share/ksysguard/faces or somethin

D28383: Add PageRouter component

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in pagerouter.h:84 > how many routes an app would normally be going to have? > > this seems really a thing for QQmlListProperty (which then each route must > become a qobject tough) > so routes: [ > Route { > > name: "home" > co

D28222: Add ShadowedImage and ShadowedTexture items

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0c7ba88d3970: Add ShadowedImage and ShadowedTexture items (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28222?vs=78294&id=78987#toc REPOSITORY R169 Kirigami CHANGE

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78985. ahiemstra added a comment. - Update zzag's last name REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78372&id=78985 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141

D28438: Add per-partition total and all partitions sensors

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "total" sensor for each partition that reports the total space for that partit

D28314: Allow setting separate corner radii for ShadowedRectangle

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "corners" grouped property that allows setting separate radii for the diff

  1   2   3   4   >