Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

marked as submitted. Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and Sinny Kumari. Changes --- Submitted with commit 8c416587adc8780639d3bef02c16a198f58b16f7 by Ashish Madeti to branch master. Repository: plasma-mediacenter Description --- Save

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

kde.org/r/123467/#review79387 --- On April 23, 2015, 7:25 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

ll work on Windows? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79364 --- On April 22, 2015, 9:47 p.m., Ashi

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

wing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

/diff/ Testing --- Correct path is showing up in the metadata when tested with mpristester. Correct cover art is showing up in the mpris controller (appearing in system tray) of Plasma 5. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma

Re: Review Request 121476: Port showdesktop applet to Plasma Next

. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121476: Port showdesktop applet to Plasma Next

ps://git.reviewboard.kde.org/r/121476/#review72912 --- On Dec. 19, 2014, 10:53 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 121476: Port showdesktop applet to Plasma Next

Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121476: Port showdesktop applet to Plasma Next

ugin.h PRE-CREATION applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION applets/showdesktop/showdesktop.h 5aeb848 applets/showdesktop/showdesktop.cpp d712519 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ash

Re: Review Request 121476: Port showdesktop applet to Plasma Next

----- On Dec. 13, 2014, 7:44 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121476/ >

Review Request 121476: Port showdesktop applet to Plasma Next

pp d712519 Diff: https://git.reviewboard.kde.org/r/121476/diff/ Testing --- Tested the applet locally, working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On Aug. 1, 2014, 11:06 p.m., Sinny Kumari wrote: > > mediaelements/mediaplayer/MediaPlayer.qml, line 108 > > > > > > Rather than saying "Please make sure the location is accessible and try > > again" , it shou

Re: Review Request 118734: Added MPRIS specifications Tracklist Interface

qdbusviewer. I created a qt console application for testing whether the signals are being emitted correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

/r/118767/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

s the "lastPlaylist" while closing in the settings, and when starting it loads the value of "lastPlaylist" in settings Diffs (updated) - libs/mediacenter/playlistmodel.cpp dccaf52 Diff: https://git.reviewboard.kde.org/r/118767/diff/ Testing ---

Re: Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"

t. Diffs - libs/mediacenter/multipleplaylistmodel.cpp 87601f5 mediaelements/playlist/MultiplePlaylists.qml 4b085fe Diff: https://git.reviewboard.kde.org/r/118824/diff/ Testing --- Changed playlist after adding / removing a playlist. Now highlight is working fine Thanks, Ash

Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"

s/playlist/MultiplePlaylists.qml 4b085fe Diff: https://git.reviewboard.kde.org/r/118824/diff/ Testing --- Changed playlist after adding / removing a playlist. Now highlight is working fine Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-dev

Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

closing in the settings, and when starting it loads the value of "lastPlaylist" in settings Diffs - libs/mediacenter/playlistmodel.cpp 0525708 Diff: https://git.reviewboard.kde.org/r/118767/diff/ Testing --- Thanks, Ashish Madeti ___

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

/mediacenter/playlistmodel.cpp 4c52f00 Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118759: Add a separator to the path where PMC stores playlist file

: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs - Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti

Re: Review Request 118734: Added MPRIS specifications Tracklist Interface

created a qt console application for testing whether the signals are being emitted correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118734: Added MPRIS specifications Tracklist Interface

correctly and the methods are working. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

ly, visit: https://git.reviewboard.kde.org/r/118691/#review59895 ------- On June 12, 2014, 11:21 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118691/

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

/mediacenter/playlistmodel.h 0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel

Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

Diff: https://git.reviewboard.kde.org/r/118657/diff/ Testing --- Moved media around in playlist, its working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

playlist, its working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

will take you to Artists/Albums section but when you return to Songs section, the focus is still on tab bar. Due to this user has to first go to the list by pressing down key once (not intuitive) whereas imho user should be able to continue from where he left. - Ashish Madeti On May 16, 2014, 8

Re: Review Request 117801: Make PMC MPRIS compatible

/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma

Re: Review Request 117801: Make PMC MPRIS compatible

c1be61a shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti

Re: Review Request 117801: Make PMC MPRIS compatible

://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117801: Make PMC MPRIS compatible

--- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117801: Make PMC MPRIS compatible

/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp cfbe097 shells/newshell/package/contents/ui/mediacenter.qml 50f3576 Diff: https://git.reviewboard.kde.org/r/117801/diff/ Testing --- Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester Thanks, Ashish

Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

3ba5d9e libs/mediacenter/medialibrary.h 3ac18a6 libs/mediacenter/medialibrary.cpp 713827a Diff: https://git.reviewboard.kde.org/r/117510/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

Diff: https://git.reviewboard.kde.org/r/117510/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117365: Add Genre to metadata PMC keeps

e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117365: Add Genre to metadata PMC keeps

/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117365: Add Genre to metadata PMC keeps

2d5fd6b plugins/kdedesktopsearch/kdemetadatamediasource.cpp e8f18eb Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 117365: Add Genre to metadata PMC keeps

Diff: https://git.reviewboard.kde.org/r/117365/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

16907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

3d681 libs/mpris2/mediaplayer2player.cpp 7871efa Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

eviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

iewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

ge). - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- On March 19, 2014, 10:52 p.m., Ashi

Review Request 116907: Implemented "Player" MPRIS spec adaptor

s/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Pl

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

tps://git.reviewboard.kde.org/r/116874/#comment37513> What if a user has paused and then clicked the next button. runtimeData.playing will be false but the next song should play. - Ashish Madeti On March 18, 2014, 7:59 p.m., R.Harish Navnit

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

mmand line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

mmand line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

-- Tested with both "open with" and command line arguments. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

s://git.reviewboard.kde.org/r/116802/#review52976 ------- On March 14, 2014, 11:31 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. T

Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

this patch. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116802/diff/ Testing --- Tested with both "open with" and command line arguments. Thanks, Ashish Madeti ___

Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

__ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > -- *Ashish Madeti* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

/filterplaylistmodel.cpp ff546f8 libs/mediacenter/playlistmodel.h 52050fb mediaelements/playlist/Playlist.qml 0e87471 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti

Re: Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

--- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116674: Fix for "Bug 331888 - Playing media when searching, often plays the wrong media"

/filterplaylistmodel.h 19688af libs/mediacenter/filterplaylistmodel.cpp ff546f8 Diff: https://git.reviewboard.kde.org/r/116674/diff/ Testing --- Played a media when search string was not empty. Correct media is playing. Thanks, Ashish Madeti

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

--- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

--- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

/filterplaylistmodel.h aa1284b Diff: https://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

://git.reviewboard.kde.org/r/116656/diff/ Testing --- Deleted some media, when filter text was not empty. Now, the correct media is getting deleted from the playlist. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

g media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in "red" color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Re: Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

ly playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in "red" color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

ly playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in "red" color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

g media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in "red" color. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Review Request 116640: Fix for "Bug 331798 - Wrong media shown as current media in playlist after reordering"

r than the currently playing media to some place above the currently playing media. 3.Moved the currently playing media to various places in the playlist. In all the cases correct song is now showed as Now Playing i.e in "red" color. Thanks, Ashish Madeti __

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

ing me in fixing the bug. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/#review52261 --- On March 6, 2014, 2:22

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma

Re: Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"

work both ways. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 Diff: https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

-- On March 6, 2014, 5:20 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116620/ > ---

Review Request 116626: Fix for "Bug 325012 - Playlist reordering works only in one direction"

https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Bug 322820 - Playlist is not reachable from home screen

get a > menu item you'll have to create a new backend and this backend will need to > run some QML code to bring up the playlist. Right now backends cannot do > this, so in order to do this you'll have to add this capability to the > backend system. > > Cheers, > &

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

ments/playlist/PlaylistDelegate.qml e1bd31d mediaelements/playlist/Playlist.qml fd83c21 Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, A

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

versed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

then before. Diffs - mediaelements/playlist/PlaylistDelegate.qml e1bd31d Diff: https://git.reviewboard.kde.org/r/116596/diff/ Testing --- 1.Deleted a song from a playlist without playing it. 2.Traversed the playlist without using keyboard or mouse scroll button. Thanks, Ashish

Bug 322820 - Playlist is not reachable from home screen

by clicking the play button on welcome screen. 2. We can add a menu item for "Browse Playlists" on welcome screen for music and videos. I will try to implement whichever is better. -- *Ashish Madeti* 2nd Year Computer Science & Engineering The LNM Institute of Information Tec