D21980: Fix ocasional crash on the touchpad kded

atulbi accepted this revision. atulbi added a comment. Me too REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21980 To: aacid, atulbi, ngraham Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D21915: Fix crash in the touchpad kded

atulbi added a comment. In D21915#482877 , @aacid wrote: > In D21915#482182 , @knambiar wrote: > > > In D21915#482145 , @aacid wrote: > > > > > The

D21278: [Touchpad KCM] Fix kded crashing at startup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup (authored by atulbi). REPOSITORY R119 Plasma Desktop

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi updated this revision to Diff 58319. atulbi added a comment. - Now we have separate m_touchpadOffAtom for synaptics and Libinput. On Libinput, used m_enabled prop. - setTouchpadOff will be ignored on X Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466804 , @romangg wrote: > > by kded on key press other than Kded Keyboard shortcuts > > Do you mean it's sent on shortcut or not? Just wondering why I couldn't replicate the issue in my testing.

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466801 , @davidedmundson wrote: > > m_connection seems to be having null or 0x0 value. > > Which means we're calling XcbAtom::atom after being constructed from the default constructor not the proper one.

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY When XcbAtom::atom() is called (by kded on key press other than Kded Keyboard shortcuts), m_connection seems to be having null or

D21269: [Touchpad KCM] Fixed loading of wrong qml file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml file (authored by atulbi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21269?vs=58248=58260#toc REPOSITORY R119 Plasma Desktop

D21269: [Touchpad KCM] Fixed loading of wrong qml file

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY On system settings, If Mouse KCM is opened first, then touchpad KCM loads the same Mouse QML file (qrc::/libinput/main.qml) instead

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi added a comment. Thank you so much for fixing it. Wanted it to on beta. INLINE COMMENTS > romangg wrote in libinputtouchpad.cpp:426 > Why this write back? What's configProps. Yeah realized later that there is no need to write config here. So no need for configProps. Should I open

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier Previous setting were not loaded on reboot instead default settings were loaded. So, added config file for saving the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. > In D20186#465395 , @romangg wrote: > >> I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? >> >> EDIT: No, they are not. In X11 + evdev

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465361 , @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465278 , @ngraham wrote: > Are you ready for me to land this? Yeah \o/ I'll take that for the next patch. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58083. atulbi added a comment. Set visible to false, until accel profiles are not supported. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=58082=58083 BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58082. atulbi added a comment. Finally no more greyed settings there \o/ Work I've planned for future releases : - Adding support to disable horizontal scrolling on wayland. - Provide settings to Disable touchpad on external mouse.

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57933. atulbi added a comment. - lmr mapping working now REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57923=57933 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57923. atulbi added a comment. - Added Copyright notice - Corrected asterisk placement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57521=57923 BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added inline comments. INLINE COMMENTS > romangg wrote in libinputtouchpad.h:57 > Why is there the negation? Put the Enabled-related function in the parent > class. X provides property for the disabled, while Wayland provides property for enabled. REPOSITORY R119 Plasma Desktop

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#462883 , @GB_2 wrote: > Ping Hey... Have you tried this patch ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57521. atulbi added a comment. - Remove CMakeLists.txt.user REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57520=57521 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57520. atulbi added a comment. - Changes Made : 1. Added abstract class LibinputCommon. 2. All the Q_PROPERTY are in LibinputCommon. 3. Added Disable Horizontal Support on X11 on Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57519. atulbi added a comment. - Removed last commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57508=57519 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57508. atulbi added a comment. - Added new abstract class LibinputCommon - Add overriding destructor - Added support for disable horizontal scrolling on Libinput On X11. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55532=57508

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#458259 , @ngraham wrote: > @atulbi were you able to get in touch with @romangg? Can I help in any way? > > The feature freeze for Plasma 5.16 is in a little over two weeks

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#454420 , @ngraham wrote: > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. Totally!! I'm working on it... Currently

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443596 , @romangg wrote: > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55532. atulbi added a comment. - Resolved issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55277=55532 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED FILES

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443723 , @knambiar wrote: > > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443554 , @ngraham wrote: > In D20186#443262 , @knambiar wrote: > > > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#442088 , @knambiar wrote: > > Got to Know a lot about how X works with input handling. XD > > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55277. atulbi added a comment. - Code Cleanup and resolved unexpected behaviour REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55251=55277 BRANCH X11Libinput REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55251. atulbi added a comment. - Avoid Setup Backend two times REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55234=55251 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#441892 , @ngraham wrote: > Thanks so much for this! Got to Know a lot about how X works with input handling. XD REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To:

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55234. atulbi added a comment. - Minor changes to optimise code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55230=55234 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier when libinput was used on X11, XInput specific UI was shown, due to which most of the options were grayed out. Now we show

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

atulbi added a comment. Thanks. Yes, I'll take this for sure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18912 To: atulbi, ngraham, #plasma, romangg, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY - Added Properties to wayland Backend - User can switch between areas and clickfinger methods if touchpads has no physical