D23274: Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 66829. GB_2 added a comment. Swap menu and home button position REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66806=66829 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#537221 , @ngraham wrote: > Try this patch to your patch: P471 Addendum to D23274 Thanks! The only issue that's left now is that the subcategory doesn't get reset (when

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 66780. GB_2 added a comment. Use Nate's fix and enable button when clicking a most used item REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64682=66780 BRANCH

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. Looks like this is more complicated than I thought. If someone wants to comandeer this revision then please do. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel,

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY In D23951 we hide "Lock Widgets" from the UI, so do the same

D23952: Remove panel toolbox

GB_2 updated this revision to Diff 66671. GB_2 added a comment. Remove unrelated change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23952?vs=66159=66671 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23952 AFFECTED FILES

D23952: Remove panel toolbox and clean up editing options

GB_2 planned changes to this revision. GB_2 added a comment. In D23952#532716 , @ngraham wrote: > I agree that we can't only have this UI be in a context menu, and we need to expose it somewhere visible too (i.e. in System Settings like we

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

GB_2 updated this revision to Diff 66614. GB_2 added a comment. Remove unneeded lines REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24129?vs=66577=66614 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 AFFECTED FILES

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

GB_2 updated this revision to Diff 66577. GB_2 added a comment. Fix more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24129?vs=66576=66577 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 AFFECTED FILES

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7401179: Fixed Display Configuration KCM Clipping.png The

D24033: Add Meta+Space as a default shortcut to activate KRunner

GB_2 added a comment. In D24033#533505 , @romangg wrote: > I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications. > >

D23798: Polish Displays KCM UI

GB_2 added a comment. In D23798#533361 , @ngraham wrote: > Thanks! Needs final approval from @romangg or someone else from #KWin before landing. Of course. REPOSITORY R104 KScreen BRANCH

D23798: Polish Displays KCM UI

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. UI LGTM! REPOSITORY R104 KScreen BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin, GB_2 Cc: filipf,

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in Panel.qml:90 > "Output" is a bit too technical I think, and"Monitor" doesn't cover the case > of projectors. Personally I like "Display" but I'm open to being convinced > otherwise. +1 for display REPOSITORY R104 KScreen

D23984: [System Settings] redesign intro page

GB_2 added inline comments. INLINE COMMENTS > introPage.qml:92 > wrapMode: Text.NoWrap > text: i18n("Frequently used:") > } Maybe change to "Frequently Used", so it's a header? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D23984: [System Settings] redesign intro page

GB_2 added a comment. As you can see in my design, I'd not add a rectangle in the backround, it looks weird to me and less clean than before. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23984: [System Settings] redesign intro page

GB_2 added a comment. What about a design like this? F7363944: System Settings Intro Page Mockup.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23952: Remove panel toolbox and clean up editing options

GB_2 updated this revision to Diff 66159. GB_2 added a comment. - Add back "Show Alternatives..." item and remove reference to panel toolbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23952?vs=66105=66159 BRANCH arcpatch-D23952 REVISION

D23952: Remove panel toolbox and clean up editing options

GB_2 added a comment. In D23952#532034 , @ngraham wrote: > Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox. That's because you still have the files and manually compiling

D23952: Remove panel toolbox clean up editing options

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY With D23951 we greatly improve the discoverability of the panel

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

GB_2 updated this revision to Diff 66102. GB_2 added a comment. Don't hide "Lock Widgets" for panels REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23950?vs=66094=66102 BRANCH

D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See M144 and T10047 . This

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Preview.qml:82 > > -Item { height: units.gridUnit / 2 } > - > -PlasmaExtras.Heading { > -level: 3 > -elide: Text.ElideRight > +Kirigami.Heading { > +level: 1 Maybe add `wrapMode:

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added inline comments. INLINE COMMENTS > Tools.qml:108 > +QQC2.Label { > +text: i18n("Colorscheme:") > } "Color scheme" REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26,

D23910: startplasma: Respect KDEWM again

GB_2 added a comment. BTW, I wonder if we can rename it to `PLASMAWM` in Plasma 6/the future. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23910 To: heikobecker, #plasma, apol, davidedmundson Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:231 > I tried that, but it looked sort of weird. I kind of like how the presence of > the icon helps to show what's the default device. Maybe you can also use `star-shape` REPOSITORY R115 Plasma Audio Volume

D23389: Use "Make default" buttons to switch the default device

GB_2 added a comment. In D23389#525358 , @ngraham wrote: > See the new `FIXME`: I can't figure out how to get the non-default device's button to become unchecked. It seems like the binding is broken. The non-default button disables itself

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

GB_2 added a comment. In D23283#526239 , @ngraham wrote: > Thanks for the review, @gb_2. Have you tested it out? I did a lot of testing, but even more testing would be appreciated since I know this has the potential to introduce some

D23798: Polish Displays KCM UI

GB_2 added a comment. In D23798#528804 , @ngraham wrote: > Did you test the patch with those suggestions? They don't work. Oh, sorry then. I didn't actually have two screens to test this. It just looked like it worked for one.

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > OutputPanel.qml:33 > +text: i18n("Settings for %1", element.display) > +visible: kcm.numberOfOutputs > 1 > +} `element.count > 1` > OutputPanel.qml:42 > onClicked: element.enabled = checked > + visible:

D23803: [Folder View] Add subtle shadows to icons

GB_2 added a comment. In D23803#528128 , @cfeck wrote: > Isn't Qt Quick amazing? Indeed! REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL

D23798: Polish Displays KCM UI

GB_2 added a comment. I have a suggestion for the "save output properties" option. INLINE COMMENTS > Panel.qml:90 > > Kirigami.FormData.label: i18n("Save values of an output:") > Kirigami.FormData.buddyFor: globalRetentionRadio "Save output properties:" >

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:123 > And I could use some help with the issue detailed in the comment here. You don't need any of that. Just do `kcm.outputModel.count > 1`. BTW, I'd also use a different minimum height if this component is hidden.

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65691. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65509=65691 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6fbfc3ded129: Add icons to Kicker/Kickoff context menu items and correct capitalizations (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10362: Change reveal password button logic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592=65681

D23798: Polish KCM UI

GB_2 added a comment. +1 INLINE COMMENTS > Screen.qml:65 > onClicked: kcm.identifyOutputs() > text: i18n("Identify") > focusPolicy: Qt.NoFocus Icon: "documentinfo" > Screen.qml:71 > onClicked: resetTotalSize() > text:

D23799: Get rid of khtml usage (kill classic mode)

GB_2 added a comment. +1, let's also focus on fixing bugs for the other two views. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D23794: HiDPI icon pixmap

GB_2 added a comment. Please add subscribers and reviewers next time. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23794 To: guoyunhe, #plasma Cc: GB_2, #plasma, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel,

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7331506: Kicker⁄Kickoff Context Menu Items Icons and Correct Capitalizations.png

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 planned changes to this revision. GB_2 added a comment. I'll try to work more on this in the future. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n,

D23785: Rename activities context menu item in task manager to "Show in Activities"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b411c132d77b: Rename activities context menu item in task manager to Show in Activities (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23785: Rename activities context menu item in taska manager to "Show in Activities"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Sync with change in D23779 . TEST PLAN Open the context menu

D23776: Add icon to "Move to Desktop/Activity" task manager context menu item and fix capitalizations

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ffee9c4097a3: Add icon to Move to Desktop/Activity task manager context menu item and fix… (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

GB_2 updated this revision to Diff 65595. GB_2 added a comment. Also add icon for "Move to Activity" item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65590=65595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

GB_2 added a comment. In D23776#527312 , @ngraham wrote: > Any reason not to add an icon for Move to Activity as well? Forgot that, will do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23776 To:

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585=65592 BRANCH

D23776: Add icon to "Move to Desktop" task manager context menu item

GB_2 updated this revision to Diff 65590. GB_2 added a comment. Also fix "Move to Activity" capitalization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65587=65590 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776

D23776: Add icon to "Move to Desktop" task manager context menu item

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7327853: Move to Desktop Task Manager Context Menu Item Icon.png

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65551. GB_2 added a comment. Use `length` property and stop revealing password if field is empty REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65541=65551 BRANCH arcpatch-D10362 REVISION

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILES

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework

D23712: [Cuttlefish] Overhaul program, use Kirigami

GB_2 added a comment. In D23712#526883 , @cblack wrote: > I preferred the sidebar as well, but a sidebar with the necessary width to fit the label + the largest icon name in Breeze without layout issues would be obscenely large, and would take

D22169: [plasma-active-window-control] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R884:c29390fab0c4: [plasma-active-window-control] Use new activities icon (authored by GB_2). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D22170: [latte-dock] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R878:c264a0a9e3fe: [latte-dock] Use new activities icon (authored by GB_2). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22170?vs=60869=65536 REVISION DETAIL

D22168: [plasma-desktop] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:267b9134c8b1: [plasma-desktop] Use new activities icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=65531=65534 REVISION

D22167: [plasma-workspace] Use new activities icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ad1b5502e1a: [plasma-workspace] Use new activities icon (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22167?vs=60865=65533 REVISION

D22168: [plasma-desktop] Use new activities icon

GB_2 updated this revision to Diff 65531. GB_2 added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=60866=65531 BRANCH arcpatch-D22168 REVISION DETAIL https://phabricator.kde.org/D22168 AFFECTED FILES

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65509. GB_2 added a comment. Use Plasma highlight effect REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=55003=65509 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Makes sense to me UI- and behavior-wise. INLINE COMMENTS > LockScreenUi.qml:443 > +font.pointSize: theme.defaultFont.pointSize + 1 > +

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

GB_2 added a comment. Ping. REPOSITORY R124 System Settings BRANCH use-new-kirigami-section-header (branched from master) REVISION DETAIL https://phabricator.kde.org/D23052 To: ngraham, #plasma, #vdg, GB_2 Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. In D23174#519704 , @ngraham wrote: > Hooray! > > Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? Unfortunately, I don't know the code base

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ListItemBase.qml:230 > +PlasmaComponents.Button { > +text: PulseObject.default ? i18n("Default device") : > i18n("Make Default") > +iconName: PulseObject.default ? "favorite" : ""

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#520127 , @mart wrote: > SidebarMode::setActiveCategory may need to be modified to make it like it tough Looks like it. INLINE COMMENTS > SidebarMode.cpp:498 > +if (introPageVisible) { > +

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. Ping. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart,

D23174: Improve the look of the Activities KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbd0465c3b1c: Improve the look of the Activities KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63818=64686 REVISION

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 marked 2 inline comments as done. GB_2 added a comment. This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png REPOSITORY R124 System Settings REVISION DETAIL

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 64682. GB_2 added a comment. Use a bool property setter and disable button when on intro page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64071=64682 BRANCH

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

GB_2 added inline comments. INLINE COMMENTS > account.ui:227 > > - > - > - > - 0 > - 0 > - > - > + > Add the icon `document-edit` REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma,

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 64217. GB_2 added a comment. Improve look REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63662=64217 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES Mainpage.dox

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23285: Prevent dragging QQC2 ComboBox contents outside menu

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D23285: Prevent dragging QQC2 ComboBox contents outside menu

GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the items outside the menu, it looks weird. This fixes it.

D21524: Keep existing configurations' strings               

GB_2 added a comment. Ping. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari, apol, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a subscriber: mart. GB_2 added a comment. @mart can you help here? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405956 F7262289: System Settings Sidebar Show Intro Page Button.png

D22896: Port System Settings sidebar to QQC2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R124:b42479962795: Port System Settings sidebar to QQC2 (authored by GB_2). REPOSITORY R124 System Settings CHANGES

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 64057. GB_2 added a comment. Move `setActionMenuVisible` to the `Private` class REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63968=64057 BRANCH arcpatch-D22896 REVISION DETAIL

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. In D23242#514239 , @hein wrote: > Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 368430 Being able to disable grouping for the icons-only taskmanager makes sense, because it

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63968. GB_2 added a comment. Add tooltip to menu button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63872=63968 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

GB_2 added a comment. I just tried it on Wayland and it looks like for some reason instead of a number it shows some kind of UUID. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n,

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. @mart is this good now? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol,

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63872. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63827=63872 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma, filipf, ngraham Cc: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. Visually +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63827. GB_2 added a comment. Use standard shortcut for "Configure System Settings..." action REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63799=63827 BRANCH arcpatch-D22896 REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63818. GB_2 added a comment. Fix "blocked" emblem icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63817=63818 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63817. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63800=63817 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63800. GB_2 added a comment. "Only for specific applications" -> "Only for specific applications:" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63793=63800 BRANCH improved-activities-kcm-ui (branched

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63799. GB_2 added a comment. Bind checked property directly REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63614=63799 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63793. GB_2 added a comment. Remove unneeded import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63792=63793 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL

D23174: Improve the look of the Activities KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in

D17598: Improve "No internet connection!" error message

GB_2 added inline comments. INLINE COMMENTS > BrowsingPage.qml:73 > +horizontalAlignment: Text.AlignHCenter > +text: xi18nc("@info", "Unable to load > applicationsplease verify Internet connectivity") > +} I'd put a dot after "applications" and

D22885: Add global animation speed slider to workspace options KCM

GB_2 added a comment. In D22885#505635 , @broulik wrote: > Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means *faster* instead of "half the speed" as reading that line would suggest. > However, KWin seems to do it the

<    1   2   3   4   5   6   7   >