D15011: [Kickoff] Make the search field always look like a search field

cfeck added a comment. David is on holidays, so maybe someone else could approve if this is urgent. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: cfeck, acrouthamel, fabianr, huftis, rooty,

D15333: Group Widget + Color Picker = Widget Out Of Bounds

cfeck added a comment. Any Plasma developer who has kdeplasma-addons installed to verify this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15333 To: McPain, #plasma, ngraham Cc: cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15598: Sort icon and cursor themes case-insensitively

cfeck added a comment. If you would need to process the data sorted, you would already sort the model. But here, it is only sorted for display, and that's exactly the use case for the proxy model. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D15514: [libbreezecommon] Use box blur instead of FFT approach

cfeck added a comment. I would even say 'after' looks better, because the bottom shadow isn't as strong as 'before'. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot,

Re: CI System Reorganisation

view all of "stable" Applications on a single page? I remember I asked if it would still be possible after the change, but I cannot see a filter or link to get an overview of all builds. Christoph Feck

D8267: Correcting symlinks between col- and row-resize and split_v and _h cursors

cfeck added a comment. We have some documentation at https://community.kde.org/Infrastructure/Phabricator REPOSITORY R113 Oxygen Theme BRANCH fixlinks REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol, cfeck Cc: davidedmundson, rdieter, tfoster, apol,

Re: Upcoming reorganisation of the CI system

an overview before doing releases. Christoph Feck

[Powerdevil] [Bug 379858] Windows open too small

https://bugs.kde.org/show_bug.cgi?id=379858 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[Powerdevil] [Bug 379858] Windows open too small

https://bugs.kde.org/show_bug.cgi?id=379858 --- Comment #3 from Christoph Feck --- See my comment at bug 394747. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||piotr...@gmail.com --- Comment #17 from

D13988: Use subseq matching for service runner

cfeck added a comment. According to https://community.kde.org/Schedules/Plasma_5 the Plasma 5.14 release is planned to depend on Frameworks 5.50. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma,

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||ubunte...@gmail.com --- Comment #16 from

D7155: Implement sorting of the device tree items

This revision was automatically updated to reflect the committed changes. Closed by commit R102:7c0f85162ee9: Implement sorting of the device tree items (authored by isaact, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D7155: Implement sorting of the device tree items

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Looks like we lost tracking this. If nobody objects, I will commit this next week. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma,

D13360: Touchpad KDED module: Convert to JSON metadata

cfeck added a comment. Regression has been reported as bug 395622. Please close when fixed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: cfeck, kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot,

Re: Closing old Plasma 4 bugs

On 08.06.2018 23:06, Scott Harvey wrote: Did anyone check how much space has been freed up in the Bugzilla database? None, because the bugs are still there; they just changed the status. On the other hand, we have some 2600+ less open tickets.

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||skonjic...@gmail.com --- Comment #13 from

Dependency on Solid/PowerManagement from KDELibs4Support

Checking what blocks porting away -workspace and -desktop from KDELibs4Support, I see Solid/PowerManagement. I have not checked what exactly is needed from this module, but could we release this module separately if there is no plan to integrate it back to Solid? -- Christoph Feck

D13071: [Klipper] Port away from KLineEdit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf5e72907510: Port away from KLineEdit (authored by cfeck). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13071?vs=34734=34823 REVISION DETAIL

D13070: [libtaskmanager] Add missing QUrlQuery includes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed274a056de9: Add missing QUrlQuery includes (authored by cfeck). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13070?vs=34732=34822 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:277 > + * @p canReturnNull. > + * @since 5.48 > + */ Next release is 5.47, but I am fine with waiting for additional feedback if this is controversial. REPOSITORY R302 KIconThemes REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:527 > * @see resetPalette > - * @since 5.39 > + * @since 5.38 > */ Is this missing a rebase or intended? See https://cgit.kde.org/kiconthemes.git/commit/?id=b506a48214a08f56d79e7847a22b0417028a46ff REPOSITORY

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

n bugzilla either. -- Christoph Feck

D13073: Weigh matching services by relating data used in query to their menuids

cfeck added inline comments. INLINE COMMENTS > tasktools.cpp:45 > #include > +#include > #include Can be removed? If not, sort correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13073 To: hein, broulik, davidedmundson Cc: cfeck, plasma-devel,

D13071: [Klipper] Port aways from KLineEdit

cfeck created this revision. cfeck added reviewers: Plasma, graesslin. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Klipper does not use completion features, so port to QLineEdit. REPOSITORY

D13070: [libtaskmanager] Add missing QUrlQuery includes

cfeck created this revision. cfeck added reviewers: Plasma, hein. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY Found by removing KDELibs4Support from CMakeLists.txt REPOSITORY R120 Plasma

D12835: Draw borders around side panels by default

cfeck added a comment. While I also use this setting, we probably should not make it default, unless the QtQuick dialogs (try desktop RMB > Configure Desktop ...) also respects this setting. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12835 To: ngraham Cc:

Re: Closing old Plasma 4 bugs

On 11.02.2018 20:52, Nate Graham wrote: All right, so let's give it a shot. How about we make it so that normal users have full privilages except the following: - Can't bulk change - Can't change Importance field We now see regressions caused by this particular change: - new 'wishlist'

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||til...@arved.at --- C

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

cfeck added a comment. In D12040#253335 , @Zren wrote: > Remove `.data()` since it seems to work without it. Even with gcc 4.8 (openSUSE Leap)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To:

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added a comment. OMG, for whatever reason, I was assuming this is about the file dialog window size. You are working on too many things at once, Nathan :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12252 To: sharvey, ngraham, mart, davidedmundson

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added a comment. I still object to enforce a minimum size. On my main system, I use a 4K screen, and having a file dialog span nearly the complete screen is irritating, and mostly unusable because I have to travel a lot to reach buttons. What is wrong with offering a good default

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

cfeck added inline comments. INLINE COMMENTS > SettingsBase.cpp:128 > + > +// enforce minimum window size > +setMinimumSize(SettingsBase::sizeHint()); Why? I use some systems in portrait mode, 768x1024 pixels. REPOSITORY R124 System Settings BRANCH enlarge-default-size (branched

D3484: Center systemmonitor window properly on multi-screen setup

cfeck added a comment. > If the application will set it's own geometry, then it'll still cause conflicts with (potential) KWin rules No, the KWin rules are a mean to override (or ignore) what applications set. An application shouldn't rely on KWin rules to deliver the user experience.

D3484: Center systemmonitor window properly on multi-screen setup

cfeck added a comment. > I thought the consensus was that the window shouldn't set it's properties (size and keepabove) and it's up to Kwin to set them It is the application that sets the window size. Since the initial size is likely wrong, applications usually remember sizes of windows

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added inline comments. INLINE COMMENTS > kiconloader.h:279 > + */ > +QPixmap loadIcon(const QString , KIconLoader::Group group, qreal > scale, int size = 0, > + int state = KIconLoader::DefaultState, const > QStringList = QStringList(), loadIcon("test",

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added a comment. In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without duplicating the icon files? REPOSITORY R302 KIconThemes REVISION DETAIL

D3484: Center systemmonitor window properly on multi-screen setup

cfeck added a comment. But it does no longer remember window size now (and for whatever reason, I cannot get the kwin rules to force an initial window size to work). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 To: valeriymalov, #plasma_workspaces,

D11848: [Kickoff] Reduce hover delay before switching tabs

cfeck added a comment. I didn't say it is a problem. I just asked if we know it isn't a problem for them. There must have been a reason the delay was added in the first place. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma,

D11848: [Kickoff] Reduce hover delay before switching tabs

cfeck added a comment. If they accidentally shoot too far, and want to move back without the tabs changing in between. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To: ngraham, #plasma, davidedmundson, abetts Cc: cfeck, plasma-devel, ragreen, Pitel,

D11848: [Kickoff] Reduce hover delay before switching tabs

cfeck added a comment. Do we have studies from users that did not complain, because they need the delay? I am thinking about touchpad or trackball users, that cannot move as fast a regular mouse. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11848 To:

D11262: KDE logout screen background color fix

cfeck added a comment. In D11262#237017 , @Pitel wrote: > I guess I should have renamed it from `isLightColor` to something like `isNotAlmostBlack`... The point was to replace almost black colors with real black because it looks better with

D11808: [weather dataengine] Fix BBC provider to adapt to change RSS feed

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. You cannot break what no longer works :) INLINE COMMENTS > ion_bbcukmet.cpp:270 > + > +XMLMapInfo& place = m_place[QStringLiteral("bbcukmet|") > +sourceAction[2]]; > + Space

D11262: KDE logout screen background color fix

cfeck added a comment. In D11262#235414 , @Pitel wrote: > I finally got to do some testing and it is not looking good for luminance formula `0.2126*r + 0.7152*g + 0.0722*b`. > > Screenshot with background color `#5500FF` (blueish, button

D6313: Support Icon Scale from Icon naming specification 0.13

cfeck added a comment. Otherwise looks good. Maybe needs more feedback from testers. INLINE COMMENTS > kiconloader.cpp:1264 > { > +return loadIcon(_name, group, 1.0 /*scale*/, size, state, overlays, > path_store, canReturnNull); > +} indent > kicontheme.cpp:169 > +} else if (scale >

D11631: Fixes pixelated icon scaling for HiDPI screens

cfeck added a comment. Does it still need KIconThemes framework elsewhere? If not, the dependency could be removed. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D11631 To: acrouthamel, rkflx, broulik Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai,

D10753: Provide the source selection as a contextual action

cfeck added a comment. Was this committed? REPOSITORY R134 Discover Software Store BRANCH sourcesUI REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

cfeck added a comment. Was this already committed? REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

cfeck added a reviewer: xuetianweng. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

cfeck added a comment. Woot! :) In the long term, the drawers probably could use a qtquick splitview to allow the user to adjust the sizes. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc:

D10668: Fix PowerDevil shortcuts migration

cfeck added a comment. Regarding the comments, I prefer a space after '//' for better readability. INLINE COMMENTS > powerdevilapp.cpp:169 > +}); > +for(const QString : actionIds) > +{ Missing space after 'for'. > powerdevilapp.cpp:170 > +for(const QString :

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

https://bugs.kde.org/show_bug.cgi?id=346972 Bug 346972 depends on bug 339863, which changed state. Bug 339863 Summary: Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon https://bugs.kde.org/show_bug.cgi?id=339863

D10563: Place toolbox in the top right corner of the screen

cfeck added inline comments. INLINE COMMENTS > ToolBoxRoot.qml:143 > function placeToolBox(ts) { > +// if nothing has been setup yet, determin default position based on > layout direction > +if (!ts) { 'determine' REPOSITORY R119 Plasma Desktop REVISION DETAIL

Re: Plasma is very slowly

On 15.02.2018 11:24, Андрей Черный wrote: Why are you running plasmashell multiple times? Fix your mess before bothering developers with it.

D10522: Added vertical separator

cfeck added a comment. When I had designed the menus for the Skulpture style, I opted for not using a separate column for checkboxes, but indent the items that use them. The separate column was used for icons, though. See http://skulpture.maxiom.de/images/skulpture-sample-2.png REPOSITORY

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

cfeck added a reviewer: hein. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Closing old Plasma 4 bugs

On 10.02.2018 21:24, Nate Graham wrote: Hello folks, We have more than 2,500 Plasma 4 bugzilla tickets that we don't intend to look at or triage. We've already prevented new tickets from being filed, but it doesn't do anyone any good to just have the old ones sitting there. My sense is that most

D10357: Show high-resolution and vector logos properly in HighDPI mode

cfeck added a comment. Suggesting Qt:AA_EnableHighDpiScaling was my fault; I really should have checked our applications to suggest the correct attribute. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc:

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Please use the summary to describe what the patch does, not why you added it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

cfeck retitled this revision from "Framework patch: Moving the mouse over a different application icon immediately changes the window list" to "Fix "Moving the mouse over a different application icon immediately changes the window list"". cfeck edited the summary of this revision. REPOSITORY

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

cfeck set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

D9874: Fix executable name in README

cfeck closed this revision. cfeck added a comment. Thanks. Next time, please use the 'Differential Revision' line as explained in our commit templates to automatically close it. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9874 To: pali, apol Cc:

D9874: Fix executable name in README

cfeck added a comment. Please only commit to 5.12 branch if you also merge to master afterwards. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9874 To: pali, apol Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9874: Fix executable name in README

cfeck added a comment. We assumed you have commit access. If you do not, please state so. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9874 To: pali, apol Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

cfeck added a comment. This partly fixes the issue. After applying this I can still reproduce by moving the mouse from the textual list to the favorite icons, or from the list to the gap between the list and the search box. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7246: Tooltips

cfeck added inline comments. INLINE COMMENTS > decoration.h:179 > void requestShowWindowMenu(); > +void requestShowToolTip(QString text); > +void requestHideToolTip(); const QString > decorationbutton.cpp:292 > +{ > + > +switch (type) { empty line > decorationbutton_p.h:69

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|DUPLICATE |---

D9549: Horizontally center shadows and make them bigger

cfeck added a comment. I remember the shadows were made thin on the left so that cascading popup menus look smoother. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: cfeck, januz,

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||bugs5.kde@s

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a comment. The patch also addresses the bug only for default fonts, but not per-application fonts that write their settings to the appnamerc file. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a reviewer: cfeck. cfeck added a comment. The config would work with removed styleName() for the cases where the weight() and style() attributes are sufficient. The intention from Qt's side was to uniquely identify fonts that cannot be selected by those two attributes. Imagine a

Re: Review Request 130247: Show root items in kicker menu. Related to #358291

/create/ for patches. - Christoph Feck On Nov. 14, 2017, 1:29 p.m., Sergei Lopatin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

D8787: Fix PWD dialog

cfeck added inline comments. INLINE COMMENTS > cfeck wrote in mountdialog.cpp:33 > Is the leasing space intended? "leading" :) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: cfeck, plasma-devel, ZrenBot, progwolff,

D8787: Fix PWD dialog

cfeck added a comment. Please clarify. If https://phabricator.kde.org/D8791 gets accepted, which issues remain that would justify a custom dialog? INLINE COMMENTS > mountdialog.cpp:33 > +m_ui.errorLabelStatic->setVisible(false); > +m_ui.vaultName->setText(QString("

D8787: Fix PWD dialog

cfeck added a comment. KPasswordDialog does not come from KDELibs4Support, but from KWidgetsAddons. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8771: Use heuristic weighted length algorithm to calculate the query term length.

cfeck added inline comments. INLINE COMMENTS > servicerunner.cpp:52 > +} > +length += 1; > +} Since there is no 'else', the length is increased by 3 for Han characters. Is this intended? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8397: Align logout screen action buttons to the top

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3e495b220fd0: Align logout screen action buttons to the top (authored by aleksejshilin, committed by cfeck). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Plasma Workspace Wallpapers] [Bug 386093] Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode

https://bugs.kde.org/show_bug.cgi?id=386093 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Reso

[kio-extras] [Bug 371278] Dolphin crashed in QList::detach() when opening smb location

https://bugs.kde.org/show_bug.cgi?id=371278 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

cfeck added a comment. Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To:

D7481: RFC: Batch window changes events on XCB

cfeck added a comment. Is there a consensus if this is still needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7769: [Task Manager] Use Grid for grouped and single tooltips

cfeck added a comment. Please commit accepted changes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7769 To: subdiff, #plasma, davidedmundson, hein Cc: cfeck, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

cfeck added a comment. No problem, can you please abandon this diff then? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D7795 To: thorstenb, #plasma, jgrulich Cc: cfeck, jgrulich, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

cfeck added a comment. What is the status of this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: cfeck, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7648: Fix ksysguard not starting on plasmoid click

cfeck added a comment. David, the beta was released. REPOSITORY R114 Plasma Addons BRANCH launch-change REVISION DETAIL https://phabricator.kde.org/D7648 To: maxrd2, #plasma, davidedmundson Cc: cfeck, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7757: Use real-time scheduling policy for kwin_wayland

cfeck added a comment. I was about to suggest that it should queue lower than "real" realtime processes, but reading the description, this was actually taken care of using the lowest priority. +1 to this feature. I think Windows also favors GUI processes over background processes, so

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

cfeck added a comment. Kai, do you plan to work on the mentioned issues? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7260: System tray icon's context menu isn't updated properly in plasma/x11

cfeck added a comment. David, can you test again? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

[Breeze] [Bug 384129] Rename colors from British to American English

https://bugs.kde.org/show_bug.cgi?id=384129 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Product|systemsettings |Breeze As

D7155: Implement sorting of the device tree items

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Isaac, do you want to work on the requested changes? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma, cfeck Cc: cfeck,

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

cfeck added a comment. https://phabricator.kde.org/D7316 has been committed, and the referenced bug marked as fixed. Reading above comments, this patch can/should be committed, too. Please check if this is still true, and either approve this patch, or discard it. REPOSITORY R127

D7345: [Style KCM] Remove message box about changes applying only to newly started applications

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7345 To: broulik, #plasma, cfeck Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7127: ignore spurious resize events to empty sizes

cfeck added a comment. The commit still says "size != oldSize". Is this correct? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: cfeck, davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot,

D7188: Use Qt scaling in Plamsa

cfeck added a comment. Add some #include KWindowSystem, otherwise the symbol is not defined. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7188 To: davidedmundson, #plasma, mart Cc: cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7046: Use xcb-icccm to read the name property

cfeck added inline comments. INLINE COMMENTS > graesslin wrote in client.cpp:1428 > Just to add a little bit of context here: we are discussing two memcopies > here in a code path which performs a roundtrip to the X server. This thing is > going to be slow and the memcopy does not matter at

D7046: Use xcb-icccm to read the name property

cfeck added inline comments. INLINE COMMENTS > graesslin wrote in client.cpp:1428 > I'll keep the second copy nevertheless. After all this mess with Qt 5 > transition I don't trust Qt in the area of QString from char array. > > I rather have here a copy too much, which won't matter, then a

D7160: Also specify a default StyleName for fonts

cfeck added a comment. Note that saving the style name is a bug, see https://bugs.kde.org/show_bug.cgi?id=378523 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH stylename REVISION DETAIL https://phabricator.kde.org/D7160 To: fvogt, #plasma, davidedmundson Cc: cfeck,

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

https://bugs.kde.org/show_bug.cgi?id=363147 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||polarathene-signup@h

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

cfeck added a comment. Eike, next time you commit patches from contributors, please use the --author option in git commit to give proper attribution. Additionally, a bug number was given, but BUG: keyword was missing in the commit message. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D6864: [System Monitor Applet] Add setting for update interval

cfeck added inline comments. INLINE COMMENTS > main.xml:13 > + > +The interval in milliseconds to update the data shown > +2000 Add a "." > ConfigGeneral.qml:115 > +suffix: i18nc("Suffix for spinbox (seconds)", " sec") > +maximumValue: 1000 >

<    1   2   3   4   5   6   >