Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-11-13 Thread Christoph Feck
On Sept. 16, 2011, 2 p.m., Aaron J. Seigo wrote: looks good. and stripping unecessary whitespace is good (adding unecessary whitespace, by corallary, is not :) Thomas Gahr wrote: Sorry to bring this up so late - has this been applied yet? I don't have push access so I can't do it

Re: Review Request: Add fromTheme property to QIconItem in QtExtraComponents for theme icons in QML

2011-11-02 Thread Christoph Feck
://git.reviewboard.kde.org/r/103009/#comment6814 Is there any specific reason why this isn't const QVariant icon? All used QVariant methods are const. - Christoph Feck On Nov. 1, 2011, 6:43 p.m., Mark Gaiser wrote

Re: Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-10-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102709/#review7502 --- Ship it! Ship It! - Christoph Feck On Sept. 26, 2011, 3:50

Re: Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-10-19 Thread Christoph Feck
On Oct. 19, 2011, 9:50 p.m., Christoph Feck wrote: Ship It! Erm, forgot the comment... Please commit to KDE/4.7, then git cherry-pick -x to master. - Christoph --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Fix ordinal suffix in plasmaclock configuration page for TTS

2011-10-16 Thread Christoph Feck
digits, so that it becomes 312th, not 312nd. Maybe it should be added to KLocale? Some languages might have completely different requirements depending on the number, so the we have a central place to add code to handle them. - Christoph Feck On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote

Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-09-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review6693 --- - Christoph On Sept. 16, 2011, 2:10 p.m., Thomas Gahr wrote:

Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-09-21 Thread Christoph Feck
On Sept. 21, 2011, 12:31 p.m., Christoph Feck wrote: If you commit this, could you check if it fixes the issues from bug 273102 ? - Christoph --- This is an automatically generated e-mail. To reply, visit: http

Re: RFC: Remove Opacity from Alt+F3 menu

2011-08-19 Thread Christoph Feck
the need to switch between them constantly. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Use underscore instead of hyphen in .so name

2011-06-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101801/ --- Review request for Plasma. Summary --- Every other applet uses

Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-14 Thread Christoph Feck
On May 14, 2011, 4:01 a.m., Shaun Reich wrote: Are you sure the behaviour for the Qt method 100% equivalent to the current? I ask this because now that the deprecated method forwards to it, naturally it's quite important to make sure nothing gets fscked up. Nicolas Alvarez wrote:

nepomukstorage.notifyrc / plasma-applet-notifications.desktop

2011-05-05 Thread Christoph Feck
for looking at it, Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

plasma_engine_metadata.so

2011-04-18 Thread Christoph Feck
Hi, both KDE/base/kde-workspace, as well as playground/base/plasma-mobile install the file lib/kde4/plasma_engine_metadata.so. I am not sure if both packages are intended to be installed together, but if they are, one of the files needs to be renamed. Christoph Feck (kdepepo

Re: Review Request: Fix plasma locale problems with multihead

2011-04-16 Thread Christoph Feck
On April 16, 2011, 10:06 a.m., Christoph Feck wrote: Compilation fails with this error: kde-workspace/plasma/desktop/shell/plasmaapp.cpp:119:59: error: taking address of temporary Alberto Mattea wrote: Weird, it works without problems here. I've seen aseigo has done further

Re: The KWin Coding Style Situation

2010-11-28 Thread Christoph Feck
, because that is where future contributions and fixes will land. Other than that, I agree that the current style is annoying and you should not force contributors to use it. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request: Fix PaintUtils::shadowText() placement

2010-09-30 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5504/ --- Review request for Plasma. Summary --- I used

Re: Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

2010-09-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5225/#review7712 --- Some UI suggestions: - change Width in UI to either Radius or

Re: Grouping Desktop moved to kdereview

2010-07-23 Thread Christoph Feck
On Friday 23 July 2010 00:51:49 Giulio Camuffo wrote: Probably the best target for this is kdeplasma-addons, event if I don't hide that I'd like to see it in kdebase. :) I am not able to build it outside kdebase because it uses kephal.

Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-10-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/#review2465 --- On 2009-09-24 03:20:31, Christoph Feck wrote

Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-24 Thread Christoph Feck
--- On 2009-09-24 03:20:31, Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/ --- (Updated 2009-09-24

Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/ --- Review request for kdelibs and Plasma. Summary --- Use the window() of the

Please review/report usage of standard Font and Icon roles in Plasma

2009-09-01 Thread Christoph Feck
(respects) those choices and intends to do so in the future, - does not respect those choices, - already has or intends to provide its own configuration. If they are no longer needed, I would like to remove them from the dialogs. Thanks, Christoph Feck (kdepepo

Re: Drop kwin's fullscreen hack

2009-08-30 Thread Christoph Feck
Hm, if it is full screen, but applications should appear above it, wouldn't that qualify for a desktop window type? And are you saying the netbook shell does not use netwm? Am Sunday 30 August 2009 19:06:34 schrieb Marco Martin: On 8/30/09, Martin Gräßlin k...@martin-graesslin.com wrote:

Re: Drop kwin's fullscreen hack

2009-08-30 Thread Christoph Feck
Am Sunday 30 August 2009 22:27:59 schrieb Marco Martin: On 8/30/09, Christoph Feck christ...@maxiom.de wrote: And are you saying the netbook shell does not use netwm? it does, what would be broken are applications that does not use it, but do they still exist and are relevant? Then I have

<    1   2   3   4   5   6