[Differential] [Closed] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2c6aa5b3499: MediaController: Update position while queuedPositionUpdate timer is running (authored by drosca). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

[Differential] [Closed] D3916: TaskManager: Hide tooltip after activating task

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c8b2ea3ba88: TaskManager: Hide tooltip after activating task (authored by drosca). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3916?vs=9601&id=9665 REVI

[Differential] [Closed] D3917: AppletConfig: Use correct icon state for category icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a54b04dd86c1: AppletConfig: Use correct icon state for category icons (authored by drosca). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3917?vs=9602&id=96

[Differential] [Request, 2 lines] D3917: AppletConfig: Use correct icon state for category icons

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QIcon::Selected should only be used when current item && active focus. TEST PLAN It now display same icon st

[Differential] [Request, 3 lines] D3916: TaskManager: Hide tooltip after activating task

drosca created this revision. drosca added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So that the tooltip doesn't unnecessarily cover activated window. Also under high load it can happen

[Differential] [Closed] D3901: Applet: Toggle mute of items with middle mouse button

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8acf4e6a78c8: Applet: Toggle mute of items with middle mouse button (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3901?vs=

[Differential] [Closed] D3900: Set mute when changing volume to 0 with slider

This revision was automatically updated to reflect the committed changes. Closed by commit R115:db9f523a03c2: Set mute when changing volume to 0 with slider (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3900?vs=9574&id

[Differential] [Closed] D3899: Applet: Make sure to never show empty icon

This revision was automatically updated to reflect the committed changes. Closed by commit R115:26dfed1e5df8: Applet: Make sure to never show empty icon (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3899?vs=9573&id=959

[Differential] [Closed] D3898: Applet: Don't delete delegates while drag is active

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f21aa35e9946: Applet: Don't delete delegates while drag is active (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3898?vs=95

[Differential] [Commented On] D3900: Set mute when changing volume to 0 with slider

drosca added a comment. That's what changing volume with hotkeys is already doing. Also, we show mute icon when volume is 0, so we should also actually mute it. And at last, some hw have leds indicating mute, so this makes it light up when moving the slider to zero. REPOSITORY R115 Plas

[Differential] [Updated, 5 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

drosca updated this revision to Diff 9581. drosca added a comment. Also don't call SetPosition when slider value equals position REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3904?vs=9579&id=9581 BRANCH mediacontroller-fix1 (branched from Plasm

[Differential] [Commented On] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

drosca added a comment. It's wrong, sorry. Removing the timer.running check from if is correct, but stopping it is not. In that state, it now fixes issue with seeking to 0 but it still seeks to *current* position - so you may hear pause in the playing song. REPOSITORY R120 Plasma Workspace

[Differential] [Request, 3 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

drosca created this revision. drosca added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes sometimes reseting position to 0 after expanding applet. TEST PLAN No longer resets to start o

[Differential] [Request, 6 lines] D3901: Applet: Toggle mute of items with middle mouse button

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH middle-mute (branched from master) REVISION DETAIL https://phabricator.k

[Differential] [Request, 4 lines] D3900: Set mute when changing volume to 0 with slider

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mute-slider (branched from master) REVISION DETAIL https://phabricator.k

[Differential] [Request, 12 lines] D3899: Applet: Make sure to never show empty icon

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Streams needs to have icon to be possible to drag them to different devices. Show "unknown" icon when icon is

[Differential] [Request, 2 lines] D3898: Applet: Don't delete delegates while drag is active

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 374288 TEST PLAN No crash, delegates are still correctly deleted REPOSITORY R115 Plasma Audio Volume

[Differential] [Closed] D3813: Draw scrollbar as focused when scrollbar itself have focus

This revision was automatically updated to reflect the committed changes. Closed by commit R31:278876855b37: Draw scrollbar as focused when scrollbar itself have focus (authored by drosca). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3813?vs=9367&id=9529 REV

[Differential] [Commented On] D3813: Draw scrollbar as focused when scrollbar itself have focus

drosca added a comment. Currently, it tries to find QAbstractScrollArea in parent chain and use focused state of this scroll area (+ there is a special case for KTextView). There is no standard way to specify the widget that is being scrolled by the scrollbar. This only works with standard Q

[Differential] [Request, 6 lines] D3813: Draw scrollbar as focused when scrollbar itself have focus

drosca created this revision. drosca added reviewers: Plasma, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes case when scrollbar have the scrolling widget as focus proxy. REPOSITORY R31 Breeze B

[Differential] [Closed] D3753: Fix comparing pa_cvolume objects

This revision was automatically updated to reflect the committed changes. Closed by commit R115:825e64edc982: Fix comparing pa_cvolume objects (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3753?vs=9204&id=9210 REVISIO

[Differential] [Request, 2 lines] D3753: Fix comparing pa_cvolume objects

drosca created this revision. drosca added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY pa_cvolume_equal returns 1 when true, 0 otherwise BUG: 373943 REPOSITORY R115 Plasma Aud

[Differential] [Accepted] D3739: Correctly initialise and compare pa_cvolume structs

drosca accepted this revision. drosca added a reviewer: drosca. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3739 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Commented On] D3736: Initialise m_volume in VolumeObject

drosca added a comment. Perhaps it would be better to use `pa_cvolume_init`? In this case it really doesn't matter, but invalid volume value (for `pa_cvolume::values`) is not zero, but `UINT32_MAX`. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Closed] D3268: Applet: Show device icons and active port name

This revision was automatically updated to reflect the committed changes. Closed by commit R115:117ff0b08dea: Applet: Show device icons and active port name (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3268?vs=8025&id

[Differential] [Closed] D3638: Implement drag from free space also for QtQuickControls

This revision was automatically updated to reflect the committed changes. Closed by commit R113:c5f1504d7ce2: Implement drag from free space also for QtQuickControls (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3638?vs=8914&id=9035#toc REPOSITORY R113 Oxygen The

Re: Review Request 129603: TextFieldStyle: Fix implicitHeight value so the text cursor is centered

marked as submitted. Review request for Plasma. Changes --- Submitted with commit d1f4b5322abacd258ae8d633667cdf391071b7e7 by David Rosca to branch master. Repository: plasma-framework Description --- This makes the TextField slightly bigger, but cursor is now correctly centered

[Differential] [Request, 126 lines] D3638: Implement drag from free space also for QtQuickControls

drosca created this revision. drosca added reviewers: Plasma, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use window manager to handle window move when dragging from free space also with QtQuickContr

[Differential] [Closed] D3585: Fix building library with qmake

This revision was automatically updated to reflect the committed changes. Closed by commit R169:48b9c50a88d4: Fix building library with qmake (authored by drosca). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3585?vs=8740&id=8876 REVISION DETAIL https://

[Differential] [Closed] D3607: AppletConfiguration: Remove custom handling of moving window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e9abd83d02b3: AppletConfiguration: Remove custom handling of moving window (authored by drosca). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3607?vs=8809&

[Differential] [Closed] D3578: [RFC] Implement drag from free space also for QtQuickControls

This revision was automatically updated to reflect the committed changes. Closed by commit R31:bc7304068610: Implement drag from free space also for QtQuickControls (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3578?vs=8808&id=8810#toc REPOSITORY R31 Breeze CHAN

[Differential] [Request, 17 lines] D3607: AppletConfiguration: Remove custom handling of moving window

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Breeze now handles moving QtQuickControls windows too. BUG: 352986 REPOSITORY R119 Plasma Desktop BRAN

[Differential] [Updated, 123 lines] D3578: [RFC] Implement drag from free space also for QtQuickControls

drosca updated this revision to Diff 8808. drosca added a comment. "using" instead of defines REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3578?vs=8804&id=8808 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3578 AFFECTED FILES kstyle/CM

[Differential] [Commented On] D3578: [RFC] Implement drag from free space also for QtQuickControls

drosca added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezewindowmanager.cpp:467 > should be "return false" > Comments few lines below says we never eat events. It needs to be `return true`. If we return false here, then we won't get following move and release events. We ca

[Differential] [Updated, 123 lines] D3578: [RFC] Implement drag from free space also for QtQuickControls

drosca updated this revision to Diff 8804. drosca added a comment. Attempt to make it build with KDE4, untested. I don't have KDE4 anymore. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3578?vs=8721&id=8804 BRANCH master REVISION DETAIL https://phabric

[Differential] [Closed] D3572: systemtray: Don't propagate unhandled wheel events

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1ea67c1fcf0: systemtray: Don't propagate unhandled wheel events (authored by drosca). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3572?vs=8704&id=8803

[Differential] [Commented On] D3578: [RFC] Implement drag from free space also for QtQuickControls

drosca added a comment. In https://phabricator.kde.org/D3578#66969, @hpereiradacosta wrote: > - Also note that you have no guarantee that all QtQuickItems pass through IsQtQuick > - This guy is called only in cases when you need slightly different render path between widgets and quick.

[Differential] [Request, 6 lines] D3585: Fix building library with qmake

drosca created this revision. drosca added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. TEST PLAN Resulting library from qmake no longer have undefined symbols REPOSITORY R169 Kirigami BRANCH master REVISI

[Differential] [Request, 91 lines] D3578: [RFC] Implement drag from free space also for QtQuickControls

drosca created this revision. drosca added reviewers: Plasma, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use window manager to handle window move when dragging from free space also with QtQuickContr

Review Request 129603: TextFieldStyle: Fix implicitHeight value so the text cursor is centered

://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/9aa4f7fd-96b3-42a8-8938-cc1ab2d6ee66__before.png after.png https://git.reviewboard.kde.org/media/uploaded/files/2016/12/02/dadf758a-9298-4ed8-872e-947c308bcedb__after.png Thanks, David Rosca

[Differential] [Request, 5 lines] D3572: systemtray: Don't propagate unhandled wheel events

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Scrolling over empty space or applet that doesn't handle wheel events no longer activates desktop containment

[Differential] [Closed] D3469: [taskmanagerrulesrc] Add Rewrite Rule for chromium

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE97ff71b5efe0: [taskmanagerrulesrc] Add Rewrite Rule for chromium (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Request, 7 lines] D3469: [taskmanagerrulesrc] Add Rewrite Rule for chromium

drosca created this revision. drosca added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Chromium also changed its window class to Chromium (was chromium before) TEST PLAN Chromium and its app

[Differential] [Updated, 21 lines] D3268: Applet: Show device icons and active port name

drosca updated this revision to Diff 8025. drosca added a comment. Change label to "PortName (DeviceName)" REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3268?vs=7913&id=8025 BRANCH device-icons (branched from master) REVISION DE

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

drosca added a comment. Updated screenshot: F498804: Spectacle.TJ7708.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3268 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Closed] D3269: kcm_keyboard: Change text of config action in tray icon to Configure Layouts

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb2e176f15d98: kcm_keyboard: Change text of config action in tray icon to Configure Layouts (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https:/

[Differential] [Accepted] D3300: [Stream] Expose "corked" property

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > stream.h:82 > quint32 deviceIndex() const; > +bool corked() const; > The getter for `corked` property should be `isCorked()`. REPOSITORY rPLASMAPA Plasma

[Differential] [Abandoned] D3057: Fix drawing QtQuickControls ComboBox popups

drosca abandoned this revision. REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik, hpereiradacosta Cc: mart, plasma-devel, lesliezhai, ali-mohamed, j

[Differential] [Request, 2 lines] D3269: kcm_keyboard: Change text of config action in tray icon to Configure Layouts

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also add icon. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabrica

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

drosca added a comment. F397499: Screenshot_20161105_110504.png F397501: Screenshot_20161105_110557.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3268 EMAIL

[Differential] [Updated] D3268: Applet: Show device icons and active port name

drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3268 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-

[Differential] [Request, 21 lines] D3268: Applet: Show device icons and active port name

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Show the device name in format "Active Port: Device Name" and icon corresponding to the active port. Pulsea

[Differential] [Closed] D3168: Use microphone volume icon for capture devices/streams in applet

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA3c760965e6b6: Use microphone volume icon for capture devices/streams in applet (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added a comment. In https://phabricator.kde.org/D2314#59454, @colomar wrote: > However, all the actions in the context menu must be available in the main UI as well. > So, this patch is good to go, but there needs to be a way to do these things without the context menu as well.

Re: Review Request 125546: xcb cursor: Add support for Qt::BlankCursor

://git.reviewboard.kde.org/r/125546/diff/ Testing --- Qt::BlankCursor now correctly sets empty cursor Thanks, David Rosca

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added a comment. In https://phabricator.kde.org/D2314#58816, @Zren wrote: > All I did was copy the Menu widget's pattern (sorta) since it was the first example I could find. Yeah, PlasmaComponents.ContextMenu sucks but if possible, I would prefer the declarative approach t

[Differential] [Updated] D3168: Use microphone volume icon for capture devices/streams in applet

drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design Cc: andreaska, plasma-devel, lesli

[Differential] [Commented On] D3168: Use microphone volume icon for capture devices/streams in applet

drosca added a comment. F379870: Spectacle.M21792.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #pla

[Differential] [Request, 62 lines] D3168: Use microphone volume icon for capture devices/streams in applet

drosca created this revision. drosca added a reviewer: Plasma. drosca added a subscriber: andreaska. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It doesn't make sense to show speaker volume icon for capture streams w

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `App

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

the other way). This never worked (emitting `contextualActionsAboutToShow` from plasmoid), but only this change exposed it. I have no idea how to fix it, other than adding new method to `AppletInterface` to emit this signal or hacky both-way connection. - David Rosca On Oct. 3, 2016, 10:45 a.m

[Differential] [Changed Subscribers] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added subscribers: colomar, drosca. drosca added a comment. @colomar Can you please comment on this? We have been talking about using a context menu in plasmoid, but I don't remember what was the final decision from the VDG? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION

[Differential] [Closed] D3083: Mute volume when decreasing volume to zero

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA6366791aaa50: Mute volume when decreasing volume to zero (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3083?vs=74

[Differential] [Accepted] D3124: Fix crash in application shutdown (alternate fix)

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D3124#58077, @davidedmundson wrote: > In https://phabricator.kde.org/D3124#58026, @drosca wrote: > > > Sorry, I've noticed this one only after acceptin

[Differential] [Requested Changes To] D3124: Fix crash in application shutdown (alternate fix)

drosca requested changes to this revision. drosca added a reviewer: drosca. drosca added a comment. This revision now requires changes to proceed. Sorry, I've noticed this one only after accepting the previous. This looks better, as long as it works without regressions. So, let's push the fi

[Differential] [Accepted] D3123: Fix crash on application shutdown

drosca accepted this revision. drosca added a reviewer: drosca. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pulseaudio.cpp:321 > + > + > Source *SourceModel::defaultSource() const extra newline REPOSITORY rPLASMAPA Plasma Audio Volume Appl

[Differential] [Request, 20 lines] D3083: Mute volume when decreasing volume to zero

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When decreasing the volume to minimal value (zero) with global shortcuts, the OSD shows the volume as muted.

[Differential] [Updated] D3057: Fix drawing QtQuickControls ComboBox popups

drosca updated the test plan for this revision. drosca added reviewers: broulik, hpereiradacosta. REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik,

[Differential] [Request, 127 lines] D3057: Fix drawing QtQuickControls ComboBox popups

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implement drawing QStyleOptionFrame QFrame::StyledPanel shape. Adaptation of the same commit from Breeze, but

[Differential] [Closed] D2985: Quicklaunch: Listen to external configuration changes

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS0f4ec3e6da9c: Quicklaunch: Listen to external configuration changes (authored by drosca). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Updated, 18 lines] D2985: Quicklaunch: Listen to external configuration changes

drosca updated this revision to Diff 7241. drosca added a comment. Same logic also for popup launchers REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2985?vs=7226&id=7241 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/

[Differential] [Updated, 9 lines] D2985: Quicklaunch: Listen to external configuration changes

drosca updated this revision to Diff 7226. drosca added a comment. Disconnect form urlsChanged while setting urls to model REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2985?vs=7212&id=7226 BRANCH Plasma/5.8 REVISION DETAIL https://

[Differential] [Closed] D2833: Quicklaunch: Add support for jumplist actions

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS5e175a976967: Quicklaunch: Add support for jumplist actions (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2833?vs=6869&id=7213#toc REPOSITORY rKDEPLASMAADDO

[Differential] [Request, 7 lines] D2985: Quicklaunch: Listen to external configuration changes

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes changing applet config from scripting. BUG: 370285 TEST PLAN Changed default panel layout.js as p

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1369bca36f6ced7d7c64899d1664469d32699f96 by David Rosca to branch master. Repository: plasma-framework Description --- ^^ Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

e also in other places. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/#review99412 --- On Sept. 23, 20

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

. Repository: plasma-framework Description --- ^^ Diffs (updated) - src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 src/declarativeimports/plasmacomponents/qmenu.cpp b7037da Diff: https://git.reviewboard.kde.org/r/128999/diff/ Testing --- Thanks, David Rosca

[Differential] [Request, 87 lines] D2833: Quicklaunch: Add support for jumplist actions

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D2833 AFFECTED FILES

Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

--- ^^ Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 src/declarativeimports/plasmacomponents/qmenu.cpp b7037da Diff: https://git.reviewboard.kde.org/r/128999/diff/ Testing --- Thanks, David Rosca

[Differential] [Accepted] D2832: [plasma-pa] Set NotificationAreaCategory to Hardware

drosca accepted this revision. drosca added a reviewer: drosca. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D2832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca Cc:

[Differential] [Closed] D2824: Make sure that default devices are not null

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA270110e5520f: Make sure that default devices are not null (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2824?vs=6

[Differential] [Request, 43 lines] D2824: Make sure that default devices are not null

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes at the time when default sink/source change is signalled by pa, we don't have that device in sinks/

Re: Review Request 128802: task bar lines

> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the activ

Re: Review Request 128802: task bar lines

look exactly the same (just icon, no line). - David Rosca On Sept. 9, 2016, 10:20 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

[Differential] [Commented On] D1126: Remove Desktop.SystemSettings import

drosca added a comment. @davidedmundson What happened? I think I updated the diff, waited for review and then just forgot, sorry. It won't happen again. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1126 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Closed] D1126: Remove Desktop.SystemSettings import

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2acf6b8c4225: Remove Desktop.SystemSettings import (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1126?vs=3655&id=6339#toc REPOSITORY rPLASMADESKTOP Plasma Des

[Differential] [Closed] D989: Don't update size when minimum size changes while animation is running

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6ba90e0467d8: Don't update size when minimum size changes while animation is running (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D989?vs=2395&id=6338#toc REPOS

[Differential] [Accepted] D2520: Add option for module-switch-on-connect

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D2520 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmund

[Differential] [Requested Changes To] D2520: Add option for module-switch-on-connect

drosca requested changes to this revision. drosca added a reviewer: drosca. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > modulemanager.cpp:74 > + > +if (switchOnConnect) { > +m_switchOnConnectConfig->set(QStringLiteral("name0"), > QSt

Re: Discussion about module-device-manager change to module-switch-on-connect

Hi, On Sun, Aug 21, 2016 at 4:16 PM, Mark Gaiser wrote: > Hi, > > > What i'd like for this thread is to consider loading > module-switch-on-connect by default (changing the line in > start-pulseaudio-x11) and thus consider removing "module-device-manager". It > would most certainly improve the u

[Differential] [Closed] D2121: DesktopView: Don't call ensureWindowType on FocusIn event

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE30b7e3f2423b: DesktopView: Don't call ensureWindowType on FocusIn event (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2121?vs=5026&id=5888#toc REPOSITORY rP

[Differential] [Commented On] D2121: DesktopView: Don't call ensureWindowType on FocusIn event

drosca added a comment. In https://phabricator.kde.org/D2121#45267, @graesslin wrote: > Patch for setting through surface event: No, that doesn't help, nor does calling ensureWindowType in QEvent::Expose. As it is now, calling ensureWindowType in QEvent::FocusIn is pointless (

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98286 --- https://phabricator.kde.org/D2121 - David Rosca On Aug

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

plasma.png file representing completely different icon. In this case, however, it would fail in the codepath above - being loaded either from plasma theme or svg with kiconloader. - David Rosca On Aug. 2, 2016, 9:11 p.m., David Edmundson wrote: > > -

[Differential] [Updated] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added reviewers: Plasma, Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, #plasma, #plasma:_design Cc: plasma-devel, ali-mohamed

[Differential] [Closed] D2219: Add option to enable volume feedback

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA6814a96da412: Add option to enable volume feedback (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2219?vs=5299&id=5542#toc REPOSITORY rPLASMAPA Plasma Audio Volume

[Differential] [Commented On] D2219: Add option to enable volume feedback

drosca added a comment. > Can we expect canberra to be available everywhere PA is? KF5 kmix has it as non-optional dependency too, so I think that should not be issue. > Is the feedback only played when there is no other source playing? It's played even if there is something pla

[Differential] [Closed] D2270: Try to be more clever about what sink to use for volume control

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA6c2f9f27543b: Try to be more clever about what sink to use for volume control (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2270?vs=5453&id=5498#toc REPOSITORY rPL

<    1   2   3   4   5   6   7   8   9   10   >