s such a useful reviewing tool.
> the patch looks alright. there are probably some opportunities for some
> optimizations and/or added clarity, but nothing that's critical or that
> would
> block this going in imo. fee free to commit it to trunk. thanks for the
> patch.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/342/
---
Review request for Plasma.
Summary
---
Unhides Panel(s) containing a T
Any comments about the patch?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
> On 2009-01-23 08:24:52, Aaron Seigo wrote:
> >
>
> Diaa Sami wrote:
> May be I'm missing something but there are some problems with this code,
> The major problem for me is that Containment doesn't have an activate()
> signal, so when I emit
> On 2009-01-23 08:24:52, Aaron Seigo wrote:
> >
May be I'm missing something but there are some problems with this code, The
major problem for me is that Containment doesn't have an activate() signal, so
when I emit applet->activate() nothing happens ...
Other than that containment is a funct
ase); the
> QString *s in the two helper functions should be QString &s;
> CorrectPathCase
> should be correctPathCase (it's a function, not a method).
>
Find the new version attached
--
Diaa Sami
Index: kde/src/KDE/kdelibs/plasma/runnercontext.cpp
===
On Mon, 19 Jan 2009 11:12 -0700, "Aaron J. Seigo" wrote:
> On Monday 19 January 2009, Diaa Sami wrote:
> > The previous patch had some mistakes, please use this one instead
>
> what's the difference between the two? (also, could you attach the
> patches
>
The previous patch had some mistakes, please use this one instead
Index: kdelibs/plasma/runnercontext.cpp
===
--- kdelibs/plasma/runnercontext.cpp(revision 911086)
+++ kdelibs/plasma/runnercontext.cpp(working copy)
@@ -47,6 +
On Sat, 17 Jan 2009 10:50 -0700, "Aaron J. Seigo" wrote:
>
> sure; if you can come to the list with some patches, i see no reason
> (assuming the performance is still good =) they couldn't go in...
>
You can find an initial version of the patch below, it looks like it works fast
enough.
Altho
On Sat, 17 Jan 2009 18:57 +0100, "Ivan Čukić" wrote:
> > so what do you think?
> Cool idea.
>
Glad the idea is appealing.
> A bit off topic - in the file open/save dialogue, the case-insensitive
> completion works only in the name field, and not in the
> breadcrumb/location
> bar, while it
Hi,
My name is Diaa sami and I'm relatively new to KDE development, recently I've
been working on making path completion in KDE case insensitive[1], which should
be more productive, I've already made Konqueror, Dolphin and the file dialogs
provide case-insensitive path co
11 matches
Mail list logo
