D27271: [kcms/colors] RFC: Accent Colours

2020-02-10 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Since this is related, I'll just drop my concept design for Colours KCM for reference on a possible colour schemes header design to consider. Ignore the button at the bottom, I've realised now that that idea is pointless since we removed so many colour schem

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

2020-02-13 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Started building plasma-desktop over here on an affected machine with this diff applied REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson Cc: The-

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

2020-02-13 Thread Dominic Hayes
The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. I can confirm this fixes the bug. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meve

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

2020-02-13 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Other people are confirming that this patch also fixes the issue: https://bugs.kde.org/show_bug.cgi?id=416358 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham,

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

2020-02-13 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27384#611135 , @davidedmundson wrote: > I still don't fully understand the bug and the fix > > So what we're saying is: > Something changes us to needs save early on startup > We emit changed early

D27436: Use task rather than tabs

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg Cc: The-Feren-OS-Dev, plasma-devel,

D27438: Set System Tray Plasmoid spacing value from 0 to 3

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY In my honest opinion Plasma's System Tray Plasmoid's current spacing value is currently set to 0, which leads to

D27438: Set System Tray Plasmoid spacing value from 0 to 3

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Before: F8107198: image.png After: F8107205: image.png Patch update coming in a bit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D27438: Set System Tray Plasmoid spacing value from 0 to 3

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75785. The-Feren-OS-Dev added a comment. Changed spacing to units.smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75783&id=75785 BRANCH master REVISION DETAIL https://phabric

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Here's it with / 2 added to the spacing value: F8107253: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni, davidr

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Would people prefer that above design to 4px? ^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Which one would people prefer? Units.smallSpacing: F8107285: image.png Units.smallSpacing / 2: F8107287: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#612459 , @ndavis wrote: > Please check how this looks with a vertical panel. Looks a whole lot better on Vertical than without spacing IMHO (unitSpacing): F8107323: image.png

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. VS same but with / 2: F8107328: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: ndavis, anthonyfieroni, davidre, ngraham, plasm

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#612463 , @ngraham wrote: > To make this patch easier to review without applying it, please add all the various sets of before-and-after images to the Test Plan section, not in comments. Done.

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#612484 , @ngraham wrote: > Also, it's nice to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between the

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. After a bit more digging around the code, I found another alternative way to do this which also fixes a bug I just noticed with this patch (there's clicking deadzones in-between the tray icons), however the method for doing it causes this spacing: F8107

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev planned changes to this revision. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Managed to come to a good compromise, however now I've hit a bit of a roadblock. I've found that by editing these lines: property int left: Math.r

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Nevermind, then, I guess something changed between now and Plasma 5.18.1 master code meaning that no longer works, back to the old method... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg C

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75800. The-Feren-OS-Dev added a comment. Changed value to Math.round(units.smallSpacing * 0.7) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75785&id=75800 BRANCH master REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Fair point, just checked that now and they're indeed the same. Got confused with 0.65 as 0.65 looks different to 0.5. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis, anth

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75803. The-Feren-OS-Dev added a comment. Went to 0.5, because 0.6 indeed looks just like 0.5 in execution REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75800&id=75803 BRANCH master REVISI

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-16 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75804. The-Feren-OS-Dev added a comment. One more patch update to keep the change consistent with the rest of the code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75803&id=75804 BRANCH m

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#612719 , @davidre wrote: > There is now not clickable space between items: > F8108239: grafik.png F8108241: grafik.png

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75850. The-Feren-OS-Dev added a comment. Changed method used for increasing spacing between tray icons to something that increases hitbox sizes as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#613051 , @davidre wrote: > In D27438#613050 , @The-Feren-OS-Dev wrote: > > > In D27438#612719 , @davidre wrote:

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75851. The-Feren-OS-Dev added a comment. Tweaked an added comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75850&id=75851 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. Had to lower the cmake version requirement to be able to compile this, but this works just fine, and it's definitely something that'd be nice to have. I can't see any re

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. How would I split it into two patches? Both patches would edit the exact same line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: broulik, kmaterka, filipf, ndavis, a

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev abandoned this revision. The-Feren-OS-Dev added a comment. Alright, I'll start splitting the patches up now. Marking this one as Abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre C

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#613104 , @IlyaBizyaev wrote: > I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: > > Does this depend on DPI/panel size maybe?

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27438#613097 , @ngraham wrote: > ...one to increase the spacing when in tablet mode, and another one to increase the spacing when in desktop mode. At this point each patch will be changing a different line i

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Actually, on second thought, @ngraham I'm not even sure if step 2 would even be worth it on its own, if possible. On your suggestion you have it adjusted to have step 3's tablet mode checker in step 2. If I don't have that check in place, for step 2, the

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. The initial patch of the three, now I've thought up a suitable way of doing this, has been made: https://phabricator.kde.org/D27465 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham

D27465: Added foundations for two future patches to complete the splitting of patch D27438

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY ngraham recommended that I split up https://phabricator.kde.org/D27438 into three patches: 1. This patch - t

D27465: Add foundations for two future patches to complete the splitting of patch D27438

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75862. The-Feren-OS-Dev added a comment. Make the click areas of system tray icons larger in Kirigami Tablet Mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27465?vs=75860&id=75862 BRANCH master

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75863. The-Feren-OS-Dev added a comment. Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode padding addition REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27465?vs=75862&id

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. ...and now the split is complete. https://phabricator.kde.org/D27466 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, an

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH D27465 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27469 AFF

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75869. The-Feren-OS-Dev added a comment. Tidied up code a bit and introduced new baseSize variable - Slightly increase system tray icon hitboxes in Non Tablet Mode Plasma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75870. The-Feren-OS-Dev added a comment. Updated diff to be in line with parent patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75864&id=75870 BRANCH arcpatch-D27465_1 REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75871. The-Feren-OS-Dev added a comment. Hopefully fixed the diff again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75870&id=75871 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75872. The-Feren-OS-Dev added a comment. Arcanist please REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75871&id=75872 BRANCH D27466 (branched from master) REVISION DETAIL https://phabri

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-17 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75873. The-Feren-OS-Dev added a comment. You gotta love arc/git sometimes... CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75872&id=75873 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

2020-02-18 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75911. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Moved baseSize declaration and changed it to a standard variable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-18 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75912. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75873&id=75912 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-18 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 75913. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75912&id=75913 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27466#619931 , @ngraham wrote: > So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite contr

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27466#620037 , @IlyaBizyaev wrote: > Repeating my comment on the previous diff for this change: on my machine, the current spacing for systray elements already looks like your "after" screenshot. With norma

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D27466#620052 , @IlyaBizyaev wrote: > In D27466#620050 , @The-Feren-OS-Dev wrote: > > > This patch only affects the System Tray widget itself, not anything else

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Went to check on different DPIs again to be sure it's fine and it definitely looks fine to me, scaling up the hitbox padding additions (and therefore the icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an issue. BRANCH D27466

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-01 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. The main point of this patch is the spacing increase between tray icons that this hitbox size increase gives, which makes the tray look less cramped as a result. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-03-04 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. `applications:systemsettings.desktop,applications:org.kde.discover.desktop,preferred://filemanager,preferred://browser` There is currently an issue that might make this cumbersome, unless it was fixed very recently as part of the patch work for this, bei

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-08 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 77208. The-Feren-OS-Dev added a comment. Rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75913&id=77208 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES applets/systemtray/package/contents

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-08 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 77209. The-Feren-OS-Dev added a comment. One more diff tweak to make it normal-er. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77208&id=77209 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES applets/sys

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-08 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 77210. The-Feren-OS-Dev added a comment. Redone, again. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77209&id=77210 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27466 AF

D28154: Add users KCM

2020-03-20 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. For the lack of text on Full Name, is there any chance some hint text could appear in the full name text box when the textbox value is empty saying something along the lines of "Full Name" or something? REPOSITORY R119 Plasma Desktop REVISION DETAIL htt

D28281: Add options for OSD feedback

2020-03-25 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D28281#634702 , @sgoth wrote: > Cool thanks! > > As this is my first contribution via phabricator, can you give me a short advice on how to proceed? > Do i "arc land" it myself? To master? IIRC

D28317: Adjust default color scheme and titlebar appearance for Tools Area

2020-03-27 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In D28317#635865 , @ngraham wrote: > Sure, that seems reasonable. I guess the question is whether we should ship it in this repo, or make it a GHNS thing, as with the other old colorschemes like Norway, Wonton S

D28317: Adjust default color scheme and titlebar appearance for Tools Area

2020-03-27 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. In my honest opinion, it'd probably be good to also get rid of Breeze Light in a separate patch as TBH as I see it right now Breeze will make Breeze Light redundant by default post-this-patch since they'll both be Breeze Light in a sense. It just seems redun

D28461: In sidebar mode show if a module is in default state or not

2020-03-31 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. IMHO this is wholly pointless a change, currently. Most people won't care about if they've made changes or not in SySe from the defaults, and quite frankly seeing that indicator on the sidebar would potentially even deter user customisation if not utterly co

D28461: In sidebar mode show if a module is in default state or not

2020-04-02 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed, meaning that only settings with changes made to them are then listed in the search

D25428: Improved support for desktop "Folder View"

2020-04-15 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Any update on the status of this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast

D23117: kcmlookandfeel - Fixed Splash Screen applying

2019-08-12 Thread Dominic Hayes
The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY This is a small change to the Look & Feel KCM Code to fix https://bugs.kde.org/show_bug.cgi?id=409015 by changing

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

2019-08-26 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Pong. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma, davidedmundson, mart Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, l

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

2019-09-19 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 66489. The-Feren-OS-Dev added a comment. - Based on a code review, re-added original behaviour for Splash Screen setting if there's no 'defaults' file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2311

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

2019-09-19 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. @fvogt Nope, but now you've mentioned that I've added an extra line if there's no defaults file found to set the Splash Screen to be the Look & Feel name like it originally would do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

2019-10-23 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 68610. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Added support for BorderlessMaximizedWindows and specifying a Latte Layout - Based on a code review, re-added original behaviour for Splash Screen setting

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

2019-10-23 Thread Dominic Hayes
The-Feren-OS-Dev updated this revision to Diff 68612. The-Feren-OS-Dev added a comment. Edited code based on feedback and added Latte Dock layout and BorderlessMaximisedWindow value changing functionality REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D24706: [RFC] Change button style

2019-11-16 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. How about doing what GNOME does with Adwaita where a small drop shadow is applied on the bottom of the button to create the illusion of a push-in-able button only for the shadow to then go when the button is being pushed down? REPOSITORY R31 Breeze REVISI

D25428: Improved support for desktop "Folder View"

2020-09-27 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. bump! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachu