hein added a comment.
> model.isDir() does a full stat of a file.
model.isDir() does indeed, but this uses model.isDir, which is a data role.
The FolderView::data() implementation already uses a cache. The cache is
inserted into the first time isDir() is called and evicted e.g. on item
hein added a comment.
UI design note: Even though I'm nerdy enough to understand the checkbox
stuff, sometimes I want to remove a favorite and spend two seconds of confusion
looking for a Remove action ...
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, pl
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3990ec235810: Fix
QSortFilterProxyModelPrivate::updateChildrenMapping crash in libtaskmanager
(authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kd
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:75b7f5c2fa63: Keep fallback icon updated (authored by
hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7092?vs=17739&id=17818
REVISION DETAIL
https
hein added a comment.
I'll now run with this revision of the patch for a while, but please look
into the above / reply! :)
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, se
hein added a comment.
I was on activity 2 and adding some faves on dash from the Recent apps
section, and the second fav I added had the same icon as the first fav I added,
even though it was for a different app. Switching to the first activity and
back to 2 fixed the icon. Could be a Qt Qui
hein added a comment.
No longer crashing!
Remaining concerns after repeating tests:
- The result of the migration is now the superset of all faves, but sorting
is a bit weird (maybe this is the best possible?)
- However it only ends up on my first activity, the other activity was
hein updated this revision to Diff 17739.
hein added a comment.
Fix logic. This was not actually doing what I wanted.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7092?vs=17738&id=17739
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
hein updated this revision to Diff 17738.
hein added a comment.
Fix dumb logic that happened from never actually reading the contents of the
else if condition ;)
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7092?vs=17622&id=17738
BRANCH
maste
hein added a comment.
> I'm possibly wrong, but instead of the new set couldn't you
> if (appDataCache.contains(window) && appDataCache[window].icon.isValid())
I don't understand on multiple levels :)
There's no QIcon::isValid, and even if there was, the icon being in the cache
an
hein updated this revision to Diff 17737.
hein marked 3 inline comments as done.
hein added a comment.
- qDeleteAll the new pointer vector on destruction.
- Add a Q_ASSERT to catch data corruption.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
hein marked 3 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in taskgroupingproxymodel.cpp:41
> Cleanup on destruction.
>
> (which sounds like the name of a new Megadeth single)
Will do.
> davidedmundson wrote in taskgroupingproxymodel.cpp:465
> (I
hein added a comment.
Updated description to match commit message because arc is stupid.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7139
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
hein edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7139
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
hein updated this revision to Diff 17733.
hein added a comment.
Slightly nicer commit message.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7139?vs=17732&id=17733
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7139
AFFECTED FIL
hein updated this revision to Diff 17732.
hein added a comment.
Forgot to actually drop the blocks updating QPMI's
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7139?vs=17731&id=17732
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
TaskGroupingProxyModel uses a simple QVector> populated
with source model row indices to represent the task group tree. To
implement QAbstractItemModel::parent(), its implementation of index()
enco
It's ... sort of dumb, but sometimes the value of advertising an LTS
branch is psychological. "Does this have an LTS branch for when I need
it, e.g. because I get more busy" seems to be on the minds of many
people making a distro choice these days, even if they don't use it
immediately or not for
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Windows we can't find an app icon for using the normal means
get the icon used by the windowing system in the Task Manager.
This fallback icon was then not updated when changed on the
window, only
hein added a comment.
I'm wondering if this should be done in KIO/KDirModel ... does Dolphin do
this per-view too?
INLINE COMMENTS
> broulik wrote in foldermodel.cpp:1714
> I think this check down here is wrong/not working properly
Can you elaborate?
REPOSITORY
R119 Plasma Desktop
REVIS
hein added a comment.
I used arc patch which usually preserves authorship, I don't know why it
didn't this time - I blame the tool. :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz, xuetianweng
Cc: cfeck, hein, xapienz, plasma-dev
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7064
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a1e2ddd67a12: Fix group dialog no longer resizing/closing
as windows are closed and the group… (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
hein updated this revision to Diff 17493.
hein added a comment.
Better code for closing on dissolve.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7035?vs=17492&id=17493
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D7035
AFFE
hein updated this revision to Diff 17492.
hein marked an inline comment as done.
hein added a comment.
Cleanup from older version.
Sorry, got distracted by an IRC meeting.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7035?vs=17491&id=17492
BR
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Also delays the dialog resize until after the move transition ends
if there's going to be one, for a less jarring experience.
BUG:382638
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REV
hein abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7032
To: hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG:382638
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D7032
AFFECTED FILES
applets/t
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:999568ada13b: Stop unnecessarily killing IBus when
applying keyboard layouts config (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6956?v
hein added a comment.
Your patch looks good to me. I'll await Weng's opinion and then commit it for
you.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz, xuetianweng
Cc: hein, xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesl
hein added a comment.
Do you have commit access?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz
Cc: hein, xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
hein added a reviewer: xuetianweng.
hein added a comment.
csslayer, can you have a look at this too?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz, xuetianweng
Cc: hein, xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesliezha
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6872
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mar
hein accepted this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6869
To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
hein added a comment.
I'm on vacation Mon-Wed and then travelling. I don't know yet when I can test
again. I'm currently wary of touching my system too much because I need it to
stay reliable as a demo machine for my presentation. If someone else can test
for the crash using the steps above,
hein added a comment.
Please don't commit this. It conflicts with https://phabricator.kde.org/D3805.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6609
To: broulik, #plasma, #vdg, davidedmundson
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Yay down to one line :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6552
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
hein added a comment.
Is there some way we can reuse the EG in main.qml, or does this have to be in
the widget code too? (I think the answer is "yes", but double-checking.)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6552
To: broulik, #plasma, hein
Cc: pl
hein added a comment.
Wouldn't it make more sense to use or extend EventGenerator than introduce a
new MouseEventFaker?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6552
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6551
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
hein added a comment.
After the crash, the re-added Appdash seems to have the same favorites as the
old Appdash instance had, which is still not the superset of the pre-migration
favorites or anything, nor the same favorites as the Kickoff.
REVISION DETAIL
https://phabricator.kde.org/D3805
hein added a comment.
I get the crash also when removing and re-adding Appdash:
Thread 1 (Thread 0x7f6573ed8dc0 (LWP 3060)):
[KCrash Handler]
#6 0x034d3d70 in ()
#7 0x7f64c813bb0c in KAStatsFavoritesModel::Private::data(QModelIndex
const&, int) const (role=266, index=
hein added a comment.
Another full test write up.
Ivan informed in an email that for a clean slate test, in addition to the SQL
deletion and deleting kactivitymanager-statsrc, also
favoritesPortedToKAstats=true needs to be removed from all places in appletsrc,
so I did another test run.
hein added a comment.
Another crash, this time a while after running with migrated favourites:
Thread 1 (Thread 0x7f8ef082cdc0 (LWP 8048)):
[KCrash Handler]
#6 0x7f8e44c0dcf8 in
KAStatsFavoritesModel::Private::removeOldCachedEntries() const
(this=0x40fc41c800) at
/home/eike/dev
hein added a comment.
Adding new favorites works. However, starting with the blank favorites I did
the following:
1. Add a favorite on all activities
2. Add a favorite specific to the current activity
3. Add another favorite on all activities
I've noticed that for both #2 and #3,
hein added a comment.
Here's what I tried to do today:
1. Set up Kicker and Appdash with different favorites
2. Patch, install
3. Log out, log in
Then I got the crash above.
4. Switch back to master, log out and back in, still have the two widgets
with different faves
5. L
hein added inline comments.
INLINE COMMENTS
> main.xml:48
> +
> + Are the favorites ported to use KActivitiesStats to allow
> per-activity favorites
> + false
Pedantic: Broken grammar
> SideBarItem.qml:59
> onActionClicked: {
> +console.log(actionId + "<-
hein added a comment.
Reproducable crash:
#0 0x7fff28407f06 in
KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x3266e40)
at
/home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:130
#1 0x7fff284063e5
hein added a comment.
I'm a little confused by the last comment - the branch in the repo hasn't
been updated in four months, so the new testing location seems to be the diff
again, yet there's a "I added a test" comment with no diff change ... :)
Anyways, I'll review the diff here.
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1aa12f1d042b: Add standard keyboard shortcut for refresh
(authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6447?vs=16049&id=16108
REVISION
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
BUG:381505
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6447
AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml
containments
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D6388
To: broulik, #plasma, drosca, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6359
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee79239a5de7: Use KRun::runApplication when possible;
split out and share more code. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D635
hein updated this revision to Diff 15789.
hein added a comment.
Ref-ify.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6358?vs=15788&id=15789
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6358
AFFECTED FILES
libtaskmanag
hein updated this revision to Diff 15788.
hein added a comment.
Collapse the requestOpenUrls implementations as well; more sanity checking
for app-service-ness.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6358?vs=15787&id=15788
BRANCH
Plasma
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
I'm not particularly happy about adding more X11 code outside of
XWindowTasksModel, but it means greater code reuse (in something that
has experienced unwelcome drift before) and there's a precedent
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d1b5447f57e4: Use KRun::runApplication, add missing
KActivities::notifyAccessed calls. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:20bf7ec11458: Fix clicking outside of preview popups to
dismiss them corrupting mouse state (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
hein updated this revision to Diff 15779.
hein added a comment.
Hide the popup button in nested views.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6247?vs=15778&id=15779
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D62
hein requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6247
To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
hein updated this revision to Diff 15778.
hein added a comment.
Drop unrelated TM changes from patch.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6247?vs=15668&id=15778
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D624
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Otherwise we:
- ... don't get startup notifications.
BUG:381500
- ... don't contribute data to recent/most used apps.
This is a surprisingly large oversight.
REPOSITORY
R120 Plasma
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
I see the definition now with the updated diff - maybe the Phab diff viewer
was acting up or something, or I really am blind ...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phab
hein added inline comments.
INLINE COMMENTS
> Zren wrote in FolderView.qml:492
> Arg, curses.
>
> `ready` is defined 2 lines up. Also, do you want me to put `scrollArea.ready`
> so it's not confused with `folderViewLayer.ready` defined in `main.qml`?
>
> https://github.com/KDE/plasma-desktop/b
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> FolderView.qml:492
> +Component.onCompleted: {
> +ready = true
> +}
Missing semicolon, also ready is defined nowhere.
REP
hein added a comment.
Yeah, it would be more efficient. Actually, could you audit your code a
little more? I think the same issue I had with the busy-looping popups (I was
working on https://phabricator.kde.org/D6247 and noticed my plasmashell using
30% CPU and stuttering a lot, and Kai ment
hein updated this revision to Diff 15668.
hein added a comment.
- Don't break the popupDialog binding. It's a super binding, really, and this
patch didn't know how to appreciate it properly.
- Opening the popup should imply selecting, it avoids other state weirdness
in double-click-to-open
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:fd4d41bd65fd: Don't rely on QQuickWindow delivering
QEvent::Ungrab as mouseUngrabEvent (as it… (authored by hein).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:84300b516b79: Fix DND onto Task Manager for groups, group
dialog scrollbar (authored by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6231?vs=15485&id=15572#toc
REPOSITORY
R119 Plasm
hein added inline comments.
INLINE COMMENTS
> broulik wrote in FolderItemDelegate.qml:119
> This check is now superfluous as it's also done in `closePopup()`
Yeah, but it's minutely faster to check this than do a function call (and the
dialog not being open is the common case), it's a little mo
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6133
To: davidedmundson, #plasma, hein
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohame
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
As a result of refactorings in 5.10, hoveredItem may not reflect the
true cursor position when preview popups become involved. When inter-
acting with an item's associated preview popup, it's still c
hein created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
QQuickWindow::sendEvent in Qt 5.7 and older had the following code
to deliver QEvent::UngrabMouse by calling QQuickItem::mouseUngrabEve
hein updated this revision to Diff 15485.
hein added a comment.
One more readonly; I'm out of stuff now.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15484&id=15485
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
hein updated this revision to Diff 15484.
hein added a comment.
Waiting for David leads to more small cleanups.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15483&id=15484
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/
hein requested review of this revision.
hein added a comment.
David, you still ok with this updated rev? Sorry, was working in parallel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6231
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr,
hein updated this revision to Diff 15483.
hein added a comment.
Properly make room for scrollbar if needed.
This was kinda-sorta intended to be there (see contentWidth) but
somehow got lost during development.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabric
hein updated this revision to Diff 15482.
hein added a comment.
Set aboutToPopulate always, and before setting the rootIndex.
Fixes pre-selecting the active window when moving the dialog
from one group to another during drag hover.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UP
hein updated this revision to Diff 15481.
hein added a comment.
Slightly simpler + better comment.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15480&id=15481
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
AFFECT
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
With this patch drag-hover activation will work for group children,
and moving between different group parents while dragging will
correctly refresh the dialog contents.
BUG:379888
The patch a
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6188
To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abet
hein added a comment.
I used to subclass in Simple Menu, but then eliminated the C++ plugin so I
could put it on the Store, so this is important for now.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: he
hein added a comment.
The widget should keep using the old behavior, grid-fitting is pretty awkward
there (and I can already hear "my icons don't line up across widgets"
complaints). This is really a desktop-specific special case motivated by people
trying to put icons into opposing screen c
hein added a comment.
The comment is mostly about the fact that this means you can no longer drop
icons there then. Keep in mind that when the view is in columnar mode,
horizontal overflow is (currently) the expected and correct behavior - if the
folder is fuller than the screen can fill, th
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
This most likely breaks the text position in the rename editor matching the
label position.
The rectangle selection code also tests for intersection with the icon and
label rects
hein added a comment.
In https://phabricator.kde.org/D6188#115977, @Zren wrote:
> Remove check for if we're already overflowing, using rtl layout, or if it's
"arrange in columns/rows", since the ScrollView shouldn't be covered by panels.
You didn't change the comment above the cod
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
Looks pretty good to me. It needs some polish as marked, but we should test
it in master soon.
INLINE COMMENTS
> FolderView.qml:526
> +}
> +re
Hi,
is there any reason why you guys need to use 4.3.5? It's over
seven years old ...
Cheers,
Eike
On 06/11/2017 08:25 PM, Shitrit, Shahaf wrote:
> Hey,
> I’m using the very useful pager widget on kde 4.3.5 .
> Unlike in previos kde version, there is a problem to see in which
> desktop I am at
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6152
To: davidedmundson, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6088
To: broulik, #plasma, hein, fvogt
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, se
I have a vacation day on the 6th (the current front-runner) as it's a
national holiday here in Korea, and Monday is one in Germany, so I'd
prefer if we could do it on Wednesday or so - but if the 6th ends up
being selected I will try to participate from a phone at least :).
Cheers,
Eike
hein accepted this revision.
hein added a comment.
Sounds good
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart, hein
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohame
hein added a comment.
So you're cleaning up the leak the next time the getter is accessed? What if
this never happens?
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart
Cc: hein, plasma-devel, #frameworks, Z
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6020
To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterbe
hein added a comment.
Please also add to kicker/dashboard if missing.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6020
To: sitter, hein, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, m
hein closed this revision.
hein added a comment.
This was committed as
https://phabricator.kde.org/R119:a8d9038a592e6d3ed87852bc2fb3a0f93449897d, not
sure why the ticket didn't get closed.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5950
To: hein, #plasm
On 05/26/2017 07:29 AM, Jonathan Riddell wrote:
> Plasma 5.10 tars are now available on racnoss for packagers
>
> Release is due on Tuesday
If possible it would be nice to still refresh plasma-desktop from
the 5.10 branch. We forgot a fix that was only commited to master,
and is now on the bran
hein added a comment.
Since I'm not available on tagging day and was concerned about missing this
fixed, I put it into the 5.9 and 5.10 branches myself now.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5933
To: ivan, hein, mart
Cc: plasma-devel, ZrenBot,
1101 - 1200 of 2806 matches
Mail list logo
