Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-27 Thread Etienne Rebetez
ically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/#review4196 ------- On June 25, 2011, 10:01 p.m., Etienne Rebetez wrote: > > --- > This is an

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-25 Thread Etienne Rebetez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/ --- (Updated June 25, 2011, 10:01 p.m.) Review request for Plasma. Changes -

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-23 Thread Etienne Rebetez
g/r/101728/#comment3364> Thats, basicaly the fix. The idea was to have the commits in the list in the same order as they appear in the timeline. But, with your suggestion i'll probaly try to make the TimeLineItem in the same loop. - Etienne On June 22, 2011, 7:37 p.m., Etienne Re

Re: Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-23 Thread Etienne Rebetez
ttp://git.reviewboard.kde.org/r/101728/#review4088 --- On June 22, 2011, 7:37 p.m., Etienne Rebetez wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request: Fix bug 276082 and refactor timeline in plasmate

2011-06-22 Thread Etienne Rebetez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101728/ --- Review request for Plasma. Summary --- Hi, When trying out plasmate

Re: Review Request: [Picture Frame] Autoupdate function for url's

2010-03-29 Thread etienne . rebetez
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3334/ --- (Updated 2010-03-29 18:08:51.127630) Review request for Plasma. Changes --

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-29 Thread etienne . rebetez
> On 2010-03-29 11:08:34, Sebastian Kügler wrote: > > Thanks for your review. Next time i'll try to do better. (Allredy in progress) > On 2010-03-29 11:08:34, Sebastian Kügler wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h, line 77 > >

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-27 Thread etienne . rebetez
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3334/ --- (Updated 2010-03-27 15:08:02.582649) Review request for Plasma. Changes --

Re: Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-27 Thread etienne . rebetez
> On 2010-03-23 17:50:42, Aaron Seigo wrote: > > personally, i don't see the need for a url configuration page at all. the > > download path should be the from desktop-wide coniguration and the picture > > should always be overwritten (the frame plasmoid is not a downloader; see > > comments b

Review Request: [Picture Frame] Update function for url's and configuration of download path

2010-03-21 Thread etienne . rebetez
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3334/ --- Review request for Plasma. Summary --- I was quite happy that the picture f

Re: Review Request: Molmasscalcuation for the kalzium-engine

2010-03-20 Thread etienne . rebetez
> On 2010-03-10 16:20:48, Carsten Niehaus wrote: > > Looks good to me. Thanks for taking care! I'am glad it's ok:) Just an other question, do i have to do somthing additional to get it in trunk? I just noticed that some newer "Ship it" code is alredy in trunk. - eti ---

Re: Review Request: Molmasscalcuation for the kalzium-engine

2010-03-09 Thread etienne . rebetez
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3228/ --- (Updated 2010-03-09 19:11:33.923597) Review request for KDE-Edu and Plasma. Ch

Review Request: Molmasscalcuation for the kalzium-engine

2010-03-09 Thread etienne . rebetez
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3228/ --- Review request for KDE-Edu and Plasma. Summary --- I was playing with plasm