D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-07 Thread Eugene Shalygin
eshalygin added a comment. Thanks a lot! REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg, graesslin Cc: graesslin, ltoscano, broulik, markg, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, a

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-07 Thread Eugene Shalygin
eshalygin updated this revision to Diff 14227. eshalygin marked 3 inline comments as done. eshalygin added a comment. Address review comments. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13677&id=14227 REVISION

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-02 Thread Eugene Shalygin
eshalygin added a comment. Thanks! REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-02 Thread Eugene Shalygin
eshalygin added a comment. ping? REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-01 Thread Eugene Shalygin
eshalygin added a comment. I don't have commit rights. Could someone commit this for me, please? REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-30 Thread Eugene Shalygin
eshalygin added a comment. Any news? REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-22 Thread Eugene Shalygin
eshalygin added a comment. @broulik ? What do you think about this implementation? REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin added a comment. Ready. Works. REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin updated this revision to Diff 13677. eshalygin added a comment. use QFileInfo::absoluteFilePath() always CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13676&id=13677 REVISION DETAIL https://phabricator.kde.org/D5538 AFFECTED FILES src/platformtheme/kdeplatfor

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin added a comment. Not ready yet. REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin updated this revision to Diff 13676. eshalygin added a comment. Fix a typo in function name CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13675&id=13676 REVISION DETAIL https://phabricator.kde.org/D5538 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin updated this revision to Diff 13675. eshalygin added a comment. Use KIO::iconForURL() REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13672&id=13675 REVISION DETAIL https://phabricator.kde.org/D5538 AFF

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin added a comment. In https://phabricator.kde.org/D5538#103838, @markg wrote: > But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead. It can't support QPlatformTheme::

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
://git.reviewboard.kde.org/r/130094/diff/ Testing --- Manual testing. Thanks, Eugene Shalygin

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
eshalygin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work. TEST PLAN Manual testing REPOSITORY R135 Integration for Qt

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
ved in 5.8? > > (didn't check Qt code) > > Eugene Shalygin wrote: > Signature of the function was changed in 5.8 if you are asking about the > #ifdef. Did I understand you correctly? > > Kai Uwe Broulik wrote: > Yep, that's what I've been askin

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
uilt-in, potentially allowing > > you to reduce your patch to like 10 lines of code :) > > > > (Btw using Qt 5.7 features is fine, Plasma-integration is released > > alongside Plasma, not KDE Frameworks, and the upcoming Plasma 5.10 release > > will depend on Qt 5

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
check Qt code) Signature of the function was changed in 5.8 if you are asking about the #ifdef. Did I understand you correctly? - Eugene --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
o reply, visit: https://git.reviewboard.kde.org/r/130094/#review103072 ------- On April 21, 2017, 11:11 a.m., Eugene Shalygin wrote: > > --- > This is an automatically generated e-

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
Diff: https://git.reviewboard.kde.org/r/130094/diff/ Testing --- Manual testing. Thanks, Eugene Shalygin

Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
, Eugene Shalygin

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-19 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=344355 Eugene Shalygin changed: What|Removed |Added Platform|Other |Gentoo Packages -- You are receiving this

[kio-extras] [Bug 344355] New: Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-19 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=344355 Bug ID: 344355 Summary: Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation Product: kio-extras Version: unspecified Platform: Other OS: L